| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:74a4de64-234c-eb7a-5532-efacf0378309 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B108:1F7A:152A3BE:1D153D1:6B002DA6 |
| html-safe-nonce | e6c1e616e91b15438b02ceeaff7b7f26aabdfe66b4db3c645d3a04afbf50c8de |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTA4OjFGN0E6MTUyQTNCRToxRDE1M0QxOjZCMDAyREE2IiwidmlzaXRvcl9pZCI6IjkxNjU0MTY5ODY5MDgzMDY4NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9b064cefcb1d2e3dc0318bf9f03c1f8ca52a2ac31232cd61e58efaad8b5d14ff |
| hovercard-subject-tag | pull_request:2171550528 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18138/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/65a2a6f848b4317e6e803ccd8cc6afc79fdadc2d432922ce5e1be7dd69c69b55/python/mypy/pull/18138 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/65a2a6f848b4317e6e803ccd8cc6afc79fdadc2d432922ce5e1be7dd69c69b55/python/mypy/pull/18138 |
| og:image:alt | Fixes #18126.
Simply allowing such intersection was insufficient: existing binder logic widened the type to T | None after the is None check.
This PR extends the binder logic to prevent constructin... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sterliakov |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/18138#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18138 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18138 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/18138 |
| Reload | https://github.com/python/mypy/pull/18138 |
| Reload | https://github.com/python/mypy/pull/18138 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| sterliakov:bugfix/st-none-typevar-overlap | https://github.com/sterliakov/mypy/tree/bugfix/st-none-typevar-overlap |
| Conversation | https://github.com/python/mypy/pull/18138 |
| Commits6 (6) | https://github.com/python/mypy/pull/18138/commits |
| Checks | https://github.com/python/mypy/pull/18138/checks |
| Files changed | https://github.com/python/mypy/pull/18138/files |
| Do not consider bare TypeVar not overlapping with None for reachability analysis | https://github.com/python/mypy/pull/18138#top |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| sterliakov:bugfix/st-none-typevar-overlap | https://github.com/sterliakov/mypy/tree/bugfix/st-none-typevar-overlap |
|
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
| Nov 10, 2024 | https://github.com/python/mypy/pull/18138#issue-2647481230 |
| #18126 | https://github.com/python/mypy/issues/18126 |
| Please reload this page | https://github.com/python/mypy/pull/18138 |
|
| https://github.com/sterliakov |
| Allow TypeVar & None intersection when checking reachability. | https://github.com/python/mypy/pull/18138/commits/42620b0bd484d0c44be9dd7d8e534886e9e44cac |
| 42620b0 | https://github.com/python/mypy/pull/18138/commits/42620b0bd484d0c44be9dd7d8e534886e9e44cac |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
| November 10, 2024 18:04 | https://github.com/python/mypy/pull/18138#event-15241687623 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18138 |
| sterliakov | https://github.com/sterliakov |
| November 10, 2024 19:18 | https://github.com/python/mypy/pull/18138#commits-pushed-7160e4e |
|
| https://github.com/sterliakov |
| Remove cast that caused a problem | https://github.com/python/mypy/pull/18138/commits/7160e4e540f2da7bb94250de2718081b65db6606 |
| 7160e4e | https://github.com/python/mypy/pull/18138/commits/7160e4e540f2da7bb94250de2718081b65db6606 |
|
| https://github.com/sterliakov |
| Move cases with 3.10+ syntax to python310 file | https://github.com/python/mypy/pull/18138/commits/207c75affc0b8d04380c4b5668de1f6ecb42420f |
| 207c75a | https://github.com/python/mypy/pull/18138/commits/207c75affc0b8d04380c4b5668de1f6ecb42420f |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18138 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
| Nov 10, 2024 | https://github.com/python/mypy/pull/18138#issuecomment-2466912470 |
| Please reload this page | https://github.com/python/mypy/pull/18138 |
| playground | https://mypy-play.net/?mypy=1.13.0&python=3.12&flags=strict&gist=f2df47d37c231b7d35e26744191d9e11 |
| Node | https://github.com/docutils/docutils/blob/ceb8eb76a21da5553017bedb9eca8bb18ebde57f/docutils/docutils/nodes.py#L81 |
| stubs | https://github.com/tk0miya/docutils-stubs/blob/b14071d065f8ee35399856fcaff6cd608294a342/docutils-stubs/nodes.pyi#L17 |
| playground | https://mypy-play.net/?mypy=master&python=3.12&flags=strict&gist=10d9f159ae3dcb3943f39e8720c13ddd |
| Please reload this page | https://github.com/python/mypy/pull/18138 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
| November 10, 2024 20:49 | https://github.com/python/mypy/pull/18138#event-15242012529 |
|
| https://github.com/sterliakov |
| Merge branch 'master' into bugfix/st-none-typevar-overlap | https://github.com/python/mypy/pull/18138/commits/374d4ddd0ef1ded0ff2ebc0c033016b59d109a91 |
| 374d4dd | https://github.com/python/mypy/pull/18138/commits/374d4ddd0ef1ded0ff2ebc0c033016b59d109a91 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18138 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Nov 15, 2024
| https://github.com/python/mypy/pull/18138#pullrequestreview-2438867061 |
|
View reviewed changes
| https://github.com/python/mypy/pull/18138/files/374d4ddd0ef1ded0ff2ebc0c033016b59d109a91 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/18138#pullrequestreview-2438867061 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/18138 |
| mypy/binder.py | https://github.com/python/mypy/pull/18138/files/374d4ddd0ef1ded0ff2ebc0c033016b59d109a91#diff-cec7c57fef20b803fc1c4e988ad3971b3597f1fd1b12db07b47f825046f264f5 |
| Please reload this page | https://github.com/python/mypy/pull/18138 |
| mypy/checker.py | https://github.com/python/mypy/pull/18138/files/374d4ddd0ef1ded0ff2ebc0c033016b59d109a91#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| Please reload this page | https://github.com/python/mypy/pull/18138 |
| sterliakov | https://github.com/sterliakov |
| November 15, 2024 18:45 | https://github.com/python/mypy/pull/18138#commits-pushed-c2af54f |
|
| https://github.com/sterliakov |
| Merge remote-tracking branch 'upstream/master' into bugfix/st-none-ty… | https://github.com/python/mypy/pull/18138/commits/c2af54f06b082974ed31b179d70ee8e7a13c3042 |
| c2af54f | https://github.com/python/mypy/pull/18138/commits/c2af54f06b082974ed31b179d70ee8e7a13c3042 |
|
| https://github.com/sterliakov |
| Avoid passing boolean flags positionally | https://github.com/python/mypy/pull/18138/commits/70aa977fbb17527e218a6e0f475dca455422114f |
| 70aa977 | https://github.com/python/mypy/pull/18138/commits/70aa977fbb17527e218a6e0f475dca455422114f |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 15, 2024 | https://github.com/python/mypy/pull/18138#issuecomment-2479664042 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/18138 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Nov 21, 2024
| https://github.com/python/mypy/pull/18138#pullrequestreview-2451709610 |
|
View reviewed changes
| https://github.com/python/mypy/pull/18138/files/70aa977fbb17527e218a6e0f475dca455422114f |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/18138#pullrequestreview-2451709610 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/18138 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| 08340c2 | https://github.com/python/mypy/commit/08340c29a939a203868d3abd5cfd997720228f32 |
| Nov 21, 2024 | https://github.com/python/mypy/pull/18138#event-15383349917 |
|
Attribute of type A | B | None becomes object after narrowing checks
#12009
| https://github.com/python/mypy/issues/12009 |
|
Regression with type narrowing of bool
#11839
| https://github.com/python/mypy/issues/11839 |
| https://github.com/cdce8p |
| cdce8p | https://github.com/cdce8p |
|
Dec 9, 2024
| https://github.com/python/mypy/pull/18138#ref-pullrequest-2727234368 |
|
Add regression test for isinstance narrowing
#18272
| https://github.com/python/mypy/pull/18272 |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Dec 9, 2024
| https://github.com/python/mypy/pull/18138#ref-commit-ac89577 |
|
| https://github.com/cdce8p |
| Add regression test for isinstance narrowing ( | https://github.com/python/mypy/commit/ac8957755a35a255f638c122e22c03b0e75b9a79 |
| #18272 | https://github.com/python/mypy/pull/18272 |
| ) | https://github.com/python/mypy/commit/ac8957755a35a255f638c122e22c03b0e75b9a79 |
| ac89577 | https://github.com/python/mypy/commit/ac8957755a35a255f638c122e22c03b0e75b9a79 |
| #11839 | https://github.com/python/mypy/issues/11839 |
| #18138 | https://github.com/python/mypy/pull/18138 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Dec 28, 2024
| https://github.com/python/mypy/pull/18138#ref-issue-343245827 |
|
Mypy forgets type information after a nested if-statement.
#5378
| https://github.com/python/mypy/issues/5378 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
|
Jan 16, 2025
| https://github.com/python/mypy/pull/18138#ref-issue-1994091476 |
|
attribute is incorrectly Any when ParamSpec decorated function is referenced in itself followed by an if statement with a class that has a method in it
#16496
| https://github.com/python/mypy/issues/16496 |
| https://github.com/PetterS |
| PetterS | https://github.com/PetterS |
| Feb 23, 2025 | https://github.com/python/mypy/pull/18138#issuecomment-2676750145 |
| Please reload this page | https://github.com/python/mypy/pull/18138 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jun 27, 2025
| https://github.com/python/mypy/pull/18138#ref-issue-623066277 |
|
Reachable code marked as unreachable in generic class with None type
#8871
| https://github.com/python/mypy/issues/8871 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18138 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/18138/files/70aa977fbb17527e218a6e0f475dca455422114f |
| Please reload this page | https://github.com/python/mypy/pull/18138 |
|
False positive "Statement is unreachable" when checking if typevar is None
| https://github.com/python/mypy/issues/18126 |
| Please reload this page | https://github.com/python/mypy/pull/18138 |
|
| https://github.com/sterliakov |
|
| https://github.com/PetterS |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |