René's URL Explorer Experiment


Title: Fix isinstance with type aliases to PEP 604 unions by hauntsaninja · Pull Request #17371 · python/mypy · GitHub

Open Graph Title: Fix isinstance with type aliases to PEP 604 unions by hauntsaninja · Pull Request #17371 · python/mypy

X Title: Fix isinstance with type aliases to PEP 604 unions by hauntsaninja · Pull Request #17371 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #12155, fixes #11673, seems pretty commonly reported issue

X Description: Fixes #12155, fixes #11673, seems pretty commonly reported issue

Opengraph URL: https://github.com/python/mypy/pull/17371

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0d554dc3-c750-a875-4231-823e38aa5433
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE00:43251:1E72B41:289B3FF:6B004BF6
html-safe-nonce28a810d8d70ac9196ee085a96e9d94fe2db958d6148bf2bf23db48a540cd29a1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTAwOjQzMjUxOjFFNzJCNDE6Mjg5QjNGRjo2QjAwNEJGNiIsInZpc2l0b3JfaWQiOiIyNjYzMTY3NTY5NzI4MzkyMTgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7f46b9543298b8b3f7bda79b27e2edfebcaec874d69f86b9f113ae7ce3690e26
hovercard-subject-tagpull_request:1917266951
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/17371/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a0b38254763cd417b99e41e151fe0fcdc478a4004beb5034151c88d0fbd6394e/python/mypy/pull/17371
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a0b38254763cd417b99e41e151fe0fcdc478a4004beb5034151c88d0fbd6394e/python/mypy/pull/17371
og:image:altFixes #12155, fixes #11673, seems pretty commonly reported issue
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/17371#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17371
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17371
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/17371
Reloadhttps://github.com/python/mypy/pull/17371
Reloadhttps://github.com/python/mypy/pull/17371
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:fix-type-aliashttps://github.com/hauntsaninja/mypy/tree/fix-type-alias
Conversationhttps://github.com/python/mypy/pull/17371
Commits4 (4)https://github.com/python/mypy/pull/17371/commits
Checkshttps://github.com/python/mypy/pull/17371/checks
Files changedhttps://github.com/python/mypy/pull/17371/files
Fix isinstance with type aliases to PEP 604 unionshttps://github.com/python/mypy/pull/17371#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:fix-type-aliashttps://github.com/hauntsaninja/mypy/tree/fix-type-alias
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jun 12, 2024https://github.com/python/mypy/pull/17371#issue-2349525531
Please reload this pagehttps://github.com/python/mypy/pull/17371
#12155https://github.com/python/mypy/issues/12155
#11673https://github.com/python/mypy/issues/11673
Please reload this pagehttps://github.com/python/mypy/pull/17371
https://github.com/hauntsaninja
Fix isinstance with PEP 604 type aliaseshttps://github.com/python/mypy/pull/17371/commits/0fa9f0c9a1285a82806d2a1f8b2eed9bb729b5b3
0fa9f0chttps://github.com/python/mypy/pull/17371/commits/0fa9f0c9a1285a82806d2a1f8b2eed9bb729b5b3
python#12155https://github.com/python/mypy/issues/12155
python#11673https://github.com/python/mypy/issues/11673
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17371
https://github.com/hauntsaninja
.https://github.com/python/mypy/pull/17371/commits/bd96ef6ba3e46eeca5c8f1afb3c8ab96495c18b7
bd96ef6https://github.com/python/mypy/pull/17371/commits/bd96ef6ba3e46eeca5c8f1afb3c8ab96495c18b7
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17371
https://github.com/hauntsaninja
.https://github.com/python/mypy/pull/17371/commits/e037a30d603c3f31cbbb6e2536a87ef320f60460
e037a30https://github.com/python/mypy/pull/17371/commits/e037a30d603c3f31cbbb6e2536a87ef320f60460
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17371
https://github.com/hauntsaninja
.https://github.com/python/mypy/pull/17371/commits/2084372190e0b8d86cf4d1118705eb4cb6dbaa67
2084372https://github.com/python/mypy/pull/17371/commits/2084372190e0b8d86cf4d1118705eb4cb6dbaa67
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 12, 2024https://github.com/python/mypy/pull/17371#issuecomment-2163926100
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/17371
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
upnext https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext
Jun 12, 2024https://github.com/python/mypy/pull/17371#event-13137982553
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jun 12, 2024https://github.com/python/mypy/pull/17371#event-13137990323
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Jun 13, 2024 https://github.com/python/mypy/pull/17371#pullrequestreview-2115445793
View reviewed changes https://github.com/python/mypy/pull/17371/files/2084372190e0b8d86cf4d1118705eb4cb6dbaa67
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/17371#pullrequestreview-2115445793
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/17371
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Jun 13, 2024https://github.com/python/mypy/pull/17371#issuecomment-2165721363
Please reload this pagehttps://github.com/python/mypy/pull/17371
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jun 13, 2024https://github.com/python/mypy/pull/17371#issuecomment-2166809362
Please reload this pagehttps://github.com/python/mypy/pull/17371
python/typeshed#12137https://github.com/python/typeshed/issues/12137
Please reload this pagehttps://github.com/python/mypy/pull/17371
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
98a22c4https://github.com/python/mypy/commit/98a22c44c26ff436f1c343ad4727258ffd72e055
Jun 13, 2024https://github.com/python/mypy/pull/17371#event-13152921758
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
June 13, 2024 21:17https://github.com/python/mypy/pull/17371#event-13152922254
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jun 13, 2024https://github.com/python/mypy/pull/17371#issuecomment-2166812052
#13810https://github.com/python/mypy/issues/13810
Please reload this pagehttps://github.com/python/mypy/pull/17371
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jun 13, 2024 https://github.com/python/mypy/pull/17371#ref-issue-1396283398
Union not being recognized as types.UnionType #13810 https://github.com/python/mypy/issues/13810
https://github.com/ngnpope
ngnpopehttps://github.com/ngnpope
Jun 14, 2024 https://github.com/python/mypy/pull/17371#ref-issue-2316207051
1.11 Release Tracking Issue #17285 https://github.com/python/mypy/issues/17285
https://github.com/ngnpope
ngnpopehttps://github.com/ngnpope
Jul 22, 2024https://github.com/python/mypy/pull/17371#issuecomment-2243200563
Please reload this pagehttps://github.com/python/mypy/pull/17371
@hauntsaninjahttps://github.com/hauntsaninja
this linehttps://github.com/python/mypy/pull/17371/files#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07R534
Please reload this pagehttps://github.com/python/mypy/pull/17371
https://github.com/ngnpope
ngnpopehttps://github.com/ngnpope
Jul 23, 2024 https://github.com/python/mypy/pull/17371#ref-pullrequest-2423684801
Fix PEP 604 isinstance caching #17563 https://github.com/python/mypy/pull/17563
https://github.com/wgreenberg
wgreenberghttps://github.com/wgreenberg
Jul 30, 2024 https://github.com/python/mypy/pull/17371#ref-pullrequest-2170088244
acme: deprecate gen_ss_cert(), introduce replacement make_self_signed_cert() certbot/certbot#9909 https://github.com/certbot/certbot/pull/9909
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 5, 2024 https://github.com/python/mypy/pull/17371#ref-issue-2413985460
(🐞) crash with --pretty from attrs raising an error in the wrong file #17535 https://github.com/python/mypy/issues/17535
https://github.com/bram-tv
bram-tvhttps://github.com/bram-tv
Aug 15, 2024 https://github.com/python/mypy/pull/17371#ref-issue-2468140685
Support typing.Union/typing.Optional in isinstance check (/support old-style unions) #17680 https://github.com/python/mypy/issues/17680
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Jan 12, 2025 https://github.com/python/mypy/pull/17371#ref-issue-2782308725
Inline configuration for a newer Python version crashes for union syntax on types (PEP 604) #18450 https://github.com/python/mypy/issues/18450
https://github.com/uranusjr
uranusjrhttps://github.com/uranusjr
Jul 8, 2025 https://github.com/python/mypy/pull/17371#ref-pullrequest-3174935739
Remove direct scheduler BaseOperator refs apache/airflow#52234 https://github.com/apache/airflow/pull/52234
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17371
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/17371/files/2084372190e0b8d86cf4d1118705eb4cb6dbaa67
Please reload this pagehttps://github.com/python/mypy/pull/17371
upnext https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext
Unexpected error behaviour: Parameterized generics cannot be used with class or instance checks https://github.com/python/mypy/issues/12155
isinstance doesn't work on type aliases that use a union https://github.com/python/mypy/issues/11673
Please reload this pagehttps://github.com/python/mypy/pull/17371
https://github.com/hauntsaninja
https://github.com/JelleZijlstra
https://github.com/ngnpope
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.