René's URL Explorer Experiment


Title: Check override compatibility for dynamically typed methods by stroxler · Pull Request #17274 · python/mypy · GitHub

Open Graph Title: Check override compatibility for dynamically typed methods by stroxler · Pull Request #17274 · python/mypy

X Title: Check override compatibility for dynamically typed methods by stroxler · Pull Request #17274 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This fixes #9618 in a fairly aggressive way, by turning on all override checks for all methods. This means that with this change, MyPy will complain in cases where just inspecting type signatures i...

X Description: This fixes #9618 in a fairly aggressive way, by turning on all override checks for all methods. This means that with this change, MyPy will complain in cases where just inspecting type signatures i...

Opengraph URL: https://github.com/python/mypy/pull/17274

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c23c884b-ce90-8d4d-b90a-7ad12e003469
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id814A:390AA2:221DF09:2E74DFA:6B0025EF
html-safe-nonce86680d9e8daf2f94504a69bc8cb4e26d0d39142b17c078cef30191f31404198f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTRBOjM5MEFBMjoyMjFERjA5OjJFNzRERkE6NkIwMDI1RUYiLCJ2aXNpdG9yX2lkIjoiODk2Mzk0Mjc3Njg4MjM0MTM1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac37d239715f5bcb27ac7f4d7dd4c1a362734e96dee92b93815103e1a4866cdfdb
hovercard-subject-tagpull_request:1880909691
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/17274/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9ce97b900a852cda53ca8fa491ba37af2f930b5035b43a963cb8886286d97144/python/mypy/pull/17274
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9ce97b900a852cda53ca8fa491ba37af2f930b5035b43a963cb8886286d97144/python/mypy/pull/17274
og:image:altThis fixes #9618 in a fairly aggressive way, by turning on all override checks for all methods. This means that with this change, MyPy will complain in cases where just inspecting type signatures i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamestroxler
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/17274#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17274
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17274
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/17274
Reloadhttps://github.com/python/mypy/pull/17274
Reloadhttps://github.com/python/mypy/pull/17274
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
stroxlerhttps://github.com/stroxler
python:masterhttps://github.com/python/mypy/tree/master
stroxler:stroxler-fixes-9618-plushttps://github.com/stroxler/mypy/tree/stroxler-fixes-9618-plus
Conversationhttps://github.com/python/mypy/pull/17274
Commits3 (3)https://github.com/python/mypy/pull/17274/commits
Checkshttps://github.com/python/mypy/pull/17274/checks
Files changedhttps://github.com/python/mypy/pull/17274/files
Check override compatibility for dynamically typed methodshttps://github.com/python/mypy/pull/17274#top
stroxlerhttps://github.com/stroxler
python:masterhttps://github.com/python/mypy/tree/master
stroxler:stroxler-fixes-9618-plushttps://github.com/stroxler/mypy/tree/stroxler-fixes-9618-plus
https://github.com/stroxler
stroxlerhttps://github.com/stroxler
May 21, 2024https://github.com/python/mypy/pull/17274#issue-2308808867
#9618https://github.com/python/mypy/issues/9618
@final decorator is not honored on override with --check-untyped-defs #9618https://github.com/python/mypy/issues/9618
Please reload this pagehttps://github.com/python/mypy/pull/17274
https://github.com/stroxler
Check override compatibility for dynamically typed methodshttps://github.com/python/mypy/pull/17274/commits/a463090c398e0f8fc4772df743a5ba266fd90522
a463090https://github.com/python/mypy/pull/17274/commits/a463090c398e0f8fc4772df743a5ba266fd90522
python#9618https://github.com/python/mypy/issues/9618
python#9618https://github.com/python/mypy/issues/9618
https://github.com/stroxler
stroxlerhttps://github.com/stroxler
force-pushedhttps://github.com/python/mypy/compare/323cbd7cbbe3ddac514596be68ca20462d710c83..a463090c398e0f8fc4772df743a5ba266fd90522
323cbd7https://github.com/python/mypy/commit/323cbd7cbbe3ddac514596be68ca20462d710c83
a463090https://github.com/python/mypy/commit/a463090c398e0f8fc4772df743a5ba266fd90522
Compare https://github.com/python/mypy/compare/323cbd7cbbe3ddac514596be68ca20462d710c83..a463090c398e0f8fc4772df743a5ba266fd90522
May 21, 2024 18:03https://github.com/python/mypy/pull/17274#event-12883661821
https://github.com/marketplace/pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hookshttps://github.com/python/mypy/pull/17274/commits/de53ba3c2d7056ddbe5cc2d3e8b62c3f3d052b2e
de53ba3https://github.com/python/mypy/pull/17274/commits/de53ba3c2d7056ddbe5cc2d3e8b62c3f3d052b2e
https://pre-commit.cihttps://pre-commit.ci
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17274
https://github.com/stroxler
Fix bad test casehttps://github.com/python/mypy/pull/17274/commits/9068fdf2fbbd9d866ebc63e01dcc80f97c8453ca
9068fdfhttps://github.com/python/mypy/pull/17274/commits/9068fdf2fbbd9d866ebc63e01dcc80f97c8453ca
https://github.com/stroxler
stroxlerhttps://github.com/stroxler
May 21, 2024https://github.com/python/mypy/pull/17274#issuecomment-2123264491
Please reload this pagehttps://github.com/python/mypy/pull/17274
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 21, 2024https://github.com/python/mypy/pull/17274#issuecomment-2123335432
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/17274
stroxlerhttps://github.com/stroxler
May 21, 2024 https://github.com/python/mypy/pull/17274#ref-commit-3b5105e
https://github.com/stroxler
Validate more about overrides on untyped methodshttps://github.com/stroxler/mypy/commit/3b5105ecfed77e30538d3733bea149ae76851721
3b5105ehttps://github.com/stroxler/mypy/commit/3b5105ecfed77e30538d3733bea149ae76851721
python#9618https://github.com/python/mypy/issues/9618
python#17274https://github.com/python/mypy/pull/17274
https://github.com/stroxler
stroxlerhttps://github.com/stroxler
May 21, 2024 https://github.com/python/mypy/pull/17274#ref-pullrequest-2309039650
Validate more about overrides on untyped methods #17276 https://github.com/python/mypy/pull/17276
https://github.com/stroxler
stroxlerhttps://github.com/stroxler
May 21, 2024https://github.com/python/mypy/pull/17274#issuecomment-2123368535
#17276https://github.com/python/mypy/pull/17276
Please reload this pagehttps://github.com/python/mypy/pull/17274
https://github.com/stroxler
stroxlerhttps://github.com/stroxler
May 21, 2024https://github.com/python/mypy/pull/17274#event-12885010512
hauntsaninjahttps://github.com/hauntsaninja
May 23, 2024 https://github.com/python/mypy/pull/17274#ref-commit-25087fd
https://github.com/stroxler
Validate more about overrides on untyped methods (https://github.com/python/mypy/commit/25087fdbb72d1495e6903d171dee999c47ba09fd
#17276https://github.com/python/mypy/pull/17276
)https://github.com/python/mypy/commit/25087fdbb72d1495e6903d171dee999c47ba09fd
25087fdhttps://github.com/python/mypy/commit/25087fdbb72d1495e6903d171dee999c47ba09fd
#9618https://github.com/python/mypy/issues/9618
#17274https://github.com/python/mypy/pull/17274
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17274
Please reload this pagehttps://github.com/python/mypy/pull/17274
@final decorator is not honored on override with --check-untyped-defs https://github.com/python/mypy/issues/9618
Please reload this pagehttps://github.com/python/mypy/pull/17274
https://github.com/stroxler
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.