René's URL Explorer Experiment


Title: Fix Literal strings containing pipe characters by JelleZijlstra · Pull Request #17148 · python/mypy · GitHub

Open Graph Title: Fix Literal strings containing pipe characters by JelleZijlstra · Pull Request #17148 · python/mypy

X Title: Fix Literal strings containing pipe characters by JelleZijlstra · Pull Request #17148 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #16367 During semantic analysis, we try to parse all strings as types, including those inside Literal[]. Previously, we preserved the original string in the UnboundType.original_str_expr attr...

X Description: Fixes #16367 During semantic analysis, we try to parse all strings as types, including those inside Literal[]. Previously, we preserved the original string in the UnboundType.original_str_expr attr...

Opengraph URL: https://github.com/python/mypy/pull/17148

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:6ae114e3-edd2-cec9-7f05-53da50163011
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA698:1A2F85:A7689A:E0C7E3:6B0047D0
html-safe-noncea7afa28cc0c122049c755dd681b55780868e3a3f67a197655af2ce5d3850eecb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjk4OjFBMkY4NTpBNzY4OUE6RTBDN0UzOjZCMDA0N0QwIiwidmlzaXRvcl9pZCI6Ijc2ODAzMDg0NzM4MTIyNDAzMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc26e79667351d392ba8e95aacb14282d8339b6ef142175f627c016a0ea499f57
hovercard-subject-tagpull_request:1833371583
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/17148
twitter:imagehttps://opengraph.githubassets.com/885d9c10f1757d8a9718dfd39b063f44f957aa6ce5404fe53ee70030773ad28c/python/mypy/pull/17148
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/885d9c10f1757d8a9718dfd39b063f44f957aa6ce5404fe53ee70030773ad28c/python/mypy/pull/17148
og:image:altFixes #16367 During semantic analysis, we try to parse all strings as types, including those inside Literal[]. Previously, we preserved the original string in the UnboundType.original_str_expr attr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleZijlstra
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/17148#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17148
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17148
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/17148
Reloadhttps://github.com/python/mypy/pull/17148
Reloadhttps://github.com/python/mypy/pull/17148
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JelleZijlstrahttps://github.com/JelleZijlstra
python:masterhttps://github.com/python/mypy/tree/master
JelleZijlstra:literalpipehttps://github.com/JelleZijlstra/mypy/tree/literalpipe
Conversationhttps://github.com/python/mypy/pull/17148
Commits11 (11)https://github.com/python/mypy/pull/17148/commits
Checkshttps://github.com/python/mypy/pull/17148/checks
Files changedhttps://github.com/python/mypy/pull/17148/files
Fix Literal strings containing pipe charactershttps://github.com/python/mypy/pull/17148#top
JelleZijlstrahttps://github.com/JelleZijlstra
python:masterhttps://github.com/python/mypy/tree/master
JelleZijlstra:literalpipehttps://github.com/JelleZijlstra/mypy/tree/literalpipe
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 21, 2024https://github.com/python/mypy/pull/17148#issue-2255142202
#16367https://github.com/python/mypy/issues/16367
Please reload this pagehttps://github.com/python/mypy/pull/17148
JelleZijlstrahttps://github.com/JelleZijlstra
April 21, 2024 08:15https://github.com/python/mypy/pull/17148#commits-pushed-c8a0499
https://github.com/JelleZijlstra
Initial version of RawExpr changehttps://github.com/python/mypy/pull/17148/commits/c8a0499245cc790e081a245b79b40990950c020e
c8a0499https://github.com/python/mypy/pull/17148/commits/c8a0499245cc790e081a245b79b40990950c020e
https://github.com/JelleZijlstra
Fix parser testshttps://github.com/python/mypy/pull/17148/commits/5f9d1f53e07a96a8736fa0d9a664e3bb4b725ff8
5f9d1f5https://github.com/python/mypy/pull/17148/commits/5f9d1f53e07a96a8736fa0d9a664e3bb4b725ff8
https://github.com/JelleZijlstra
fix stubgen testhttps://github.com/python/mypy/pull/17148/commits/757a8e6f6710f5a0d2f43e17c35dda5020488e4b
757a8e6https://github.com/python/mypy/pull/17148/commits/757a8e6f6710f5a0d2f43e17c35dda5020488e4b
https://github.com/JelleZijlstra
Fix quoted "Final"https://github.com/python/mypy/pull/17148/commits/ed15fdf05ffbc7665e4e0b0bbc2aca90976891dd
ed15fdfhttps://github.com/python/mypy/pull/17148/commits/ed15fdf05ffbc7665e4e0b0bbc2aca90976891dd
https://github.com/JelleZijlstra
Extend testhttps://github.com/python/mypy/pull/17148/commits/b29ae1da8212f47b60306b45d9d9cc5bb3cd1076
b29ae1dhttps://github.com/python/mypy/pull/17148/commits/b29ae1da8212f47b60306b45d9d9cc5bb3cd1076
https://github.com/JelleZijlstra
Fix mypychttps://github.com/python/mypy/pull/17148/commits/8dd0ed5328d2ae0716c344958dccb5fb993b3d44
8dd0ed5https://github.com/python/mypy/pull/17148/commits/8dd0ed5328d2ae0716c344958dccb5fb993b3d44
https://github.com/JelleZijlstra
Clean up original_str_exprhttps://github.com/python/mypy/pull/17148/commits/9112397b3ee67177040cc64b4130616821c8ecf0
9112397https://github.com/python/mypy/pull/17148/commits/9112397b3ee67177040cc64b4130616821c8ecf0
https://github.com/JelleZijlstra
formattinghttps://github.com/python/mypy/pull/17148/commits/6f86cb4d2751b9524b3c02744b946965682cb6cf
6f86cb4https://github.com/python/mypy/pull/17148/commits/6f86cb4d2751b9524b3c02744b946965682cb6cf
https://github.com/JelleZijlstra
fix self checkhttps://github.com/python/mypy/pull/17148/commits/36019e584d8ea8ed8f7dd225289ebd85b147bbd9
36019e5https://github.com/python/mypy/pull/17148/commits/36019e584d8ea8ed8f7dd225289ebd85b147bbd9
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17148
JelleZijlstrahttps://github.com/JelleZijlstra
April 21, 2024 10:38https://github.com/python/mypy/pull/17148#commits-pushed-6ddb9c5
https://github.com/JelleZijlstra
Fix string annotations in some contextshttps://github.com/python/mypy/pull/17148/commits/6ddb9c50fb695cd6b0610211e5f3cb6f7fa82b3a
6ddb9c5https://github.com/python/mypy/pull/17148/commits/6ddb9c50fb695cd6b0610211e5f3cb6f7fa82b3a
https://github.com/JelleZijlstra
One morehttps://github.com/python/mypy/pull/17148/commits/b41f71e67b0513e061d3bdd0f727fad192d821e7
b41f71ehttps://github.com/python/mypy/pull/17148/commits/b41f71e67b0513e061d3bdd0f727fad192d821e7
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 21, 2024https://github.com/python/mypy/pull/17148#issuecomment-2068149013
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/17148
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 21, 2024 https://github.com/python/mypy/pull/17148#pullrequestreview-2013565161
View reviewed changes https://github.com/python/mypy/pull/17148/files/b41f71e67b0513e061d3bdd0f727fad192d821e7
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
1072c78https://github.com/python/mypy/commit/1072c78ad375b7f0511549287f54432050396717
Apr 22, 2024https://github.com/python/mypy/pull/17148#event-12553099723
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
April 22, 2024 02:31https://github.com/python/mypy/pull/17148#event-12553100120
https://github.com/max-muoto
max-muotohttps://github.com/max-muoto
Jun 8, 2024 https://github.com/python/mypy/pull/17148#ref-pullrequest-2341779344
Add missing tarfile.open overload for writable objects python/typeshed#12117 https://github.com/python/typeshed/pull/12117
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jul 10, 2024 https://github.com/python/mypy/pull/17148#ref-issue-2401489423
AssertionError with TypedDict and --cache-fine-grained in v1.11.0 #17515 https://github.com/python/mypy/issues/17515
https://github.com/andersk
anderskhttps://github.com/andersk
Jul 26, 2024 https://github.com/python/mypy/pull/17148#ref-issue-2431260323
Another AssertionError with TypedDict and --cache-fine-grained in v1.11.0 #17587 https://github.com/python/mypy/issues/17587
anderskhttps://github.com/andersk
Jul 26, 2024 https://github.com/python/mypy/pull/17148#ref-commit-5006204
https://github.com/andersk
Fix RawExpressionType.accept crash with --cache-fine-grainedhttps://github.com/andersk/mypy/commit/500620484d0e12fd875ebb801a61b6c881820897
5006204https://github.com/andersk/mypy/commit/500620484d0e12fd875ebb801a61b6c881820897
1072c78https://github.com/andersk/mypy/commit/1072c78ad375b7f0511549287f54432050396717
python#17148https://github.com/python/mypy/pull/17148
python#17587https://github.com/python/mypy/issues/17587
https://github.com/andersk
anderskhttps://github.com/andersk
Jul 26, 2024 https://github.com/python/mypy/pull/17148#ref-pullrequest-2431305122
Fix RawExpressionType.accept crash with --cache-fine-grained #17588 https://github.com/python/mypy/pull/17588
JelleZijlstrahttps://github.com/JelleZijlstra
Jul 26, 2024 https://github.com/python/mypy/pull/17148#ref-commit-8b74b5a
https://github.com/andersk
Fixhttps://github.com/python/mypy/commit/8b74b5ab03742ba86348dfe14d0468a995f74ee7
RawExpressionType.accepthttps://github.com/python/mypy/commit/8b74b5ab03742ba86348dfe14d0468a995f74ee7
crash withhttps://github.com/python/mypy/commit/8b74b5ab03742ba86348dfe14d0468a995f74ee7
--cache-fine-grainedhttps://github.com/python/mypy/commit/8b74b5ab03742ba86348dfe14d0468a995f74ee7
(https://github.com/python/mypy/commit/8b74b5ab03742ba86348dfe14d0468a995f74ee7
#17588https://github.com/python/mypy/pull/17588
8b74b5ahttps://github.com/python/mypy/commit/8b74b5ab03742ba86348dfe14d0468a995f74ee7
https://github.com/python/mypy/pull/17588
1072c78https://github.com/python/mypy/commit/1072c78ad375b7f0511549287f54432050396717
#17148https://github.com/python/mypy/pull/17148
#17574https://github.com/python/mypy/issues/17574
#17587https://github.com/python/mypy/issues/17587
hauntsaninjahttps://github.com/hauntsaninja
Jul 27, 2024 https://github.com/python/mypy/pull/17148#ref-commit-b3a102e
https://github.com/andersk
https://github.com/hauntsaninja
Fixhttps://github.com/python/mypy/commit/b3a102ef31f63a8a8ba32c8dbe160ddef3c43054
RawExpressionType.accepthttps://github.com/python/mypy/commit/b3a102ef31f63a8a8ba32c8dbe160ddef3c43054
crash withhttps://github.com/python/mypy/commit/b3a102ef31f63a8a8ba32c8dbe160ddef3c43054
--cache-fine-grainedhttps://github.com/python/mypy/commit/b3a102ef31f63a8a8ba32c8dbe160ddef3c43054
(https://github.com/python/mypy/commit/b3a102ef31f63a8a8ba32c8dbe160ddef3c43054
#17588https://github.com/python/mypy/pull/17588
b3a102ehttps://github.com/python/mypy/commit/b3a102ef31f63a8a8ba32c8dbe160ddef3c43054
https://github.com/python/mypy/pull/17588
1072c78https://github.com/python/mypy/commit/1072c78ad375b7f0511549287f54432050396717
#17148https://github.com/python/mypy/pull/17148
#17574https://github.com/python/mypy/issues/17574
#17587https://github.com/python/mypy/issues/17587
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 4, 2024https://github.com/python/mypy/pull/17148#issuecomment-2267500269
Please reload this pagehttps://github.com/python/mypy/pull/17148
ilevkivskyihttps://github.com/ilevkivskyi
Aug 4, 2024 https://github.com/python/mypy/pull/17148#ref-commit-7d8162f
https://github.com/ilevkivskyi
Revert "Fix Literal strings containing pipe characters (https://github.com/python/mypy/commit/7d8162f4d01a34fd306d8d28be49a31e430adecc
#17148https://github.com/python/mypy/pull/17148
)"https://github.com/python/mypy/commit/7d8162f4d01a34fd306d8d28be49a31e430adecc
7d8162fhttps://github.com/python/mypy/commit/7d8162f4d01a34fd306d8d28be49a31e430adecc
1072c78https://github.com/python/mypy/commit/1072c78ad375b7f0511549287f54432050396717
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 4, 2024 https://github.com/python/mypy/pull/17148#ref-pullrequest-2447090290
Revert "Fix Literal strings containing pipe characters" #17638 https://github.com/python/mypy/pull/17638
ilevkivskyihttps://github.com/ilevkivskyi
Aug 4, 2024 https://github.com/python/mypy/pull/17148#ref-commit-bc39f17
https://github.com/ilevkivskyi
Revert "Fix Literal strings containing pipe characters" (https://github.com/python/mypy/commit/bc39f1714e2e5f39eb90f05f74575a7c397f068b
#17638https://github.com/python/mypy/pull/17638
)https://github.com/python/mypy/commit/bc39f1714e2e5f39eb90f05f74575a7c397f068b
bc39f17https://github.com/python/mypy/commit/bc39f1714e2e5f39eb90f05f74575a7c397f068b
#17148https://github.com/python/mypy/pull/17148
mr-chttps://github.com/mr-c
Aug 14, 2024 https://github.com/python/mypy/pull/17148#ref-commit-ed69f96
https://github.com/ilevkivskyi
https://github.com/mr-c
Revert "Fix Literal strings containing pipe characters" (https://github.com/mr-c/mypy/commit/ed69f96dd80f30afcb8ebe5118b726bc37c1d933
python#17638https://github.com/python/mypy/pull/17638
)https://github.com/mr-c/mypy/commit/ed69f96dd80f30afcb8ebe5118b726bc37c1d933
ed69f96https://github.com/mr-c/mypy/commit/ed69f96dd80f30afcb8ebe5118b726bc37c1d933
python#17148https://github.com/python/mypy/pull/17148
md384https://github.com/md384
Aug 14, 2024 https://github.com/python/mypy/pull/17148#ref-commit-214b1a2
https://github.com/ilevkivskyi
Revert "Fix Literal strings containing pipe characters" (https://github.com/md384/mypy/commit/214b1a23ffad22a9952fd3f4dbc524826c27606c
python#17638https://github.com/python/mypy/pull/17638
)https://github.com/md384/mypy/commit/214b1a23ffad22a9952fd3f4dbc524826c27606c
214b1a2https://github.com/md384/mypy/commit/214b1a23ffad22a9952fd3f4dbc524826c27606c
python#17148https://github.com/python/mypy/pull/17148
bc39f17https://github.com/md384/mypy/commit/bc39f1714e2e5f39eb90f05f74575a7c397f068b
hauntsaninjahttps://github.com/hauntsaninja
Aug 24, 2024 https://github.com/python/mypy/pull/17148#ref-commit-32675dd
https://github.com/ilevkivskyi
https://github.com/hauntsaninja
Revert "Fix Literal strings containing pipe characters" (https://github.com/python/mypy/commit/32675dddfacccef616557916cb872757605ab493
#17638https://github.com/python/mypy/pull/17638
)https://github.com/python/mypy/commit/32675dddfacccef616557916cb872757605ab493
32675ddhttps://github.com/python/mypy/commit/32675dddfacccef616557916cb872757605ab493
#17148https://github.com/python/mypy/pull/17148
bc39f17https://github.com/python/mypy/commit/bc39f1714e2e5f39eb90f05f74575a7c397f068b
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
September 10, 2024 23:37https://github.com/python/mypy/pull/17148#event-14207412734
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17148
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/17148/files/b41f71e67b0513e061d3bdd0f727fad192d821e7
Please reload this pagehttps://github.com/python/mypy/pull/17148
mypy interprets arguments which contains a pipe to Literal as type strings instead of literals https://github.com/python/mypy/issues/16367
Please reload this pagehttps://github.com/python/mypy/pull/17148
https://github.com/JelleZijlstra
https://github.com/ilevkivskyi
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.