René's URL Explorer Experiment


Title: Fix attrs hashability detection when inheriting from mutable by Tinche · Pull Request #17012 · python/mypy · GitHub

Open Graph Title: Fix attrs hashability detection when inheriting from mutable by Tinche · Pull Request #17012 · python/mypy

X Title: Fix attrs hashability detection when inheriting from mutable by Tinche · Pull Request #17012 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Frozen attrs classes inheriting from mutable classes are hashable; fix this case and add a test. Also support frozen classes with hash=False (although I'm not sure this is a common use case at ...

X Description: Frozen attrs classes inheriting from mutable classes are hashable; fix this case and add a test. Also support frozen classes with hash=False (although I'm not sure this is a common use case...

Opengraph URL: https://github.com/python/mypy/pull/17012

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:73af58cc-5a56-52b6-665a-b610025ccab5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7EA:3430F7:BE7D1E:FF7BFA:6B004D07
html-safe-nonce224a9fd300102d07e01ee128f340f0ac3ba8c9b165eb249ae5c28c16804a401d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0VBOjM0MzBGNzpCRTdEMUU6RkY3QkZBOjZCMDA0RDA3IiwidmlzaXRvcl9pZCI6IjQwMTQ0MTQ4NTMyNjY2NzAxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac215f326ca3615648a1c1226c52291333db3294077f906064fed9f17503e46b4d
hovercard-subject-tagpull_request:1764630735
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/17012/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3e5e9adc9a474ae2fc500044f4b81da88f1317288c3d0fc2d4534a5d72829ed7/python/mypy/pull/17012
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3e5e9adc9a474ae2fc500044f4b81da88f1317288c3d0fc2d4534a5d72829ed7/python/mypy/pull/17012
og:image:altFrozen attrs classes inheriting from mutable classes are hashable; fix this case and add a test. Also support frozen classes with hash=False (although I'm not sure this is a common use case at ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTinche
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/17012#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17012
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17012
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/17012
Reloadhttps://github.com/python/mypy/pull/17012
Reloadhttps://github.com/python/mypy/pull/17012
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
Tinchehttps://github.com/Tinche
python:masterhttps://github.com/python/mypy/tree/master
Tinche:tin/fix-attrs-frozen-hashabilityhttps://github.com/Tinche/mypy/tree/tin/fix-attrs-frozen-hashability
Conversationhttps://github.com/python/mypy/pull/17012
Commits3 (3)https://github.com/python/mypy/pull/17012/commits
Checkshttps://github.com/python/mypy/pull/17012/checks
Files changedhttps://github.com/python/mypy/pull/17012/files
Fix attrs hashability detection when inheriting from mutablehttps://github.com/python/mypy/pull/17012#top
Tinchehttps://github.com/Tinche
python:masterhttps://github.com/python/mypy/tree/master
Tinche:tin/fix-attrs-frozen-hashabilityhttps://github.com/Tinche/mypy/tree/tin/fix-attrs-frozen-hashability
https://github.com/Tinche
Tinchehttps://github.com/Tinche
Mar 10, 2024https://github.com/python/mypy/pull/17012#issue-2177948078
Please reload this pagehttps://github.com/python/mypy/pull/17012
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17012
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17012
Tinchehttps://github.com/Tinche
March 11, 2024 20:48https://github.com/python/mypy/pull/17012#commits-pushed-d8a7f0f
https://github.com/Tinche
Fix attrs hashability detection when inheriting from mutablehttps://github.com/python/mypy/pull/17012/commits/d8a7f0f2b67e7a00e845170e7c549fe67bfede92
d8a7f0fhttps://github.com/python/mypy/pull/17012/commits/d8a7f0f2b67e7a00e845170e7c549fe67bfede92
https://github.com/marketplace/pre-commit-ci
https://github.com/Tinche
[pre-commit.ci] auto fixes from pre-commit.com hookshttps://github.com/python/mypy/pull/17012/commits/6836bd681fabbb5958fa682c3ef9689162a4b0cb
6836bd6https://github.com/python/mypy/pull/17012/commits/6836bd681fabbb5958fa682c3ef9689162a4b0cb
https://pre-commit.cihttps://pre-commit.ci
https://github.com/Tinche
Tweak test fixturehttps://github.com/python/mypy/pull/17012/commits/45454ef986f22de5e4fa5d0811ad75f794b2a2b8
45454efhttps://github.com/python/mypy/pull/17012/commits/45454ef986f22de5e4fa5d0811ad75f794b2a2b8
https://github.com/Tinche
Tinchehttps://github.com/Tinche
force-pushedhttps://github.com/python/mypy/compare/633db11c945a328fffef7dd4d8000a98c0887a8e..45454ef986f22de5e4fa5d0811ad75f794b2a2b8
633db11https://github.com/python/mypy/commit/633db11c945a328fffef7dd4d8000a98c0887a8e
45454efhttps://github.com/python/mypy/commit/45454ef986f22de5e4fa5d0811ad75f794b2a2b8
Compare https://github.com/python/mypy/compare/633db11c945a328fffef7dd4d8000a98c0887a8e..45454ef986f22de5e4fa5d0811ad75f794b2a2b8
March 11, 2024 19:48https://github.com/python/mypy/pull/17012#event-12079222653
https://github.com/Tinche
Tinchehttps://github.com/Tinche
Mar 11, 2024https://github.com/python/mypy/pull/17012#issuecomment-1989307940
@sobolevnhttps://github.com/sobolevn
Please reload this pagehttps://github.com/python/mypy/pull/17012
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 11, 2024https://github.com/python/mypy/pull/17012#issuecomment-1989330957
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/17012
Hnasarhttps://github.com/Hnasar
Mar 11, 2024 https://github.com/python/mypy/pull/17012#ref-commit-73bf317
https://github.com/Tinche
https://github.com/Hnasar
Fix attrs hashability detectionhttps://github.com/Hnasar/mypy/commit/73bf3179fb55d82c2bdcfa26fcea4bcba54b1ad7
73bf317https://github.com/Hnasar/mypy/commit/73bf3179fb55d82c2bdcfa26fcea4bcba54b1ad7
91be285https://github.com/Hnasar/mypy/commit/91be28552e062601adc2a07075263994c102d5cc
https://www.attrs.org/en/stable/hashing.htmlhttps://www.attrs.org/en/stable/hashing.html
https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689
python#17015https://github.com/python/mypy/issues/17015
python#16556 (comment)https://github.com/python/mypy/pull/16556#issuecomment-1987116488
python#17012https://github.com/python/mypy/pull/17012
Hnasarhttps://github.com/Hnasar
Mar 11, 2024 https://github.com/python/mypy/pull/17012#ref-commit-00c0ef7
https://github.com/Hnasar
https://github.com/Tinche
Fix attrs hashability detectionhttps://github.com/Hnasar/mypy/commit/00c0ef733e7189397fb8c01ef770adb5f85ddd59
00c0ef7https://github.com/Hnasar/mypy/commit/00c0ef733e7189397fb8c01ef770adb5f85ddd59
91be285https://github.com/Hnasar/mypy/commit/91be28552e062601adc2a07075263994c102d5cc
https://www.attrs.org/en/stable/hashing.htmlhttps://www.attrs.org/en/stable/hashing.html
https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689
python#17015https://github.com/python/mypy/issues/17015
python#16556 (comment)https://github.com/python/mypy/pull/16556#issuecomment-1987116488
python#17012https://github.com/python/mypy/pull/17012
Hnasarhttps://github.com/Hnasar
Mar 11, 2024 https://github.com/python/mypy/pull/17012#ref-commit-93502ae
https://github.com/Hnasar
https://github.com/Tinche
attrs: Fix emulating hash method logichttps://github.com/Hnasar/mypy/commit/93502ae3464e6389bb0d90b50ab633fe99e64c45
93502aehttps://github.com/Hnasar/mypy/commit/93502ae3464e6389bb0d90b50ab633fe99e64c45
91be285https://github.com/Hnasar/mypy/commit/91be28552e062601adc2a07075263994c102d5cc
https://www.attrs.org/en/stable/hashing.htmlhttps://www.attrs.org/en/stable/hashing.html
https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689
python#17015https://github.com/python/mypy/issues/17015
python#16556 (comment)https://github.com/python/mypy/pull/16556#issuecomment-1987116488
python#17012https://github.com/python/mypy/pull/17012
Hnasarhttps://github.com/Hnasar
Mar 11, 2024 https://github.com/python/mypy/pull/17012#ref-commit-2349743
https://github.com/Hnasar
https://github.com/Tinche
attrs: Fix emulating hash method logichttps://github.com/Hnasar/mypy/commit/2349743b9c41d27ccdbfcdb579498ed84ffac88e
2349743https://github.com/Hnasar/mypy/commit/2349743b9c41d27ccdbfcdb579498ed84ffac88e
91be285https://github.com/Hnasar/mypy/commit/91be28552e062601adc2a07075263994c102d5cc
https://www.attrs.org/en/stable/hashing.htmlhttps://www.attrs.org/en/stable/hashing.html
https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689
python#17015https://github.com/python/mypy/issues/17015
python#16556 (comment)https://github.com/python/mypy/pull/16556#issuecomment-1987116488
python#17012https://github.com/python/mypy/pull/17012
Hnasarhttps://github.com/Hnasar
Mar 11, 2024 https://github.com/python/mypy/pull/17012#ref-commit-a663346
https://github.com/Hnasar
https://github.com/Tinche
attrs: Fix emulating hash method logichttps://github.com/Hnasar/mypy/commit/a663346072fb718acec71e95933694eea157072f
a663346https://github.com/Hnasar/mypy/commit/a663346072fb718acec71e95933694eea157072f
91be285https://github.com/Hnasar/mypy/commit/91be28552e062601adc2a07075263994c102d5cc
https://www.attrs.org/en/stable/hashing.htmlhttps://www.attrs.org/en/stable/hashing.html
https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689
python#17015https://github.com/python/mypy/issues/17015
python#16556 (comment)https://github.com/python/mypy/pull/16556#issuecomment-1987116488
python#17012https://github.com/python/mypy/pull/17012
https://github.com/Hnasar
Hnasarhttps://github.com/Hnasar
Mar 11, 2024 https://github.com/python/mypy/pull/17012#ref-pullrequest-2180461592
attrs: Fix emulating hash method logic #17016 https://github.com/python/mypy/pull/17016
https://github.com/Hnasar
Hnasarhttps://github.com/Hnasar
Mar 11, 2024https://github.com/python/mypy/pull/17012#issuecomment-1989664674
@Tinchehttps://github.com/Tinche
#17015https://github.com/python/mypy/issues/17015
#17016https://github.com/python/mypy/pull/17016
Please reload this pagehttps://github.com/python/mypy/pull/17012
Hnasarhttps://github.com/Hnasar
Mar 12, 2024 https://github.com/python/mypy/pull/17012#ref-commit-d40909e
https://github.com/Hnasar
https://github.com/Tinche
attrs: Fix emulating hash method logichttps://github.com/Hnasar/mypy/commit/d40909edea240cda5878170fe3a4b19e1412fff0
d40909ehttps://github.com/Hnasar/mypy/commit/d40909edea240cda5878170fe3a4b19e1412fff0
91be285https://github.com/Hnasar/mypy/commit/91be28552e062601adc2a07075263994c102d5cc
https://www.attrs.org/en/stable/hashing.htmlhttps://www.attrs.org/en/stable/hashing.html
https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689
python#17015https://github.com/python/mypy/issues/17015
python#16556 (comment)https://github.com/python/mypy/pull/16556#issuecomment-1987116488
python#17012https://github.com/python/mypy/pull/17012
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Mar 12, 2024https://github.com/python/mypy/pull/17012#issuecomment-1990987200
@Tinchehttps://github.com/Tinche
Please reload this pagehttps://github.com/python/mypy/pull/17012
https://github.com/Tinche
Tinchehttps://github.com/Tinche
Mar 12, 2024https://github.com/python/mypy/pull/17012#issuecomment-1991089214
@Hnasarhttps://github.com/Hnasar
@sobolevnhttps://github.com/sobolevn
Please reload this pagehttps://github.com/python/mypy/pull/17012
https://github.com/Tinche
Tinchehttps://github.com/Tinche
Mar 12, 2024https://github.com/python/mypy/pull/17012#event-12085621082
JukkaLhttps://github.com/JukkaL
Mar 15, 2024 https://github.com/python/mypy/pull/17012#ref-commit-31dc503
https://github.com/Hnasar
https://github.com/Tinche
attrs: Fix emulating hash method logic (https://github.com/python/mypy/commit/31dc50371aaa267f258f74275b4bc07f27d70001
#17016https://github.com/python/mypy/pull/17016
)https://github.com/python/mypy/commit/31dc50371aaa267f258f74275b4bc07f27d70001
31dc503https://github.com/python/mypy/commit/31dc50371aaa267f258f74275b4bc07f27d70001
91be285https://github.com/python/mypy/commit/91be28552e062601adc2a07075263994c102d5cc
https://www.attrs.org/en/stable/hashing.htmlhttps://www.attrs.org/en/stable/hashing.html
https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689https://github.com/python-attrs/attrs/blob/9e443b18527dc96b194e92805fa751cbf8434ba9/src/attr/_make.py#L1660-L1689
#17015https://github.com/python/mypy/issues/17015
#16556 (comment)https://github.com/python/mypy/pull/16556#issuecomment-1987116488
#17012https://github.com/python/mypy/pull/17012
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F17012
Please reload this pagehttps://github.com/python/mypy/pull/17012
Please reload this pagehttps://github.com/python/mypy/pull/17012
https://github.com/Tinche
https://github.com/Hnasar
https://github.com/sobolevn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.