| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4e664456-bb0c-c798-9c9c-cca5bc714a54 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BCA8:F5AA9:293556D:383832B:6B004BF2 |
| html-safe-nonce | 8705b0771eb2e2fbc1bdea88fd34a1830a476168fd3216569219de4227e1409b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0E4OkY1QUE5OjI5MzU1NkQ6MzgzODMyQjo2QjAwNEJGMiIsInZpc2l0b3JfaWQiOiI3NDAyNDg5MTAyNjgxMDAwOTQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1a49e9889b6b1bcae61d40d8fe5ac5c2ce28b804ce75f27b4c081fcb8aaaa652 |
| hovercard-subject-tag | pull_request:1706430694 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/16849/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1711cd6f143c27006d33bee21b7118d8546b42827591bfd0a0a3e50ab60bf582/python/mypy/pull/16849 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1711cd6f143c27006d33bee21b7118d8546b42827591bfd0a0a3e50ab60bf582/python/mypy/pull/16849 |
| og:image:alt | Closes #16649
It's the first time I am contributing to mypy so I am not very familiar with how it works entirely behind the scene. The issue that I had is that a crash happens when using tuple ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | picnixz |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/16849#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/16849 |
| Reload | https://github.com/python/mypy/pull/16849 |
| Reload | https://github.com/python/mypy/pull/16849 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| picnixz:gh-16649-type-comments-and-constrained-generics | https://github.com/picnixz/mypy/tree/gh-16649-type-comments-and-constrained-generics |
| Conversation | https://github.com/python/mypy/pull/16849 |
| Commits6 (6) | https://github.com/python/mypy/pull/16849/commits |
| Checks | https://github.com/python/mypy/pull/16849/checks |
| Files changed | https://github.com/python/mypy/pull/16849/files |
| Fix type comments crash inside generic definitions | https://github.com/python/mypy/pull/16849#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| picnixz:gh-16649-type-comments-and-constrained-generics | https://github.com/picnixz/mypy/tree/gh-16649-type-comments-and-constrained-generics |
|
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| Feb 1, 2024 | https://github.com/python/mypy/pull/16849#issue-2112702605 |
| #16649 | https://github.com/python/mypy/issues/16649 |
| Please reload this page | https://github.com/python/mypy/pull/16849 |
| picnixz | https://github.com/picnixz |
| February 1, 2024 15:34 | https://github.com/python/mypy/pull/16849#commits-pushed-e8b0554 |
|
| https://github.com/picnixz |
| Fix type comments crash inside generic definitions | https://github.com/python/mypy/pull/16849/commits/e8b0554b2ba0bad884d619084b2561aaaae048a2 |
| e8b0554 | https://github.com/python/mypy/pull/16849/commits/e8b0554b2ba0bad884d619084b2561aaaae048a2 |
|
| https://github.com/picnixz |
| remove unnecessary test | https://github.com/python/mypy/pull/16849/commits/472fcf100d7272573865cfae4478fe2af8988808 |
| 472fcf1 | https://github.com/python/mypy/pull/16849/commits/472fcf100d7272573865cfae4478fe2af8988808 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849 |
|
| https://github.com/picnixz |
| Merge branch 'master' into | https://github.com/python/mypy/pull/16849/commits/9d6f56fb41af3b65cbfb6e6b81dd6b187ca28649 |
| pythongh-16649 | https://github.com/python/mypy/issues/16649 |
| -type-comments-and-constrain… | https://github.com/python/mypy/pull/16849/commits/9d6f56fb41af3b65cbfb6e6b81dd6b187ca28649 |
| 9d6f56f | https://github.com/python/mypy/pull/16849/commits/9d6f56fb41af3b65cbfb6e6b81dd6b187ca28649 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849 |
|
| https://github.com/picnixz |
| Merge branch 'master' into | https://github.com/python/mypy/pull/16849/commits/5ebb7b925a5f58588de24fcb6c6cf3d2cfdccf99 |
| pythongh-16649 | https://github.com/python/mypy/issues/16649 |
| -type-comments-and-constrain… | https://github.com/python/mypy/pull/16849/commits/5ebb7b925a5f58588de24fcb6c6cf3d2cfdccf99 |
| 5ebb7b9 | https://github.com/python/mypy/pull/16849/commits/5ebb7b925a5f58588de24fcb6c6cf3d2cfdccf99 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849 |
|
| https://github.com/picnixz |
| Merge branch 'master' into | https://github.com/python/mypy/pull/16849/commits/b9b31a5a0e5f722e27a69a072dfb0207bcfbc243 |
| pythongh-16649 | https://github.com/python/mypy/issues/16649 |
| -type-comments-and-constrain… | https://github.com/python/mypy/pull/16849/commits/b9b31a5a0e5f722e27a69a072dfb0207bcfbc243 |
| b9b31a5 | https://github.com/python/mypy/pull/16849/commits/b9b31a5a0e5f722e27a69a072dfb0207bcfbc243 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| Jun 22, 2024 | https://github.com/python/mypy/pull/16849#issuecomment-2184209308 |
| @AlexWaygood | https://github.com/AlexWaygood |
| Please reload this page | https://github.com/python/mypy/pull/16849 |
|
| https://github.com/picnixz |
| Merge branch 'python:master' into | https://github.com/python/mypy/pull/16849/commits/92dfc73a37afd76405f7fddcbd0ef1fa47ec45bc |
| pythongh-16649 | https://github.com/python/mypy/issues/16649 |
| -type-comments-and-co… | https://github.com/python/mypy/pull/16849/commits/92dfc73a37afd76405f7fddcbd0ef1fa47ec45bc |
| 92dfc73 | https://github.com/python/mypy/pull/16849/commits/92dfc73a37afd76405f7fddcbd0ef1fa47ec45bc |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jun 23, 2024 | https://github.com/python/mypy/pull/16849#issuecomment-2184275208 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/16849 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
|
Jun 23, 2024
| https://github.com/python/mypy/pull/16849#ref-issue-2316207051 |
|
1.11 Release Tracking Issue
#17285
| https://github.com/python/mypy/issues/17285 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jul 1, 2024
| https://github.com/python/mypy/pull/16849#pullrequestreview-2152384256 |
|
View reviewed changes
| https://github.com/python/mypy/pull/16849/files/92dfc73a37afd76405f7fddcbd0ef1fa47ec45bc |
| hauntsaninja | https://github.com/hauntsaninja |
| Please reload this page | https://github.com/python/mypy/pull/16849 |
| https://github.com/python/mypy/pull/16849#pullrequestreview-2152384256 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/16849 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| 4ae632b | https://github.com/python/mypy/commit/4ae632b6f07b33dc5937a3b1dd28af98a080bc88 |
| Jul 1, 2024 | https://github.com/python/mypy/pull/16849#event-13357579968 |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jul 1, 2024
| https://github.com/python/mypy/pull/16849#ref-commit-c37d972 |
|
| https://github.com/picnixz |
|
| https://github.com/hauntsaninja |
| Fix type comments crash inside generic definitions ( | https://github.com/python/mypy/commit/c37d972f8abe0b2a46dbf7bab0898cd2afe6f69c |
| #16849 | https://github.com/python/mypy/pull/16849 |
| ) | https://github.com/python/mypy/commit/c37d972f8abe0b2a46dbf7bab0898cd2afe6f69c |
| c37d972 | https://github.com/python/mypy/commit/c37d972f8abe0b2a46dbf7bab0898cd2afe6f69c |
| #16649 | https://github.com/python/mypy/issues/16649 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| July 2, 2024 06:53 | https://github.com/python/mypy/pull/16849#event-13360627286 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| Jul 2, 2024 | https://github.com/python/mypy/pull/16849#issuecomment-2202094105 |
| Please reload this page | https://github.com/python/mypy/pull/16849 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/16849/files/92dfc73a37afd76405f7fddcbd0ef1fa47ec45bc |
| Please reload this page | https://github.com/python/mypy/pull/16849 |
|
Crash when using type comments inside a generic class with constrained type variables.
| https://github.com/python/mypy/issues/16649 |
| Please reload this page | https://github.com/python/mypy/pull/16849 |
|
| https://github.com/picnixz |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |