René's URL Explorer Experiment


Title: Fix type comments crash inside generic definitions by picnixz · Pull Request #16849 · python/mypy · GitHub

Open Graph Title: Fix type comments crash inside generic definitions by picnixz · Pull Request #16849 · python/mypy

X Title: Fix type comments crash inside generic definitions by picnixz · Pull Request #16849 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Closes #16649 It's the first time I am contributing to mypy so I am not very familiar with how it works entirely behind the scene. The issue that I had is that a crash happens when using tuple ...

X Description: Closes #16649 It's the first time I am contributing to mypy so I am not very familiar with how it works entirely behind the scene. The issue that I had is that a crash happens when using tu...

Opengraph URL: https://github.com/python/mypy/pull/16849

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4e664456-bb0c-c798-9c9c-cca5bc714a54
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBCA8:F5AA9:293556D:383832B:6B004BF2
html-safe-nonce8705b0771eb2e2fbc1bdea88fd34a1830a476168fd3216569219de4227e1409b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0E4OkY1QUE5OjI5MzU1NkQ6MzgzODMyQjo2QjAwNEJGMiIsInZpc2l0b3JfaWQiOiI3NDAyNDg5MTAyNjgxMDAwOTQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1a49e9889b6b1bcae61d40d8fe5ac5c2ce28b804ce75f27b4c081fcb8aaaa652
hovercard-subject-tagpull_request:1706430694
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/16849/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1711cd6f143c27006d33bee21b7118d8546b42827591bfd0a0a3e50ab60bf582/python/mypy/pull/16849
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1711cd6f143c27006d33bee21b7118d8546b42827591bfd0a0a3e50ab60bf582/python/mypy/pull/16849
og:image:altCloses #16649 It's the first time I am contributing to mypy so I am not very familiar with how it works entirely behind the scene. The issue that I had is that a crash happens when using tuple ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/16849#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/16849
Reloadhttps://github.com/python/mypy/pull/16849
Reloadhttps://github.com/python/mypy/pull/16849
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
picnixz:gh-16649-type-comments-and-constrained-genericshttps://github.com/picnixz/mypy/tree/gh-16649-type-comments-and-constrained-generics
Conversationhttps://github.com/python/mypy/pull/16849
Commits6 (6)https://github.com/python/mypy/pull/16849/commits
Checkshttps://github.com/python/mypy/pull/16849/checks
Files changedhttps://github.com/python/mypy/pull/16849/files
Fix type comments crash inside generic definitionshttps://github.com/python/mypy/pull/16849#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
picnixz:gh-16649-type-comments-and-constrained-genericshttps://github.com/picnixz/mypy/tree/gh-16649-type-comments-and-constrained-generics
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Feb 1, 2024https://github.com/python/mypy/pull/16849#issue-2112702605
#16649https://github.com/python/mypy/issues/16649
Please reload this pagehttps://github.com/python/mypy/pull/16849
picnixzhttps://github.com/picnixz
February 1, 2024 15:34https://github.com/python/mypy/pull/16849#commits-pushed-e8b0554
https://github.com/picnixz
Fix type comments crash inside generic definitionshttps://github.com/python/mypy/pull/16849/commits/e8b0554b2ba0bad884d619084b2561aaaae048a2
e8b0554https://github.com/python/mypy/pull/16849/commits/e8b0554b2ba0bad884d619084b2561aaaae048a2
https://github.com/picnixz
remove unnecessary testhttps://github.com/python/mypy/pull/16849/commits/472fcf100d7272573865cfae4478fe2af8988808
472fcf1https://github.com/python/mypy/pull/16849/commits/472fcf100d7272573865cfae4478fe2af8988808
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849
https://github.com/picnixz
Merge branch 'master' intohttps://github.com/python/mypy/pull/16849/commits/9d6f56fb41af3b65cbfb6e6b81dd6b187ca28649
pythongh-16649https://github.com/python/mypy/issues/16649
-type-comments-and-constrain…https://github.com/python/mypy/pull/16849/commits/9d6f56fb41af3b65cbfb6e6b81dd6b187ca28649
9d6f56fhttps://github.com/python/mypy/pull/16849/commits/9d6f56fb41af3b65cbfb6e6b81dd6b187ca28649
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849
https://github.com/picnixz
Merge branch 'master' intohttps://github.com/python/mypy/pull/16849/commits/5ebb7b925a5f58588de24fcb6c6cf3d2cfdccf99
pythongh-16649https://github.com/python/mypy/issues/16649
-type-comments-and-constrain…https://github.com/python/mypy/pull/16849/commits/5ebb7b925a5f58588de24fcb6c6cf3d2cfdccf99
5ebb7b9https://github.com/python/mypy/pull/16849/commits/5ebb7b925a5f58588de24fcb6c6cf3d2cfdccf99
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849
https://github.com/picnixz
Merge branch 'master' intohttps://github.com/python/mypy/pull/16849/commits/b9b31a5a0e5f722e27a69a072dfb0207bcfbc243
pythongh-16649https://github.com/python/mypy/issues/16649
-type-comments-and-constrain…https://github.com/python/mypy/pull/16849/commits/b9b31a5a0e5f722e27a69a072dfb0207bcfbc243
b9b31a5https://github.com/python/mypy/pull/16849/commits/b9b31a5a0e5f722e27a69a072dfb0207bcfbc243
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jun 22, 2024https://github.com/python/mypy/pull/16849#issuecomment-2184209308
@AlexWaygoodhttps://github.com/AlexWaygood
Please reload this pagehttps://github.com/python/mypy/pull/16849
https://github.com/picnixz
Merge branch 'python:master' intohttps://github.com/python/mypy/pull/16849/commits/92dfc73a37afd76405f7fddcbd0ef1fa47ec45bc
pythongh-16649https://github.com/python/mypy/issues/16649
-type-comments-and-co…https://github.com/python/mypy/pull/16849/commits/92dfc73a37afd76405f7fddcbd0ef1fa47ec45bc
92dfc73https://github.com/python/mypy/pull/16849/commits/92dfc73a37afd76405f7fddcbd0ef1fa47ec45bc
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 23, 2024https://github.com/python/mypy/pull/16849#issuecomment-2184275208
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/16849
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jun 23, 2024 https://github.com/python/mypy/pull/16849#ref-issue-2316207051
1.11 Release Tracking Issue #17285 https://github.com/python/mypy/issues/17285
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jul 1, 2024 https://github.com/python/mypy/pull/16849#pullrequestreview-2152384256
View reviewed changes https://github.com/python/mypy/pull/16849/files/92dfc73a37afd76405f7fddcbd0ef1fa47ec45bc
hauntsaninjahttps://github.com/hauntsaninja
Please reload this pagehttps://github.com/python/mypy/pull/16849
https://github.com/python/mypy/pull/16849#pullrequestreview-2152384256
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/16849
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
4ae632bhttps://github.com/python/mypy/commit/4ae632b6f07b33dc5937a3b1dd28af98a080bc88
Jul 1, 2024https://github.com/python/mypy/pull/16849#event-13357579968
hauntsaninjahttps://github.com/hauntsaninja
Jul 1, 2024 https://github.com/python/mypy/pull/16849#ref-commit-c37d972
https://github.com/picnixz
https://github.com/hauntsaninja
Fix type comments crash inside generic definitions (https://github.com/python/mypy/commit/c37d972f8abe0b2a46dbf7bab0898cd2afe6f69c
#16849https://github.com/python/mypy/pull/16849
)https://github.com/python/mypy/commit/c37d972f8abe0b2a46dbf7bab0898cd2afe6f69c
c37d972https://github.com/python/mypy/commit/c37d972f8abe0b2a46dbf7bab0898cd2afe6f69c
#16649https://github.com/python/mypy/issues/16649
https://github.com/picnixz
picnixzhttps://github.com/picnixz
July 2, 2024 06:53https://github.com/python/mypy/pull/16849#event-13360627286
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jul 2, 2024https://github.com/python/mypy/pull/16849#issuecomment-2202094105
Please reload this pagehttps://github.com/python/mypy/pull/16849
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16849
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/16849/files/92dfc73a37afd76405f7fddcbd0ef1fa47ec45bc
Please reload this pagehttps://github.com/python/mypy/pull/16849
Crash when using type comments inside a generic class with constrained type variables. https://github.com/python/mypy/issues/16649
Please reload this pagehttps://github.com/python/mypy/pull/16849
https://github.com/picnixz
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.