| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3be3080b-a001-c13c-0bd0-098df86b4b9e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EAA4:3B7325:FA9E3:145E6F:6AFF9DF6 |
| html-safe-nonce | 53278027ca50bf4b70c2affd0a11136bff818f1159c3dbbc25c3cb561cae9a3a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUE0OjNCNzMyNTpGQTlFMzoxNDVFNkY6NkFGRjlERjYiLCJ2aXNpdG9yX2lkIjoiNjI1MDg5NzE1MjQ0NTIyNjQ4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 69ab03717d60a0da5fdde2ffcc7e9261b5293a80b75e21138a2ae877a2a1e02c |
| hovercard-subject-tag | pull_request:1616778610 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/16566/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4122fc58ad848b803e3ef73911c09bd6dc65912cb3be115e4ea522594d6d0901/python/mypy/pull/16566 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4122fc58ad848b803e3ef73911c09bd6dc65912cb3be115e4ea522594d6d0901/python/mypy/pull/16566 |
| og:image:alt | Once class C is final, we know that a derived class won't add a __bool__ or a __len__ so if they're missing, we can assume every instance of C to be truthy.
Relates to #16565. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ikonst |
| hostname | github.com |
| expected-hostname | github.com |
| None | ba28afc7a27af7a823370a957c9e2c39d10289886a55f1d91350f367020c25ca |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 72f549919f17231189a8ff5726b8003c72c7eb99 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/16566#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16566 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16566 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/16566 |
| Reload | https://github.com/python/mypy/pull/16566 |
| Reload | https://github.com/python/mypy/pull/16566 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| ikonst:final-never-false | https://github.com/ikonst/mypy/tree/final-never-false |
| Conversation | https://github.com/python/mypy/pull/16566 |
| Commits5 (5) | https://github.com/python/mypy/pull/16566/commits |
| Checks | https://github.com/python/mypy/pull/16566/checks |
| Files changed | https://github.com/python/mypy/pull/16566/files |
| @final class without __bool__ cannot have falsey instances | https://github.com/python/mypy/pull/16566#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| ikonst:final-never-false | https://github.com/ikonst/mypy/tree/final-never-false |
|
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| Nov 26, 2023 | https://github.com/python/mypy/pull/16566#issue-2010893266 |
| Please reload this page | https://github.com/python/mypy/pull/16566 |
| #16565 | https://github.com/python/mypy/issues/16565 |
| Please reload this page | https://github.com/python/mypy/pull/16566 |
|
| https://github.com/ikonst |
| @Final | https://github.com/Final |
| class without __bool__ cannot have falsey instances | https://github.com/python/mypy/pull/16566/commits/b20b2624b746b9fc732292bbe8b4d062e9b7d0f7 |
| b20b262 | https://github.com/python/mypy/pull/16566/commits/b20b2624b746b9fc732292bbe8b4d062e9b7d0f7 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
|
Nov 26, 2023
| https://github.com/python/mypy/pull/16566#ref-issue-2010824063 |
|
Getting a union from an and expression
#16565
| https://github.com/python/mypy/issues/16565 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16566 |
|
| https://github.com/ikonst |
| also check __len__ | https://github.com/python/mypy/pull/16566/commits/bcb225da37dab2a4e45358da7d5b9ecbe4a4202b |
| bcb225d | https://github.com/python/mypy/pull/16566/commits/bcb225da37dab2a4e45358da7d5b9ecbe4a4202b |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16566 |
| ikonst | https://github.com/ikonst |
| November 27, 2023 10:48 | https://github.com/python/mypy/pull/16566#commits-pushed-b23314f |
|
| https://github.com/ikonst |
| more precise naming | https://github.com/python/mypy/pull/16566/commits/b23314f797464e3bcc98ae62125e177185fa2d14 |
| b23314f | https://github.com/python/mypy/pull/16566/commits/b23314f797464e3bcc98ae62125e177185fa2d14 |
|
| https://github.com/marketplace/pre-commit-ci |
| [pre-commit.ci] auto fixes from pre-commit.com hooks | https://github.com/python/mypy/pull/16566/commits/a1f3d11cc1d3ae2e0d9df627870dc0cfbd1386a9 |
| a1f3d11 | https://github.com/python/mypy/pull/16566/commits/a1f3d11cc1d3ae2e0d9df627870dc0cfbd1386a9 |
| https://pre-commit.ci | https://pre-commit.ci |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Nov 27, 2023
| https://github.com/python/mypy/pull/16566#pullrequestreview-1750774474 |
|
View reviewed changes
| https://github.com/python/mypy/pull/16566/files/a1f3d11cc1d3ae2e0d9df627870dc0cfbd1386a9 |
| test-data/unit/check-final.test | https://github.com/python/mypy/pull/16566/files/a1f3d11cc1d3ae2e0d9df627870dc0cfbd1386a9#diff-f4872f5865881c8964f6166a87c1c3aa1cc120e27cfdb8c050b547cf4282de47 |
| Please reload this page | https://github.com/python/mypy/pull/16566 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16566 |
|
| https://github.com/ikonst |
|
| https://github.com/AlexWaygood |
| Update comment | https://github.com/python/mypy/pull/16566/commits/94c9327178b4ad963d47c267ac45ebf32c660ab3 |
| 94c9327 | https://github.com/python/mypy/pull/16566/commits/94c9327178b4ad963d47c267ac45ebf32c660ab3 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 27, 2023 | https://github.com/python/mypy/pull/16566#issuecomment-1828254793 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/16566 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Dec 4, 2023
| https://github.com/python/mypy/pull/16566#pullrequestreview-1761950530 |
|
View reviewed changes
| https://github.com/python/mypy/pull/16566/files/94c9327178b4ad963d47c267ac45ebf32c660ab3 |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/mypy/pull/16566#pullrequestreview-1761950530 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/16566 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| 7c33e7c | https://github.com/python/mypy/commit/7c33e7c03444ae748b82163e7b4e1666dfaf94c7 |
| Dec 4, 2023 | https://github.com/python/mypy/pull/16566#event-11136379448 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| December 4, 2023 20:10 | https://github.com/python/mypy/pull/16566#event-11143879805 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jan 2, 2024
| https://github.com/python/mypy/pull/16566#ref-issue-2060755573 |
|
False positive with warn-unreachable and no-strict-optional (canonical)
#16718
| https://github.com/python/mypy/issues/16718 |
| https://github.com/KotlinIsland |
| KotlinIsland | https://github.com/KotlinIsland |
| Jan 4, 2024 | https://github.com/python/mypy/pull/16566#issuecomment-1876411987 |
| Please reload this page | https://github.com/python/mypy/pull/16566 |
| (🎁) final class without a __bool__ or __len__ method can never test false #12158 | https://github.com/python/mypy/issues/12158 |
| Please reload this page | https://github.com/python/mypy/pull/16566 |
| https://github.com/KotlinIsland |
| KotlinIsland | https://github.com/KotlinIsland |
|
Jan 4, 2024
| https://github.com/python/mypy/pull/16566#ref-issue-1129254615 |
|
(🎁) final class without a __bool__ or __len__ method can never test false
#12158
| https://github.com/python/mypy/issues/12158 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Apr 1, 2024
| https://github.com/python/mypy/pull/16566#ref-pullrequest-2218734438 |
|
[pre-commit.ci] pre-commit autoupdate
matplotlib/matplotlib#28003
| https://github.com/matplotlib/matplotlib/pull/28003 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16566 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/16566/files/94c9327178b4ad963d47c267ac45ebf32c660ab3 |
|
| https://github.com/AlexWaygood |
|
AlexWaygood
| https://github.com/AlexWaygood |
|
| https://github.com/python/mypy/pull/16566/files/a1f3d11cc1d3ae2e0d9df627870dc0cfbd1386a9 |
| Please reload this page | https://github.com/python/mypy/pull/16566 |
| Please reload this page | https://github.com/python/mypy/pull/16566 |
|
| https://github.com/ikonst |
|
| https://github.com/KotlinIsland |
|
| https://github.com/hauntsaninja |
|
| https://github.com/AlexWaygood |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |