René's URL Explorer Experiment


Title: Exclude private attributes from override checks by ilevkivskyi · Pull Request #16464 · python/mypy · GitHub

Open Graph Title: Exclude private attributes from override checks by ilevkivskyi · Pull Request #16464 · python/mypy

X Title: Exclude private attributes from override checks by ilevkivskyi · Pull Request #16464 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #9910 Fixes #16452 We already exclude private names from override type compatibility checks etc., but it looks like some override checks were still performed, we need to skip them, since priv...

X Description: Fixes #9910 Fixes #16452 We already exclude private names from override type compatibility checks etc., but it looks like some override checks were still performed, we need to skip them, since priv...

Opengraph URL: https://github.com/python/mypy/pull/16464

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4ef14379-12bc-b313-375e-677558bb2d78
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA600:26654F:2D00886:3B96738:6B002376
html-safe-nonce9ef82378e246536bb3cb48dad788d97c78d8032e951b6bf50d729ffbd49aaeae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjAwOjI2NjU0RjoyRDAwODg2OjNCOTY3Mzg6NkIwMDIzNzYiLCJ2aXNpdG9yX2lkIjoiNjg3OTg1MzczODUwMTE2OTgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaceef691fbbf74351c9adb3f882818b2092a404ad6b0d7e295556c0957eba8d4a0
hovercard-subject-tagpull_request:1597515659
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/16464/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b974b85bc7de399bcbff53e979365be3e54f5da636f26667584078192113ad44/python/mypy/pull/16464
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b974b85bc7de399bcbff53e979365be3e54f5da636f26667584078192113ad44/python/mypy/pull/16464
og:image:altFixes #9910 Fixes #16452 We already exclude private names from override type compatibility checks etc., but it looks like some override checks were still performed, we need to skip them, since priv...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/16464#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16464
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16464
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/16464
Reloadhttps://github.com/python/mypy/pull/16464
Reloadhttps://github.com/python/mypy/pull/16464
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-privatehttps://github.com/ilevkivskyi/mypy/tree/fix-private
Conversationhttps://github.com/python/mypy/pull/16464
Commits4 (4)https://github.com/python/mypy/pull/16464/commits
Checkshttps://github.com/python/mypy/pull/16464/checks
Files changedhttps://github.com/python/mypy/pull/16464/files
Exclude private attributes from override checkshttps://github.com/python/mypy/pull/16464#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-privatehttps://github.com/ilevkivskyi/mypy/tree/fix-private
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 11, 2023https://github.com/python/mypy/pull/16464#issue-1989099694
#9910https://github.com/python/mypy/issues/9910
#16452https://github.com/python/mypy/issues/16452
Please reload this pagehttps://github.com/python/mypy/pull/16464
ilevkivskyihttps://github.com/ilevkivskyi
November 11, 2023 19:53https://github.com/python/mypy/pull/16464#commits-pushed-a24b5e6
https://github.com/ilevkivskyi
Exclude private attributes from override checkshttps://github.com/python/mypy/pull/16464/commits/a24b5e67b40181b509b3cdbef893975400838ed5
a24b5e6https://github.com/python/mypy/pull/16464/commits/a24b5e67b40181b509b3cdbef893975400838ed5
https://github.com/ilevkivskyi
Undo accidental changehttps://github.com/python/mypy/pull/16464/commits/daacfb656339c21e7651fc027695425e1b3a6632
daacfb6https://github.com/python/mypy/pull/16464/commits/daacfb656339c21e7651fc027695425e1b3a6632
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
AlexWaygoodhttps://github.com/AlexWaygood
JukkaLhttps://github.com/JukkaL
hauntsaninjahttps://github.com/hauntsaninja
November 11, 2023 19:58https://github.com/python/mypy/pull/16464#event-10933078823
Dataclasses that inherit from other dataclasses fail type-checking when explicit-override is enabled #16452 https://github.com/python/mypy/issues/16452
Release 1.7 planning #16341 https://github.com/python/mypy/issues/16341
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16464
https://github.com/ilevkivskyi
Update testhttps://github.com/python/mypy/pull/16464/commits/03222d8a2b6d668de80c1122c1cab6dadea40bea
03222d8https://github.com/python/mypy/pull/16464/commits/03222d8a2b6d668de80c1122c1cab6dadea40bea
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16464
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Nov 11, 2023 https://github.com/python/mypy/pull/16464#pullrequestreview-1726135238
View reviewed changes https://github.com/python/mypy/pull/16464/files/03222d8a2b6d668de80c1122c1cab6dadea40bea
AlexWaygoodhttps://github.com/AlexWaygood
https://github.com/python/mypy/pull/16464#pullrequestreview-1726135238
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/16464
test-data/unit/check-functions.testhttps://github.com/python/mypy/pull/16464/files/03222d8a2b6d668de80c1122c1cab6dadea40bea#diff-fa1f78f6fcbf8808c290ed5a11be79a477f528e4b1d1f59cd7661f57df5369b0
Please reload this pagehttps://github.com/python/mypy/pull/16464
https://github.com/ilevkivskyi
https://github.com/AlexWaygood
Update test-data/unit/check-functions.testhttps://github.com/python/mypy/pull/16464/commits/02fec388a0b799b153b42eb0499077c95b1ac001
02fec38https://github.com/python/mypy/pull/16464/commits/02fec388a0b799b153b42eb0499077c95b1ac001
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 12, 2023https://github.com/python/mypy/pull/16464#issuecomment-1806967160
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/16464
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
8f3fe7chttps://github.com/python/mypy/commit/8f3fe7c0768ffcbcce760b3088702d95f3c57220
Nov 12, 2023https://github.com/python/mypy/pull/16464#event-10934166434
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
November 12, 2023 09:54https://github.com/python/mypy/pull/16464#event-10934166545
JukkaLhttps://github.com/JukkaL
Nov 22, 2023 https://github.com/python/mypy/pull/16464#ref-commit-88791ca
https://github.com/ilevkivskyi
https://github.com/AlexWaygood
https://github.com/JukkaL
Exclude private attributes from override checks (https://github.com/python/mypy/commit/88791cabe0521f77b699405154d90f3bb7c6b31b
#16464https://github.com/python/mypy/pull/16464
)https://github.com/python/mypy/commit/88791cabe0521f77b699405154d90f3bb7c6b31b
88791cahttps://github.com/python/mypy/commit/88791cabe0521f77b699405154d90f3bb7c6b31b
#9910https://github.com/python/mypy/issues/9910
#16452https://github.com/python/mypy/issues/16452
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16464
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/mypy/pull/16464/files/03222d8a2b6d668de80c1122c1cab6dadea40bea
Please reload this pagehttps://github.com/python/mypy/pull/16464
Dataclasses that inherit from other dataclasses fail type-checking when explicit-override is enabled https://github.com/python/mypy/issues/16452
'Final' (PEP 591) shouldn't apply to '__private' symbols https://github.com/python/mypy/issues/9910
Please reload this pagehttps://github.com/python/mypy/pull/16464
https://github.com/ilevkivskyi
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.