| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7b4e7554-73b4-0521-5309-fe8b66fff68f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C572:07D0:66FEA:820A9:6AFFBA29 |
| html-safe-nonce | 14a95f78b20665df5662690d87fd01944f64d3aac106deeafa6ef03d73c4280b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTcyOjA3RDA6NjZGRUE6ODIwQTk6NkFGRkJBMjkiLCJ2aXNpdG9yX2lkIjoiNTEzNTA2NjY0NjEwNDIyNjM0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 23170d565775ee39b87754cf65ec1030d4336fc1bc4bfb99cdb8817f8d5d82b7 |
| hovercard-subject-tag | pull_request:1589456309 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/16417/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7f28a03978265e41c3381e21a39ea709a12d17f7b4ca0068f68a0550602fb1d5/python/mypy/pull/16417 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7f28a03978265e41c3381e21a39ea709a12d17f7b4ca0068f68a0550602fb1d5/python/mypy/pull/16417 |
| og:image:alt | #16388 introduced a bug where, with --junit-format=global, the junit file would indicate an error (with no message) even if everything passed. That was because _generate_junit_contents would check ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mrwright |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7e461843db1c75e40d788c5cfd440d0e4ae1271cf19e06a798d0e7feb2d708f3 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d29a6a99861646939301302fab465f9f123b4773 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/16417#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16417 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16417 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/16417 |
| Reload | https://github.com/python/mypy/pull/16417 |
| Reload | https://github.com/python/mypy/pull/16417 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| msullivan | https://github.com/msullivan |
| python:master | https://github.com/python/mypy/tree/master |
| mrwright:fix-junit | https://github.com/mrwright/mypy/tree/fix-junit |
| Conversation | https://github.com/python/mypy/pull/16417 |
| Commits1 (1) | https://github.com/python/mypy/pull/16417/commits |
| Checks | https://github.com/python/mypy/pull/16417/checks |
| Files changed | https://github.com/python/mypy/pull/16417/files |
| Fix junit writing bug introduced in #16388 | https://github.com/python/mypy/pull/16417#top |
| msullivan | https://github.com/msullivan |
| python:master | https://github.com/python/mypy/tree/master |
| mrwright:fix-junit | https://github.com/mrwright/mypy/tree/fix-junit |
|
| https://github.com/mrwright |
| mrwright | https://github.com/mrwright |
| Nov 6, 2023 | https://github.com/python/mypy/pull/16417#issue-1980084150 |
| #16388 | https://github.com/python/mypy/pull/16388 |
| Please reload this page | https://github.com/python/mypy/pull/16417 |
|
| https://github.com/mrwright |
| Fix junit writing bug introduced in | https://github.com/python/mypy/pull/16417/commits/48e62fc64b08c2bc0d4dfb33237ea8806f087787 |
| python#16388 | https://github.com/python/mypy/pull/16388 |
| 48e62fc | https://github.com/python/mypy/pull/16417/commits/48e62fc64b08c2bc0d4dfb33237ea8806f087787 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Nov 6, 2023
| https://github.com/python/mypy/pull/16417#pullrequestreview-1716277457 |
|
View reviewed changes
| https://github.com/python/mypy/pull/16417/files/48e62fc64b08c2bc0d4dfb33237ea8806f087787 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 6, 2023 | https://github.com/python/mypy/pull/16417#issuecomment-1796609187 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/16417 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| 285519c | https://github.com/python/mypy/commit/285519cca8c64f5fc35bde6bfa52c48d1fb1cea1 |
| Nov 7, 2023 | https://github.com/python/mypy/pull/16417#event-10881182971 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16417 |
|
| https://github.com/msullivan |
|
msullivan
| https://github.com/msullivan |
|
| https://github.com/python/mypy/pull/16417/files/48e62fc64b08c2bc0d4dfb33237ea8806f087787 |
| Please reload this page | https://github.com/python/mypy/pull/16417 |
| Please reload this page | https://github.com/python/mypy/pull/16417 |
|
| https://github.com/mrwright |
|
| https://github.com/msullivan |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |