René's URL Explorer Experiment


Title: Fix junit writing bug introduced in #16388 by mrwright · Pull Request #16417 · python/mypy · GitHub

Open Graph Title: Fix junit writing bug introduced in #16388 by mrwright · Pull Request #16417 · python/mypy

X Title: Fix junit writing bug introduced in #16388 by mrwright · Pull Request #16417 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: #16388 introduced a bug where, with --junit-format=global, the junit file would indicate an error (with no message) even if everything passed. That was because _generate_junit_contents would check ...

X Description: #16388 introduced a bug where, with --junit-format=global, the junit file would indicate an error (with no message) even if everything passed. That was because _generate_junit_contents would check ...

Opengraph URL: https://github.com/python/mypy/pull/16417

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7b4e7554-73b4-0521-5309-fe8b66fff68f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC572:07D0:66FEA:820A9:6AFFBA29
html-safe-nonce14a95f78b20665df5662690d87fd01944f64d3aac106deeafa6ef03d73c4280b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTcyOjA3RDA6NjZGRUE6ODIwQTk6NkFGRkJBMjkiLCJ2aXNpdG9yX2lkIjoiNTEzNTA2NjY0NjEwNDIyNjM0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac23170d565775ee39b87754cf65ec1030d4336fc1bc4bfb99cdb8817f8d5d82b7
hovercard-subject-tagpull_request:1589456309
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/16417/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7f28a03978265e41c3381e21a39ea709a12d17f7b4ca0068f68a0550602fb1d5/python/mypy/pull/16417
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7f28a03978265e41c3381e21a39ea709a12d17f7b4ca0068f68a0550602fb1d5/python/mypy/pull/16417
og:image:alt#16388 introduced a bug where, with --junit-format=global, the junit file would indicate an error (with no message) even if everything passed. That was because _generate_junit_contents would check ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemrwright
hostnamegithub.com
expected-hostnamegithub.com
None7e461843db1c75e40d788c5cfd440d0e4ae1271cf19e06a798d0e7feb2d708f3
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released29a6a99861646939301302fab465f9f123b4773
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/16417#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16417
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16417
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/16417
Reloadhttps://github.com/python/mypy/pull/16417
Reloadhttps://github.com/python/mypy/pull/16417
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
msullivanhttps://github.com/msullivan
python:masterhttps://github.com/python/mypy/tree/master
mrwright:fix-junithttps://github.com/mrwright/mypy/tree/fix-junit
Conversationhttps://github.com/python/mypy/pull/16417
Commits1 (1)https://github.com/python/mypy/pull/16417/commits
Checkshttps://github.com/python/mypy/pull/16417/checks
Files changedhttps://github.com/python/mypy/pull/16417/files
Fix junit writing bug introduced in #16388https://github.com/python/mypy/pull/16417#top
msullivanhttps://github.com/msullivan
python:masterhttps://github.com/python/mypy/tree/master
mrwright:fix-junithttps://github.com/mrwright/mypy/tree/fix-junit
https://github.com/mrwright
mrwrighthttps://github.com/mrwright
Nov 6, 2023https://github.com/python/mypy/pull/16417#issue-1980084150
#16388https://github.com/python/mypy/pull/16388
Please reload this pagehttps://github.com/python/mypy/pull/16417
https://github.com/mrwright
Fix junit writing bug introduced inhttps://github.com/python/mypy/pull/16417/commits/48e62fc64b08c2bc0d4dfb33237ea8806f087787
python#16388https://github.com/python/mypy/pull/16388
48e62fchttps://github.com/python/mypy/pull/16417/commits/48e62fc64b08c2bc0d4dfb33237ea8806f087787
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Nov 6, 2023 https://github.com/python/mypy/pull/16417#pullrequestreview-1716277457
View reviewed changes https://github.com/python/mypy/pull/16417/files/48e62fc64b08c2bc0d4dfb33237ea8806f087787
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 6, 2023https://github.com/python/mypy/pull/16417#issuecomment-1796609187
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/16417
https://github.com/msullivan
msullivanhttps://github.com/msullivan
285519chttps://github.com/python/mypy/commit/285519cca8c64f5fc35bde6bfa52c48d1fb1cea1
Nov 7, 2023https://github.com/python/mypy/pull/16417#event-10881182971
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16417
https://github.com/msullivan
msullivan https://github.com/msullivan
https://github.com/python/mypy/pull/16417/files/48e62fc64b08c2bc0d4dfb33237ea8806f087787
Please reload this pagehttps://github.com/python/mypy/pull/16417
Please reload this pagehttps://github.com/python/mypy/pull/16417
https://github.com/mrwright
https://github.com/msullivan
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.