René's URL Explorer Experiment


Title: Do not intersect types in isinstance checks if at least one is final. by tyralla · Pull Request #16330 · python/mypy · GitHub

Open Graph Title: Do not intersect types in isinstance checks if at least one is final. by tyralla · Pull Request #16330 · python/mypy

X Title: Do not intersect types in isinstance checks if at least one is final. by tyralla · Pull Request #16330 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #15148 I think it also fixes the initial bug reported in #12163 (this is why I added a TypeVar test case) but not this bug reported later in the same issue.

X Description: Fixes #15148 I think it also fixes the initial bug reported in #12163 (this is why I added a TypeVar test case) but not this bug reported later in the same issue.

Opengraph URL: https://github.com/python/mypy/pull/16330

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a0edc3bd-285b-3883-cdc3-f4f78efa242e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9404:11BB24:A38BFA:DC589A:6AFF9E73
html-safe-noncee52fa3f363e3f3cfc6bc1e53bcaa56fc6a963d86c8276b6668db9c924f2ea6f3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDA0OjExQkIyNDpBMzhCRkE6REM1ODlBOjZBRkY5RTczIiwidmlzaXRvcl9pZCI6IjE1NDE5MTIyMTA0NTQ4NDcwOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace50409d3d6ca926d3ef19a0a38fab97af97f50e5b463209de3d611935d427b9b
hovercard-subject-tagpull_request:1575137360
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/16330/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a0499cd754bdd300ce7ee443e6602dfefd14a0c3c5e4caba332df67461ddd299/python/mypy/pull/16330
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a0499cd754bdd300ce7ee443e6602dfefd14a0c3c5e4caba332df67461ddd299/python/mypy/pull/16330
og:image:altFixes #15148 I think it also fixes the initial bug reported in #12163 (this is why I added a TypeVar test case) but not this bug reported later in the same issue.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametyralla
hostnamegithub.com
expected-hostnamegithub.com
Noneba28afc7a27af7a823370a957c9e2c39d10289886a55f1d91350f367020c25ca
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release72f549919f17231189a8ff5726b8003c72c7eb99
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/16330#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16330
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16330
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/16330
Reloadhttps://github.com/python/mypy/pull/16330
Reloadhttps://github.com/python/mypy/pull/16330
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
tyralla:fix/narrowing_final_subclasseshttps://github.com/tyralla/mypy/tree/fix/narrowing_final_subclasses
Conversationhttps://github.com/python/mypy/pull/16330
Commits1 (1)https://github.com/python/mypy/pull/16330/commits
Checkshttps://github.com/python/mypy/pull/16330/checks
Files changedhttps://github.com/python/mypy/pull/16330/files
Do not intersect types in isinstance checks if at least one is final.https://github.com/python/mypy/pull/16330#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
tyralla:fix/narrowing_final_subclasseshttps://github.com/tyralla/mypy/tree/fix/narrowing_final_subclasses
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 26, 2023https://github.com/python/mypy/pull/16330#issue-1963875614
#15148https://github.com/python/mypy/issues/15148
initial bughttps://github.com/python/mypy/issues/12163#issue-1131262225
#12163https://github.com/python/mypy/issues/12163
this bughttps://github.com/python/mypy/issues/12163#issuecomment-1035865305
Please reload this pagehttps://github.com/python/mypy/pull/16330
https://github.com/tyralla
Do not intersect types in isinstance checks if at least one is final.https://github.com/python/mypy/pull/16330/commits/86449668f6666c18ebab314400232881ddf161c1
8644966https://github.com/python/mypy/pull/16330/commits/86449668f6666c18ebab314400232881ddf161c1
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 26, 2023 https://github.com/python/mypy/pull/16330#ref-pullrequest-1956484076
Support narrowing unions that include type[None]. #16315 https://github.com/python/mypy/pull/16315
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 26, 2023https://github.com/python/mypy/pull/16330#issuecomment-1781447189
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/16330
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 26, 2023https://github.com/python/mypy/pull/16330#issuecomment-1781493134
#16315https://github.com/python/mypy/pull/16315
Please reload this pagehttps://github.com/python/mypy/pull/16330
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 27, 2023https://github.com/python/mypy/pull/16330#issuecomment-1783611122
Please reload this pagehttps://github.com/python/mypy/pull/16330
Please reload this pagehttps://github.com/python/mypy/pull/16330
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 27, 2023 https://github.com/python/mypy/pull/16330#ref-issue-1685885553
(🎁) Intersections with @final types should trigger unreachable errors #15148 https://github.com/python/mypy/issues/15148
https://github.com/KotlinIsland
KotlinIslandhttps://github.com/KotlinIsland
Oct 28, 2023 https://github.com/python/mypy/pull/16330#pullrequestreview-1702686055
View reviewed changes https://github.com/python/mypy/pull/16330/files/86449668f6666c18ebab314400232881ddf161c1
KotlinIslandhttps://github.com/KotlinIsland
https://github.com/python/mypy/pull/16330#pullrequestreview-1702686055
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/16330
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 28, 2023https://github.com/python/mypy/pull/16330#issuecomment-1783720793
@KotlinIslandhttps://github.com/KotlinIsland
Please reload this pagehttps://github.com/python/mypy/pull/16330
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 28, 2023 https://github.com/python/mypy/pull/16330#ref-issue-1966519329
Inconsistent narrowing for builtins.type and typing.Type #16349 https://github.com/python/mypy/issues/16349
https://github.com/KotlinIsland
KotlinIslandhttps://github.com/KotlinIsland
Oct 28, 2023https://github.com/python/mypy/pull/16330#issuecomment-1783789899
Please reload this pagehttps://github.com/python/mypy/pull/16330
@KotlinIslandhttps://github.com/KotlinIsland
@tyrallahttps://github.com/tyralla
Please reload this pagehttps://github.com/python/mypy/pull/16330
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Dec 3, 2023 https://github.com/python/mypy/pull/16330#ref-issue-2021629090
Release 1.8 planning #16602 https://github.com/python/mypy/issues/16602
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Dec 4, 2023 https://github.com/python/mypy/pull/16330#pullrequestreview-1761722976
View reviewed changes https://github.com/python/mypy/pull/16330/files/86449668f6666c18ebab314400232881ddf161c1
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Dec 4, 2023https://github.com/python/mypy/pull/16330#issuecomment-1837963521
Please reload this pagehttps://github.com/python/mypy/pull/16330
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
c224da5https://github.com/python/mypy/commit/c224da5c7c414f92ded4b7816d16d5dd4ed32193
Dec 4, 2023https://github.com/python/mypy/pull/16330#event-11134946568
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Dec 26, 2023 https://github.com/python/mypy/pull/16330#ref-issue-2056233807
MethodType uses FunctionLike types inconsistently python/typeshed#11200 https://github.com/python/typeshed/issues/11200
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Apr 1, 2024 https://github.com/python/mypy/pull/16330#ref-pullrequest-2218734438
[pre-commit.ci] pre-commit autoupdate matplotlib/matplotlib#28003 https://github.com/matplotlib/matplotlib/pull/28003
https://github.com/brianschubert
brianschuberthttps://github.com/brianschubert
Dec 8, 2024 https://github.com/python/mypy/pull/16330#ref-issue-1131262225
TypeVar not narrowed when using isinstance or issubclass on final classes #12163 https://github.com/python/mypy/issues/12163
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16330
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/16330/files/86449668f6666c18ebab314400232881ddf161c1
https://github.com/KotlinIsland
KotlinIsland https://github.com/KotlinIsland
https://github.com/python/mypy/pull/16330/files/86449668f6666c18ebab314400232881ddf161c1
Please reload this pagehttps://github.com/python/mypy/pull/16330
(🎁) Intersections with @final types should trigger unreachable errors https://github.com/python/mypy/issues/15148
Please reload this pagehttps://github.com/python/mypy/pull/16330
https://github.com/tyralla
https://github.com/KotlinIsland
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.