| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a0edc3bd-285b-3883-cdc3-f4f78efa242e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9404:11BB24:A38BFA:DC589A:6AFF9E73 |
| html-safe-nonce | e52fa3f363e3f3cfc6bc1e53bcaa56fc6a963d86c8276b6668db9c924f2ea6f3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDA0OjExQkIyNDpBMzhCRkE6REM1ODlBOjZBRkY5RTczIiwidmlzaXRvcl9pZCI6IjE1NDE5MTIyMTA0NTQ4NDcwOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e50409d3d6ca926d3ef19a0a38fab97af97f50e5b463209de3d611935d427b9b |
| hovercard-subject-tag | pull_request:1575137360 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/16330/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a0499cd754bdd300ce7ee443e6602dfefd14a0c3c5e4caba332df67461ddd299/python/mypy/pull/16330 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a0499cd754bdd300ce7ee443e6602dfefd14a0c3c5e4caba332df67461ddd299/python/mypy/pull/16330 |
| og:image:alt | Fixes #15148
I think it also fixes the initial bug reported in #12163 (this is why I added a TypeVar test case) but not this bug reported later in the same issue. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tyralla |
| hostname | github.com |
| expected-hostname | github.com |
| None | ba28afc7a27af7a823370a957c9e2c39d10289886a55f1d91350f367020c25ca |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 72f549919f17231189a8ff5726b8003c72c7eb99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/16330#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16330 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16330 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/16330 |
| Reload | https://github.com/python/mypy/pull/16330 |
| Reload | https://github.com/python/mypy/pull/16330 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| tyralla:fix/narrowing_final_subclasses | https://github.com/tyralla/mypy/tree/fix/narrowing_final_subclasses |
| Conversation | https://github.com/python/mypy/pull/16330 |
| Commits1 (1) | https://github.com/python/mypy/pull/16330/commits |
| Checks | https://github.com/python/mypy/pull/16330/checks |
| Files changed | https://github.com/python/mypy/pull/16330/files |
| Do not intersect types in isinstance checks if at least one is final. | https://github.com/python/mypy/pull/16330#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| tyralla:fix/narrowing_final_subclasses | https://github.com/tyralla/mypy/tree/fix/narrowing_final_subclasses |
|
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Oct 26, 2023 | https://github.com/python/mypy/pull/16330#issue-1963875614 |
| #15148 | https://github.com/python/mypy/issues/15148 |
| initial bug | https://github.com/python/mypy/issues/12163#issue-1131262225 |
| #12163 | https://github.com/python/mypy/issues/12163 |
| this bug | https://github.com/python/mypy/issues/12163#issuecomment-1035865305 |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
|
| https://github.com/tyralla |
| Do not intersect types in isinstance checks if at least one is final. | https://github.com/python/mypy/pull/16330/commits/86449668f6666c18ebab314400232881ddf161c1 |
| 8644966 | https://github.com/python/mypy/pull/16330/commits/86449668f6666c18ebab314400232881ddf161c1 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
|
Oct 26, 2023
| https://github.com/python/mypy/pull/16330#ref-pullrequest-1956484076 |
|
Support narrowing unions that include type[None].
#16315
| https://github.com/python/mypy/pull/16315 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 26, 2023 | https://github.com/python/mypy/pull/16330#issuecomment-1781447189 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Oct 26, 2023 | https://github.com/python/mypy/pull/16330#issuecomment-1781493134 |
| #16315 | https://github.com/python/mypy/pull/16315 |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Oct 27, 2023 | https://github.com/python/mypy/pull/16330#issuecomment-1783611122 |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
|
Oct 27, 2023
| https://github.com/python/mypy/pull/16330#ref-issue-1685885553 |
|
(🎁) Intersections with @final types should trigger unreachable errors
#15148
| https://github.com/python/mypy/issues/15148 |
| https://github.com/KotlinIsland |
| KotlinIsland | https://github.com/KotlinIsland |
|
Oct 28, 2023
| https://github.com/python/mypy/pull/16330#pullrequestreview-1702686055 |
|
View reviewed changes
| https://github.com/python/mypy/pull/16330/files/86449668f6666c18ebab314400232881ddf161c1 |
| KotlinIsland | https://github.com/KotlinIsland |
| https://github.com/python/mypy/pull/16330#pullrequestreview-1702686055 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Oct 28, 2023 | https://github.com/python/mypy/pull/16330#issuecomment-1783720793 |
| @KotlinIsland | https://github.com/KotlinIsland |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
|
Oct 28, 2023
| https://github.com/python/mypy/pull/16330#ref-issue-1966519329 |
|
Inconsistent narrowing for builtins.type and typing.Type
#16349
| https://github.com/python/mypy/issues/16349 |
| https://github.com/KotlinIsland |
| KotlinIsland | https://github.com/KotlinIsland |
| Oct 28, 2023 | https://github.com/python/mypy/pull/16330#issuecomment-1783789899 |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
| @KotlinIsland | https://github.com/KotlinIsland |
| @tyralla | https://github.com/tyralla |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Dec 3, 2023
| https://github.com/python/mypy/pull/16330#ref-issue-2021629090 |
|
Release 1.8 planning
#16602
| https://github.com/python/mypy/issues/16602 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Dec 4, 2023
| https://github.com/python/mypy/pull/16330#pullrequestreview-1761722976 |
|
View reviewed changes
| https://github.com/python/mypy/pull/16330/files/86449668f6666c18ebab314400232881ddf161c1 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| Dec 4, 2023 | https://github.com/python/mypy/pull/16330#issuecomment-1837963521 |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| c224da5 | https://github.com/python/mypy/commit/c224da5c7c414f92ded4b7816d16d5dd4ed32193 |
| Dec 4, 2023 | https://github.com/python/mypy/pull/16330#event-11134946568 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
|
Dec 26, 2023
| https://github.com/python/mypy/pull/16330#ref-issue-2056233807 |
|
MethodType uses FunctionLike types inconsistently
python/typeshed#11200
| https://github.com/python/typeshed/issues/11200 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Apr 1, 2024
| https://github.com/python/mypy/pull/16330#ref-pullrequest-2218734438 |
|
[pre-commit.ci] pre-commit autoupdate
matplotlib/matplotlib#28003
| https://github.com/matplotlib/matplotlib/pull/28003 |
| https://github.com/brianschubert |
| brianschubert | https://github.com/brianschubert |
|
Dec 8, 2024
| https://github.com/python/mypy/pull/16330#ref-issue-1131262225 |
|
TypeVar not narrowed when using isinstance or issubclass on final classes
#12163
| https://github.com/python/mypy/issues/12163 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16330 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/16330/files/86449668f6666c18ebab314400232881ddf161c1 |
|
| https://github.com/KotlinIsland |
|
KotlinIsland
| https://github.com/KotlinIsland |
|
| https://github.com/python/mypy/pull/16330/files/86449668f6666c18ebab314400232881ddf161c1 |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
|
(🎁) Intersections with @final types should trigger unreachable errors
| https://github.com/python/mypy/issues/15148 |
| Please reload this page | https://github.com/python/mypy/pull/16330 |
|
| https://github.com/tyralla |
|
| https://github.com/KotlinIsland |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |