| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f249379e-e555-fdef-addf-80e725fc3c5c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF2A:4D728:161C575:1C21E60:6AFFA536 |
| html-safe-nonce | 294e7fa124ccd93a41870720c9fec218610a2aab3d264f6111fedd1aef707f6e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjJBOjRENzI4OjE2MUM1NzU6MUMyMUU2MDo2QUZGQTUzNiIsInZpc2l0b3JfaWQiOiI4NTc3NDQ0MzA0OTEyMzYwNzU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d0d6e9e65e315ea68d5f0cb09de2c58b8d3851960b34ecb627462e57c1595e35 |
| hovercard-subject-tag | pull_request:1568576130 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/16315/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8a1e7e6ac66f5865c76223df66d541e62cb7de98b7dac9d8b96f9a0e50e3bdc6/python/mypy/pull/16315 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8a1e7e6ac66f5865c76223df66d541e62cb7de98b7dac9d8b96f9a0e50e3bdc6/python/mypy/pull/16315 |
| og:image:alt | Fixes #16279
See my comment in the referenced issue. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tyralla |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6a41d7f592f24f38b58637f25dec5e9e26cb838995072a495a552ba4e4eecf75 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0e75efa5f34074f831bc22b1a793c40d20fa144b |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/16315#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/16315 |
| Reload | https://github.com/python/mypy/pull/16315 |
| Reload | https://github.com/python/mypy/pull/16315 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| tyralla:fix/narrow_nonetype | https://github.com/tyralla/mypy/tree/fix/narrow_nonetype |
| Conversation | https://github.com/python/mypy/pull/16315 |
| Commits7 (7) | https://github.com/python/mypy/pull/16315/commits |
| Checks | https://github.com/python/mypy/pull/16315/checks |
| Files changed | https://github.com/python/mypy/pull/16315/files |
| Support narrowing unions that include type[None]. | https://github.com/python/mypy/pull/16315#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| tyralla:fix/narrow_nonetype | https://github.com/tyralla/mypy/tree/fix/narrow_nonetype |
|
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Oct 23, 2023 | https://github.com/python/mypy/pull/16315#issue-1956484076 |
| #16279 | https://github.com/python/mypy/issues/16279 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| tyralla | https://github.com/tyralla |
| October 23, 2023 08:53 | https://github.com/python/mypy/pull/16315#commits-pushed-05f2c71 |
|
| https://github.com/tyralla |
| Support narrowing unions that include type[None]. | https://github.com/python/mypy/pull/16315/commits/05f2c713556be88b73e8c73159d958642683b5ad |
| 05f2c71 | https://github.com/python/mypy/pull/16315/commits/05f2c713556be88b73e8c73159d958642683b5ad |
|
| https://github.com/tyralla |
| Merge branch 'master' into fix/narrow_nonetype | https://github.com/python/mypy/pull/16315/commits/1ea576cd4b215f00ce0c81a31896371e48249d30 |
| 1ea576c | https://github.com/python/mypy/pull/16315/commits/1ea576cd4b215f00ce0c81a31896371e48249d30 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
|
Oct 23, 2023
| https://github.com/python/mypy/pull/16315#ref-issue-1948087175 |
|
can't narrow a union of type[None]
#16279
| https://github.com/python/mypy/issues/16279 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Oct 23, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1775039893 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Oct 23, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1775358558 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Oct 23, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1775447979 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/ghost |
| ghost | https://github.com/ghost |
|
Oct 23, 2023
| https://github.com/python/mypy/pull/16315#pullrequestreview-1693353997 |
|
View reviewed changes
| https://github.com/python/mypy/pull/16315/files/1ea576cd4b215f00ce0c81a31896371e48249d30 |
| test-data/unit/check-narrowing.test | https://github.com/python/mypy/pull/16315/files/1ea576cd4b215f00ce0c81a31896371e48249d30#diff-0413401ad6a91bc5c66579455009ba606ee0ddfb0a78278c9e53618c83b53ed5 |
| ghost | https://github.com/ghost |
| Oct 23, 2023 | https://github.com/python/mypy/pull/16315#discussion_r1369158720 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| tyralla | https://github.com/tyralla |
| Oct 24, 2023 | https://github.com/python/mypy/pull/16315#discussion_r1369630070 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
|
| https://github.com/tyralla |
| special case types.NoneType | https://github.com/python/mypy/pull/16315/commits/32ca5f43a2bf4712794097134dd32a9bf59bfe83 |
| 32ca5f4 | https://github.com/python/mypy/pull/16315/commits/32ca5f43a2bf4712794097134dd32a9bf59bfe83 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Oct 24, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1776561121 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Oct 25, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1779387785 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/python/cpython/blob/1262e41842957c3b402fc0cf0a6eb2ea230c828f/Tools/clinic/clinic.py#L5828-L5831 | https://github.com/python/cpython/blob/1262e41842957c3b402fc0cf0a6eb2ea230c828f/Tools/clinic/clinic.py#L5828-L5831 |
| https://github.com/python/cpython/blob/1262e41842957c3b402fc0cf0a6eb2ea230c828f/Tools/clinic/clinic.py#L5719 | https://github.com/python/cpython/blob/1262e41842957c3b402fc0cf0a6eb2ea230c828f/Tools/clinic/clinic.py#L5719 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Oct 25, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1779519218 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Oct 25, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1779607749 |
| #15148 | https://github.com/python/mypy/issues/15148 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Oct 26, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1781409783 |
| #16330 | https://github.com/python/mypy/pull/16330 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Oct 26, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1781424645 |
| #16330 | https://github.com/python/mypy/pull/16330 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
|
Oct 26, 2023
| https://github.com/python/mypy/pull/16315#ref-pullrequest-1963875614 |
|
Do not intersect types in isinstance checks if at least one is final.
#16330
| https://github.com/python/mypy/pull/16330 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| October 28, 2023 06:17 | https://github.com/python/mypy/pull/16315#event-10797175195 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Dec 4, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1838140251 |
| @tyralla | https://github.com/tyralla |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
|
| https://github.com/tyralla |
| Merge branch 'master' into fix/narrow_nonetype | https://github.com/python/mypy/pull/16315/commits/fc853e9f2bd92fbe5c814010e15c6c7d4eb60c55 |
| fc853e9 | https://github.com/python/mypy/pull/16315/commits/fc853e9f2bd92fbe5c814010e15c6c7d4eb60c55 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Dec 4, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1838891384 |
| @AlexWaygood | https://github.com/AlexWaygood |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Dec 4, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1839184605 |
| #16330 | https://github.com/python/mypy/pull/16330 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Dec 5, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1840055694 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
|
| https://github.com/tyralla |
| Add test case `testNarrowingIsInstanceNoIntersectionWithFinalTypeAndN… | https://github.com/python/mypy/pull/16315/commits/fe12f7d1a62a66c45ba23c45965e4064117a2fff |
| fe12f7d | https://github.com/python/mypy/pull/16315/commits/fe12f7d1a62a66c45ba23c45965e4064117a2fff |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315 |
| tyralla | https://github.com/tyralla |
| December 5, 2023 10:19 | https://github.com/python/mypy/pull/16315#commits-pushed-58f0562 |
|
| https://github.com/tyralla |
| A little additional effort for `Subclass of "..." and "NoneType" cann… | https://github.com/python/mypy/pull/16315/commits/58f0562f34af9c8854b50496a96bb1c3e9300410 |
| 58f0562 | https://github.com/python/mypy/pull/16315/commits/58f0562f34af9c8854b50496a96bb1c3e9300410 |
|
| https://github.com/marketplace/pre-commit-ci |
| [pre-commit.ci] auto fixes from pre-commit.com hooks | https://github.com/python/mypy/pull/16315/commits/55b2858e87f041ea463c244cf9d8fddc7a0e0afa |
| 55b2858 | https://github.com/python/mypy/pull/16315/commits/55b2858e87f041ea463c244cf9d8fddc7a0e0afa |
| https://pre-commit.ci | https://pre-commit.ci |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Dec 5, 2023 | https://github.com/python/mypy/pull/16315#issuecomment-1840381309 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Jan 9, 2024 | https://github.com/python/mypy/pull/16315#issuecomment-1882419057 |
| @AlexWaygood | https://github.com/AlexWaygood |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Jan 9, 2024 | https://github.com/python/mypy/pull/16315#issuecomment-1882541631 |
| @AlexWaygood | https://github.com/AlexWaygood |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Jan 9, 2024 | https://github.com/python/mypy/pull/16315#issuecomment-1882575003 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Jan 9, 2024 | https://github.com/python/mypy/pull/16315#issuecomment-1882580425 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
upnext
| https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext |
| Jan 9, 2024 | https://github.com/python/mypy/pull/16315#event-11427772744 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jan 14, 2024
| https://github.com/python/mypy/pull/16315#pullrequestreview-1820136968 |
|
View reviewed changes
| https://github.com/python/mypy/pull/16315/files/55b2858e87f041ea463c244cf9d8fddc7a0e0afa |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/mypy/pull/16315#pullrequestreview-1820136968 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| 261e569 | https://github.com/python/mypy/commit/261e569e2c256451692dd57c05295ef0bcfb34fd |
| Jan 14, 2024 | https://github.com/python/mypy/pull/16315#event-11479762125 |
| https://github.com/brianschubert |
| brianschubert | https://github.com/brianschubert |
|
Dec 8, 2024
| https://github.com/python/mypy/pull/16315#ref-issue-1212688595 |
|
Inconsistent type inference with type(None)
#12658
| https://github.com/python/mypy/issues/12658 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/16315/files/55b2858e87f041ea463c244cf9d8fddc7a0e0afa |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
|
upnext
| https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext |
|
can't narrow a union of type[None]
| https://github.com/python/mypy/issues/16279 |
| Please reload this page | https://github.com/python/mypy/pull/16315 |
|
| https://github.com/tyralla |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/AlexWaygood |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |