René's URL Explorer Experiment


Title: Support narrowing unions that include type[None]. by tyralla · Pull Request #16315 · python/mypy · GitHub

Open Graph Title: Support narrowing unions that include type[None]. by tyralla · Pull Request #16315 · python/mypy

X Title: Support narrowing unions that include type[None]. by tyralla · Pull Request #16315 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #16279 See my comment in the referenced issue.

X Description: Fixes #16279 See my comment in the referenced issue.

Opengraph URL: https://github.com/python/mypy/pull/16315

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f249379e-e555-fdef-addf-80e725fc3c5c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF2A:4D728:161C575:1C21E60:6AFFA536
html-safe-nonce294e7fa124ccd93a41870720c9fec218610a2aab3d264f6111fedd1aef707f6e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjJBOjRENzI4OjE2MUM1NzU6MUMyMUU2MDo2QUZGQTUzNiIsInZpc2l0b3JfaWQiOiI4NTc3NDQ0MzA0OTEyMzYwNzU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd0d6e9e65e315ea68d5f0cb09de2c58b8d3851960b34ecb627462e57c1595e35
hovercard-subject-tagpull_request:1568576130
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/16315/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8a1e7e6ac66f5865c76223df66d541e62cb7de98b7dac9d8b96f9a0e50e3bdc6/python/mypy/pull/16315
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8a1e7e6ac66f5865c76223df66d541e62cb7de98b7dac9d8b96f9a0e50e3bdc6/python/mypy/pull/16315
og:image:altFixes #16279 See my comment in the referenced issue.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametyralla
hostnamegithub.com
expected-hostnamegithub.com
None6a41d7f592f24f38b58637f25dec5e9e26cb838995072a495a552ba4e4eecf75
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0e75efa5f34074f831bc22b1a793c40d20fa144b
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/16315#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/16315
Reloadhttps://github.com/python/mypy/pull/16315
Reloadhttps://github.com/python/mypy/pull/16315
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
tyralla:fix/narrow_nonetypehttps://github.com/tyralla/mypy/tree/fix/narrow_nonetype
Conversationhttps://github.com/python/mypy/pull/16315
Commits7 (7)https://github.com/python/mypy/pull/16315/commits
Checkshttps://github.com/python/mypy/pull/16315/checks
Files changedhttps://github.com/python/mypy/pull/16315/files
Support narrowing unions that include type[None].https://github.com/python/mypy/pull/16315#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
tyralla:fix/narrow_nonetypehttps://github.com/tyralla/mypy/tree/fix/narrow_nonetype
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 23, 2023https://github.com/python/mypy/pull/16315#issue-1956484076
#16279https://github.com/python/mypy/issues/16279
Please reload this pagehttps://github.com/python/mypy/pull/16315
tyrallahttps://github.com/tyralla
October 23, 2023 08:53https://github.com/python/mypy/pull/16315#commits-pushed-05f2c71
https://github.com/tyralla
Support narrowing unions that include type[None].https://github.com/python/mypy/pull/16315/commits/05f2c713556be88b73e8c73159d958642683b5ad
05f2c71https://github.com/python/mypy/pull/16315/commits/05f2c713556be88b73e8c73159d958642683b5ad
https://github.com/tyralla
Merge branch 'master' into fix/narrow_nonetypehttps://github.com/python/mypy/pull/16315/commits/1ea576cd4b215f00ce0c81a31896371e48249d30
1ea576chttps://github.com/python/mypy/pull/16315/commits/1ea576cd4b215f00ce0c81a31896371e48249d30
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 23, 2023 https://github.com/python/mypy/pull/16315#ref-issue-1948087175
can't narrow a union of type[None] #16279 https://github.com/python/mypy/issues/16279
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 23, 2023https://github.com/python/mypy/pull/16315#issuecomment-1775039893
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Oct 23, 2023https://github.com/python/mypy/pull/16315#issuecomment-1775358558
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 23, 2023https://github.com/python/mypy/pull/16315#issuecomment-1775447979
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/ghost
ghosthttps://github.com/ghost
Oct 23, 2023 https://github.com/python/mypy/pull/16315#pullrequestreview-1693353997
View reviewed changes https://github.com/python/mypy/pull/16315/files/1ea576cd4b215f00ce0c81a31896371e48249d30
test-data/unit/check-narrowing.testhttps://github.com/python/mypy/pull/16315/files/1ea576cd4b215f00ce0c81a31896371e48249d30#diff-0413401ad6a91bc5c66579455009ba606ee0ddfb0a78278c9e53618c83b53ed5
ghosthttps://github.com/ghost
Oct 23, 2023https://github.com/python/mypy/pull/16315#discussion_r1369158720
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/16315
tyrallahttps://github.com/tyralla
Oct 24, 2023https://github.com/python/mypy/pull/16315#discussion_r1369630070
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
special case types.NoneTypehttps://github.com/python/mypy/pull/16315/commits/32ca5f43a2bf4712794097134dd32a9bf59bfe83
32ca5f4https://github.com/python/mypy/pull/16315/commits/32ca5f43a2bf4712794097134dd32a9bf59bfe83
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 24, 2023https://github.com/python/mypy/pull/16315#issuecomment-1776561121
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Oct 25, 2023https://github.com/python/mypy/pull/16315#issuecomment-1779387785
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/python/cpython/blob/1262e41842957c3b402fc0cf0a6eb2ea230c828f/Tools/clinic/clinic.py#L5828-L5831https://github.com/python/cpython/blob/1262e41842957c3b402fc0cf0a6eb2ea230c828f/Tools/clinic/clinic.py#L5828-L5831
https://github.com/python/cpython/blob/1262e41842957c3b402fc0cf0a6eb2ea230c828f/Tools/clinic/clinic.py#L5719https://github.com/python/cpython/blob/1262e41842957c3b402fc0cf0a6eb2ea230c828f/Tools/clinic/clinic.py#L5719
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 25, 2023https://github.com/python/mypy/pull/16315#issuecomment-1779519218
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 25, 2023https://github.com/python/mypy/pull/16315#issuecomment-1779607749
#15148https://github.com/python/mypy/issues/15148
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 26, 2023https://github.com/python/mypy/pull/16315#issuecomment-1781409783
#16330https://github.com/python/mypy/pull/16330
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Oct 26, 2023https://github.com/python/mypy/pull/16315#issuecomment-1781424645
#16330https://github.com/python/mypy/pull/16330
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Oct 26, 2023 https://github.com/python/mypy/pull/16315#ref-pullrequest-1963875614
Do not intersect types in isinstance checks if at least one is final. #16330 https://github.com/python/mypy/pull/16330
https://github.com/tyralla
tyrallahttps://github.com/tyralla
October 28, 2023 06:17https://github.com/python/mypy/pull/16315#event-10797175195
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Dec 4, 2023https://github.com/python/mypy/pull/16315#issuecomment-1838140251
@tyrallahttps://github.com/tyralla
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
Merge branch 'master' into fix/narrow_nonetypehttps://github.com/python/mypy/pull/16315/commits/fc853e9f2bd92fbe5c814010e15c6c7d4eb60c55
fc853e9https://github.com/python/mypy/pull/16315/commits/fc853e9f2bd92fbe5c814010e15c6c7d4eb60c55
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Dec 4, 2023https://github.com/python/mypy/pull/16315#issuecomment-1838891384
@AlexWaygoodhttps://github.com/AlexWaygood
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Dec 4, 2023https://github.com/python/mypy/pull/16315#issuecomment-1839184605
#16330https://github.com/python/mypy/pull/16330
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Dec 5, 2023https://github.com/python/mypy/pull/16315#issuecomment-1840055694
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
Add test case `testNarrowingIsInstanceNoIntersectionWithFinalTypeAndN…https://github.com/python/mypy/pull/16315/commits/fe12f7d1a62a66c45ba23c45965e4064117a2fff
fe12f7dhttps://github.com/python/mypy/pull/16315/commits/fe12f7d1a62a66c45ba23c45965e4064117a2fff
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315
tyrallahttps://github.com/tyralla
December 5, 2023 10:19https://github.com/python/mypy/pull/16315#commits-pushed-58f0562
https://github.com/tyralla
A little additional effort for `Subclass of "..." and "NoneType" cann…https://github.com/python/mypy/pull/16315/commits/58f0562f34af9c8854b50496a96bb1c3e9300410
58f0562https://github.com/python/mypy/pull/16315/commits/58f0562f34af9c8854b50496a96bb1c3e9300410
https://github.com/marketplace/pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hookshttps://github.com/python/mypy/pull/16315/commits/55b2858e87f041ea463c244cf9d8fddc7a0e0afa
55b2858https://github.com/python/mypy/pull/16315/commits/55b2858e87f041ea463c244cf9d8fddc7a0e0afa
https://pre-commit.cihttps://pre-commit.ci
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Dec 5, 2023https://github.com/python/mypy/pull/16315#issuecomment-1840381309
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Jan 9, 2024https://github.com/python/mypy/pull/16315#issuecomment-1882419057
@AlexWaygoodhttps://github.com/AlexWaygood
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Jan 9, 2024https://github.com/python/mypy/pull/16315#issuecomment-1882541631
@AlexWaygoodhttps://github.com/AlexWaygood
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Jan 9, 2024https://github.com/python/mypy/pull/16315#issuecomment-1882575003
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Jan 9, 2024https://github.com/python/mypy/pull/16315#issuecomment-1882580425
Please reload this pagehttps://github.com/python/mypy/pull/16315
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
upnext https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext
Jan 9, 2024https://github.com/python/mypy/pull/16315#event-11427772744
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 14, 2024 https://github.com/python/mypy/pull/16315#pullrequestreview-1820136968
View reviewed changes https://github.com/python/mypy/pull/16315/files/55b2858e87f041ea463c244cf9d8fddc7a0e0afa
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/mypy/pull/16315#pullrequestreview-1820136968
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
261e569https://github.com/python/mypy/commit/261e569e2c256451692dd57c05295ef0bcfb34fd
Jan 14, 2024https://github.com/python/mypy/pull/16315#event-11479762125
https://github.com/brianschubert
brianschuberthttps://github.com/brianschubert
Dec 8, 2024 https://github.com/python/mypy/pull/16315#ref-issue-1212688595
Inconsistent type inference with type(None) #12658 https://github.com/python/mypy/issues/12658
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F16315
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/16315/files/55b2858e87f041ea463c244cf9d8fddc7a0e0afa
Please reload this pagehttps://github.com/python/mypy/pull/16315
upnext https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext
can't narrow a union of type[None] https://github.com/python/mypy/issues/16279
Please reload this pagehttps://github.com/python/mypy/pull/16315
https://github.com/tyralla
https://github.com/JelleZijlstra
https://github.com/AlexWaygood
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.