René's URL Explorer Experiment


Title: Gracefully handle invalid type comments in the fast parser by ddfisher · Pull Request #1600 · python/mypy · GitHub

Open Graph Title: Gracefully handle invalid type comments in the fast parser by ddfisher · Pull Request #1600 · python/mypy

X Title: Gracefully handle invalid type comments in the fast parser by ddfisher · Pull Request #1600 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Gives errors with the appropriate line number (instead of unhelpful stack traces) on syntax errors or invalid AST nodes in type comments. E.g.: syntax error: x = None # type: a : b invalid AST nod...

X Description: Gives errors with the appropriate line number (instead of unhelpful stack traces) on syntax errors or invalid AST nodes in type comments. E.g.: syntax error: x = None # type: a : b invalid AST nod...

Opengraph URL: https://github.com/python/mypy/pull/1600

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d52f8a53-5c29-14ce-9d51-1e87cc26809c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BFC:1DD784:B42343:F1319D:6B004AED
html-safe-noncebf87b4fdc739a1dcb7249ae6c270267748cb0bb14d4044880c7df07c33d8b939
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkZDOjFERDc4NDpCNDIzNDM6RjEzMTlEOjZCMDA0QUVEIiwidmlzaXRvcl9pZCI6IjUwMjg0MzI5MjAzNjEwNjExMDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1d8e8eac96e3ce4439b0013d54241dc82e0c018be0b0cbb0763af5f60edbd2c2
hovercard-subject-tagpull_request:72248685
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/1600/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/75e5899cd7849f3b435887fcea398f56c6792cea78fcd59b8cf8fdd2d1afdbcd/python/mypy/pull/1600
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/75e5899cd7849f3b435887fcea398f56c6792cea78fcd59b8cf8fdd2d1afdbcd/python/mypy/pull/1600
og:image:altGives errors with the appropriate line number (instead of unhelpful stack traces) on syntax errors or invalid AST nodes in type comments. E.g.: syntax error: x = None # type: a : b invalid AST nod...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameddfisher
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/1600#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F1600
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F1600
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/1600
Reloadhttps://github.com/python/mypy/pull/1600
Reloadhttps://github.com/python/mypy/pull/1600
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
ddfisher:PR/type-comment-errorshttps://github.com/ddfisher/mypy/tree/PR/type-comment-errors
Conversationhttps://github.com/python/mypy/pull/1600
Commits4 (4)https://github.com/python/mypy/pull/1600/commits
Checkshttps://github.com/python/mypy/pull/1600/checks
Files changedhttps://github.com/python/mypy/pull/1600/files
Gracefully handle invalid type comments in the fast parserhttps://github.com/python/mypy/pull/1600#top
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
ddfisher:PR/type-comment-errorshttps://github.com/ddfisher/mypy/tree/PR/type-comment-errors
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
Jun 1, 2016https://github.com/python/mypy/pull/1600#issue-158002274
Please reload this pagehttps://github.com/python/mypy/pull/1600
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jun 1, 2016https://github.com/python/mypy/pull/1600#issuecomment-223122212
Please reload this pagehttps://github.com/python/mypy/pull/1600
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
Jun 2, 2016https://github.com/python/mypy/pull/1600#issuecomment-223433024
Please reload this pagehttps://github.com/python/mypy/pull/1600
gvanrossumhttps://github.com/gvanrossum
Jun 2, 2016 https://github.com/python/mypy/pull/1600#discussion-diff-65636213
View reviewed changes https://github.com/python/mypy/pull/1600/files/cfc985df0cba00cf058aec94ddbd853a16974ad9#diff-a7d2c40f4be6322cee498432ca9dbbc3a356c3cbcb61029231452f6638bb11b5
mypy/fastparse.pyhttps://github.com/python/mypy/pull/1600/files#diff-a7d2c40f4be6322cee498432ca9dbbc3a356c3cbcb61029231452f6638bb11b5
gvanrossumhttps://github.com/gvanrossum
Jun 2, 2016https://github.com/python/mypy/pull/1600#discussion_r65636213
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/1600
ddfisherhttps://github.com/ddfisher
Jun 2, 2016https://github.com/python/mypy/pull/1600#discussion_r65637726
Please reload this pagehttps://github.com/python/mypy/pull/1600
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/1600
gvanrossumhttps://github.com/gvanrossum
Jun 2, 2016https://github.com/python/mypy/pull/1600#discussion_r65638282
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#1610https://github.com/python/mypy/pull/1610
Please reload this pagehttps://github.com/python/mypy/pull/1600
ddfisherhttps://github.com/ddfisher
Jun 3, 2016https://github.com/python/mypy/pull/1600#discussion_r65639359
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/1600
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jun 2, 2016https://github.com/python/mypy/pull/1600#issuecomment-223452806
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/1600
ddfisherhttps://github.com/ddfisher
June 2, 2016 17:59https://github.com/python/mypy/pull/1600#commits-pushed-e644ae3
https://github.com/ddfisher
Gracefully handle invalid type comments in the fast parserhttps://github.com/python/mypy/pull/1600/commits/e644ae33626dca56eb0393824f4e4777acd01ee7
e644ae3https://github.com/python/mypy/pull/1600/commits/e644ae33626dca56eb0393824f4e4777acd01ee7
https://github.com/ddfisher
fix lint errorshttps://github.com/python/mypy/pull/1600/commits/a709217f4651263983dabba3e3f4c85687592d71
a709217https://github.com/python/mypy/pull/1600/commits/a709217f4651263983dabba3e3f4c85687592d71
https://github.com/ddfisher
Combine except clauseshttps://github.com/python/mypy/pull/1600/commits/a79b2f1f418fea6dd855808ba6eb574eba5495db
a79b2f1https://github.com/python/mypy/pull/1600/commits/a79b2f1f418fea6dd855808ba6eb574eba5495db
https://github.com/ddfisher
remove type ignorehttps://github.com/python/mypy/pull/1600/commits/57e2b02008dea698bc2bb1227f4f2ba780148255
57e2b02https://github.com/python/mypy/pull/1600/commits/57e2b02008dea698bc2bb1227f4f2ba780148255
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
force-pushedhttps://github.com/python/mypy/compare/5a5f8b02e5aa48a5aba1ab117b17fa28b4faee19..57e2b02008dea698bc2bb1227f4f2ba780148255
5a5f8b0https://github.com/python/mypy/commit/5a5f8b02e5aa48a5aba1ab117b17fa28b4faee19
57e2b02https://github.com/python/mypy/commit/57e2b02008dea698bc2bb1227f4f2ba780148255
Compare https://github.com/python/mypy/compare/5a5f8b02e5aa48a5aba1ab117b17fa28b4faee19..57e2b02008dea698bc2bb1227f4f2ba780148255
June 3, 2016 01:00https://github.com/python/mypy/pull/1600#event-680585525
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
Jun 3, 2016https://github.com/python/mypy/pull/1600#issuecomment-223465045
Please reload this pagehttps://github.com/python/mypy/pull/1600
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
9982db6https://github.com/python/mypy/commit/9982db6789de8725e428cd8b9bce20da1432fe01
Jun 3, 2016https://github.com/python/mypy/pull/1600#event-680600444
Uninformative message with fast-parser #1633 https://github.com/python/mypy/issues/1633
Add some initial tests for the fast parser #1648 https://github.com/python/mypy/pull/1648
Forgetting parens around arguments in python2 annotations crashes mypy fast-parser #1656 https://github.com/python/mypy/issues/1656
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F1600
Please reload this pagehttps://github.com/python/mypy/pull/1600
Please reload this pagehttps://github.com/python/mypy/pull/1600
https://github.com/ddfisher
https://github.com/gvanrossum
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.