René's URL Explorer Experiment


Title: TypedDict 'in' narrowing w/o @final by ikonst · Pull Request #15698 · python/mypy · GitHub

Open Graph Title: TypedDict 'in' narrowing w/o @final by ikonst · Pull Request #15698 · python/mypy

X Title: TypedDict 'in' narrowing w/o @final by ikonst · Pull Request #15698 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: We shouldn't require T1 and T2 to be final, to have 'foo' in Union[TD1, TD2] narrowing take place. We previously (#13838) thought we should, but @erictraut made a good point that TypedD...

X Description: We shouldn't require T1 and T2 to be final, to have 'foo' in Union[TD1, TD2] narrowing take place. We previously (#13838) thought we should, but @erictraut made a good point...

Opengraph URL: https://github.com/python/mypy/pull/15698

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f9a94c13-2278-a52f-57ec-c67ed2f59038
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8586:390AA2:221BB9E:2E71C06:6B0025E3
html-safe-nonce46a155a8ecc446a3b239124f9798b47c49ed53ede593f41234f9814711fe658a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTg2OjM5MEFBMjoyMjFCQjlFOjJFNzFDMDY6NkIwMDI1RTMiLCJ2aXNpdG9yX2lkIjoiNTY2ODIwNTM4MTg0Nzg4NTI4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace9850b06c63da2b19834db26e8df64865d92136b2af6a5d8027fa7f8ce70ff9f
hovercard-subject-tagpull_request:1438429834
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15698/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3632d0d7a704937832e240bee5d5c755f62a88c48ab1ce3f8c66e18e66d3369f/python/mypy/pull/15698
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3632d0d7a704937832e240bee5d5c755f62a88c48ab1ce3f8c66e18e66d3369f/python/mypy/pull/15698
og:image:altWe shouldn't require T1 and T2 to be final, to have 'foo' in Union[TD1, TD2] narrowing take place. We previously (#13838) thought we should, but @erictraut made a good point that TypedD...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameikonst
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/15698#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15698
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15698
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/15698
Reloadhttps://github.com/python/mypy/pull/15698
Reloadhttps://github.com/python/mypy/pull/15698
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ikonsthttps://github.com/ikonst
python:masterhttps://github.com/python/mypy/tree/master
ikonst:issue-15697https://github.com/ikonst/mypy/tree/issue-15697
Conversationhttps://github.com/python/mypy/pull/15698
Commits3 (3)https://github.com/python/mypy/pull/15698/commits
Checkshttps://github.com/python/mypy/pull/15698/checks
Files changedhttps://github.com/python/mypy/pull/15698/files
TypedDict 'in' narrowing w/o @finalhttps://github.com/python/mypy/pull/15698#top
ikonsthttps://github.com/ikonst
python:masterhttps://github.com/python/mypy/tree/master
ikonst:issue-15697https://github.com/ikonst/mypy/tree/issue-15697
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Jul 18, 2023https://github.com/python/mypy/pull/15698#issue-1809016953
Please reload this pagehttps://github.com/python/mypy/pull/15698
#13838https://github.com/python/mypy/pull/13838
@erictrauthttps://github.com/erictraut
#15697https://github.com/python/mypy/issues/15697
Please reload this pagehttps://github.com/python/mypy/pull/15698
https://github.com/ikonst
TypedDict 'in' narrowing w/ohttps://github.com/python/mypy/pull/15698/commits/a8dbd22c04c124cc4fa652ae9971df6fc92d0668
@Finalhttps://github.com/Final
a8dbd22https://github.com/python/mypy/pull/15698/commits/a8dbd22c04c124cc4fa652ae9971df6fc92d0668
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15698
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Jul 18, 2023https://github.com/python/mypy/pull/15698#issuecomment-1639360854
https://github.com/Rapptz/discord.py/blob/b7785d29cbd43b0d21c823b31fd5ae5a0dd2e94a/discord/audit_logs.py#L247-L261https://github.com/Rapptz/discord.py/blob/b7785d29cbd43b0d21c823b31fd5ae5a0dd2e94a/discord/audit_logs.py#L247-L261
Please reload this pagehttps://github.com/python/mypy/pull/15698
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Jul 31, 2023https://github.com/python/mypy/pull/15698#issuecomment-1657331515
@hauntsaninjahttps://github.com/hauntsaninja
#13838https://github.com/python/mypy/pull/13838
Please reload this pagehttps://github.com/python/mypy/pull/15698
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Aug 12, 2023 https://github.com/python/mypy/pull/15698#pullrequestreview-1574890926
View reviewed changes https://github.com/python/mypy/pull/15698/files/a8dbd22c04c124cc4fa652ae9971df6fc92d0668
test-data/unit/check-typeddict.testhttps://github.com/python/mypy/pull/15698/files/a8dbd22c04c124cc4fa652ae9971df6fc92d0668#diff-1db589b0c06e93bf0f492fb32a043ad16c054379c19cd39da57960e98c4b8be0
hauntsaninjahttps://github.com/hauntsaninja
Aug 12, 2023https://github.com/python/mypy/pull/15698#discussion_r1292131868
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15698
ikonsthttps://github.com/ikonst
Aug 13, 2023https://github.com/python/mypy/pull/15698#discussion_r1292619296
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
a68b87ahttps://github.com/python/mypy/commit/a68b87abff4f38d0ebf469e986f1aad98cbe0de5
Please reload this pagehttps://github.com/python/mypy/pull/15698
https://github.com/ikonst
remove morehttps://github.com/python/mypy/pull/15698/commits/a68b87abff4f38d0ebf469e986f1aad98cbe0de5
@finalshttps://github.com/finals
+ improve testshttps://github.com/python/mypy/pull/15698/commits/a68b87abff4f38d0ebf469e986f1aad98cbe0de5
a68b87ahttps://github.com/python/mypy/pull/15698/commits/a68b87abff4f38d0ebf469e986f1aad98cbe0de5
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15698
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Aug 18, 2023https://github.com/python/mypy/pull/15698#issuecomment-1683302980
@hauntsaninjahttps://github.com/hauntsaninja
Please reload this pagehttps://github.com/python/mypy/pull/15698
https://github.com/ikonst
Merge branch 'master' into issue-15697https://github.com/python/mypy/pull/15698/commits/5a53d458519738aabc982afe045e1bea2dcd77c4
5a53d45https://github.com/python/mypy/pull/15698/commits/5a53d458519738aabc982afe045e1bea2dcd77c4
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 18, 2023https://github.com/python/mypy/pull/15698#issuecomment-1683319023
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/15698
https://github.com/gandhis1
gandhis1https://github.com/gandhis1
Nov 14, 2023https://github.com/python/mypy/pull/15698#issuecomment-1810439377
Please reload this pagehttps://github.com/python/mypy/pull/15698
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Jan 12, 2024https://github.com/python/mypy/pull/15698#issuecomment-1888375607
@hauntsaninjahttps://github.com/hauntsaninja
Please reload this pagehttps://github.com/python/mypy/pull/15698
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 15, 2024https://github.com/python/mypy/pull/15698#issuecomment-1892809273
https://github.com/python/typing-council#decisionshttps://github.com/python/typing-council#decisions
Please reload this pagehttps://github.com/python/mypy/pull/15698
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15698
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/15698/files/a8dbd22c04c124cc4fa652ae9971df6fc92d0668
Please reload this pagehttps://github.com/python/mypy/pull/15698
TypedDict 'in' narrowing w/o @final https://github.com/python/mypy/issues/15697
Please reload this pagehttps://github.com/python/mypy/pull/15698
https://github.com/ikonst
https://github.com/gandhis1
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.