| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f9a94c13-2278-a52f-57ec-c67ed2f59038 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8586:390AA2:221BB9E:2E71C06:6B0025E3 |
| html-safe-nonce | 46a155a8ecc446a3b239124f9798b47c49ed53ede593f41234f9814711fe658a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTg2OjM5MEFBMjoyMjFCQjlFOjJFNzFDMDY6NkIwMDI1RTMiLCJ2aXNpdG9yX2lkIjoiNTY2ODIwNTM4MTg0Nzg4NTI4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e9850b06c63da2b19834db26e8df64865d92136b2af6a5d8027fa7f8ce70ff9f |
| hovercard-subject-tag | pull_request:1438429834 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15698/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3632d0d7a704937832e240bee5d5c755f62a88c48ab1ce3f8c66e18e66d3369f/python/mypy/pull/15698 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3632d0d7a704937832e240bee5d5c755f62a88c48ab1ce3f8c66e18e66d3369f/python/mypy/pull/15698 |
| og:image:alt | We shouldn't require T1 and T2 to be final, to have 'foo' in Union[TD1, TD2] narrowing take place. We previously (#13838) thought we should, but @erictraut made a good point that TypedD... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ikonst |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/15698#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15698 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15698 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/15698 |
| Reload | https://github.com/python/mypy/pull/15698 |
| Reload | https://github.com/python/mypy/pull/15698 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ikonst | https://github.com/ikonst |
| python:master | https://github.com/python/mypy/tree/master |
| ikonst:issue-15697 | https://github.com/ikonst/mypy/tree/issue-15697 |
| Conversation | https://github.com/python/mypy/pull/15698 |
| Commits3 (3) | https://github.com/python/mypy/pull/15698/commits |
| Checks | https://github.com/python/mypy/pull/15698/checks |
| Files changed | https://github.com/python/mypy/pull/15698/files |
| TypedDict 'in' narrowing w/o @final | https://github.com/python/mypy/pull/15698#top |
| ikonst | https://github.com/ikonst |
| python:master | https://github.com/python/mypy/tree/master |
| ikonst:issue-15697 | https://github.com/ikonst/mypy/tree/issue-15697 |
|
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| Jul 18, 2023 | https://github.com/python/mypy/pull/15698#issue-1809016953 |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
| #13838 | https://github.com/python/mypy/pull/13838 |
| @erictraut | https://github.com/erictraut |
| #15697 | https://github.com/python/mypy/issues/15697 |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
|
| https://github.com/ikonst |
| TypedDict 'in' narrowing w/o | https://github.com/python/mypy/pull/15698/commits/a8dbd22c04c124cc4fa652ae9971df6fc92d0668 |
| @Final | https://github.com/Final |
| a8dbd22 | https://github.com/python/mypy/pull/15698/commits/a8dbd22c04c124cc4fa652ae9971df6fc92d0668 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15698 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| Jul 18, 2023 | https://github.com/python/mypy/pull/15698#issuecomment-1639360854 |
| https://github.com/Rapptz/discord.py/blob/b7785d29cbd43b0d21c823b31fd5ae5a0dd2e94a/discord/audit_logs.py#L247-L261 | https://github.com/Rapptz/discord.py/blob/b7785d29cbd43b0d21c823b31fd5ae5a0dd2e94a/discord/audit_logs.py#L247-L261 |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| Jul 31, 2023 | https://github.com/python/mypy/pull/15698#issuecomment-1657331515 |
| @hauntsaninja | https://github.com/hauntsaninja |
| #13838 | https://github.com/python/mypy/pull/13838 |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Aug 12, 2023
| https://github.com/python/mypy/pull/15698#pullrequestreview-1574890926 |
|
View reviewed changes
| https://github.com/python/mypy/pull/15698/files/a8dbd22c04c124cc4fa652ae9971df6fc92d0668 |
| test-data/unit/check-typeddict.test | https://github.com/python/mypy/pull/15698/files/a8dbd22c04c124cc4fa652ae9971df6fc92d0668#diff-1db589b0c06e93bf0f492fb32a043ad16c054379c19cd39da57960e98c4b8be0 |
| hauntsaninja | https://github.com/hauntsaninja |
| Aug 12, 2023 | https://github.com/python/mypy/pull/15698#discussion_r1292131868 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
| ikonst | https://github.com/ikonst |
| Aug 13, 2023 | https://github.com/python/mypy/pull/15698#discussion_r1292619296 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| a68b87a | https://github.com/python/mypy/commit/a68b87abff4f38d0ebf469e986f1aad98cbe0de5 |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
|
| https://github.com/ikonst |
| remove more | https://github.com/python/mypy/pull/15698/commits/a68b87abff4f38d0ebf469e986f1aad98cbe0de5 |
| @finals | https://github.com/finals |
| + improve tests | https://github.com/python/mypy/pull/15698/commits/a68b87abff4f38d0ebf469e986f1aad98cbe0de5 |
| a68b87a | https://github.com/python/mypy/pull/15698/commits/a68b87abff4f38d0ebf469e986f1aad98cbe0de5 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15698 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| Aug 18, 2023 | https://github.com/python/mypy/pull/15698#issuecomment-1683302980 |
| @hauntsaninja | https://github.com/hauntsaninja |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
|
| https://github.com/ikonst |
| Merge branch 'master' into issue-15697 | https://github.com/python/mypy/pull/15698/commits/5a53d458519738aabc982afe045e1bea2dcd77c4 |
| 5a53d45 | https://github.com/python/mypy/pull/15698/commits/5a53d458519738aabc982afe045e1bea2dcd77c4 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 18, 2023 | https://github.com/python/mypy/pull/15698#issuecomment-1683319023 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
| https://github.com/gandhis1 |
| gandhis1 | https://github.com/gandhis1 |
| Nov 14, 2023 | https://github.com/python/mypy/pull/15698#issuecomment-1810439377 |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| Jan 12, 2024 | https://github.com/python/mypy/pull/15698#issuecomment-1888375607 |
| @hauntsaninja | https://github.com/hauntsaninja |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| Jan 15, 2024 | https://github.com/python/mypy/pull/15698#issuecomment-1892809273 |
| https://github.com/python/typing-council#decisions | https://github.com/python/typing-council#decisions |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15698 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/15698/files/a8dbd22c04c124cc4fa652ae9971df6fc92d0668 |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
|
TypedDict 'in' narrowing w/o @final
| https://github.com/python/mypy/issues/15697 |
| Please reload this page | https://github.com/python/mypy/pull/15698 |
|
| https://github.com/ikonst |
|
| https://github.com/gandhis1 |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |