René's URL Explorer Experiment


Title: Exclude the same special attributes from Protocol as CPython by HexDecimal · Pull Request #15490 · python/mypy · GitHub

Open Graph Title: Exclude the same special attributes from Protocol as CPython by HexDecimal · Pull Request #15490 · python/mypy

X Title: Exclude the same special attributes from Protocol as CPython by HexDecimal · Pull Request #15490 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #11884 Fixes #11886 Tests have been added for these cases. PR is based on #11885 @sobolevn CPython holds a collection of attributes which it excludes from protocols. It can be viewed here. Th...

X Description: Fixes #11884 Fixes #11886 Tests have been added for these cases. PR is based on #11885 @sobolevn CPython holds a collection of attributes which it excludes from protocols. It can be viewed here. Th...

Opengraph URL: https://github.com/python/mypy/pull/15490

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:884d208e-99fa-fe25-8b95-28b5f15d21ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5FA:36D598:712FBC:975213:6B0037DE
html-safe-noncef613acc0523464964e223c2b9addcbe0a096064d2b18e11fc8dfb14bcc820e49
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUZBOjM2RDU5ODo3MTJGQkM6OTc1MjEzOjZCMDAzN0RFIiwidmlzaXRvcl9pZCI6IjQwNjk0MTcyNDkxNTk1MjYzNjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac93cc27a1c3730050ebcdeb39833bffee88846b8ff27c31c740280737b67eef0b
hovercard-subject-tagpull_request:1402263036
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15490/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6e3ac4f5a252e76d81d484a88efe4f253b166f672e3541ab3703d4c19ea845b1/python/mypy/pull/15490
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6e3ac4f5a252e76d81d484a88efe4f253b166f672e3541ab3703d4c19ea845b1/python/mypy/pull/15490
og:image:altFixes #11884 Fixes #11886 Tests have been added for these cases. PR is based on #11885 @sobolevn CPython holds a collection of attributes which it excludes from protocols. It can be viewed here. Th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameHexDecimal
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/15490#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15490
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15490
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/15490
Reloadhttps://github.com/python/mypy/pull/15490
Reloadhttps://github.com/python/mypy/pull/15490
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
HexDecimal:protocol-exclusionshttps://github.com/HexDecimal/mypy/tree/protocol-exclusions
Conversationhttps://github.com/python/mypy/pull/15490
Commits6 (6)https://github.com/python/mypy/pull/15490/commits
Checkshttps://github.com/python/mypy/pull/15490/checks
Files changedhttps://github.com/python/mypy/pull/15490/files
Exclude the same special attributes from Protocol as CPythonhttps://github.com/python/mypy/pull/15490#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
HexDecimal:protocol-exclusionshttps://github.com/HexDecimal/mypy/tree/protocol-exclusions
https://github.com/HexDecimal
HexDecimalhttps://github.com/HexDecimal
Jun 21, 2023https://github.com/python/mypy/pull/15490#issue-1768247993
Please reload this pagehttps://github.com/python/mypy/pull/15490
#11884https://github.com/python/mypy/issues/11884
#11886https://github.com/python/mypy/issues/11886
#11885https://github.com/python/mypy/pull/11885
@sobolevnhttps://github.com/sobolevn
It can be viewed herehttps://github.com/python/cpython/blob/fc32522b081c895f3798e4a16788b800cff08166/Lib/typing.py#L1672-L1693
#11886https://github.com/python/mypy/issues/11886
#11886https://github.com/python/mypy/issues/11886
#11013https://github.com/python/mypy/issues/11013
Please reload this pagehttps://github.com/python/mypy/pull/15490
HexDecimalhttps://github.com/HexDecimal
June 21, 2023 09:36https://github.com/python/mypy/pull/15490#commits-pushed-2966617
https://github.com/HexDecimal
Test __slots__ used as a protocol memberhttps://github.com/python/mypy/pull/15490/commits/2966617f826e92a4c3134413dff50d6fc9dd4d87
2966617https://github.com/python/mypy/pull/15490/commits/2966617f826e92a4c3134413dff50d6fc9dd4d87
https://github.com/HexDecimal
Exclude special attributes not collected by Pythonhttps://github.com/python/mypy/pull/15490/commits/67872e81101781e8c1d73f346cd87963a075c071
67872e8https://github.com/python/mypy/pull/15490/commits/67872e81101781e8c1d73f346cd87963a075c071
https://github.com/HexDecimal
Add tests for __class_getitem__ in protocolshttps://github.com/python/mypy/pull/15490/commits/e2edbf93f2de5e2b9be610b38f952247af4be98f
e2edbf9https://github.com/python/mypy/pull/15490/commits/e2edbf93f2de5e2b9be610b38f952247af4be98f
https://github.com/HexDecimal
Make EXCLUDED_ATTRIBUTES a class constanthttps://github.com/python/mypy/pull/15490/commits/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d
87ddf42https://github.com/python/mypy/pull/15490/commits/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15490
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Jun 21, 2023 https://github.com/python/mypy/pull/15490#pullrequestreview-1491693977
View reviewed changes https://github.com/python/mypy/pull/15490/files/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d
mypy/nodes.pyhttps://github.com/python/mypy/pull/15490/files/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
sobolevnhttps://github.com/sobolevn
Jun 21, 2023https://github.com/python/mypy/pull/15490#discussion_r1237592029
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15490
HexDecimalhttps://github.com/HexDecimal
Jun 21, 2023https://github.com/python/mypy/pull/15490#discussion_r1237606238
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15490
mypy/nodes.pyhttps://github.com/python/mypy/pull/15490/files/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
sobolevnhttps://github.com/sobolevn
Jun 21, 2023https://github.com/python/mypy/pull/15490#discussion_r1237592554
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@AlexWaygoodhttps://github.com/AlexWaygood
Please reload this pagehttps://github.com/python/mypy/pull/15490
AlexWaygoodhttps://github.com/AlexWaygood
Jun 21, 2023https://github.com/python/mypy/pull/15490#discussion_r1237610257
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@HexDecimalhttps://github.com/HexDecimal
https://github.com/python/cpython/blob/4328dc646517f9251bdf6c827014f01c5229e8d9/Lib/typing.py#L1678-L1682https://github.com/python/cpython/blob/4328dc646517f9251bdf6c827014f01c5229e8d9/Lib/typing.py#L1678-L1682
Please reload this pagehttps://github.com/python/mypy/pull/15490
AlexWaygoodhttps://github.com/AlexWaygood
Jun 21, 2023https://github.com/python/mypy/pull/15490#discussion_r1237612576
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15490
HexDecimalhttps://github.com/HexDecimal
Jun 22, 2023https://github.com/python/mypy/pull/15490#discussion_r1237902726
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3823https://github.com/python/mypy/issues/3823
Please reload this pagehttps://github.com/python/mypy/pull/15490
mypy/nodes.pyhttps://github.com/python/mypy/pull/15490/files/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
sobolevnhttps://github.com/sobolevn
Jun 21, 2023https://github.com/python/mypy/pull/15490#discussion_r1237595258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15490
https://github.com/HexDecimal
Move excluded attributes back to the top-levelhttps://github.com/python/mypy/pull/15490/commits/b348e714b98ded11ccdaac713898bf32d0056bcf
b348e71https://github.com/python/mypy/pull/15490/commits/b348e714b98ded11ccdaac713898bf32d0056bcf
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15490
https://github.com/HexDecimal
Add test for Protocol slots with init assignmenthttps://github.com/python/mypy/pull/15490/commits/f473ea0d6b088e83c6fa8fe716590bae42dae0d3
f473ea0https://github.com/python/mypy/pull/15490/commits/f473ea0d6b088e83c6fa8fe716590bae42dae0d3
python#11013https://github.com/python/mypy/issues/11013
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 22, 2023https://github.com/python/mypy/pull/15490#issuecomment-1601898245
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/15490
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jun 26, 2023 https://github.com/python/mypy/pull/15490#pullrequestreview-1497805012
View reviewed changes https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/mypy/pull/15490#pullrequestreview-1497805012
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15490
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
upnext https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext
Jun 26, 2023https://github.com/python/mypy/pull/15490#event-9634734330
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Jun 26, 2023 https://github.com/python/mypy/pull/15490#pullrequestreview-1498057091
View reviewed changes https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3
AlexWaygoodhttps://github.com/AlexWaygood
https://github.com/python/mypy/pull/15490#pullrequestreview-1498057091
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15490
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
Jun 26, 2023 https://github.com/python/mypy/pull/15490#pullrequestreview-1499224394
View reviewed changes https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3
emmatypinghttps://github.com/emmatyping
https://github.com/python/mypy/pull/15490#pullrequestreview-1499224394
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15490
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
7ce3568https://github.com/python/mypy/commit/7ce3568d823c52e734983333271d315b637a61e6
Jun 26, 2023https://github.com/python/mypy/pull/15490#event-9643522306
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Aug 12, 2023 https://github.com/python/mypy/pull/15490#ref-issue-1845782978
regression with Generic/ParamSpec between 1.4.1 and 1.5.0 #15844 https://github.com/python/mypy/issues/15844
https://github.com/HexDecimal
HexDecimalhttps://github.com/HexDecimal
Feb 11, 2025 https://github.com/python/mypy/pull/15490#ref-issue-2846003353
Adding __slots__ to a function-like Protocol breaks support for function assigment to the Protocol microsoft/pyright#9878 https://github.com/microsoft/pyright/issues/9878
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15490
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/mypy/pull/15490/files/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d
https://github.com/emmatyping
emmatyping https://github.com/emmatyping
https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3
Please reload this pagehttps://github.com/python/mypy/pull/15490
upnext https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext
Should __class_getitem__ be considered part of the interface of Protocol classes? https://github.com/python/mypy/issues/11886
__slots__ and protocols don't work right for issubclass and typevar bounds https://github.com/python/mypy/issues/11884
__slots__ requires explicit type definition and must be Any (and nothing else) when used with Protocols https://github.com/python/mypy/issues/11013
Please reload this pagehttps://github.com/python/mypy/pull/15490
https://github.com/HexDecimal
https://github.com/sobolevn
https://github.com/emmatyping
https://github.com/hauntsaninja
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.