| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:884d208e-99fa-fe25-8b95-28b5f15d21ec |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D5FA:36D598:712FBC:975213:6B0037DE |
| html-safe-nonce | f613acc0523464964e223c2b9addcbe0a096064d2b18e11fc8dfb14bcc820e49 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUZBOjM2RDU5ODo3MTJGQkM6OTc1MjEzOjZCMDAzN0RFIiwidmlzaXRvcl9pZCI6IjQwNjk0MTcyNDkxNTk1MjYzNjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 93cc27a1c3730050ebcdeb39833bffee88846b8ff27c31c740280737b67eef0b |
| hovercard-subject-tag | pull_request:1402263036 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15490/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6e3ac4f5a252e76d81d484a88efe4f253b166f672e3541ab3703d4c19ea845b1/python/mypy/pull/15490 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6e3ac4f5a252e76d81d484a88efe4f253b166f672e3541ab3703d4c19ea845b1/python/mypy/pull/15490 |
| og:image:alt | Fixes #11884
Fixes #11886
Tests have been added for these cases.
PR is based on #11885
@sobolevn
CPython holds a collection of attributes which it excludes from protocols. It can be viewed here. Th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | HexDecimal |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/15490#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15490 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15490 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/15490 |
| Reload | https://github.com/python/mypy/pull/15490 |
| Reload | https://github.com/python/mypy/pull/15490 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests545 (545) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| HexDecimal:protocol-exclusions | https://github.com/HexDecimal/mypy/tree/protocol-exclusions |
| Conversation | https://github.com/python/mypy/pull/15490 |
| Commits6 (6) | https://github.com/python/mypy/pull/15490/commits |
| Checks | https://github.com/python/mypy/pull/15490/checks |
| Files changed | https://github.com/python/mypy/pull/15490/files |
| Exclude the same special attributes from Protocol as CPython | https://github.com/python/mypy/pull/15490#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| HexDecimal:protocol-exclusions | https://github.com/HexDecimal/mypy/tree/protocol-exclusions |
|
| https://github.com/HexDecimal |
| HexDecimal | https://github.com/HexDecimal |
| Jun 21, 2023 | https://github.com/python/mypy/pull/15490#issue-1768247993 |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| #11884 | https://github.com/python/mypy/issues/11884 |
| #11886 | https://github.com/python/mypy/issues/11886 |
| #11885 | https://github.com/python/mypy/pull/11885 |
| @sobolevn | https://github.com/sobolevn |
| It can be viewed here | https://github.com/python/cpython/blob/fc32522b081c895f3798e4a16788b800cff08166/Lib/typing.py#L1672-L1693 |
| #11886 | https://github.com/python/mypy/issues/11886 |
| #11886 | https://github.com/python/mypy/issues/11886 |
| #11013 | https://github.com/python/mypy/issues/11013 |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| HexDecimal | https://github.com/HexDecimal |
| June 21, 2023 09:36 | https://github.com/python/mypy/pull/15490#commits-pushed-2966617 |
|
| https://github.com/HexDecimal |
| Test __slots__ used as a protocol member | https://github.com/python/mypy/pull/15490/commits/2966617f826e92a4c3134413dff50d6fc9dd4d87 |
| 2966617 | https://github.com/python/mypy/pull/15490/commits/2966617f826e92a4c3134413dff50d6fc9dd4d87 |
|
| https://github.com/HexDecimal |
| Exclude special attributes not collected by Python | https://github.com/python/mypy/pull/15490/commits/67872e81101781e8c1d73f346cd87963a075c071 |
| 67872e8 | https://github.com/python/mypy/pull/15490/commits/67872e81101781e8c1d73f346cd87963a075c071 |
|
| https://github.com/HexDecimal |
| Add tests for __class_getitem__ in protocols | https://github.com/python/mypy/pull/15490/commits/e2edbf93f2de5e2b9be610b38f952247af4be98f |
| e2edbf9 | https://github.com/python/mypy/pull/15490/commits/e2edbf93f2de5e2b9be610b38f952247af4be98f |
|
| https://github.com/HexDecimal |
| Make EXCLUDED_ATTRIBUTES a class constant | https://github.com/python/mypy/pull/15490/commits/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d |
| 87ddf42 | https://github.com/python/mypy/pull/15490/commits/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15490 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Jun 21, 2023
| https://github.com/python/mypy/pull/15490#pullrequestreview-1491693977 |
|
View reviewed changes
| https://github.com/python/mypy/pull/15490/files/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d |
| mypy/nodes.py | https://github.com/python/mypy/pull/15490/files/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68 |
| sobolevn | https://github.com/sobolevn |
| Jun 21, 2023 | https://github.com/python/mypy/pull/15490#discussion_r1237592029 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| HexDecimal | https://github.com/HexDecimal |
| Jun 21, 2023 | https://github.com/python/mypy/pull/15490#discussion_r1237606238 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| mypy/nodes.py | https://github.com/python/mypy/pull/15490/files/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68 |
| sobolevn | https://github.com/sobolevn |
| Jun 21, 2023 | https://github.com/python/mypy/pull/15490#discussion_r1237592554 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @AlexWaygood | https://github.com/AlexWaygood |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| AlexWaygood | https://github.com/AlexWaygood |
| Jun 21, 2023 | https://github.com/python/mypy/pull/15490#discussion_r1237610257 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @HexDecimal | https://github.com/HexDecimal |
| https://github.com/python/cpython/blob/4328dc646517f9251bdf6c827014f01c5229e8d9/Lib/typing.py#L1678-L1682 | https://github.com/python/cpython/blob/4328dc646517f9251bdf6c827014f01c5229e8d9/Lib/typing.py#L1678-L1682 |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| AlexWaygood | https://github.com/AlexWaygood |
| Jun 21, 2023 | https://github.com/python/mypy/pull/15490#discussion_r1237612576 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| HexDecimal | https://github.com/HexDecimal |
| Jun 22, 2023 | https://github.com/python/mypy/pull/15490#discussion_r1237902726 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #3823 | https://github.com/python/mypy/issues/3823 |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| mypy/nodes.py | https://github.com/python/mypy/pull/15490/files/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68 |
| sobolevn | https://github.com/sobolevn |
| Jun 21, 2023 | https://github.com/python/mypy/pull/15490#discussion_r1237595258 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
|
| https://github.com/HexDecimal |
| Move excluded attributes back to the top-level | https://github.com/python/mypy/pull/15490/commits/b348e714b98ded11ccdaac713898bf32d0056bcf |
| b348e71 | https://github.com/python/mypy/pull/15490/commits/b348e714b98ded11ccdaac713898bf32d0056bcf |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15490 |
|
| https://github.com/HexDecimal |
| Add test for Protocol slots with init assignment | https://github.com/python/mypy/pull/15490/commits/f473ea0d6b088e83c6fa8fe716590bae42dae0d3 |
| f473ea0 | https://github.com/python/mypy/pull/15490/commits/f473ea0d6b088e83c6fa8fe716590bae42dae0d3 |
| python#11013 | https://github.com/python/mypy/issues/11013 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jun 22, 2023 | https://github.com/python/mypy/pull/15490#issuecomment-1601898245 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jun 26, 2023
| https://github.com/python/mypy/pull/15490#pullrequestreview-1497805012 |
|
View reviewed changes
| https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3 |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/mypy/pull/15490#pullrequestreview-1497805012 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
upnext
| https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext |
| Jun 26, 2023 | https://github.com/python/mypy/pull/15490#event-9634734330 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Jun 26, 2023
| https://github.com/python/mypy/pull/15490#pullrequestreview-1498057091 |
|
View reviewed changes
| https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3 |
| AlexWaygood | https://github.com/AlexWaygood |
| https://github.com/python/mypy/pull/15490#pullrequestreview-1498057091 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| https://github.com/emmatyping |
| emmatyping | https://github.com/emmatyping |
|
Jun 26, 2023
| https://github.com/python/mypy/pull/15490#pullrequestreview-1499224394 |
|
View reviewed changes
| https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3 |
| emmatyping | https://github.com/emmatyping |
| https://github.com/python/mypy/pull/15490#pullrequestreview-1499224394 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| 7ce3568 | https://github.com/python/mypy/commit/7ce3568d823c52e734983333271d315b637a61e6 |
| Jun 26, 2023 | https://github.com/python/mypy/pull/15490#event-9643522306 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Aug 12, 2023
| https://github.com/python/mypy/pull/15490#ref-issue-1845782978 |
|
regression with Generic/ParamSpec between 1.4.1 and 1.5.0
#15844
| https://github.com/python/mypy/issues/15844 |
| https://github.com/HexDecimal |
| HexDecimal | https://github.com/HexDecimal |
|
Feb 11, 2025
| https://github.com/python/mypy/pull/15490#ref-issue-2846003353 |
|
Adding __slots__ to a function-like Protocol breaks support for function assigment to the Protocol
microsoft/pyright#9878
| https://github.com/microsoft/pyright/issues/9878 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15490 |
|
| https://github.com/sobolevn |
|
sobolevn
| https://github.com/sobolevn |
|
| https://github.com/python/mypy/pull/15490/files/87ddf420d3812ebb3a479a5e9c8d2b66e405d20d |
|
| https://github.com/emmatyping |
|
emmatyping
| https://github.com/emmatyping |
|
| https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3 |
|
| https://github.com/AlexWaygood |
|
AlexWaygood
| https://github.com/AlexWaygood |
|
| https://github.com/python/mypy/pull/15490/files/f473ea0d6b088e83c6fa8fe716590bae42dae0d3 |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
|
upnext
| https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext |
|
Should __class_getitem__ be considered part of the interface of Protocol classes?
| https://github.com/python/mypy/issues/11886 |
|
__slots__ and protocols don't work right for issubclass and typevar bounds
| https://github.com/python/mypy/issues/11884 |
|
__slots__ requires explicit type definition and must be Any (and nothing else) when used with Protocols
| https://github.com/python/mypy/issues/11013 |
| Please reload this page | https://github.com/python/mypy/pull/15490 |
|
| https://github.com/HexDecimal |
|
| https://github.com/sobolevn |
|
| https://github.com/emmatyping |
|
| https://github.com/hauntsaninja |
|
| https://github.com/AlexWaygood |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |