| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:985de0ca-d57c-d824-8f5b-bd5d3a80467b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A408:1BAA33:223DCED:2D8490E:6B004D52 |
| html-safe-nonce | 010dbc6467bf5451b2dc1b4a7d3feadf29c506ccb731442175d7b686ea65b2de |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDA4OjFCQUEzMzoyMjNEQ0VEOjJEODQ5MEU6NkIwMDRENTIiLCJ2aXNpdG9yX2lkIjoiNjI5ODM5ODU2NzMyMTA2MjczOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 61d25ecc64caa764ad019f9b3a0526bc7f91fa7cf8b0f96935d2c365a7880f0c |
| hovercard-subject-tag | pull_request:1384608912 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15393/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/92373d43b7ba7d13f48148cfd52b81265fcf75bc4577ec2e46f8052be63a64c2/python/mypy/pull/15393 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/92373d43b7ba7d13f48148cfd52b81265fcf75bc4577ec2e46f8052be63a64c2/python/mypy/pull/15393 |
| og:image:alt | This reverts commit 391ed85.
The use of a Union item type for attr.Attribute would likely be more useful to callsites of attr.fields - otherwise this currently results in inferring builtins.object ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jhance |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/15393#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15393 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15393 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/15393 |
| Reload | https://github.com/python/mypy/pull/15393 |
| Reload | https://github.com/python/mypy/pull/15393 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| jhance | https://github.com/jhance |
| python:master | https://github.com/python/mypy/tree/master |
| jhance:revert-attrs | https://github.com/jhance/mypy/tree/revert-attrs |
| Conversation | https://github.com/python/mypy/pull/15393 |
| Commits1 (1) | https://github.com/python/mypy/pull/15393/commits |
| Checks | https://github.com/python/mypy/pull/15393/checks |
| Files changed | https://github.com/python/mypy/pull/15393/files |
| Revert "Add support for attrs.fields (#15021)" | https://github.com/python/mypy/pull/15393#top |
| jhance | https://github.com/jhance |
| python:master | https://github.com/python/mypy/tree/master |
| jhance:revert-attrs | https://github.com/jhance/mypy/tree/revert-attrs |
|
| https://github.com/jhance |
| jhance | https://github.com/jhance |
| Jun 8, 2023 | https://github.com/python/mypy/pull/15393#issue-1748062902 |
| 391ed85 | https://github.com/python/mypy/commit/391ed853f7857222d7eb209ecdc48f0a130f70d7 |
| @Tinche | https://github.com/Tinche |
| Please reload this page | https://github.com/python/mypy/pull/15393 |
|
| https://github.com/jhance |
| Revert "Add support for | https://github.com/python/mypy/pull/15393/commits/46c873a6ec66b88cb89db6007bd6dec1f6a40267 |
| attrs.fields | https://github.com/python/mypy/pull/15393/commits/46c873a6ec66b88cb89db6007bd6dec1f6a40267 |
| ( | https://github.com/python/mypy/pull/15393/commits/46c873a6ec66b88cb89db6007bd6dec1f6a40267 |
| python#15021 | https://github.com/python/mypy/pull/15021 |
| )" | https://github.com/python/mypy/pull/15393/commits/46c873a6ec66b88cb89db6007bd6dec1f6a40267 |
| 46c873a | https://github.com/python/mypy/pull/15393/commits/46c873a6ec66b88cb89db6007bd6dec1f6a40267 |
| 391ed85 | https://github.com/jhance/mypy/commit/391ed853f7857222d7eb209ecdc48f0a130f70d7 |
| @Tinche | https://github.com/Tinche |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Jun 8, 2023
| https://github.com/python/mypy/pull/15393#pullrequestreview-1470125623 |
|
View reviewed changes
| https://github.com/python/mypy/pull/15393/files/46c873a6ec66b88cb89db6007bd6dec1f6a40267 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/15393#pullrequestreview-1470125623 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15393 |
| https://github.com/Tinche |
| Tinche | https://github.com/Tinche |
| Jun 8, 2023 | https://github.com/python/mypy/pull/15393#issuecomment-1582738851 |
| @JukkaL | https://github.com/JukkaL |
| #15021 (comment) | https://github.com/python/mypy/pull/15021#issuecomment-1582716956 |
| Please reload this page | https://github.com/python/mypy/pull/15393 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jun 8, 2023 | https://github.com/python/mypy/pull/15393#issuecomment-1582792112 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/15393 |
| https://github.com/Tinche |
| Tinche | https://github.com/Tinche |
|
Jun 8, 2023
| https://github.com/python/mypy/pull/15393#ref-pullrequest-1748646263 |
|
Try tweaking attrs.fields()
#15396
| https://github.com/python/mypy/pull/15396 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jun 9, 2023 | https://github.com/python/mypy/pull/15393#issuecomment-1584250902 |
| Please reload this page | https://github.com/python/mypy/pull/15393 |
| #15396 (comment) | https://github.com/python/mypy/pull/15396#issuecomment-1583445693 |
| Please reload this page | https://github.com/python/mypy/pull/15393 |
| https://github.com/jhance |
| jhance | https://github.com/jhance |
| Jun 9, 2023 | https://github.com/python/mypy/pull/15393#issuecomment-1584601556 |
| Please reload this page | https://github.com/python/mypy/pull/15393 |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jul 16, 2023
| https://github.com/python/mypy/pull/15393#ref-commit-68904ff |
|
| https://github.com/hauntsaninja |
| Fix inference for attrs.fields | https://github.com/hauntsaninja/mypy/commit/68904ff2e601ac81affc130952257492574cb3db |
| 68904ff | https://github.com/hauntsaninja/mypy/commit/68904ff2e601ac81affc130952257492574cb3db |
| python#15393 | https://github.com/python/mypy/pull/15393 |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jul 16, 2023
| https://github.com/python/mypy/pull/15393#ref-commit-ecc00ef |
|
| https://github.com/hauntsaninja |
| Fix inference for attrs.fields | https://github.com/hauntsaninja/mypy/commit/ecc00efc9d08e71c080962ae1a4c5314f8c65f6e |
| ecc00ef | https://github.com/hauntsaninja/mypy/commit/ecc00efc9d08e71c080962ae1a4c5314f8c65f6e |
| python#15393 | https://github.com/python/mypy/pull/15393 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jul 16, 2023
| https://github.com/python/mypy/pull/15393#ref-pullrequest-1806407241 |
|
Fix inference for attrs.fields
#15688
| https://github.com/python/mypy/pull/15688 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| Jul 16, 2023 | https://github.com/python/mypy/pull/15393#issuecomment-1636965997 |
| #15688 | https://github.com/python/mypy/pull/15688 |
| Please reload this page | https://github.com/python/mypy/pull/15393 |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jul 16, 2023
| https://github.com/python/mypy/pull/15393#ref-commit-6d4bb06 |
|
| https://github.com/hauntsaninja |
| Fix inference for attrs.fields | https://github.com/hauntsaninja/mypy/commit/6d4bb06217dee863eca798ea292df49b0d579b95 |
| 6d4bb06 | https://github.com/hauntsaninja/mypy/commit/6d4bb06217dee863eca798ea292df49b0d579b95 |
| python#15393 | https://github.com/python/mypy/pull/15393 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
#15688
| https://github.com/python/mypy/pull/15688 |
| Jul 29, 2023 | https://github.com/python/mypy/pull/15393#event-9955576348 |
| https://github.com/Tinche |
| Tinche | https://github.com/Tinche |
| Jul 29, 2023 | https://github.com/python/mypy/pull/15393#issuecomment-1656961322 |
| @hauntsaninja | https://github.com/hauntsaninja |
| Please reload this page | https://github.com/python/mypy/pull/15393 |
| https://github.com/gertvdijk |
| gertvdijk | https://github.com/gertvdijk |
|
Sep 24, 2023
| https://github.com/python/mypy/pull/15393#ref-issue-1910404478 |
|
Type of default value for attrs.field() is revealed as Union[builtins.int, None]
#16174
| https://github.com/python/mypy/issues/16174 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15393 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/15393/files/46c873a6ec66b88cb89db6007bd6dec1f6a40267 |
| Please reload this page | https://github.com/python/mypy/pull/15393 |
| Please reload this page | https://github.com/python/mypy/pull/15393 |
|
| https://github.com/jhance |
|
| https://github.com/Tinche |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/hauntsaninja |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |