René's URL Explorer Experiment


Title: Revert "Add support for `attrs.fields` (#15021)" by jhance · Pull Request #15393 · python/mypy · GitHub

Open Graph Title: Revert "Add support for `attrs.fields` (#15021)" by jhance · Pull Request #15393 · python/mypy

X Title: Revert "Add support for `attrs.fields` (#15021)" by jhance · Pull Request #15393 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This reverts commit 391ed85. The use of a Union item type for attr.Attribute would likely be more useful to callsites of attr.fields - otherwise this currently results in inferring builtins.object ...

X Description: This reverts commit 391ed85. The use of a Union item type for attr.Attribute would likely be more useful to callsites of attr.fields - otherwise this currently results in inferring builtins.object ...

Opengraph URL: https://github.com/python/mypy/pull/15393

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:985de0ca-d57c-d824-8f5b-bd5d3a80467b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA408:1BAA33:223DCED:2D8490E:6B004D52
html-safe-nonce010dbc6467bf5451b2dc1b4a7d3feadf29c506ccb731442175d7b686ea65b2de
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDA4OjFCQUEzMzoyMjNEQ0VEOjJEODQ5MEU6NkIwMDRENTIiLCJ2aXNpdG9yX2lkIjoiNjI5ODM5ODU2NzMyMTA2MjczOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac61d25ecc64caa764ad019f9b3a0526bc7f91fa7cf8b0f96935d2c365a7880f0c
hovercard-subject-tagpull_request:1384608912
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15393/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/92373d43b7ba7d13f48148cfd52b81265fcf75bc4577ec2e46f8052be63a64c2/python/mypy/pull/15393
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/92373d43b7ba7d13f48148cfd52b81265fcf75bc4577ec2e46f8052be63a64c2/python/mypy/pull/15393
og:image:altThis reverts commit 391ed85. The use of a Union item type for attr.Attribute would likely be more useful to callsites of attr.fields - otherwise this currently results in inferring builtins.object ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejhance
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/15393#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15393
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15393
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/15393
Reloadhttps://github.com/python/mypy/pull/15393
Reloadhttps://github.com/python/mypy/pull/15393
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
jhancehttps://github.com/jhance
python:masterhttps://github.com/python/mypy/tree/master
jhance:revert-attrshttps://github.com/jhance/mypy/tree/revert-attrs
Conversationhttps://github.com/python/mypy/pull/15393
Commits1 (1)https://github.com/python/mypy/pull/15393/commits
Checkshttps://github.com/python/mypy/pull/15393/checks
Files changedhttps://github.com/python/mypy/pull/15393/files
Revert "Add support for attrs.fields (#15021)"https://github.com/python/mypy/pull/15393#top
jhancehttps://github.com/jhance
python:masterhttps://github.com/python/mypy/tree/master
jhance:revert-attrshttps://github.com/jhance/mypy/tree/revert-attrs
https://github.com/jhance
jhancehttps://github.com/jhance
Jun 8, 2023https://github.com/python/mypy/pull/15393#issue-1748062902
391ed85https://github.com/python/mypy/commit/391ed853f7857222d7eb209ecdc48f0a130f70d7
@Tinchehttps://github.com/Tinche
Please reload this pagehttps://github.com/python/mypy/pull/15393
https://github.com/jhance
Revert "Add support forhttps://github.com/python/mypy/pull/15393/commits/46c873a6ec66b88cb89db6007bd6dec1f6a40267
attrs.fieldshttps://github.com/python/mypy/pull/15393/commits/46c873a6ec66b88cb89db6007bd6dec1f6a40267
(https://github.com/python/mypy/pull/15393/commits/46c873a6ec66b88cb89db6007bd6dec1f6a40267
python#15021https://github.com/python/mypy/pull/15021
)"https://github.com/python/mypy/pull/15393/commits/46c873a6ec66b88cb89db6007bd6dec1f6a40267
46c873ahttps://github.com/python/mypy/pull/15393/commits/46c873a6ec66b88cb89db6007bd6dec1f6a40267
391ed85https://github.com/jhance/mypy/commit/391ed853f7857222d7eb209ecdc48f0a130f70d7
@Tinchehttps://github.com/Tinche
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Jun 8, 2023 https://github.com/python/mypy/pull/15393#pullrequestreview-1470125623
View reviewed changes https://github.com/python/mypy/pull/15393/files/46c873a6ec66b88cb89db6007bd6dec1f6a40267
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/15393#pullrequestreview-1470125623
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15393
https://github.com/Tinche
Tinchehttps://github.com/Tinche
Jun 8, 2023https://github.com/python/mypy/pull/15393#issuecomment-1582738851
@JukkaLhttps://github.com/JukkaL
#15021 (comment)https://github.com/python/mypy/pull/15021#issuecomment-1582716956
Please reload this pagehttps://github.com/python/mypy/pull/15393
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 8, 2023https://github.com/python/mypy/pull/15393#issuecomment-1582792112
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/15393
https://github.com/Tinche
Tinchehttps://github.com/Tinche
Jun 8, 2023 https://github.com/python/mypy/pull/15393#ref-pullrequest-1748646263
Try tweaking attrs.fields() #15396 https://github.com/python/mypy/pull/15396
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jun 9, 2023https://github.com/python/mypy/pull/15393#issuecomment-1584250902
Please reload this pagehttps://github.com/python/mypy/pull/15393
#15396 (comment)https://github.com/python/mypy/pull/15396#issuecomment-1583445693
Please reload this pagehttps://github.com/python/mypy/pull/15393
https://github.com/jhance
jhancehttps://github.com/jhance
Jun 9, 2023https://github.com/python/mypy/pull/15393#issuecomment-1584601556
Please reload this pagehttps://github.com/python/mypy/pull/15393
hauntsaninjahttps://github.com/hauntsaninja
Jul 16, 2023 https://github.com/python/mypy/pull/15393#ref-commit-68904ff
https://github.com/hauntsaninja
Fix inference for attrs.fieldshttps://github.com/hauntsaninja/mypy/commit/68904ff2e601ac81affc130952257492574cb3db
68904ffhttps://github.com/hauntsaninja/mypy/commit/68904ff2e601ac81affc130952257492574cb3db
python#15393https://github.com/python/mypy/pull/15393
hauntsaninjahttps://github.com/hauntsaninja
Jul 16, 2023 https://github.com/python/mypy/pull/15393#ref-commit-ecc00ef
https://github.com/hauntsaninja
Fix inference for attrs.fieldshttps://github.com/hauntsaninja/mypy/commit/ecc00efc9d08e71c080962ae1a4c5314f8c65f6e
ecc00efhttps://github.com/hauntsaninja/mypy/commit/ecc00efc9d08e71c080962ae1a4c5314f8c65f6e
python#15393https://github.com/python/mypy/pull/15393
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jul 16, 2023 https://github.com/python/mypy/pull/15393#ref-pullrequest-1806407241
Fix inference for attrs.fields #15688 https://github.com/python/mypy/pull/15688
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jul 16, 2023https://github.com/python/mypy/pull/15393#issuecomment-1636965997
#15688https://github.com/python/mypy/pull/15688
Please reload this pagehttps://github.com/python/mypy/pull/15393
hauntsaninjahttps://github.com/hauntsaninja
Jul 16, 2023 https://github.com/python/mypy/pull/15393#ref-commit-6d4bb06
https://github.com/hauntsaninja
Fix inference for attrs.fieldshttps://github.com/hauntsaninja/mypy/commit/6d4bb06217dee863eca798ea292df49b0d579b95
6d4bb06https://github.com/hauntsaninja/mypy/commit/6d4bb06217dee863eca798ea292df49b0d579b95
python#15393https://github.com/python/mypy/pull/15393
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
#15688 https://github.com/python/mypy/pull/15688
Jul 29, 2023https://github.com/python/mypy/pull/15393#event-9955576348
https://github.com/Tinche
Tinchehttps://github.com/Tinche
Jul 29, 2023https://github.com/python/mypy/pull/15393#issuecomment-1656961322
@hauntsaninjahttps://github.com/hauntsaninja
Please reload this pagehttps://github.com/python/mypy/pull/15393
https://github.com/gertvdijk
gertvdijkhttps://github.com/gertvdijk
Sep 24, 2023 https://github.com/python/mypy/pull/15393#ref-issue-1910404478
Type of default value for attrs.field() is revealed as Union[builtins.int, None] #16174 https://github.com/python/mypy/issues/16174
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15393
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/15393/files/46c873a6ec66b88cb89db6007bd6dec1f6a40267
Please reload this pagehttps://github.com/python/mypy/pull/15393
Please reload this pagehttps://github.com/python/mypy/pull/15393
https://github.com/jhance
https://github.com/Tinche
https://github.com/ilevkivskyi
https://github.com/hauntsaninja
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.