René's URL Explorer Experiment


Title: Speed up make_simplified_union, fix recursive tuple crash by hauntsaninja · Pull Request #15128 · python/mypy · GitHub

Open Graph Title: Speed up make_simplified_union, fix recursive tuple crash by hauntsaninja · Pull Request #15128 · python/mypy

X Title: Speed up make_simplified_union, fix recursive tuple crash by hauntsaninja · Pull Request #15128 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #15192 The following code optimises make_simplified_union in the common case that there are exact duplicates in the union. In this regard, this is similar to #15104 There's a behaviour ch...

X Description: Fixes #15192 The following code optimises make_simplified_union in the common case that there are exact duplicates in the union. In this regard, this is similar to #15104 There's a behaviou...

Opengraph URL: https://github.com/python/mypy/pull/15128

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:55036f11-268f-e202-c8e9-b6a1a9bb5ff6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB748:182C25:B753C0:F5A296:6B004D03
html-safe-noncebde936d34b8dcb60e7e877f2d4bd065a1f30e542883397762aab6d3670521b35
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzQ4OjE4MkMyNTpCNzUzQzA6RjVBMjk2OjZCMDA0RDAzIiwidmlzaXRvcl9pZCI6Ijc2NTMwOTgwMjIwNDEwNDYyNzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf64bb4059482e8d23674e814716200742c6af31d6e5abaa276d59bf066f3de6e
hovercard-subject-tagpull_request:1327415490
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15128/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/54c31d4fc5202e589cdaf4a2058a05aa206d0edf92de4eddbfc64f5a0eb3bd22/python/mypy/pull/15128
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/54c31d4fc5202e589cdaf4a2058a05aa206d0edf92de4eddbfc64f5a0eb3bd22/python/mypy/pull/15128
og:image:altFixes #15192 The following code optimises make_simplified_union in the common case that there are exact duplicates in the union. In this regard, this is similar to #15104 There's a behaviour ch...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/15128#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15128
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15128
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/15128
Reloadhttps://github.com/python/mypy/pull/15128
Reloadhttps://github.com/python/mypy/pull/15128
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:msuhttps://github.com/hauntsaninja/mypy/tree/msu
Conversationhttps://github.com/python/mypy/pull/15128
Commits8 (8)https://github.com/python/mypy/pull/15128/commits
Checkshttps://github.com/python/mypy/pull/15128/checks
Files changedhttps://github.com/python/mypy/pull/15128/files
Speed up make_simplified_union, fix recursive tuple crashhttps://github.com/python/mypy/pull/15128#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:msuhttps://github.com/hauntsaninja/mypy/tree/msu
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 25, 2023https://github.com/python/mypy/pull/15128#issue-1683484820
Please reload this pagehttps://github.com/python/mypy/pull/15128
#15192https://github.com/python/mypy/issues/15192
#15104https://github.com/python/mypy/pull/15104
Please reload this pagehttps://github.com/python/mypy/pull/15128
hauntsaninjahttps://github.com/hauntsaninja
April 25, 2023 10:18https://github.com/python/mypy/pull/15128#commits-pushed-184e415
https://github.com/hauntsaninja
Speed up make_simplified_union, remove a potential crashhttps://github.com/python/mypy/pull/15128/commits/184e415502add001425ef93fb74464618973879f
184e415https://github.com/python/mypy/pull/15128/commits/184e415502add001425ef93fb74464618973879f
python#15104https://github.com/python/mypy/pull/15104
https://github.com/marketplace/pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hookshttps://github.com/python/mypy/pull/15128/commits/cd5f40bca7f450db88a70188db5f61ea72c6e8d5
cd5f40bhttps://github.com/python/mypy/pull/15128/commits/cd5f40bca7f450db88a70188db5f61ea72c6e8d5
https://pre-commit.cihttps://pre-commit.ci
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15128
https://github.com/hauntsaninja
Merge branch 'master' into msuhttps://github.com/python/mypy/pull/15128/commits/13c4007133684146d0f0a71d68d2f60913490723
13c4007https://github.com/python/mypy/pull/15128/commits/13c4007133684146d0f0a71d68d2f60913490723
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 25, 2023https://github.com/python/mypy/pull/15128#issuecomment-1522165211
Please reload this pagehttps://github.com/python/mypy/pull/15128
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15128
hauntsaninjahttps://github.com/hauntsaninja
April 25, 2023 15:38https://github.com/python/mypy/pull/15128#commits-pushed-b009483
https://github.com/hauntsaninja
fix performance on materializehttps://github.com/python/mypy/pull/15128/commits/b0094833435f29a933d33319b8182e6c06947236
b009483https://github.com/python/mypy/pull/15128/commits/b0094833435f29a933d33319b8182e6c06947236
https://github.com/marketplace/pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hookshttps://github.com/python/mypy/pull/15128/commits/bea67d29c7b7e002658d3e44441147e75c178aab
bea67d2https://github.com/python/mypy/pull/15128/commits/bea67d29c7b7e002658d3e44441147e75c178aab
https://pre-commit.cihttps://pre-commit.ci
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15128
https://github.com/hauntsaninja
more perfhttps://github.com/python/mypy/pull/15128/commits/fd8463b7a98ae74378b742066ed8fa50848d8903
fd8463bhttps://github.com/python/mypy/pull/15128/commits/fd8463b7a98ae74378b742066ed8fa50848d8903
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 25, 2023https://github.com/python/mypy/pull/15128#issuecomment-1522559266
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
April 26, 2023 00:11https://github.com/python/mypy/pull/15128#event-9097652509
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 26, 2023 https://github.com/python/mypy/pull/15128#ref-issue-1440002516
mypy 0.990 is 1000x slow on pydantic codebase vs 0.982 #14034 https://github.com/python/mypy/issues/14034
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 26, 2023https://github.com/python/mypy/pull/15128#issuecomment-1522802688
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
May 3, 2023https://github.com/python/mypy/pull/15128#issuecomment-1533048935
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
May 3, 2023 https://github.com/python/mypy/pull/15128#pullrequestreview-1410924635
View reviewed changes https://github.com/python/mypy/pull/15128/files/fd8463b7a98ae74378b742066ed8fa50848d8903
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/15128#pullrequestreview-1410924635
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15128
mypy/typeops.pyhttps://github.com/python/mypy/pull/15128/files/fd8463b7a98ae74378b742066ed8fa50848d8903#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
Please reload this pagehttps://github.com/python/mypy/pull/15128
mypy/typeops.pyhttps://github.com/python/mypy/pull/15128/files/fd8463b7a98ae74378b742066ed8fa50848d8903#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
Please reload this pagehttps://github.com/python/mypy/pull/15128
mypy/typeops.pyhttps://github.com/python/mypy/pull/15128/files/fd8463b7a98ae74378b742066ed8fa50848d8903#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
Please reload this pagehttps://github.com/python/mypy/pull/15128
mypy/typeops.pyhttps://github.com/python/mypy/pull/15128/files/fd8463b7a98ae74378b742066ed8fa50848d8903#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
JukkaLhttps://github.com/JukkaL
May 3, 2023https://github.com/python/mypy/pull/15128#discussion_r1183709470
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15128
hauntsaninjahttps://github.com/hauntsaninja
May 5, 2023https://github.com/python/mypy/pull/15128#discussion_r1186481963
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#15094https://github.com/python/mypy/pull/15094
#15098https://github.com/python/mypy/pull/15098
Please reload this pagehttps://github.com/python/mypy/pull/15128
mypy/typeops.pyhttps://github.com/python/mypy/pull/15128/files/fd8463b7a98ae74378b742066ed8fa50848d8903#diff-1dce7e2a19559e2ff4e08fd46877b87c9cfec3cb5e6d465157788542948e11e4
JukkaLhttps://github.com/JukkaL
May 3, 2023https://github.com/python/mypy/pull/15128#discussion_r1183709650
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 5, 2023 https://github.com/python/mypy/pull/15128#ref-issue-1697552693
Segfault when manipulating a recursive union #15192 https://github.com/python/mypy/issues/15192
hauntsaninjahttps://github.com/hauntsaninja
May 5, 2023 13:30https://github.com/python/mypy/pull/15128#commits-pushed-b132663
https://github.com/hauntsaninja
add regression test for crashhttps://github.com/python/mypy/pull/15128/commits/b13266362ebccea7f78c12453bf98cbac30373a2
b132663https://github.com/python/mypy/pull/15128/commits/b13266362ebccea7f78c12453bf98cbac30373a2
https://github.com/hauntsaninja
micro optimisationshttps://github.com/python/mypy/pull/15128/commits/bc79133751238230eb77fe54fff157026134a973
bc79133https://github.com/python/mypy/pull/15128/commits/bc79133751238230eb77fe54fff157026134a973
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 5, 2023https://github.com/python/mypy/pull/15128#event-9180298451
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 5, 2023https://github.com/python/mypy/pull/15128#issuecomment-1536755736
Please reload this pagehttps://github.com/python/mypy/pull/15128
#15192https://github.com/python/mypy/issues/15192
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 5, 2023https://github.com/python/mypy/pull/15128#issuecomment-1536769380
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 6, 2023https://github.com/python/mypy/pull/15128#event-9181751520
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
7832e1fhttps://github.com/python/mypy/commit/7832e1f4ec5edf5f814c91f323c2d4ccc3022603
May 6, 2023https://github.com/python/mypy/pull/15128#event-9183159318
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 6, 2023 20:22https://github.com/python/mypy/pull/15128#event-9183159394
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 6, 2023https://github.com/python/mypy/pull/15128#issuecomment-1537217004
Please reload this pagehttps://github.com/python/mypy/pull/15128
#15128 (comment)https://github.com/python/mypy/pull/15128#issuecomment-1536769380
#15128 (comment)https://github.com/python/mypy/pull/15128#issuecomment-1522559266
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 10, 2023https://github.com/python/mypy/pull/15128#issuecomment-1542356669
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 10, 2023https://github.com/python/mypy/pull/15128#issuecomment-1542383085
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 10, 2023https://github.com/python/mypy/pull/15128#issuecomment-1542430605
#15216https://github.com/python/mypy/pull/15216
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jun 14, 2023 https://github.com/python/mypy/pull/15128#ref-pullrequest-1692592947
Improve performance reports hauntsaninja/mypy_primer#81 https://github.com/hauntsaninja/mypy_primer/pull/81
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15128
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/15128/files/fd8463b7a98ae74378b742066ed8fa50848d8903
Please reload this pagehttps://github.com/python/mypy/pull/15128
Segfault when manipulating a recursive union https://github.com/python/mypy/issues/15192
Please reload this pagehttps://github.com/python/mypy/pull/15128
https://github.com/hauntsaninja
https://github.com/JukkaL
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.