| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4b912521-155e-aaad-0174-7e44df114bee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8C14:308D9D:27942EB:360DF69:6B004617 |
| html-safe-nonce | 1216fbf1fd744235421f1f225145c39fb2af2b1d6054751c0797bb298ee7d160 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzE0OjMwOEQ5RDoyNzk0MkVCOjM2MERGNjk6NkIwMDQ2MTciLCJ2aXNpdG9yX2lkIjoiMzE5OTQ1NzkzMDk5ODk5MDM1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d09e7d7aadd06bc2622199ec4e1a063d9ff6e2c62a2a5fb3d28029c927e87567 |
| hovercard-subject-tag | pull_request:1324264736 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15105/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a78437a6a6528c7d82d9ca6bc94f7d11fc9db938312ae99b91174929223f8c2c/python/mypy/pull/15105 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a78437a6a6528c7d82d9ca6bc94f7d11fc9db938312ae99b91174929223f8c2c/python/mypy/pull/15105 |
| og:image:alt | I figured this might be faster and less code. Also just curious what the process is like to contribute to mypy. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | adriangb |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/15105#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15105 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15105 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/15105 |
| Reload | https://github.com/python/mypy/pull/15105 |
| Reload | https://github.com/python/mypy/pull/15105 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests545 (545) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| adriangb:use-dict-for-duplicates | https://github.com/adriangb/mypy/tree/use-dict-for-duplicates |
| Conversation | https://github.com/python/mypy/pull/15105 |
| Commits8 (8) | https://github.com/python/mypy/pull/15105/commits |
| Checks | https://github.com/python/mypy/pull/15105/checks |
| Files changed | https://github.com/python/mypy/pull/15105/files |
| Use dict keys for order-preserving dedupes instead of set + list | https://github.com/python/mypy/pull/15105#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| adriangb:use-dict-for-duplicates | https://github.com/adriangb/mypy/tree/use-dict-for-duplicates |
|
| https://github.com/adriangb |
| adriangb | https://github.com/adriangb |
| Apr 23, 2023 | https://github.com/python/mypy/pull/15105#issue-1679883280 |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| adriangb | https://github.com/adriangb |
| April 23, 2023 00:31 | https://github.com/python/mypy/pull/15105#commits-pushed-caccc1e |
|
| https://github.com/adriangb |
| Use dict keys for order-preserving dedupes instead of set + list | https://github.com/python/mypy/pull/15105/commits/caccc1e72d5e43ef83955de6d2a2b8f3fed92682 |
| caccc1e | https://github.com/python/mypy/pull/15105/commits/caccc1e72d5e43ef83955de6d2a2b8f3fed92682 |
|
| https://github.com/adriangb |
| use fromkeys | https://github.com/python/mypy/pull/15105/commits/eaf250fbf993a26e8d814cee1463f2d4b6956a0c |
| eaf250f | https://github.com/python/mypy/pull/15105/commits/eaf250fbf993a26e8d814cee1463f2d4b6956a0c |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Apr 23, 2023
| https://github.com/python/mypy/pull/15105#pullrequestreview-1396846865 |
|
View reviewed changes
| https://github.com/python/mypy/pull/15105/files/caccc1e72d5e43ef83955de6d2a2b8f3fed92682 |
| mypyc/ir/rtypes.py | https://github.com/python/mypy/pull/15105/files/caccc1e72d5e43ef83955de6d2a2b8f3fed92682#diff-abb1d7da16bab6a47fbe6151aae972c14893c859523903adc3fc8ce78a01e826 |
| AlexWaygood | https://github.com/AlexWaygood |
| Apr 23, 2023 | https://github.com/python/mypy/pull/15105#discussion_r1174518284 |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| adriangb | https://github.com/adriangb |
| Apr 23, 2023 | https://github.com/python/mypy/pull/15105#discussion_r1174518760 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| mypyc/ir/rtypes.py | https://github.com/python/mypy/pull/15105/files/caccc1e72d5e43ef83955de6d2a2b8f3fed92682#diff-abb1d7da16bab6a47fbe6151aae972c14893c859523903adc3fc8ce78a01e826 |
| AlexWaygood | https://github.com/AlexWaygood |
| Apr 23, 2023 | https://github.com/python/mypy/pull/15105#discussion_r1174518333 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| adriangb | https://github.com/adriangb |
| Apr 23, 2023 | https://github.com/python/mypy/pull/15105#discussion_r1174519029 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| mypyc/ir/rtypes.py | https://github.com/python/mypy/pull/15105/files/caccc1e72d5e43ef83955de6d2a2b8f3fed92682#diff-abb1d7da16bab6a47fbe6151aae972c14893c859523903adc3fc8ce78a01e826 |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| adriangb | https://github.com/adriangb |
| April 23, 2023 00:36 | https://github.com/python/mypy/pull/15105#commits-pushed-8bfb994 |
|
| https://github.com/adriangb |
| use fromkeys | https://github.com/python/mypy/pull/15105/commits/8bfb99490cf674d27bc0a0443a6da01e74c4dfd6 |
| 8bfb994 | https://github.com/python/mypy/pull/15105/commits/8bfb99490cf674d27bc0a0443a6da01e74c4dfd6 |
|
| https://github.com/adriangb |
| don't call keys | https://github.com/python/mypy/pull/15105/commits/6d0dbd5598ada7089c45c1f62db07eb04b21fe6b |
| 6d0dbd5 | https://github.com/python/mypy/pull/15105/commits/6d0dbd5598ada7089c45c1f62db07eb04b21fe6b |
|
| https://github.com/adriangb |
| code golf | https://github.com/python/mypy/pull/15105/commits/282dc44ce061d73bdb32cbdfaf106636c983732d |
| 282dc44 | https://github.com/python/mypy/pull/15105/commits/282dc44ce061d73bdb32cbdfaf106636c983732d |
|
| https://github.com/adriangb |
| remove test | https://github.com/python/mypy/pull/15105/commits/4a498d208881c4e7fd6f001de5b4bc71ac32097e |
| 4a498d2 | https://github.com/python/mypy/pull/15105/commits/4a498d208881c4e7fd6f001de5b4bc71ac32097e |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Apr 23, 2023
| https://github.com/python/mypy/pull/15105#pullrequestreview-1396847890 |
|
View reviewed changes
| https://github.com/python/mypy/pull/15105/files/4a498d208881c4e7fd6f001de5b4bc71ac32097e |
| mypyc/ir/rtypes.py | https://github.com/python/mypy/pull/15105/files/4a498d208881c4e7fd6f001de5b4bc71ac32097e#diff-abb1d7da16bab6a47fbe6151aae972c14893c859523903adc3fc8ce78a01e826 |
| AlexWaygood | https://github.com/AlexWaygood |
| Apr 23, 2023 | https://github.com/python/mypy/pull/15105#discussion_r1174519376 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| adriangb | https://github.com/adriangb |
| Apr 23, 2023 | https://github.com/python/mypy/pull/15105#discussion_r1174610457 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/1755071/233852642-3045ccc9-e4e1-4bff-81c5-3bf973309528.png |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| adriangb | https://github.com/adriangb |
| Apr 23, 2023 | https://github.com/python/mypy/pull/15105#discussion_r1174610516 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Apr 23, 2023
| https://github.com/python/mypy/pull/15105#pullrequestreview-1396847918 |
|
View reviewed changes
| https://github.com/python/mypy/pull/15105/files/4a498d208881c4e7fd6f001de5b4bc71ac32097e |
| hauntsaninja | https://github.com/hauntsaninja |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| https://github.com/python/mypy/pull/15105#pullrequestreview-1396847918 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #15104 | https://github.com/python/mypy/pull/15104 |
| #15104 | https://github.com/python/mypy/pull/15104 |
| #15098 | https://github.com/python/mypy/pull/15098 |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
|
| https://github.com/adriangb |
| remove import | https://github.com/python/mypy/pull/15105/commits/3bf13640f6b64c96292d41d91109944f8eb66464 |
| 3bf1364 | https://github.com/python/mypy/pull/15105/commits/3bf13640f6b64c96292d41d91109944f8eb66464 |
| https://github.com/adriangb |
| adriangb | https://github.com/adriangb |
| Apr 23, 2023 | https://github.com/python/mypy/pull/15105#issuecomment-1518966655 |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
|
| https://github.com/adriangb |
| Only create a list if necessary | https://github.com/python/mypy/pull/15105/commits/5ecc7eedcd3aa54e8d1bbd6d6df53e46564e1bd2 |
| 5ecc7ee | https://github.com/python/mypy/pull/15105/commits/5ecc7eedcd3aa54e8d1bbd6d6df53e46564e1bd2 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Apr 23, 2023
| https://github.com/python/mypy/pull/15105#pullrequestreview-1396936313 |
|
View reviewed changes
| https://github.com/python/mypy/pull/15105/files/5ecc7eedcd3aa54e8d1bbd6d6df53e46564e1bd2 |
| AlexWaygood | https://github.com/AlexWaygood |
| https://github.com/python/mypy/pull/15105#pullrequestreview-1396936313 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| 315b466 | https://github.com/python/mypy/commit/315b4663068cd570b4979e55538e90e349ed4e5a |
| Apr 23, 2023 | https://github.com/python/mypy/pull/15105#event-9075606912 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15105 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/15105/files/4a498d208881c4e7fd6f001de5b4bc71ac32097e |
|
| https://github.com/AlexWaygood |
|
AlexWaygood
| https://github.com/AlexWaygood |
|
| https://github.com/python/mypy/pull/15105/files/5ecc7eedcd3aa54e8d1bbd6d6df53e46564e1bd2 |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
| Please reload this page | https://github.com/python/mypy/pull/15105 |
|
| https://github.com/adriangb |
|
| https://github.com/hauntsaninja |
|
| https://github.com/AlexWaygood |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |