René's URL Explorer Experiment


Title: Use dict keys for order-preserving dedupes instead of set + list by adriangb · Pull Request #15105 · python/mypy · GitHub

Open Graph Title: Use dict keys for order-preserving dedupes instead of set + list by adriangb · Pull Request #15105 · python/mypy

X Title: Use dict keys for order-preserving dedupes instead of set + list by adriangb · Pull Request #15105 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: I figured this might be faster and less code. Also just curious what the process is like to contribute to mypy.

X Description: I figured this might be faster and less code. Also just curious what the process is like to contribute to mypy.

Opengraph URL: https://github.com/python/mypy/pull/15105

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4b912521-155e-aaad-0174-7e44df114bee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C14:308D9D:27942EB:360DF69:6B004617
html-safe-nonce1216fbf1fd744235421f1f225145c39fb2af2b1d6054751c0797bb298ee7d160
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzE0OjMwOEQ5RDoyNzk0MkVCOjM2MERGNjk6NkIwMDQ2MTciLCJ2aXNpdG9yX2lkIjoiMzE5OTQ1NzkzMDk5ODk5MDM1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd09e7d7aadd06bc2622199ec4e1a063d9ff6e2c62a2a5fb3d28029c927e87567
hovercard-subject-tagpull_request:1324264736
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15105/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a78437a6a6528c7d82d9ca6bc94f7d11fc9db938312ae99b91174929223f8c2c/python/mypy/pull/15105
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a78437a6a6528c7d82d9ca6bc94f7d11fc9db938312ae99b91174929223f8c2c/python/mypy/pull/15105
og:image:altI figured this might be faster and less code. Also just curious what the process is like to contribute to mypy.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameadriangb
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/15105#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15105
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15105
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/15105
Reloadhttps://github.com/python/mypy/pull/15105
Reloadhttps://github.com/python/mypy/pull/15105
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
adriangb:use-dict-for-duplicateshttps://github.com/adriangb/mypy/tree/use-dict-for-duplicates
Conversationhttps://github.com/python/mypy/pull/15105
Commits8 (8)https://github.com/python/mypy/pull/15105/commits
Checkshttps://github.com/python/mypy/pull/15105/checks
Files changedhttps://github.com/python/mypy/pull/15105/files
Use dict keys for order-preserving dedupes instead of set + listhttps://github.com/python/mypy/pull/15105#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
adriangb:use-dict-for-duplicateshttps://github.com/adriangb/mypy/tree/use-dict-for-duplicates
https://github.com/adriangb
adriangbhttps://github.com/adriangb
Apr 23, 2023https://github.com/python/mypy/pull/15105#issue-1679883280
Please reload this pagehttps://github.com/python/mypy/pull/15105
Please reload this pagehttps://github.com/python/mypy/pull/15105
adriangbhttps://github.com/adriangb
April 23, 2023 00:31https://github.com/python/mypy/pull/15105#commits-pushed-caccc1e
https://github.com/adriangb
Use dict keys for order-preserving dedupes instead of set + listhttps://github.com/python/mypy/pull/15105/commits/caccc1e72d5e43ef83955de6d2a2b8f3fed92682
caccc1ehttps://github.com/python/mypy/pull/15105/commits/caccc1e72d5e43ef83955de6d2a2b8f3fed92682
https://github.com/adriangb
use fromkeyshttps://github.com/python/mypy/pull/15105/commits/eaf250fbf993a26e8d814cee1463f2d4b6956a0c
eaf250fhttps://github.com/python/mypy/pull/15105/commits/eaf250fbf993a26e8d814cee1463f2d4b6956a0c
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 23, 2023 https://github.com/python/mypy/pull/15105#pullrequestreview-1396846865
View reviewed changes https://github.com/python/mypy/pull/15105/files/caccc1e72d5e43ef83955de6d2a2b8f3fed92682
mypyc/ir/rtypes.pyhttps://github.com/python/mypy/pull/15105/files/caccc1e72d5e43ef83955de6d2a2b8f3fed92682#diff-abb1d7da16bab6a47fbe6151aae972c14893c859523903adc3fc8ce78a01e826
AlexWaygoodhttps://github.com/AlexWaygood
Apr 23, 2023https://github.com/python/mypy/pull/15105#discussion_r1174518284
Please reload this pagehttps://github.com/python/mypy/pull/15105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15105
adriangbhttps://github.com/adriangb
Apr 23, 2023https://github.com/python/mypy/pull/15105#discussion_r1174518760
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15105
mypyc/ir/rtypes.pyhttps://github.com/python/mypy/pull/15105/files/caccc1e72d5e43ef83955de6d2a2b8f3fed92682#diff-abb1d7da16bab6a47fbe6151aae972c14893c859523903adc3fc8ce78a01e826
AlexWaygoodhttps://github.com/AlexWaygood
Apr 23, 2023https://github.com/python/mypy/pull/15105#discussion_r1174518333
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15105
adriangbhttps://github.com/adriangb
Apr 23, 2023https://github.com/python/mypy/pull/15105#discussion_r1174519029
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15105
mypyc/ir/rtypes.pyhttps://github.com/python/mypy/pull/15105/files/caccc1e72d5e43ef83955de6d2a2b8f3fed92682#diff-abb1d7da16bab6a47fbe6151aae972c14893c859523903adc3fc8ce78a01e826
Please reload this pagehttps://github.com/python/mypy/pull/15105
adriangbhttps://github.com/adriangb
April 23, 2023 00:36https://github.com/python/mypy/pull/15105#commits-pushed-8bfb994
https://github.com/adriangb
use fromkeyshttps://github.com/python/mypy/pull/15105/commits/8bfb99490cf674d27bc0a0443a6da01e74c4dfd6
8bfb994https://github.com/python/mypy/pull/15105/commits/8bfb99490cf674d27bc0a0443a6da01e74c4dfd6
https://github.com/adriangb
don't call keyshttps://github.com/python/mypy/pull/15105/commits/6d0dbd5598ada7089c45c1f62db07eb04b21fe6b
6d0dbd5https://github.com/python/mypy/pull/15105/commits/6d0dbd5598ada7089c45c1f62db07eb04b21fe6b
https://github.com/adriangb
code golfhttps://github.com/python/mypy/pull/15105/commits/282dc44ce061d73bdb32cbdfaf106636c983732d
282dc44https://github.com/python/mypy/pull/15105/commits/282dc44ce061d73bdb32cbdfaf106636c983732d
https://github.com/adriangb
remove testhttps://github.com/python/mypy/pull/15105/commits/4a498d208881c4e7fd6f001de5b4bc71ac32097e
4a498d2https://github.com/python/mypy/pull/15105/commits/4a498d208881c4e7fd6f001de5b4bc71ac32097e
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 23, 2023 https://github.com/python/mypy/pull/15105#pullrequestreview-1396847890
View reviewed changes https://github.com/python/mypy/pull/15105/files/4a498d208881c4e7fd6f001de5b4bc71ac32097e
mypyc/ir/rtypes.pyhttps://github.com/python/mypy/pull/15105/files/4a498d208881c4e7fd6f001de5b4bc71ac32097e#diff-abb1d7da16bab6a47fbe6151aae972c14893c859523903adc3fc8ce78a01e826
AlexWaygoodhttps://github.com/AlexWaygood
Apr 23, 2023https://github.com/python/mypy/pull/15105#discussion_r1174519376
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15105
adriangbhttps://github.com/adriangb
Apr 23, 2023https://github.com/python/mypy/pull/15105#discussion_r1174610457
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/1755071/233852642-3045ccc9-e4e1-4bff-81c5-3bf973309528.png
Please reload this pagehttps://github.com/python/mypy/pull/15105
adriangbhttps://github.com/adriangb
Apr 23, 2023https://github.com/python/mypy/pull/15105#discussion_r1174610516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15105
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 23, 2023 https://github.com/python/mypy/pull/15105#pullrequestreview-1396847918
View reviewed changes https://github.com/python/mypy/pull/15105/files/4a498d208881c4e7fd6f001de5b4bc71ac32097e
hauntsaninjahttps://github.com/hauntsaninja
Please reload this pagehttps://github.com/python/mypy/pull/15105
https://github.com/python/mypy/pull/15105#pullrequestreview-1396847918
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#15104https://github.com/python/mypy/pull/15104
#15104https://github.com/python/mypy/pull/15104
#15098https://github.com/python/mypy/pull/15098
Please reload this pagehttps://github.com/python/mypy/pull/15105
https://github.com/adriangb
remove importhttps://github.com/python/mypy/pull/15105/commits/3bf13640f6b64c96292d41d91109944f8eb66464
3bf1364https://github.com/python/mypy/pull/15105/commits/3bf13640f6b64c96292d41d91109944f8eb66464
https://github.com/adriangb
adriangbhttps://github.com/adriangb
Apr 23, 2023https://github.com/python/mypy/pull/15105#issuecomment-1518966655
Please reload this pagehttps://github.com/python/mypy/pull/15105
https://github.com/adriangb
Only create a list if necessaryhttps://github.com/python/mypy/pull/15105/commits/5ecc7eedcd3aa54e8d1bbd6d6df53e46564e1bd2
5ecc7eehttps://github.com/python/mypy/pull/15105/commits/5ecc7eedcd3aa54e8d1bbd6d6df53e46564e1bd2
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 23, 2023 https://github.com/python/mypy/pull/15105#pullrequestreview-1396936313
View reviewed changes https://github.com/python/mypy/pull/15105/files/5ecc7eedcd3aa54e8d1bbd6d6df53e46564e1bd2
AlexWaygoodhttps://github.com/AlexWaygood
https://github.com/python/mypy/pull/15105#pullrequestreview-1396936313
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15105
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
315b466https://github.com/python/mypy/commit/315b4663068cd570b4979e55538e90e349ed4e5a
Apr 23, 2023https://github.com/python/mypy/pull/15105#event-9075606912
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15105
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/15105/files/4a498d208881c4e7fd6f001de5b4bc71ac32097e
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/mypy/pull/15105/files/5ecc7eedcd3aa54e8d1bbd6d6df53e46564e1bd2
Please reload this pagehttps://github.com/python/mypy/pull/15105
Please reload this pagehttps://github.com/python/mypy/pull/15105
https://github.com/adriangb
https://github.com/hauntsaninja
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.