René's URL Explorer Experiment


Title: Fix performance in union subtyping by hauntsaninja · Pull Request #15104 · python/mypy · GitHub

Open Graph Title: Fix performance in union subtyping by hauntsaninja · Pull Request #15104 · python/mypy

X Title: Fix performance in union subtyping by hauntsaninja · Pull Request #15104 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This is a performance optimisation for subtyping between two unions that are largely the same. Fixes #14034 This makes @adriangb's example in #14034 (comment) finish basically instantly. I coul...

X Description: This is a performance optimisation for subtyping between two unions that are largely the same. Fixes #14034 This makes @adriangb's example in #14034 (comment) finish basically instantly. I ...

Opengraph URL: https://github.com/python/mypy/pull/15104

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7a9b2a2f-be38-2ec8-2272-2af8345976b4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9A0:3E987B:78E053:A1A70E:6B003CF1
html-safe-nonce36b21cfa52425764b583c5bb4e1fc66bcc926393c0a5d8747314145d94d42e11
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUEwOjNFOTg3Qjo3OEUwNTM6QTFBNzBFOjZCMDAzQ0YxIiwidmlzaXRvcl9pZCI6IjU2ODIyNzY1NjIyOTI5ODA5NzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6eefc9eee9006d2336291b775315647b776d173e6244f69fa7cce78a7b097633
hovercard-subject-tagpull_request:1324259182
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15104/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/81d3c5343f0dc632c0a3a636102442a5020072529bbd1b7294468b7fed46830b/python/mypy/pull/15104
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/81d3c5343f0dc632c0a3a636102442a5020072529bbd1b7294468b7fed46830b/python/mypy/pull/15104
og:image:altThis is a performance optimisation for subtyping between two unions that are largely the same. Fixes #14034 This makes @adriangb's example in #14034 (comment) finish basically instantly. I coul...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/15104#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15104
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15104
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/15104
Reloadhttps://github.com/python/mypy/pull/15104
Reloadhttps://github.com/python/mypy/pull/15104
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:union-perfhttps://github.com/hauntsaninja/mypy/tree/union-perf
Conversationhttps://github.com/python/mypy/pull/15104
Commits1 (1)https://github.com/python/mypy/pull/15104/commits
Checkshttps://github.com/python/mypy/pull/15104/checks
Files changedhttps://github.com/python/mypy/pull/15104/files
Fix performance in union subtypinghttps://github.com/python/mypy/pull/15104#top
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:union-perfhttps://github.com/hauntsaninja/mypy/tree/union-perf
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 23, 2023https://github.com/python/mypy/pull/15104#issue-1679876438
Please reload this pagehttps://github.com/python/mypy/pull/15104
#14034https://github.com/python/mypy/issues/14034
@adriangbhttps://github.com/adriangb
#14034 (comment)https://github.com/python/mypy/issues/14034#issuecomment-1470252641
Please reload this pagehttps://github.com/python/mypy/pull/15104
https://github.com/hauntsaninja
Fix performance in union subtypinghttps://github.com/python/mypy/pull/15104/commits/d89b31740e0d20a04ec9fff4d2b360d644cb2b42
d89b317https://github.com/python/mypy/pull/15104/commits/d89b31740e0d20a04ec9fff4d2b360d644cb2b42
python#14034https://github.com/python/mypy/issues/14034
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
JukkaLhttps://github.com/JukkaL
April 23, 2023 06:09https://github.com/python/mypy/pull/15104#event-9074278126
https://github.com/adriangb
adriangbhttps://github.com/adriangb
Apr 23, 2023https://github.com/python/mypy/pull/15104#issuecomment-1518959780
Please reload this pagehttps://github.com/python/mypy/pull/15104
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 23, 2023https://github.com/python/mypy/pull/15104#issuecomment-1518961176
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/15104
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 23, 2023 https://github.com/python/mypy/pull/15104#ref-pullrequest-1679883280
Use dict keys for order-preserving dedupes instead of set + list #15105 https://github.com/python/mypy/pull/15105
https://github.com/dmontagu
dmontaguhttps://github.com/dmontagu
Apr 23, 2023https://github.com/python/mypy/pull/15104#issuecomment-1518971073
Please reload this pagehttps://github.com/python/mypy/pull/15104
Please reload this pagehttps://github.com/python/mypy/pull/15104
https://github.com/cdce8p
cdce8phttps://github.com/cdce8p
Apr 23, 2023 https://github.com/python/mypy/pull/15104#ref-issue-1673292680
Release 1.3 planning #15075 https://github.com/python/mypy/issues/15075
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Apr 23, 2023 https://github.com/python/mypy/pull/15104#pullrequestreview-1396908923
View reviewed changes https://github.com/python/mypy/pull/15104/files/d89b31740e0d20a04ec9fff4d2b360d644cb2b42
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/15104#pullrequestreview-1396908923
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/15104
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
bd6ce23https://github.com/python/mypy/commit/bd6ce237f62366f156f4af074e398d761fb41359
Apr 23, 2023https://github.com/python/mypy/pull/15104#event-9074903386
https://github.com/samuelcolvin
samuelcolvinhttps://github.com/samuelcolvin
Apr 23, 2023https://github.com/python/mypy/pull/15104#issuecomment-1519073668
Please reload this pagehttps://github.com/python/mypy/pull/15104
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
April 23, 2023 22:24https://github.com/python/mypy/pull/15104#event-9075622620
wesleywrighthttps://github.com/wesleywright
Apr 24, 2023 https://github.com/python/mypy/pull/15104#ref-commit-d887e9c
https://github.com/hauntsaninja
Fix performance in union subtyping (https://github.com/python/mypy/commit/d887e9c0d090694b66b5fa20ac249b3d749a8518
#15104https://github.com/python/mypy/pull/15104
)https://github.com/python/mypy/commit/d887e9c0d090694b66b5fa20ac249b3d749a8518
d887e9chttps://github.com/python/mypy/commit/d887e9c0d090694b66b5fa20ac249b3d749a8518
#14034https://github.com/python/mypy/issues/14034
@adriangbhttps://github.com/adriangb
#14034 (comment)https://github.com/python/mypy/issues/14034#issuecomment-1470252641
hauntsaninjahttps://github.com/hauntsaninja
Apr 25, 2023 https://github.com/python/mypy/pull/15104#ref-commit-184e415
https://github.com/hauntsaninja
Speed up make_simplified_union, remove a potential crashhttps://github.com/hauntsaninja/mypy/commit/184e415502add001425ef93fb74464618973879f
184e415https://github.com/hauntsaninja/mypy/commit/184e415502add001425ef93fb74464618973879f
python#15104https://github.com/python/mypy/pull/15104
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 25, 2023 https://github.com/python/mypy/pull/15104#ref-pullrequest-1683484820
Speed up make_simplified_union, fix recursive tuple crash #15128 https://github.com/python/mypy/pull/15128
hauntsaninjahttps://github.com/hauntsaninja
May 6, 2023 https://github.com/python/mypy/pull/15104#ref-commit-7832e1f
https://github.com/hauntsaninja
Speed up make_simplified_union, fix recursive tuple crash (https://github.com/python/mypy/commit/7832e1f4ec5edf5f814c91f323c2d4ccc3022603
#15128https://github.com/python/mypy/pull/15128
)https://github.com/python/mypy/commit/7832e1f4ec5edf5f814c91f323c2d4ccc3022603
7832e1fhttps://github.com/python/mypy/commit/7832e1f4ec5edf5f814c91f323c2d4ccc3022603
#15192https://github.com/python/mypy/issues/15192
#15104https://github.com/python/mypy/pull/15104
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 7, 2025 https://github.com/python/mypy/pull/15104#ref-issue-3046365023
Add a benchmark involving realistic code that creates large unions astral-sh/ty#240 https://github.com/astral-sh/ty/issues/240
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15104
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/15104/files/d89b31740e0d20a04ec9fff4d2b360d644cb2b42
Please reload this pagehttps://github.com/python/mypy/pull/15104
mypy 0.990 is 1000x slow on pydantic codebase vs 0.982 https://github.com/python/mypy/issues/14034
Please reload this pagehttps://github.com/python/mypy/pull/15104
https://github.com/hauntsaninja
https://github.com/adriangb
https://github.com/dmontagu
https://github.com/samuelcolvin
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.