René's URL Explorer Experiment


Title: Remove potentially dead code from make_simplified_union by hauntsaninja · Pull Request #15094 · python/mypy · GitHub

Open Graph Title: Remove potentially dead code from make_simplified_union by hauntsaninja · Pull Request #15094 · python/mypy

X Title: Remove potentially dead code from make_simplified_union by hauntsaninja · Pull Request #15094 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: I was looking into optimising a couple code paths. This change is likely incorrect, but unit tests seemed to pass for me locally without this. We should have a test that covers this and hopefully p...

X Description: I was looking into optimising a couple code paths. This change is likely incorrect, but unit tests seemed to pass for me locally without this. We should have a test that covers this and hopefully p...

Opengraph URL: https://github.com/python/mypy/pull/15094

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dfeb629e-50ec-6113-5741-a475423c2e24
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2F6:2046A4:BFC875:10060FB:6B004D3D
html-safe-nonce4aff111d1425853af4713316dfc354dd3b522ae5b85968d225523bb7b74233e4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkY2OjIwNDZBNDpCRkM4NzU6MTAwNjBGQjo2QjAwNEQzRCIsInZpc2l0b3JfaWQiOiIyOTk0ODk0NDY2OTYxMTMyODYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd1ad180a02d58c19ef242fb7286a5f4888954fabe8139fce8e66608a3db2e763
hovercard-subject-tagpull_request:1322619576
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15094/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fb8136c6dc765000dee4c8b8c719c7d842383ae50ddf94cb54df95368426390b/python/mypy/pull/15094
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fb8136c6dc765000dee4c8b8c719c7d842383ae50ddf94cb54df95368426390b/python/mypy/pull/15094
og:image:altI was looking into optimising a couple code paths. This change is likely incorrect, but unit tests seemed to pass for me locally without this. We should have a test that covers this and hopefully p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/15094#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15094
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15094
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/15094
Reloadhttps://github.com/python/mypy/pull/15094
Reloadhttps://github.com/python/mypy/pull/15094
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:simplifhttps://github.com/hauntsaninja/mypy/tree/simplif
Conversationhttps://github.com/python/mypy/pull/15094
Commits1 (1)https://github.com/python/mypy/pull/15094/commits
Checkshttps://github.com/python/mypy/pull/15094/checks
Files changedhttps://github.com/python/mypy/pull/15094/files
Remove potentially dead code from make_simplified_unionhttps://github.com/python/mypy/pull/15094#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:simplifhttps://github.com/hauntsaninja/mypy/tree/simplif
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 21, 2023https://github.com/python/mypy/pull/15094#issue-1677990015
Please reload this pagehttps://github.com/python/mypy/pull/15094
Please reload this pagehttps://github.com/python/mypy/pull/15094
https://github.com/hauntsaninja
Remove potentially dead code from make_simplified_unionhttps://github.com/python/mypy/pull/15094/commits/67ebbdcfa5bb7cce693c16ac14e68ff4f5f6c858
67ebbdchttps://github.com/python/mypy/pull/15094/commits/67ebbdcfa5bb7cce693c16ac14e68ff4f5f6c858
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 21, 2023https://github.com/python/mypy/pull/15094#issuecomment-1517413711
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/15094
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 21, 2023https://github.com/python/mypy/pull/15094#event-9064798031
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
April 21, 2023 07:50https://github.com/python/mypy/pull/15094#event-9064799556
hauntsaninjahttps://github.com/hauntsaninja
Apr 21, 2023 https://github.com/python/mypy/pull/15094#ref-commit-2d0f839
https://github.com/hauntsaninja
Regression test for make_simplified_union truthinesshttps://github.com/hauntsaninja/mypy/commit/2d0f83924ebf81c9858d6d8c5fed5ee6b2d34478
2d0f839https://github.com/hauntsaninja/mypy/commit/2d0f83924ebf81c9858d6d8c5fed5ee6b2d34478
python#15094https://github.com/python/mypy/pull/15094
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 21, 2023 https://github.com/python/mypy/pull/15094#ref-pullrequest-1679034789
Regression test for make_simplified_union truthiness #15098 https://github.com/python/mypy/pull/15098
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 21, 2023 https://github.com/python/mypy/pull/15094#ref-commit-3cca987
https://github.com/hauntsaninja
Regression test for make_simplified_union truthiness (https://github.com/python/mypy/commit/3cca9873d51a5b7b4bf1b68a0b57d0116f522646
#15098https://github.com/python/mypy/pull/15098
)https://github.com/python/mypy/commit/3cca9873d51a5b7b4bf1b68a0b57d0116f522646
3cca987https://github.com/python/mypy/commit/3cca9873d51a5b7b4bf1b68a0b57d0116f522646
#15094https://github.com/python/mypy/pull/15094
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 5, 2023 https://github.com/python/mypy/pull/15094#ref-pullrequest-1683484820
Speed up make_simplified_union, fix recursive tuple crash #15128 https://github.com/python/mypy/pull/15128
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15094
Please reload this pagehttps://github.com/python/mypy/pull/15094
Please reload this pagehttps://github.com/python/mypy/pull/15094
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.