| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1cbc6106-ed21-4a72-a747-aa3a8412e641 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9A02:22E601:BC2F69:FC4D5A:6B004CFC |
| html-safe-nonce | cf0d85e60db501f8095ebe289863cf6a604f2e17a58e483f233cf7e0c0df868e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTAyOjIyRTYwMTpCQzJGNjk6RkM0RDVBOjZCMDA0Q0ZDIiwidmlzaXRvcl9pZCI6IjIyMDc1NzY0Nzg1NTg3MzU2MTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 367e5b201f8c30e895c2f6572daacf632edf65d524c7123e76f6574597698842 |
| hovercard-subject-tag | pull_request:1315542509 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/15064/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4fc701e32bf1a6984179988f7bf4c8f5d630e308a5ebef421e7d97f8bcdb40d4/python/mypy/pull/15064 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4fc701e32bf1a6984179988f7bf4c8f5d630e308a5ebef421e7d97f8bcdb40d4/python/mypy/pull/15064 |
| og:image:alt | Fixes #5362 including test cases from that report + my own duplicate report. Fairly small change that directly allows class defs and analyzes them so that looking up later finds the needed symbol.
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hmc-cs-mdrissi |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/15064#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15064 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15064 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/15064 |
| Reload | https://github.com/python/mypy/pull/15064 |
| Reload | https://github.com/python/mypy/pull/15064 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hmc-cs-mdrissi | https://github.com/hmc-cs-mdrissi |
| python:master | https://github.com/python/mypy/tree/master |
| hmc-cs-mdrissi:md/nested_namedtuple_classes | https://github.com/hmc-cs-mdrissi/mypy/tree/md/nested_namedtuple_classes |
| Conversation | https://github.com/python/mypy/pull/15064 |
| Commits2 (2) | https://github.com/python/mypy/pull/15064/commits |
| Checks | https://github.com/python/mypy/pull/15064/checks |
| Files changed | https://github.com/python/mypy/pull/15064/files |
| Support nested namedtuple classes. | https://github.com/python/mypy/pull/15064#top |
| hmc-cs-mdrissi | https://github.com/hmc-cs-mdrissi |
| python:master | https://github.com/python/mypy/tree/master |
| hmc-cs-mdrissi:md/nested_namedtuple_classes | https://github.com/hmc-cs-mdrissi/mypy/tree/md/nested_namedtuple_classes |
|
| https://github.com/hmc-cs-mdrissi |
| hmc-cs-mdrissi | https://github.com/hmc-cs-mdrissi |
| Apr 16, 2023 | https://github.com/python/mypy/pull/15064#issue-1669922962 |
| Please reload this page | https://github.com/python/mypy/pull/15064 |
| #5362 | https://github.com/python/mypy/issues/5362 |
| report | https://github.com/python/mypy/issues/15061 |
| Please reload this page | https://github.com/python/mypy/pull/15064 |
| Support nested namedtuple classes. | https://github.com/python/mypy/pull/15064/commits/d70e348e4e9e942ff2766f6d3ba73304de138423 |
| d70e348 | https://github.com/python/mypy/pull/15064/commits/d70e348e4e9e942ff2766f6d3ba73304de138423 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15064 |
| fix non-incremental test case | https://github.com/python/mypy/pull/15064/commits/18c6de79ea95dcce23ddbaa494029bcda60ae9ef |
| 18c6de7 | https://github.com/python/mypy/pull/15064/commits/18c6de79ea95dcce23ddbaa494029bcda60ae9ef |
| https://github.com/hmc-cs-mdrissi |
| hmc-cs-mdrissi | https://github.com/hmc-cs-mdrissi |
| Apr 17, 2023 | https://github.com/python/mypy/pull/15064#issuecomment-1510688834 |
| Please reload this page | https://github.com/python/mypy/pull/15064 |
| here | https://github.com/python/mypy/pull/14119 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/mypy/pull/15064 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Apr 17, 2023 | https://github.com/python/mypy/pull/15064#issuecomment-1510701677 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/15064 |
| https://github.com/hmc-cs-mdrissi |
| hmc-cs-mdrissi | https://github.com/hmc-cs-mdrissi |
|
Apr 17, 2023
| https://github.com/python/mypy/pull/15064#pullrequestreview-1387278197 |
|
View reviewed changes
| https://github.com/python/mypy/pull/15064/files/18c6de79ea95dcce23ddbaa494029bcda60ae9ef |
| mypy/semanal_namedtuple.py | https://github.com/python/mypy/pull/15064/files/18c6de79ea95dcce23ddbaa494029bcda60ae9ef#diff-407d3897e177054db01199416f9e43dad2d71e0711a6e9d2c16ca84400024d0d |
| hmc-cs-mdrissi | https://github.com/hmc-cs-mdrissi |
| Apr 17, 2023 | https://github.com/python/mypy/pull/15064#discussion_r1168182914 |
| Please reload this page | https://github.com/python/mypy/pull/15064 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| here | https://github.com/python/mypy/blob/4276308be01ea498d946a79554b4a10b1cf13ccb/mypy/semanal.py#L1724 |
| line | https://github.com/python/mypy/blob/4276308be01ea498d946a79554b4a10b1cf13ccb/mypy/semanal_namedtuple.py#L187 |
| Please reload this page | https://github.com/python/mypy/pull/15064 |
| JukkaL | https://github.com/JukkaL |
| Apr 17, 2023 | https://github.com/python/mypy/pull/15064#discussion_r1168776329 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/15064 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
|
Jul 30, 2023
| https://github.com/python/mypy/pull/15064#ref-issue-1827456383 |
|
NamedTuples cannot have nested classes
#15775
| https://github.com/python/mypy/issues/15775 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Jul 30, 2023
| https://github.com/python/mypy/pull/15064#ref-pullrequest-1827459977 |
|
Allow nested classes in NamedTuple bodies
#15776
| https://github.com/python/mypy/pull/15776 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F15064 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/15064/files/18c6de79ea95dcce23ddbaa494029bcda60ae9ef |
| Please reload this page | https://github.com/python/mypy/pull/15064 |
|
Mypy rejects valid nested class inside of a NamedTuple class definition
| https://github.com/python/mypy/issues/5362 |
| Please reload this page | https://github.com/python/mypy/pull/15064 |
|
| https://github.com/hmc-cs-mdrissi |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |