René's URL Explorer Experiment


Title: Fix mishandling of typing.Self in attrs generated inits by davfsa · Pull Request #14689 · python/mypy · GitHub

Open Graph Title: Fix mishandling of typing.Self in attrs generated inits by davfsa · Pull Request #14689 · python/mypy

X Title: Fix mishandling of typing.Self in attrs generated inits by davfsa · Pull Request #14689 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fix mishandling of typing.Self in attrs generated inits by using the same expansion method as the dataclasses plugin Fixes #14685

X Description: Fix mishandling of typing.Self in attrs generated inits by using the same expansion method as the dataclasses plugin Fixes #14685

Opengraph URL: https://github.com/python/mypy/pull/14689

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:97be6d34-59dc-2418-9064-176e329f7017
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2A8:2E6021:279E73D:33F4297:6B0004F6
html-safe-nonce3fb185338788ca57679f11ceec0dcf8137a5cbef2caaa38cae25c4ba01ba5f01
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkE4OjJFNjAyMToyNzlFNzNEOjMzRjQyOTc6NkIwMDA0RjYiLCJ2aXNpdG9yX2lkIjoiNDMyNjY3MjQxOTk1NjcyMDg4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd7c152d4fa4828b915e90b2d51ea6a3681d91351ee6b5d20cfcf733c75c708cd
hovercard-subject-tagpull_request:1238917391
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/14689/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/27465a883465c3e6c8820e69a36ebee2bf2a4da65f3e83ae4c4c2a1c82d9b063/python/mypy/pull/14689
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/27465a883465c3e6c8820e69a36ebee2bf2a4da65f3e83ae4c4c2a1c82d9b063/python/mypy/pull/14689
og:image:altFix mishandling of typing.Self in attrs generated inits by using the same expansion method as the dataclasses plugin Fixes #14685
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedavfsa
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/14689#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14689
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14689
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/14689
Reloadhttps://github.com/python/mypy/pull/14689
Reloadhttps://github.com/python/mypy/pull/14689
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
davfsahttps://github.com/davfsa
python:masterhttps://github.com/python/mypy/tree/master
davfsa:bugfix/14685-attrs-self-handlinghttps://github.com/davfsa/mypy/tree/bugfix/14685-attrs-self-handling
Conversationhttps://github.com/python/mypy/pull/14689
Commits13 (13)https://github.com/python/mypy/pull/14689/commits
Checkshttps://github.com/python/mypy/pull/14689/checks
Files changedhttps://github.com/python/mypy/pull/14689/files
Fix mishandling of typing.Self in attrs generated initshttps://github.com/python/mypy/pull/14689#top
davfsahttps://github.com/davfsa
python:masterhttps://github.com/python/mypy/tree/master
davfsa:bugfix/14685-attrs-self-handlinghttps://github.com/davfsa/mypy/tree/bugfix/14685-attrs-self-handling
https://github.com/davfsa
davfsahttps://github.com/davfsa
Feb 13, 2023https://github.com/python/mypy/pull/14689#issue-1582260117
#14685https://github.com/python/mypy/issues/14685
Please reload this pagehttps://github.com/python/mypy/pull/14689
davfsahttps://github.com/davfsa
February 13, 2023 13:25https://github.com/python/mypy/pull/14689#commits-pushed-d6770af
https://github.com/davfsa
Fix mishandling of typing.Self in attrs generated initshttps://github.com/python/mypy/pull/14689/commits/d6770af5f3af07c4c89e17e674a244fd82e5d1a8
d6770afhttps://github.com/python/mypy/pull/14689/commits/d6770af5f3af07c4c89e17e674a244fd82e5d1a8
https://github.com/davfsa
Add missing typehinthttps://github.com/python/mypy/pull/14689/commits/3cc52907e9a644b0496f3c8c8132404d978ff656
3cc5290https://github.com/python/mypy/pull/14689/commits/3cc52907e9a644b0496f3c8c8132404d978ff656
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14689
https://github.com/davfsa
davfsahttps://github.com/davfsa
Feb 13, 2023https://github.com/python/mypy/pull/14689#issuecomment-1427929894
Please reload this pagehttps://github.com/python/mypy/pull/14689
Please reload this pagehttps://github.com/python/mypy/pull/14689
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Feb 13, 2023https://github.com/python/mypy/pull/14689#issuecomment-1427948429
Please reload this pagehttps://github.com/python/mypy/pull/14689
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
topic-attrs https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-attrs
topic-self-types https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-self-types
Feb 13, 2023https://github.com/python/mypy/pull/14689#event-8504645044
https://github.com/davfsa
davfsahttps://github.com/davfsa
Feb 13, 2023https://github.com/python/mypy/pull/14689#issuecomment-1428043759
https://mypy.readthedocs.io/en/stable/kinds_of_types.html#no-strict-optionalhttps://mypy.readthedocs.io/en/stable/kinds_of_types.html#no-strict-optional
Please reload this pagehttps://github.com/python/mypy/pull/14689
davfsahttps://github.com/davfsa
February 14, 2023 01:02https://github.com/python/mypy/pull/14689#commits-pushed-d76e440
https://github.com/davfsa
Add missing flag to testhttps://github.com/python/mypy/pull/14689/commits/d76e440e1586ebb08e66baae83a4584dfa6ba774
d76e440https://github.com/python/mypy/pull/14689/commits/d76e440e1586ebb08e66baae83a4584dfa6ba774
https://github.com/davfsa
De-duplicate codehttps://github.com/python/mypy/pull/14689/commits/6d0615d8d465a10b95c52bcff39dc30cf90ada66
6d0615dhttps://github.com/python/mypy/pull/14689/commits/6d0615d8d465a10b95c52bcff39dc30cf90ada66
https://github.com/davfsa
davfsahttps://github.com/davfsa
Feb 14, 2023https://github.com/python/mypy/pull/14689#issuecomment-1428887814
@A5rockshttps://github.com/A5rocks
Please reload this pagehttps://github.com/python/mypy/pull/14689
https://github.com/davfsa
Fix typehinthttps://github.com/python/mypy/pull/14689/commits/95488d8f0729fc50170d72cd1356b5afbe97bb63
95488d8https://github.com/python/mypy/pull/14689/commits/95488d8f0729fc50170d72cd1356b5afbe97bb63
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14689
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Feb 14, 2023 https://github.com/python/mypy/pull/14689#pullrequestreview-1297680246
View reviewed changes https://github.com/python/mypy/pull/14689/files/95488d8f0729fc50170d72cd1356b5afbe97bb63
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/14689#pullrequestreview-1297680246
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14689
mypy/expandtype.pyhttps://github.com/python/mypy/pull/14689/files/95488d8f0729fc50170d72cd1356b5afbe97bb63#diff-91900391ac75c32e76d37331a68d7f0b91bbdc2323d7919a36a87ecc43899499
Please reload this pagehttps://github.com/python/mypy/pull/14689
mypy/plugins/dataclasses.pyhttps://github.com/python/mypy/pull/14689/files/95488d8f0729fc50170d72cd1356b5afbe97bb63#diff-1fdad80f805993800524fbb9b684cc3d09879f54a0e51c71f2a447c7d46c1eb4
Please reload this pagehttps://github.com/python/mypy/pull/14689
test-data/unit/check-attr.testhttps://github.com/python/mypy/pull/14689/files/95488d8f0729fc50170d72cd1356b5afbe97bb63#diff-0a3b87cb7639d25b0ecf82a84593a30120970e9db3a5fc209b5ab6f678f79786
Please reload this pagehttps://github.com/python/mypy/pull/14689
davfsahttps://github.com/davfsa
February 15, 2023 17:04https://github.com/python/mypy/pull/14689#commits-pushed-c40674b
https://github.com/davfsa
Merge branch 'master' into bugfix/14685-attrs-self-handlinghttps://github.com/python/mypy/pull/14689/commits/c40674ba973e03610f25869159a2cc1dde47ba9b
c40674bhttps://github.com/python/mypy/pull/14689/commits/c40674ba973e03610f25869159a2cc1dde47ba9b
https://github.com/davfsa
Add recommended test and fix small bughttps://github.com/python/mypy/pull/14689/commits/23b9ab5916a411c7f926655458c6147f3eada7c3
23b9ab5https://github.com/python/mypy/pull/14689/commits/23b9ab5916a411c7f926655458c6147f3eada7c3
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14689
https://github.com/davfsa
davfsahttps://github.com/davfsa
Feb 15, 2023https://github.com/python/mypy/pull/14689#issuecomment-1432047339
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/14689
https://github.com/davfsa
Revert merging of functionshttps://github.com/python/mypy/pull/14689/commits/1dba00ada33ca5c355e72d90e9d2cd1876fe04bd
1dba00ahttps://github.com/python/mypy/pull/14689/commits/1dba00ada33ca5c355e72d90e9d2cd1876fe04bd
https://github.com/davfsa
davfsahttps://github.com/davfsa
JukkaLhttps://github.com/JukkaL
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
ilevkivskyihttps://github.com/ilevkivskyi
February 17, 2023 09:20https://github.com/python/mypy/pull/14689#event-8545219422
davfsahttps://github.com/davfsa
February 17, 2023 10:22https://github.com/python/mypy/pull/14689#commits-pushed-96c5647
https://github.com/davfsa
Remove un-used importshttps://github.com/python/mypy/pull/14689/commits/96c564706b2c3df88542a5f9566ed36ab48d2f1e
96c5647https://github.com/python/mypy/pull/14689/commits/96c564706b2c3df88542a5f9566ed36ab48d2f1e
https://github.com/davfsa
Fix typehinthttps://github.com/python/mypy/pull/14689/commits/930e0663e92422faadd6016f6ff58c4ef0efb214
930e066https://github.com/python/mypy/pull/14689/commits/930e0663e92422faadd6016f6ff58c4ef0efb214
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14689
https://github.com/davfsa
Merge branch 'master' into bugfix/14685-attrs-self-handlinghttps://github.com/python/mypy/pull/14689/commits/c8b343f2ddb084d7f3828069d3ae655ae3add548
c8b343fhttps://github.com/python/mypy/pull/14689/commits/c8b343f2ddb084d7f3828069d3ae655ae3add548
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14689
https://github.com/davfsa
Merge branch 'master' into bugfix/14685-attrs-self-handlinghttps://github.com/python/mypy/pull/14689/commits/85a6055b96f7c3ed364c28b03a8b20b46729d0ec
85a6055https://github.com/python/mypy/pull/14689/commits/85a6055b96f7c3ed364c28b03a8b20b46729d0ec
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14689
https://github.com/davfsa
Merge branch 'master' into bugfix/14685-attrs-self-handlinghttps://github.com/python/mypy/pull/14689/commits/c5a1ddcc9e9142ddf40bb1799e6df0e9e23403c1
c5a1ddchttps://github.com/python/mypy/pull/14689/commits/c5a1ddcc9e9142ddf40bb1799e6df0e9e23403c1
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 7, 2023https://github.com/python/mypy/pull/14689#issuecomment-1580637490
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/14689
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14689
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/14689/files/23b9ab5916a411c7f926655458c6147f3eada7c3
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/14689
topic-attrs https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-attrs
topic-self-types https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-self-types
Attrs plugin mishandles typing.Self in generated inits https://github.com/python/mypy/issues/14685
Please reload this pagehttps://github.com/python/mypy/pull/14689
https://github.com/davfsa
https://github.com/A5rocks
https://github.com/JukkaL
https://github.com/ilevkivskyi
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.