René's URL Explorer Experiment


Title: [dataclass_transform] support subclass/metaclass-based transforms by wesleywright · Pull Request #14657 · python/mypy · GitHub

Open Graph Title: [dataclass_transform] support subclass/metaclass-based transforms by wesleywright · Pull Request #14657 · python/mypy

X Title: [dataclass_transform] support subclass/metaclass-based transforms by wesleywright · Pull Request #14657 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Support dataclass_transforms that use inheritance or metaclasses rather than decorators. This only needs plumbing changes so that we can get the correct metadata for a given class and trigger the d...

X Description: Support dataclass_transforms that use inheritance or metaclasses rather than decorators. This only needs plumbing changes so that we can get the correct metadata for a given class and trigger the d...

Opengraph URL: https://github.com/python/mypy/pull/14657

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:57cd4ae0-4671-4824-79fc-ce00567a7c44
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC624:280F7A:80B3:B393:6AEC8188
html-safe-nonce537df64593d1b7c3cd3cc9429a543f2eb829c4b004227f7ef09fb46550d1f083
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjI0OjI4MEY3QTo4MEIzOkIzOTM6NkFFQzgxODgiLCJ2aXNpdG9yX2lkIjoiNzczNTA0MjQzNzUxOTU0MDYxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9a0500a4f81a6fdc2400f4eba104bdca651548ecf9f518f8c6bfb24128003d79
hovercard-subject-tagpull_request:1234288500
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/14657/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/839bc02332d0f6c3d06d8e9d577d3df0c971394cec4572e86174a701e4ca3f98/python/mypy/pull/14657
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/839bc02332d0f6c3d06d8e9d577d3df0c971394cec4572e86174a701e4ca3f98/python/mypy/pull/14657
og:image:altSupport dataclass_transforms that use inheritance or metaclasses rather than decorators. This only needs plumbing changes so that we can get the correct metadata for a given class and trigger the d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewesleywright
hostnamegithub.com
expected-hostnamegithub.com
None9e71b15756bc4afd8519e1d2c309d0293587d17d6675d0f439cc304af9ed67ee
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c2272d26b06ef11573649367fbbb67bfa00cd4f
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/14657#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14657
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14657
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/14657
Reloadhttps://github.com/python/mypy/pull/14657
Reloadhttps://github.com/python/mypy/pull/14657
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests522 (522)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/pulse
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
wesleywright:dataclass-transform-subclasses-and-metaclasseshttps://github.com/wesleywright/mypy/tree/dataclass-transform-subclasses-and-metaclasses
Conversationhttps://github.com/python/mypy/pull/14657
Commits7 (7)https://github.com/python/mypy/pull/14657/commits
Checkshttps://github.com/python/mypy/pull/14657/checks
Files changedhttps://github.com/python/mypy/pull/14657/files
[dataclass_transform] support subclass/metaclass-based transformshttps://github.com/python/mypy/pull/14657#top
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
wesleywright:dataclass-transform-subclasses-and-metaclasseshttps://github.com/wesleywright/mypy/tree/dataclass-transform-subclasses-and-metaclasses
https://github.com/wesleywright
wesleywrighthttps://github.com/wesleywright
Feb 8, 2023https://github.com/python/mypy/pull/14657#issue-1576952839
Please reload this pagehttps://github.com/python/mypy/pull/14657
[dataclass_transform] support subclass/metaclass-based transformshttps://github.com/python/mypy/pull/14657/commits/da954bee94501ad25127c30a66536a2369d1cb80
da954behttps://github.com/python/mypy/pull/14657/commits/da954bee94501ad25127c30a66536a2369d1cb80
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14657
https://github.com/Jackenmen
Jackenmenhttps://github.com/Jackenmen
Feb 9, 2023 https://github.com/python/mypy/pull/14657#ref-issue-1577123132
Setup "ecosystem CI" to avoid regressions for existing users astral-sh/ruff#2677 https://github.com/astral-sh/ruff/issues/2677
https://github.com/wesleywright
wesleywrighthttps://github.com/wesleywright
Feb 9, 2023https://github.com/python/mypy/pull/14657#issuecomment-1424430684
Please reload this pagehttps://github.com/python/mypy/pull/14657
Please reload this pagehttps://github.com/python/mypy/pull/14657
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Feb 9, 2023 https://github.com/python/mypy/pull/14657#pullrequestreview-1291764120
View reviewed changes https://github.com/python/mypy/pull/14657/files/da954bee94501ad25127c30a66536a2369d1cb80
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/14657#pullrequestreview-1291764120
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
mypy/plugins/dataclasses.pyhttps://github.com/python/mypy/pull/14657/files/da954bee94501ad25127c30a66536a2369d1cb80#diff-1fdad80f805993800524fbb9b684cc3d09879f54a0e51c71f2a447c7d46c1eb4
JukkaLhttps://github.com/JukkaL
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1101861495
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
wesleywrighthttps://github.com/wesleywright
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1102103935
Please reload this pagehttps://github.com/python/mypy/pull/14657
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#14667https://github.com/python/mypy/pull/14667
Please reload this pagehttps://github.com/python/mypy/pull/14657
mypy/semanal_shared.pyhttps://github.com/python/mypy/pull/14657/files/da954bee94501ad25127c30a66536a2369d1cb80#diff-0f351ae22d890b1b7f2fdee0993280c437c36edbff3d2ca4be38292713541530
JukkaLhttps://github.com/JukkaL
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1101864512
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
wesleywrighthttps://github.com/wesleywright
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1101899114
Please reload this pagehttps://github.com/python/mypy/pull/14657
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
the PEPhttps://peps.python.org/pep-0681/#the-dataclass-transform-decorator
Please reload this pagehttps://github.com/python/mypy/pull/14657
wesleywrighthttps://github.com/wesleywright
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1102124304
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
test-data/unit/check-dataclass-transform.testhttps://github.com/python/mypy/pull/14657/files/da954bee94501ad25127c30a66536a2369d1cb80#diff-9894d13baa0ec038a408abfd71fd596818d44604695b5f514ac572c0f4315ae7
JukkaLhttps://github.com/JukkaL
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1101865083
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
test-data/unit/check-dataclass-transform.testhttps://github.com/python/mypy/pull/14657/files/da954bee94501ad25127c30a66536a2369d1cb80#diff-9894d13baa0ec038a408abfd71fd596818d44604695b5f514ac572c0f4315ae7
JukkaLhttps://github.com/JukkaL
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1101865540
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
test-data/unit/check-dataclass-transform.testhttps://github.com/python/mypy/pull/14657/files/da954bee94501ad25127c30a66536a2369d1cb80#diff-9894d13baa0ec038a408abfd71fd596818d44604695b5f514ac572c0f4315ae7
JukkaLhttps://github.com/JukkaL
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1101865917
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
mypy/nodes.pyhttps://github.com/python/mypy/pull/14657/files/da954bee94501ad25127c30a66536a2369d1cb80#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
JukkaLhttps://github.com/JukkaL
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1101867311
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
test-data/unit/check-dataclass-transform.testhttps://github.com/python/mypy/pull/14657/files/da954bee94501ad25127c30a66536a2369d1cb80#diff-9894d13baa0ec038a408abfd71fd596818d44604695b5f514ac572c0f4315ae7
JukkaLhttps://github.com/JukkaL
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1101870665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
wesleywrighthttps://github.com/wesleywright
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1101900516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
JukkaLhttps://github.com/JukkaL
Feb 9, 2023https://github.com/python/mypy/pull/14657#discussion_r1102025370
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
JukkaLhttps://github.com/JukkaL
Feb 10, 2023https://github.com/python/mypy/pull/14657#discussion_r1102562683
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
February 9, 2023 23:00https://github.com/python/mypy/pull/14657#commits-pushed-b872016
move dataclass_transform_spec field from ClassDef to TypeInfohttps://github.com/python/mypy/pull/14657/commits/b8720166a84fafd3df602c3816fa1ac694c130b2
b872016https://github.com/python/mypy/pull/14657/commits/b8720166a84fafd3df602c3816fa1ac694c130b2
add test coverage for subclass of subclass/using metaclasshttps://github.com/python/mypy/pull/14657/commits/b388a8f90cea7cf8fd2b24f3ffdd663e215116c7
b388a8fhttps://github.com/python/mypy/pull/14657/commits/b388a8f90cea7cf8fd2b24f3ffdd663e215116c7
comment explaining why we don't search the metaclass's MROhttps://github.com/python/mypy/pull/14657/commits/486cae9042ef0f3f34fc6be4a852c4a19c8b139e
486cae9https://github.com/python/mypy/pull/14657/commits/486cae9042ef0f3f34fc6be4a852c4a19c8b139e
add test case for subclass of metaclass as transformhttps://github.com/python/mypy/pull/14657/commits/8c52fc9f56f4e80814b0677fbc0f99880979b5d9
8c52fc9https://github.com/python/mypy/pull/14657/commits/8c52fc9f56f4e80814b0677fbc0f99880979b5d9
remove period from error messagehttps://github.com/python/mypy/pull/14657/commits/51598eb45828f140eadcc7d7b67946c0635c1e52
51598ebhttps://github.com/python/mypy/pull/14657/commits/51598eb45828f140eadcc7d7b67946c0635c1e52
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14657
fix tests after removing periodhttps://github.com/python/mypy/pull/14657/commits/16d9f0837052280f291fa34701e0fb4751faef38
16d9f08https://github.com/python/mypy/pull/14657/commits/16d9f0837052280f291fa34701e0fb4751faef38
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Feb 10, 2023https://github.com/python/mypy/pull/14657#issuecomment-1425073881
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/14657
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Feb 10, 2023 https://github.com/python/mypy/pull/14657#pullrequestreview-1292858177
View reviewed changes https://github.com/python/mypy/pull/14657/files/16d9f0837052280f291fa34701e0fb4751faef38
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/14657#pullrequestreview-1292858177
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14657
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
99b04cahttps://github.com/python/mypy/commit/99b04cac8b216bb426b1fab5a3ff447d1451c967
Feb 10, 2023https://github.com/python/mypy/pull/14657#event-8488446142
consolidate literal bool argument error messages #14693 https://github.com/python/mypy/pull/14693
[dataclass_transform] support field_specifiers #14667 https://github.com/python/mypy/pull/14667
JukkaLhttps://github.com/JukkaL
Feb 14, 2023 https://github.com/python/mypy/pull/14657#ref-commit-0b4ccae
consolidate literal bool argument error messages (https://github.com/python/mypy/commit/0b4ccaeb7dc282199e727978bc40d0fdde1897c9
#14693https://github.com/python/mypy/pull/14693
)https://github.com/python/mypy/commit/0b4ccaeb7dc282199e727978bc40d0fdde1897c9
0b4ccaehttps://github.com/python/mypy/commit/0b4ccaeb7dc282199e727978bc40d0fdde1897c9
#14580https://github.com/python/mypy/pull/14580
#14657https://github.com/python/mypy/pull/14657
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14657
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/14657/files/16d9f0837052280f291fa34701e0fb4751faef38
Please reload this pagehttps://github.com/python/mypy/pull/14657
Please reload this pagehttps://github.com/python/mypy/pull/14657
https://github.com/wesleywright
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.