René's URL Explorer Experiment


Title: Fix bug with in operator used with a union of Container and Iterable by koogoro · Pull Request #14384 · python/mypy · GitHub

Open Graph Title: Fix bug with in operator used with a union of Container and Iterable by koogoro · Pull Request #14384 · python/mypy

X Title: Fix bug with in operator used with a union of Container and Iterable by koogoro · Pull Request #14384 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #4954. Modifies analysis of in comparison expressions. Previously, mypy would check the right operand of an in expression to see if it was a union of Containers, and then if it was a union of...

X Description: Fixes #4954. Modifies analysis of in comparison expressions. Previously, mypy would check the right operand of an in expression to see if it was a union of Containers, and then if it was a union of...

Opengraph URL: https://github.com/python/mypy/pull/14384

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7498ab2c-0d2c-854f-48b1-9ddc6ce25c1a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8774:D7A67:F8F22A:147F95B:6AEC0C90
html-safe-noncec31fb84cd610745c2a3791b7b786c21cb484673141bd617c90b0b8227da00601
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Nzc0OkQ3QTY3OkY4RjIyQToxNDdGOTVCOjZBRUMwQzkwIiwidmlzaXRvcl9pZCI6IjU0MzUwNTY4NzAzNDQzNjMxNTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8e8dc2864828d3aea4040456508d4875b4b3486cbd77812020ccf3b6d1d298d9
hovercard-subject-tagpull_request:1183839718
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/14384/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9d483e9f03b8254655d3e222e6b68f8373b9b58d59cbf8b91ec19f76b2dc452a/python/mypy/pull/14384
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9d483e9f03b8254655d3e222e6b68f8373b9b58d59cbf8b91ec19f76b2dc452a/python/mypy/pull/14384
og:image:altFixes #4954. Modifies analysis of in comparison expressions. Previously, mypy would check the right operand of an in expression to see if it was a union of Containers, and then if it was a union of...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekoogoro
hostnamegithub.com
expected-hostnamegithub.com
Noned063d52022f5f270ef55a70761d126c8085d492d3c251084b07781784c02dad4
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56e59340194011ba3cb6809acfa979ccbd174288
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/14384#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14384
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14384
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/14384
Reloadhttps://github.com/python/mypy/pull/14384
Reloadhttps://github.com/python/mypy/pull/14384
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests522 (522)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/pulse
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
koogoro:maxmurin/bugfix-union-of-container-and-iterablehttps://github.com/koogoro/mypy/tree/maxmurin/bugfix-union-of-container-and-iterable
Conversationhttps://github.com/python/mypy/pull/14384
Commits4 (4)https://github.com/python/mypy/pull/14384/commits
Checkshttps://github.com/python/mypy/pull/14384/checks
Files changedhttps://github.com/python/mypy/pull/14384/files
Fix bug with in operator used with a union of Container and Iterablehttps://github.com/python/mypy/pull/14384#top
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
koogoro:maxmurin/bugfix-union-of-container-and-iterablehttps://github.com/koogoro/mypy/tree/maxmurin/bugfix-union-of-container-and-iterable
https://github.com/koogoro
koogorohttps://github.com/koogoro
Jan 3, 2023https://github.com/python/mypy/pull/14384#issue-1517800074
#4954https://github.com/python/mypy/issues/4954
Please reload this pagehttps://github.com/python/mypy/pull/14384
https://github.com/koogoro
fix bug, add testhttps://github.com/python/mypy/pull/14384/commits/64026af910114d68d94b851fb88e1574422848ad
64026afhttps://github.com/python/mypy/pull/14384/commits/64026af910114d68d94b851fb88e1574422848ad
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14384
https://github.com/koogoro
change method name to better describe its function, don't remove meth…https://github.com/python/mypy/pull/14384/commits/81829d252ac06aa1337510f83e67e5c9270fbbda
81829d2https://github.com/python/mypy/pull/14384/commits/81829d252ac06aa1337510f83e67e5c9270fbbda
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14384
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Jan 11, 2023 https://github.com/python/mypy/pull/14384#pullrequestreview-1244438240
View reviewed changes https://github.com/python/mypy/pull/14384/files/81829d252ac06aa1337510f83e67e5c9270fbbda
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/14384#pullrequestreview-1244438240
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14384
mypy/checkexpr.pyhttps://github.com/python/mypy/pull/14384/files/81829d252ac06aa1337510f83e67e5c9270fbbda#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
JukkaLhttps://github.com/JukkaL
Jan 11, 2023https://github.com/python/mypy/pull/14384#discussion_r1067343188
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14384
koogorohttps://github.com/koogoro
January 26, 2023 13:56https://github.com/python/mypy/pull/14384#commits-pushed-05abbb5
https://github.com/koogoro
change block comment formathttps://github.com/python/mypy/pull/14384/commits/05abbb56a30dcf2508833253c08958f7bdaab252
05abbb5https://github.com/python/mypy/pull/14384/commits/05abbb56a30dcf2508833253c08958f7bdaab252
https://github.com/koogoro
Merge branch 'master' into maxmurin/bugfix-union-of-container-and-ite…https://github.com/python/mypy/pull/14384/commits/4aa98131897ff62f2717187f1da6fa6c1cab263c
4aa9813https://github.com/python/mypy/pull/14384/commits/4aa98131897ff62f2717187f1da6fa6c1cab263c
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 26, 2023https://github.com/python/mypy/pull/14384#issuecomment-1405613810
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/14384
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
1d247eahttps://github.com/python/mypy/commit/1d247eaa0e4b61947ec807d8179e3356d1e7bba6
Jan 30, 2023https://github.com/python/mypy/pull/14384#event-8391279972
https://github.com/koogoro
koogorohttps://github.com/koogoro
Feb 17, 2023 https://github.com/python/mypy/pull/14384#ref-pullrequest-1590005769
Fix for bug with in operation on optionals in no-strict-optional mode #14727 https://github.com/python/mypy/pull/14727
hauntsaninjahttps://github.com/hauntsaninja
Feb 18, 2023 https://github.com/python/mypy/pull/14384#ref-commit-c99133f
https://github.com/koogoro
Fix for bug with in operation on optionals in no-strict-optional …https://github.com/python/mypy/commit/c99133f405f286ed3429c809e9ae2cb3faaa2ceb
c99133fhttps://github.com/python/mypy/commit/c99133f405f286ed3429c809e9ae2cb3faaa2ceb
#14727https://github.com/python/mypy/pull/14727
#14384https://github.com/python/mypy/pull/14384
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14384
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/14384/files/81829d252ac06aa1337510f83e67e5c9270fbbda
Please reload this pagehttps://github.com/python/mypy/pull/14384
'in' operator rejected with union right operand https://github.com/python/mypy/issues/4954
Please reload this pagehttps://github.com/python/mypy/pull/14384
https://github.com/koogoro
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.