René's URL Explorer Experiment


Title: More helpful type guards by A5rocks · Pull Request #14238 · python/mypy · GitHub

Open Graph Title: More helpful type guards by A5rocks · Pull Request #14238 · python/mypy

X Title: More helpful type guards by A5rocks · Pull Request #14238 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: A TODO I found while looking at something else got me down this rabbit hole, and I noticed mypy's subpar performance in these two cases. Short descriptions from before I did this, so may be tec...

X Description: A TODO I found while looking at something else got me down this rabbit hole, and I noticed mypy's subpar performance in these two cases. Short descriptions from before I did this, so may be...

Opengraph URL: https://github.com/python/mypy/pull/14238

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:19cef646-7976-de5c-e91a-a6f1be462ac7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD10:106F5D:1F953B:2AA882:6B002268
html-safe-nonce0a4831f7d513debddae5818196d404475966333e35dfecab5577ceacaa87a3dc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDEwOjEwNkY1RDoxRjk1M0I6MkFBODgyOjZCMDAyMjY4IiwidmlzaXRvcl9pZCI6IjU1MTMxMTU3NzkyMzY2MzUyNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac631959c9a273ea4d35463689c887839b0f8d1af20dcf2b87b46e2205cd26b999
hovercard-subject-tagpull_request:1144053969
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/14238/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cb1aa9dab8616452bd26dfb8af7108536a0fdf8f59cfbb0a97d3566bdc975ab5/python/mypy/pull/14238
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cb1aa9dab8616452bd26dfb8af7108536a0fdf8f59cfbb0a97d3566bdc975ab5/python/mypy/pull/14238
og:image:altA TODO I found while looking at something else got me down this rabbit hole, and I noticed mypy's subpar performance in these two cases. Short descriptions from before I did this, so may be tec...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameA5rocks
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/14238#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14238
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14238
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/14238
Reloadhttps://github.com/python/mypy/pull/14238
Reloadhttps://github.com/python/mypy/pull/14238
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
A5rocks:typeguard-ocdhttps://github.com/A5rocks/mypy/tree/typeguard-ocd
Conversationhttps://github.com/python/mypy/pull/14238
Commits9 (9)https://github.com/python/mypy/pull/14238/commits
Checkshttps://github.com/python/mypy/pull/14238/checks
Files changedhttps://github.com/python/mypy/pull/14238/files
More helpful type guardshttps://github.com/python/mypy/pull/14238#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
A5rocks:typeguard-ocdhttps://github.com/A5rocks/mypy/tree/typeguard-ocd
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Dec 3, 2022https://github.com/python/mypy/pull/14238#issue-1473779852
Please reload this pagehttps://github.com/python/mypy/pull/14238
#13199https://github.com/python/mypy/issues/13199
#14425https://github.com/python/mypy/issues/14425
Please reload this pagehttps://github.com/python/mypy/pull/14238
A5rockshttps://github.com/A5rocks
December 3, 2022 13:49https://github.com/python/mypy/pull/14238#commits-pushed-a29a6ec
https://github.com/A5rocks
The specification requires positional argumentshttps://github.com/python/mypy/pull/14238/commits/a29a6ec49add9c1849853fb3d12551f00a3bc5d6
a29a6echttps://github.com/python/mypy/pull/14238/commits/a29a6ec49add9c1849853fb3d12551f00a3bc5d6
https://github.com/A5rocks
Start allowing keyword arguments to type guardshttps://github.com/python/mypy/pull/14238/commits/3dda329c1665f2c662770b88077e21dbe3e21281
3dda329https://github.com/python/mypy/pull/14238/commits/3dda329c1665f2c662770b88077e21dbe3e21281
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14238
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Dec 3, 2022https://github.com/python/mypy/pull/14238#issuecomment-1336094734
https://peps.python.org/pep-0647/#narrowing-of-implicit-self-and-cls-parametershttps://peps.python.org/pep-0647/#narrowing-of-implicit-self-and-cls-parameters
Please reload this pagehttps://github.com/python/mypy/pull/14238
https://github.com/A5rocks
Special case staticmethodhttps://github.com/python/mypy/pull/14238/commits/10c7e3fbb7ac894f2427369567b195d32138ac76
10c7e3fhttps://github.com/python/mypy/pull/14238/commits/10c7e3fbb7ac894f2427369567b195d32138ac76
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14238
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Dec 4, 2022 https://github.com/python/mypy/pull/14238#pullrequestreview-1203686914
View reviewed changes https://github.com/python/mypy/pull/14238/files/10c7e3fbb7ac894f2427369567b195d32138ac76
sobolevnhttps://github.com/sobolevn
https://github.com/python/mypy/pull/14238#pullrequestreview-1203686914
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14238
mypy/checker.pyhttps://github.com/python/mypy/pull/14238/files/10c7e3fbb7ac894f2427369567b195d32138ac76#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/14238
mypy/checker.pyhttps://github.com/python/mypy/pull/14238/files/10c7e3fbb7ac894f2427369567b195d32138ac76#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/14238
mypy/semanal.pyhttps://github.com/python/mypy/pull/14238/files/10c7e3fbb7ac894f2427369567b195d32138ac76#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
Please reload this pagehttps://github.com/python/mypy/pull/14238
https://github.com/A5rocks
PR reviewhttps://github.com/python/mypy/pull/14238/commits/3ea4baf3c1ee4de5c4fecc872e36ab35e585cf89
3ea4bafhttps://github.com/python/mypy/pull/14238/commits/3ea4baf3c1ee4de5c4fecc872e36ab35e585cf89
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
sobolevnhttps://github.com/sobolevn
December 5, 2022 14:08https://github.com/python/mypy/pull/14238#event-7955319057
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14238
https://github.com/A5rocks
Fix testshttps://github.com/python/mypy/pull/14238/commits/9c9a791ac89bd6aecd2f42972e7fc27155828375
9c9a791https://github.com/python/mypy/pull/14238/commits/9c9a791ac89bd6aecd2f42972e7fc27155828375
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14238
https://github.com/A5rocks
Small test fixeshttps://github.com/python/mypy/pull/14238/commits/43adc46dc81a39d59dd8fb197c77b4d085220fa2
43adc46https://github.com/python/mypy/pull/14238/commits/43adc46dc81a39d59dd8fb197c77b4d085220fa2
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14238
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Dec 10, 2022https://github.com/python/mypy/pull/14238#issuecomment-1345154574
#14273https://github.com/python/mypy/issues/14273
Please reload this pagehttps://github.com/python/mypy/pull/14238
https://github.com/A5rocks
Merge branch 'master' into typeguard-ocdhttps://github.com/python/mypy/pull/14238/commits/58af039bf31d653632f52a10699be4dfa451c338
58af039https://github.com/python/mypy/pull/14238/commits/58af039bf31d653632f52a10699be4dfa451c338
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14238
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Dec 10, 2022 https://github.com/python/mypy/pull/14238#pullrequestreview-1212469289
View reviewed changes https://github.com/python/mypy/pull/14238/files/58af039bf31d653632f52a10699be4dfa451c338
test-data/unit/check-typeguard.testhttps://github.com/python/mypy/pull/14238/files/9c9a791ac89bd6aecd2f42972e7fc27155828375..43adc46dc81a39d59dd8fb197c77b4d085220fa2#diff-ad4f23953abd6459e54da402b4ee3f0c62562fe8a606fb0f73fa57ebb196e3d1
Please reload this pagehttps://github.com/python/mypy/pull/14238
https://github.com/A5rocks
Move Python 3.8 tests to check-python38https://github.com/python/mypy/pull/14238/commits/c6f55d194af849ef9920d5bbe72fb81b274d7d77
c6f55d1https://github.com/python/mypy/pull/14238/commits/c6f55d194af849ef9920d5bbe72fb81b274d7d77
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
sobolevnhttps://github.com/sobolevn
December 11, 2022 06:33https://github.com/python/mypy/pull/14238#event-8006748014
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14238
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Dec 11, 2022https://github.com/python/mypy/pull/14238#issuecomment-1345476685
Please reload this pagehttps://github.com/python/mypy/pull/14238
Please reload this pagehttps://github.com/python/mypy/pull/14238
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Dec 11, 2022https://github.com/python/mypy/pull/14238#issuecomment-1345478715
Please reload this pagehttps://github.com/python/mypy/pull/14238
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
topic-typeguard-typeis https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-typeguard-typeis
Dec 11, 2022https://github.com/python/mypy/pull/14238#event-8008915581
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Jan 12, 2023https://github.com/python/mypy/pull/14238#issuecomment-1379833808
Please reload this pagehttps://github.com/python/mypy/pull/14238
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
upnext https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext
Jan 12, 2023https://github.com/python/mypy/pull/14238#event-8207943789
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 26, 2023 https://github.com/python/mypy/pull/14238#ref-issue-1377755941
Release 1.0 planning #13685 https://github.com/python/mypy/issues/13685
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 31, 2023 https://github.com/python/mypy/pull/14238#pullrequestreview-1276527832
View reviewed changes https://github.com/python/mypy/pull/14238/files/c6f55d194af849ef9920d5bbe72fb81b274d7d77
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/mypy/pull/14238#pullrequestreview-1276527832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14238
test-data/unit/check-typeguard.testhttps://github.com/python/mypy/pull/14238/files/c6f55d194af849ef9920d5bbe72fb81b274d7d77#diff-ad4f23953abd6459e54da402b4ee3f0c62562fe8a606fb0f73fa57ebb196e3d1
hauntsaninjahttps://github.com/hauntsaninja
Jan 31, 2023https://github.com/python/mypy/pull/14238#discussion_r1091482936
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14238
https://github.com/hauntsaninja
Merge branch 'master' into typeguard-ocdhttps://github.com/python/mypy/pull/14238/commits/e7265c44a021fa84686e3b95cfeb93caf700c9cc
e7265c4https://github.com/python/mypy/pull/14238/commits/e7265c44a021fa84686e3b95cfeb93caf700c9cc
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 31, 2023https://github.com/python/mypy/pull/14238#issuecomment-1409828838
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/14238
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 31, 2023https://github.com/python/mypy/pull/14238#issuecomment-1409873711
Please reload this pagehttps://github.com/python/mypy/pull/14238
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
28c67cbhttps://github.com/python/mypy/commit/28c67cbeb09a14865ccc17cc1d13debcdf744940
Jan 31, 2023https://github.com/python/mypy/pull/14238#event-8396177572
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 31, 2023 https://github.com/python/mypy/pull/14238#ref-issue-1563791928
New "Must not defer during final iteration" crash #14565 https://github.com/python/mypy/issues/14565
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Mar 24, 2023 https://github.com/python/mypy/pull/14238#ref-pullrequest-1638613619
Don't accidentally ignore typeguard validity for staticmethods #14953 https://github.com/python/mypy/pull/14953
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
March 24, 2023 02:24https://github.com/python/mypy/pull/14238#event-8834101484
hauntsaninjahttps://github.com/hauntsaninja
Mar 26, 2023 https://github.com/python/mypy/pull/14238#ref-commit-c170056
https://github.com/A5rocks
Check typeguard validity for staticmethods (https://github.com/python/mypy/commit/c170056213e10dc58e260e319fb714987f94abf2
#14953https://github.com/python/mypy/pull/14953
)https://github.com/python/mypy/commit/c170056213e10dc58e260e319fb714987f94abf2
c170056https://github.com/python/mypy/commit/c170056213e10dc58e260e319fb714987f94abf2
#14238https://github.com/python/mypy/pull/14238
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14238
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/14238/files/c6f55d194af849ef9920d5bbe72fb81b274d7d77
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
Please reload this pagehttps://github.com/python/mypy/pull/14238
topic-typeguard-typeis https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-typeguard-typeis
upnext https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext
no error when no argument in TypeGuard function https://github.com/python/mypy/issues/13199
Please reload this pagehttps://github.com/python/mypy/pull/14238
https://github.com/A5rocks
https://github.com/sobolevn
https://github.com/hauntsaninja
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.