| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3fed2856-d0e9-526d-b05d-11678a129fa5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A87A:11BB24:224196C:2E82EEF:6B0023D9 |
| html-safe-nonce | cf240f3e6dae46c6b8797eb20b719ed401f4cec386b93c1dfd453c1c35553b47 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODdBOjExQkIyNDoyMjQxOTZDOjJFODJFRUY6NkIwMDIzRDkiLCJ2aXNpdG9yX2lkIjoiNTczNTc2NTgxODcwOTM4NjIwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 678296465569103d7a5f6f0d6fba4f38ee94a3902c1ac4f11d9948b95d8ad36f |
| hovercard-subject-tag | pull_request:1136759432 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/14203/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/53db6f5442a0f697dcf96e5dec1b12388129de95704065c333207f0d09ed6d12/python/mypy/pull/14203 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/53db6f5442a0f697dcf96e5dec1b12388129de95704065c333207f0d09ed6d12/python/mypy/pull/14203 |
| og:image:alt | Previously, we would ignore any class definitions and would fail to detect undefined classes and functions. This updates the logic to handle them.
Closes #686 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilinum |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/14203#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14203 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14203 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/14203 |
| Reload | https://github.com/python/mypy/pull/14203 |
| Reload | https://github.com/python/mypy/pull/14203 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilinum | https://github.com/ilinum |
| python:master | https://github.com/python/mypy/tree/master |
| ilinum:partial/classdefs | https://github.com/ilinum/mypy/tree/partial/classdefs |
| Conversation | https://github.com/python/mypy/pull/14203 |
| Commits5 (5) | https://github.com/python/mypy/pull/14203/commits |
| Checks | https://github.com/python/mypy/pull/14203/checks |
| Files changed | https://github.com/python/mypy/pull/14203/files |
| [use before def] handle class and function definitions | https://github.com/python/mypy/pull/14203#top |
| ilinum | https://github.com/ilinum |
| python:master | https://github.com/python/mypy/tree/master |
| ilinum:partial/classdefs | https://github.com/ilinum/mypy/tree/partial/classdefs |
|
| https://github.com/ilinum |
| ilinum | https://github.com/ilinum |
| Nov 27, 2022 | https://github.com/python/mypy/pull/14203#issue-1465526528 |
| Please reload this page | https://github.com/python/mypy/pull/14203 |
| #686 | https://github.com/python/mypy/issues/686 |
| Please reload this page | https://github.com/python/mypy/pull/14203 |
|
| https://github.com/ilinum |
| [partially defined] handle class definitions | https://github.com/python/mypy/pull/14203/commits/0b8ffe36756935344ca29cdeb747940da5d6641e |
| 0b8ffe3 | https://github.com/python/mypy/pull/14203/commits/0b8ffe36756935344ca29cdeb747940da5d6641e |
| https://github.com/ilinum |
| ilinum | https://github.com/ilinum |
| Nov 27, 2022 | https://github.com/python/mypy/pull/14203#event-7897947250 |
|
| https://github.com/ilinum |
| handle functions | https://github.com/python/mypy/pull/14203/commits/82c8c9b0046d6dc5f99897ba62aa2e4f31e800b0 |
| 82c8c9b | https://github.com/python/mypy/pull/14203/commits/82c8c9b0046d6dc5f99897ba62aa2e4f31e800b0 |
| https://github.com/ilinum |
| ilinum | https://github.com/ilinum |
| force-pushed | https://github.com/python/mypy/compare/3c5d21e3fc44b0a385f79020c4e3aac6f28e27f0..82c8c9b0046d6dc5f99897ba62aa2e4f31e800b0 |
| 3c5d21e | https://github.com/python/mypy/commit/3c5d21e3fc44b0a385f79020c4e3aac6f28e27f0 |
| 82c8c9b | https://github.com/python/mypy/commit/82c8c9b0046d6dc5f99897ba62aa2e4f31e800b0 |
|
Compare
| https://github.com/python/mypy/compare/3c5d21e3fc44b0a385f79020c4e3aac6f28e27f0..82c8c9b0046d6dc5f99897ba62aa2e4f31e800b0 |
| November 27, 2022 17:59 | https://github.com/python/mypy/pull/14203#event-7897949268 |
| https://github.com/ilinum |
| ilinum | https://github.com/ilinum |
|
Nov 27, 2022
| https://github.com/python/mypy/pull/14203#ref-issue-77514336 |
|
References to names before they're bound should generate an error (UnboundLocalError)
#686
| https://github.com/python/mypy/issues/686 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14203 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Nov 27, 2022
| https://github.com/python/mypy/pull/14203#pullrequestreview-1195044937 |
|
View reviewed changes
| https://github.com/python/mypy/pull/14203/files/82c8c9b0046d6dc5f99897ba62aa2e4f31e800b0 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/14203#pullrequestreview-1195044937 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/14203 |
| mypy/partially_defined.py | https://github.com/python/mypy/pull/14203/files/82c8c9b0046d6dc5f99897ba62aa2e4f31e800b0#diff-82dc339999c38bace1a680cbfe27d5611f13eddd2d46899cc0683f32d44b3f6e |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Nov 27, 2022 | https://github.com/python/mypy/pull/14203#discussion_r1032997186 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/14203 |
| ilinum | https://github.com/ilinum |
| Nov 29, 2022 | https://github.com/python/mypy/pull/14203#discussion_r1034174242 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/14203 |
| test-data/unit/check-partially-defined.test | https://github.com/python/mypy/pull/14203/files/82c8c9b0046d6dc5f99897ba62aa2e4f31e800b0#diff-b54d7f9dc61884e7099f0853c7b45497fd6ab9bcbdae6ecb5884d2b7d27bc228 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Nov 27, 2022 | https://github.com/python/mypy/pull/14203#discussion_r1032997611 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/14203 |
| ilinum | https://github.com/ilinum |
| Nov 29, 2022 | https://github.com/python/mypy/pull/14203#discussion_r1034174258 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/14203 |
| ilinum | https://github.com/ilinum |
| November 28, 2022 17:53 | https://github.com/python/mypy/pull/14203#commits-pushed-d406a16 |
|
| https://github.com/ilinum |
| Merge branch 'master' into partial/classdefs | https://github.com/python/mypy/pull/14203/commits/d406a1604383a1470555d1358228f521b4859a92 |
| d406a16 | https://github.com/python/mypy/pull/14203/commits/d406a1604383a1470555d1358228f521b4859a92 |
|
| https://github.com/ilinum |
| enter and exit on class scope | https://github.com/python/mypy/pull/14203/commits/cf64b649aa2ca2d184c1150994fa51cb04d1d07a |
| cf64b64 | https://github.com/python/mypy/pull/14203/commits/cf64b649aa2ca2d184c1150994fa51cb04d1d07a |
|
| https://github.com/ilinum |
| More tests | https://github.com/python/mypy/pull/14203/commits/67099bb8b2f89ccef2a326dd2a6761cea0b42874 |
| 67099bb | https://github.com/python/mypy/pull/14203/commits/67099bb8b2f89ccef2a326dd2a6761cea0b42874 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 29, 2022 | https://github.com/python/mypy/pull/14203#issuecomment-1329924084 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/14203 |
| https://github.com/ilinum |
| ilinum | https://github.com/ilinum |
| d094c38 | https://github.com/python/mypy/commit/d094c381277b7bec3c3b9956a53395e989347112 |
| Nov 29, 2022 | https://github.com/python/mypy/pull/14203#event-7908014315 |
| https://github.com/ilinum |
| ilinum | https://github.com/ilinum |
| November 29, 2022 01:00 | https://github.com/python/mypy/pull/14203#event-7908014588 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14203 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/14203/files/82c8c9b0046d6dc5f99897ba62aa2e4f31e800b0 |
| Please reload this page | https://github.com/python/mypy/pull/14203 |
|
References to names before they're bound should generate an error (UnboundLocalError)
| https://github.com/python/mypy/issues/686 |
| Please reload this page | https://github.com/python/mypy/pull/14203 |
|
| https://github.com/ilinum |
|
| https://github.com/ilevkivskyi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |