René's URL Explorer Experiment


Title: Try empty context when assigning to union typed variables by ilevkivskyi · Pull Request #14151 · python/mypy · GitHub

Open Graph Title: Try empty context when assigning to union typed variables by ilevkivskyi · Pull Request #14151 · python/mypy

X Title: Try empty context when assigning to union typed variables by ilevkivskyi · Pull Request #14151 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #4805 Fixes #13936 It is known that mypy can overuse outer type context sometimes (especially when it is a union). This prevents a common use case for narrowing types (see issue and test case...

X Description: Fixes #4805 Fixes #13936 It is known that mypy can overuse outer type context sometimes (especially when it is a union). This prevents a common use case for narrowing types (see issue and test case...

Opengraph URL: https://github.com/python/mypy/pull/14151

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fc9d916c-a69d-51c9-69ea-5ec55891d5a8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE132:1A7566:6AE14A:8F0581:6B003749
html-safe-nonceb05cd47a9198b634768f1c748bfff63ad67e3871bc05714461efe7dea2c76e45
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTMyOjFBNzU2Njo2QUUxNEE6OEYwNTgxOjZCMDAzNzQ5IiwidmlzaXRvcl9pZCI6IjExNTExNzY3MDkyNzQ0Nzg4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca94cc90c3f2e217cbb6fc1a72715fd5bd849fc23a8af14ed7d4392685b7abc93
hovercard-subject-tagpull_request:1128833334
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/14151/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f9a50220311e67134961064a537a1903e06d1da30afb8fd0dcc40c5cfa1cf3ee/python/mypy/pull/14151
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f9a50220311e67134961064a537a1903e06d1da30afb8fd0dcc40c5cfa1cf3ee/python/mypy/pull/14151
og:image:altFixes #4805 Fixes #13936 It is known that mypy can overuse outer type context sometimes (especially when it is a union). This prevents a common use case for narrowing types (see issue and test case...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/14151#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14151
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14151
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/14151
Reloadhttps://github.com/python/mypy/pull/14151
Reloadhttps://github.com/python/mypy/pull/14151
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:union-empty-contexthttps://github.com/ilevkivskyi/mypy/tree/union-empty-context
Conversationhttps://github.com/python/mypy/pull/14151
Commits5 (5)https://github.com/python/mypy/pull/14151/commits
Checkshttps://github.com/python/mypy/pull/14151/checks
Files changedhttps://github.com/python/mypy/pull/14151/files
Try empty context when assigning to union typed variableshttps://github.com/python/mypy/pull/14151#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:union-empty-contexthttps://github.com/ilevkivskyi/mypy/tree/union-empty-context
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 19, 2022https://github.com/python/mypy/pull/14151#issue-1456525117
Please reload this pagehttps://github.com/python/mypy/pull/14151
#4805https://github.com/python/mypy/issues/4805
#13936https://github.com/python/mypy/issues/13936
Please reload this pagehttps://github.com/python/mypy/pull/14151
https://github.com/ilevkivskyi
Try empty context when assigning to union typed variableshttps://github.com/python/mypy/pull/14151/commits/c8164dc8667702ed104e7064b231ec790571385b
c8164dchttps://github.com/python/mypy/pull/14151/commits/c8164dc8667702ed104e7064b231ec790571385b
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
hauntsaninjahttps://github.com/hauntsaninja
November 19, 2022 14:56https://github.com/python/mypy/pull/14151#event-7849772281
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14151
https://github.com/ilevkivskyi
Be more carefulhttps://github.com/python/mypy/pull/14151/commits/3c3b7594313652efa5ae83f17ecf811483c8cc1d
3c3b759https://github.com/python/mypy/pull/14151/commits/3c3b7594313652efa5ae83f17ecf811483c8cc1d
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Nov 19, 2022https://github.com/python/mypy/pull/14151#issuecomment-1320934273
#13936https://github.com/python/mypy/issues/13936
Please reload this pagehttps://github.com/python/mypy/pull/14151
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14151
https://github.com/ilevkivskyi
Handle one more edge casehttps://github.com/python/mypy/pull/14151/commits/05f849c2ed499e3df186dc1a58afe3a7ed2aa4ac
05f849chttps://github.com/python/mypy/pull/14151/commits/05f849c2ed499e3df186dc1a58afe3a7ed2aa4ac
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14151
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 19, 2022https://github.com/python/mypy/pull/14151#issuecomment-1320952981
Please reload this pagehttps://github.com/python/mypy/pull/14151
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Nov 20, 2022 https://github.com/python/mypy/pull/14151#pullrequestreview-1187141993
View reviewed changes https://github.com/python/mypy/pull/14151/files/05f849c2ed499e3df186dc1a58afe3a7ed2aa4ac
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/mypy/pull/14151#pullrequestreview-1187141993
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14151
mypy/checker.pyhttps://github.com/python/mypy/pull/14151/files/05f849c2ed499e3df186dc1a58afe3a7ed2aa4ac#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/14151
https://github.com/ilevkivskyi
Address CR (perf)https://github.com/python/mypy/pull/14151/commits/a6c67d32a2675cd6e0a1bcf4b71c2dc3fd547f72
a6c67d3https://github.com/python/mypy/pull/14151/commits/a6c67d32a2675cd6e0a1bcf4b71c2dc3fd547f72
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
hauntsaninjahttps://github.com/hauntsaninja
November 21, 2022 15:12https://github.com/python/mypy/pull/14151#event-7858417666
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14151
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Nov 21, 2022 https://github.com/python/mypy/pull/14151#pullrequestreview-1188575687
View reviewed changes https://github.com/python/mypy/pull/14151/files/a6c67d32a2675cd6e0a1bcf4b71c2dc3fd547f72
mypy/checker.pyhttps://github.com/python/mypy/pull/14151/files/a6c67d32a2675cd6e0a1bcf4b71c2dc3fd547f72#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
JukkaLhttps://github.com/JukkaL
Nov 21, 2022https://github.com/python/mypy/pull/14151#discussion_r1028270849
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14151
ilevkivskyihttps://github.com/ilevkivskyi
Nov 21, 2022https://github.com/python/mypy/pull/14151#discussion_r1028281851
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/14151
https://github.com/ilevkivskyi
Some perf optimizationhttps://github.com/python/mypy/pull/14151/commits/233d0dcbbea7995f48f4669efecb6d115604937a
233d0dchttps://github.com/python/mypy/pull/14151/commits/233d0dcbbea7995f48f4669efecb6d115604937a
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 21, 2022https://github.com/python/mypy/pull/14151#issuecomment-1322574579
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/14151
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 21, 2022https://github.com/python/mypy/pull/14151#issuecomment-1322684706
Please reload this pagehttps://github.com/python/mypy/pull/14151
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
b83ac9chttps://github.com/python/mypy/commit/b83ac9cff3d38f868e45e4c4b011cbd2fdd37fc3
Nov 22, 2022https://github.com/python/mypy/pull/14151#event-7869666601
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
November 22, 2022 16:28https://github.com/python/mypy/pull/14151#event-7869667139
Type is not infered from default value of dict.get() #10890 https://github.com/python/mypy/issues/10890
Narrowing str | dict[str, str] with isinstance and .get() #13351 https://github.com/python/mypy/issues/13351
https://github.com/ichard26
ichard26https://github.com/ichard26
Aug 21, 2023 https://github.com/python/mypy/pull/14151#ref-issue-1026745466
mypy deduces type as Optional after dict.get(x, x) #11337 https://github.com/python/mypy/issues/11337
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Aug 24, 2023 https://github.com/python/mypy/pull/14151#ref-issue-687838617
Variable loses type inference after passing through dictionary of known type #9369 https://github.com/python/mypy/issues/9369
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 1, 2023 https://github.com/python/mypy/pull/14151#ref-issue-1943636996
Type inference for max() "tainted" by default #16267 https://github.com/python/mypy/issues/16267
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14151
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/14151/files/a6c67d32a2675cd6e0a1bcf4b71c2dc3fd547f72
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
Please reload this pagehttps://github.com/python/mypy/pull/14151
Type narrowing failure inside AsyncExitStack blocks https://github.com/python/mypy/issues/13936
mypy not inferring that variable cannot be None after assignment from dict.get https://github.com/python/mypy/issues/4805
Please reload this pagehttps://github.com/python/mypy/pull/14151
https://github.com/ilevkivskyi
https://github.com/AlexWaygood
https://github.com/JukkaL
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.