| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fa877bcb-5c41-f1bf-303c-7387c1c1a7ee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 981A:137B3:1A83A98:22FCF79:6B002FDC |
| html-safe-nonce | bbed1d5db21cfd30ec11af2110ccdbfc08dcdf4d6e8948a7eb5b761d8c27113c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODFBOjEzN0IzOjFBODNBOTg6MjJGQ0Y3OTo2QjAwMkZEQyIsInZpc2l0b3JfaWQiOiIyNjQ3MDE4ODUzNDcyNjc3ODUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8b0ed64de30724e783663c8f279a9aa8646db5a484c2179837643f8540296c10 |
| hovercard-subject-tag | pull_request:1123451574 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/14104/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d6235ec99f3b851d493b38a12e3151b0e159abf6814b8fe8e0a08ee36ce4010a/python/mypy/pull/14104 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d6235ec99f3b851d493b38a12e3151b0e159abf6814b8fe8e0a08ee36ce4010a/python/mypy/pull/14104 |
| og:image:alt | Fixes #12744
The fix is straightforward. Current logic can produce a random mix of old and new nodes if there are functions/methods nested in other statements. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/14104#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14104 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14104 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/14104 |
| Reload | https://github.com/python/mypy/pull/14104 |
| Reload | https://github.com/python/mypy/pull/14104 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:fix-daemon-crash | https://github.com/ilevkivskyi/mypy/tree/fix-daemon-crash |
| Conversation | https://github.com/python/mypy/pull/14104 |
| Commits3 (3) | https://github.com/python/mypy/pull/14104/commits |
| Checks | https://github.com/python/mypy/pull/14104/checks |
| Files changed | https://github.com/python/mypy/pull/14104/files |
| Correctly process nested definitions in astmerge | https://github.com/python/mypy/pull/14104#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:fix-daemon-crash | https://github.com/ilevkivskyi/mypy/tree/fix-daemon-crash |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Nov 15, 2022 | https://github.com/python/mypy/pull/14104#issue-1450434152 |
| #12744 | https://github.com/python/mypy/issues/12744 |
| Please reload this page | https://github.com/python/mypy/pull/14104 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| November 15, 2022 21:56 | https://github.com/python/mypy/pull/14104#commits-pushed-641b4cb |
|
| https://github.com/ilevkivskyi |
| Correctly process nested definitions in astmerge | https://github.com/python/mypy/pull/14104/commits/641b4cb2c666d13d528063f35a9d25c81e5a2777 |
| 641b4cb | https://github.com/python/mypy/pull/14104/commits/641b4cb2c666d13d528063f35a9d25c81e5a2777 |
|
| https://github.com/ilevkivskyi |
| Clean up test | https://github.com/python/mypy/pull/14104/commits/d7b8bb6c2111c33090b58e873ce002b0ad25c8bb |
| d7b8bb6 | https://github.com/python/mypy/pull/14104/commits/d7b8bb6c2111c33090b58e873ce002b0ad25c8bb |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| JukkaL | https://github.com/JukkaL |
| Michael0x2a | https://github.com/Michael0x2a |
| hauntsaninja | https://github.com/hauntsaninja |
| November 15, 2022 22:00 | https://github.com/python/mypy/pull/14104#event-7817886141 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Nov 15, 2022
| https://github.com/python/mypy/pull/14104#pullrequestreview-1181613344 |
|
View reviewed changes
| https://github.com/python/mypy/pull/14104/files/d7b8bb6c2111c33090b58e873ce002b0ad25c8bb |
|
| https://github.com/ilevkivskyi |
| Merge branch 'master' into fix-daemon-crash | https://github.com/python/mypy/pull/14104/commits/e4861e0602885e6b14cfa831fbb5ab69cd694a11 |
| e4861e0 | https://github.com/python/mypy/pull/14104/commits/e4861e0602885e6b14cfa831fbb5ab69cd694a11 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 15, 2022 | https://github.com/python/mypy/pull/14104#issuecomment-1315969499 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/14104 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 0d2a954 | https://github.com/python/mypy/commit/0d2a954a20f239cde5f958b3e757ee4daab0d8b0 |
| Nov 15, 2022 | https://github.com/python/mypy/pull/14104#event-7818209851 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| November 15, 2022 22:55 | https://github.com/python/mypy/pull/14104#event-7818210186 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F14104 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/14104/files/d7b8bb6c2111c33090b58e873ce002b0ad25c8bb |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/Michael0x2a |
|
Michael0x2a
| https://github.com/Michael0x2a |
| Please reload this page | https://github.com/python/mypy/pull/14104 |
|
dmypy: ValueError: value is not in list when running a second time
| https://github.com/python/mypy/issues/12744 |
| Please reload this page | https://github.com/python/mypy/pull/14104 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |