| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dba20f78-9267-46d0-5daf-7fdfdc7dfaa0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C058:5314B:2874DBF:3507A89:6B000A38 |
| html-safe-nonce | 59c6e063bc2b96c06046f2e684238534221cf2cc0e31e8d7e73cb89cb01fcdda |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDU4OjUzMTRCOjI4NzREQkY6MzUwN0E4OTo2QjAwMEEzOCIsInZpc2l0b3JfaWQiOiI0NTg0NDU4NzIzNTg5NjIyMzI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f150cc3f15f8316b1fe329e06f14f3df2d957ae99390580c497386062b8986f6 |
| hovercard-subject-tag | pull_request:1081320516 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/13851/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a2a5a2ca7ec3d7ab96009f455345924f3734b0e546952cb292f27941beb960c9/python/mypy/pull/13851 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a2a5a2ca7ec3d7ab96009f455345924f3734b0e546952cb292f27941beb960c9/python/mypy/pull/13851 |
| og:image:alt | Closes #3948
This however gives a note instead of an error, so that type checking result will be success. I also added an error code for the note so that people can opt-out if they want to. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/13851#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13851 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13851 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/13851 |
| Reload | https://github.com/python/mypy/pull/13851 |
| Reload | https://github.com/python/mypy/pull/13851 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:annot-note | https://github.com/ilevkivskyi/mypy/tree/annot-note |
| Conversation | https://github.com/python/mypy/pull/13851 |
| Commits1 (1) | https://github.com/python/mypy/pull/13851/commits |
| Checks | https://github.com/python/mypy/pull/13851/checks |
| Files changed | https://github.com/python/mypy/pull/13851/files |
| Add a note on variable annotation within unchecked function | https://github.com/python/mypy/pull/13851#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:annot-note | https://github.com/ilevkivskyi/mypy/tree/annot-note |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 9, 2022 | https://github.com/python/mypy/pull/13851#issue-1402339744 |
| #3948 | https://github.com/python/mypy/issues/3948 |
| Please reload this page | https://github.com/python/mypy/pull/13851 |
|
| https://github.com/ilevkivskyi |
| Add a note on variable annotation within unchecked function | https://github.com/python/mypy/pull/13851/commits/b14b5ea3dc98be91633a95ad8900032c7848217a |
| b14b5ea | https://github.com/python/mypy/pull/13851/commits/b14b5ea3dc98be91633a95ad8900032c7848217a |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| AlexWaygood | https://github.com/AlexWaygood |
| JukkaL | https://github.com/JukkaL |
| hauntsaninja | https://github.com/hauntsaninja |
| October 9, 2022 17:19 | https://github.com/python/mypy/pull/13851#event-7549677591 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 9, 2022 | https://github.com/python/mypy/pull/13851#issuecomment-1272594060 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/13851 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 9, 2022 | https://github.com/python/mypy/pull/13851#issuecomment-1272599595 |
| Please reload this page | https://github.com/python/mypy/pull/13851 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Oct 9, 2022
| https://github.com/python/mypy/pull/13851#pullrequestreview-1135386770 |
|
View reviewed changes
| https://github.com/python/mypy/pull/13851/files/b14b5ea3dc98be91633a95ad8900032c7848217a |
| AlexWaygood | https://github.com/AlexWaygood |
| Please reload this page | https://github.com/python/mypy/pull/13851 |
| https://github.com/python/mypy/pull/13851#pullrequestreview-1135386770 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/13851 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Oct 9, 2022
| https://github.com/python/mypy/pull/13851#pullrequestreview-1135402215 |
|
View reviewed changes
| https://github.com/python/mypy/pull/13851/files/b14b5ea3dc98be91633a95ad8900032c7848217a |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| fe1e571 | https://github.com/python/mypy/commit/fe1e571fcc266639f1a8c7959918c1638ef64271 |
| Oct 9, 2022 | https://github.com/python/mypy/pull/13851#event-7550101888 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| October 9, 2022 23:48 | https://github.com/python/mypy/pull/13851#event-7550101954 |
| https://github.com/cdce8p |
| cdce8p | https://github.com/cdce8p |
| Oct 11, 2022 | https://github.com/python/mypy/pull/13851#issuecomment-1274345759 |
| Please reload this page | https://github.com/python/mypy/pull/13851 |
| mypy/mypy/main.py | https://github.com/python/mypy/blob/1eaf4c70c0b83c3f0f639e3c53daaf3872bea5b0/mypy/main.py#L112-L114 |
| 1eaf4c7 | https://github.com/python/mypy/commit/1eaf4c70c0b83c3f0f639e3c53daaf3872bea5b0 |
| Please reload this page | https://github.com/python/mypy/pull/13851 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 11, 2022 | https://github.com/python/mypy/pull/13851#issuecomment-1274519216 |
| Please reload this page | https://github.com/python/mypy/pull/13851 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Oct 11, 2022
| https://github.com/python/mypy/pull/13851#ref-issue-1405083111 |
|
Mypy 0.990 Release Planning
#13871
| https://github.com/python/mypy/issues/13871 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Oct 12, 2022
| https://github.com/python/mypy/pull/13851#ref-pullrequest-1406783508 |
|
Return 0 if there are only notes and no errors
#13879
| https://github.com/python/mypy/pull/13879 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 12, 2022 | https://github.com/python/mypy/pull/13851#issuecomment-1276713141 |
| @cdce8p | https://github.com/cdce8p |
| #13879 | https://github.com/python/mypy/pull/13879 |
| Please reload this page | https://github.com/python/mypy/pull/13851 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Oct 12, 2022
| https://github.com/python/mypy/pull/13851#ref-pullrequest-1406809347 |
|
Show error codes for some notes
#13880
| https://github.com/python/mypy/pull/13880 |
| JukkaL | https://github.com/JukkaL |
|
Oct 13, 2022
| https://github.com/python/mypy/pull/13851#ref-commit-9227bce |
|
| https://github.com/ilevkivskyi |
| Show error codes for some notes ( | https://github.com/python/mypy/commit/9227bceb629a1b566a60cbdd09fef6731f7bfcb1 |
| #13880 | https://github.com/python/mypy/pull/13880 |
| ) | https://github.com/python/mypy/commit/9227bceb629a1b566a60cbdd09fef6731f7bfcb1 |
| 9227bce | https://github.com/python/mypy/commit/9227bceb629a1b566a60cbdd09fef6731f7bfcb1 |
| #13851 | https://github.com/python/mypy/pull/13851 |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Oct 14, 2022
| https://github.com/python/mypy/pull/13851#ref-commit-201d116 |
|
| https://github.com/ilevkivskyi |
| Return 0 if there are only notes and no errors ( | https://github.com/python/mypy/commit/201d1161fc501dfa02463c99994b933ec71e7cb9 |
| #13879 | https://github.com/python/mypy/pull/13879 |
| ) | https://github.com/python/mypy/commit/201d1161fc501dfa02463c99994b933ec71e7cb9 |
| 201d116 | https://github.com/python/mypy/commit/201d1161fc501dfa02463c99994b933ec71e7cb9 |
| #10013 | https://github.com/python/mypy/issues/10013 |
| #13851 (comment) | https://github.com/python/mypy/pull/13851#issuecomment-1274345759 |
| https://github.com/mvashishtha |
| mvashishtha | https://github.com/mvashishtha |
|
Dec 2, 2022
| https://github.com/python/mypy/pull/13851#ref-issue-1473566869 |
|
TEST: Cap mypy at latest version for longer term fix to #5326
modin-project/modin#5327
| https://github.com/modin-project/modin/issues/5327 |
| https://github.com/Kilo59 |
| Kilo59 | https://github.com/Kilo59 |
|
Dec 15, 2022
| https://github.com/python/mypy/pull/13851#ref-pullrequest-1498595546 |
|
[MAINTENANCE] mypy config update
fivetran/great_expectations#6589
| https://github.com/fivetran/great_expectations/pull/6589 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13851 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/mypy/pull/13851/files/b14b5ea3dc98be91633a95ad8900032c7848217a |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/AlexWaygood |
|
AlexWaygood
| https://github.com/AlexWaygood |
|
| https://github.com/python/mypy/pull/13851/files/b14b5ea3dc98be91633a95ad8900032c7848217a |
| Please reload this page | https://github.com/python/mypy/pull/13851 |
|
Give an error if there is a variable annotation within a function but no signature
| https://github.com/python/mypy/issues/3948 |
| Please reload this page | https://github.com/python/mypy/pull/13851 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/cdce8p |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/AlexWaygood |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |