René's URL Explorer Experiment


Title: Fix module and protocol subtyping, module hasattr by hauntsaninja · Pull Request #13778 · python/mypy · GitHub

Open Graph Title: Fix module and protocol subtyping, module hasattr by hauntsaninja · Pull Request #13778 · python/mypy

X Title: Fix module and protocol subtyping, module hasattr by hauntsaninja · Pull Request #13778 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #13771 (comment)

X Description: Fixes #13771 (comment)

Opengraph URL: https://github.com/python/mypy/pull/13778

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5b6f5012-c5b8-20a2-baf8-40a4478f2923
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8D0:2463C6:36E6F0:49E8F9:6B00290F
html-safe-noncedf298d56d7433e1ffc2e9518e259e899f7d56be739ca9ec0c8dfe6f4a14744f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEQwOjI0NjNDNjozNkU2RjA6NDlFOEY5OjZCMDAyOTBGIiwidmlzaXRvcl9pZCI6IjgyMTQwODY0OTgyNTgwMDQyNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca75528d4c2f50389a1ccbf626135d31eceeddb41296015af2b72f11a764d0c9f
hovercard-subject-tagpull_request:1072170434
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/13778/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ed3f668dae25c5b9dcc3c9149cd8c2612244c1a49209286458413bd4227ae755/python/mypy/pull/13778
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ed3f668dae25c5b9dcc3c9149cd8c2612244c1a49209286458413bd4227ae755/python/mypy/pull/13778
og:image:altFixes #13771 (comment)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/13778#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13778
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13778
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/13778
Reloadhttps://github.com/python/mypy/pull/13778
Reloadhttps://github.com/python/mypy/pull/13778
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:moduletype-getattrhttps://github.com/hauntsaninja/mypy/tree/moduletype-getattr
Conversationhttps://github.com/python/mypy/pull/13778
Commits3 (3)https://github.com/python/mypy/pull/13778/commits
Checkshttps://github.com/python/mypy/pull/13778/checks
Files changedhttps://github.com/python/mypy/pull/13778/files
Fix module and protocol subtyping, module hasattrhttps://github.com/python/mypy/pull/13778#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:moduletype-getattrhttps://github.com/hauntsaninja/mypy/tree/moduletype-getattr
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Sep 30, 2022https://github.com/python/mypy/pull/13778#issue-1391827065
#13771 (comment)https://github.com/python/mypy/issues/13771#issuecomment-1262749908
Please reload this pagehttps://github.com/python/mypy/pull/13778
https://github.com/hauntsaninja
Fix module and protocol subtypinghttps://github.com/python/mypy/pull/13778/commits/b37c47955588d46fe94f10c0bdc1801317656b30
b37c479https://github.com/python/mypy/pull/13778/commits/b37c47955588d46fe94f10c0bdc1801317656b30
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13778
hauntsaninjahttps://github.com/hauntsaninja
September 29, 2022 22:46https://github.com/python/mypy/pull/13778#commits-pushed-4d38174
https://github.com/hauntsaninja
fix module hasattrhttps://github.com/python/mypy/pull/13778/commits/4d38174371923de2a7c793ff114c1b53fe3d4d64
4d38174https://github.com/python/mypy/pull/13778/commits/4d38174371923de2a7c793ff114c1b53fe3d4d64
https://github.com/hauntsaninja
random testshttps://github.com/python/mypy/pull/13778/commits/1a1f3a13b4e77d7b42641c791ddcc54b39bbb1e5
1a1f3a1https://github.com/python/mypy/pull/13778/commits/1a1f3a13b4e77d7b42641c791ddcc54b39bbb1e5
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
September 30, 2022 05:52https://github.com/python/mypy/pull/13778#event-7492307968
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Sep 30, 2022https://github.com/python/mypy/pull/13778#event-7492308495
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
ilevkivskyihttps://github.com/ilevkivskyi
September 30, 2022 05:52https://github.com/python/mypy/pull/13778#event-7492308749
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13778
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 30, 2022https://github.com/python/mypy/pull/13778#issuecomment-1263151107
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/13778
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 30, 2022 https://github.com/python/mypy/pull/13778#pullrequestreview-1126590640
View reviewed changes https://github.com/python/mypy/pull/13778/files/1a1f3a13b4e77d7b42641c791ddcc54b39bbb1e5
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/13778#pullrequestreview-1126590640
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/13778
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Oct 2, 2022 https://github.com/python/mypy/pull/13778#ref-issue-1391340396
modules as protocols doesn't type-check against the protocol #13771 https://github.com/python/mypy/issues/13771
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
34f5cechttps://github.com/python/mypy/commit/34f5cec15e4e58857098e07145b3f772fa57c314
Oct 2, 2022https://github.com/python/mypy/pull/13778#event-7502153265
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Oct 2, 2022 https://github.com/python/mypy/pull/13778#ref-issue-1336219147
Mypy 0.980 Release Planning #13385 https://github.com/python/mypy/issues/13385
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
October 2, 2022 17:40https://github.com/python/mypy/pull/13778#event-7502345079
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13778
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/13778/files/1a1f3a13b4e77d7b42641c791ddcc54b39bbb1e5
Please reload this pagehttps://github.com/python/mypy/pull/13778
modules as protocols doesn't type-check against the protocol https://github.com/python/mypy/issues/13771
Please reload this pagehttps://github.com/python/mypy/pull/13778
https://github.com/hauntsaninja
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.