René's URL Explorer Experiment


Title: Allow `@final` on `TypedDict` by godlygeek · Pull Request #13557 · python/mypy · GitHub

Open Graph Title: Allow `@final` on `TypedDict` by godlygeek · Pull Request #13557 · python/mypy

X Title: Allow `@final` on `TypedDict` by godlygeek · Pull Request #13557 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Allow a TypedDict to be decorated with @final. Like a regular class, mypy will emit an error if a final TypedDict is subclassed. Relates-to: #7981 Description Allow @final to be applied to a TypedD...

X Description: Allow a TypedDict to be decorated with @final. Like a regular class, mypy will emit an error if a final TypedDict is subclassed. Relates-to: #7981 Description Allow @final to be applied to a TypedD...

Opengraph URL: https://github.com/python/mypy/pull/13557

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1a4ef397-d924-fb97-a3a3-dcd47debfbba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB1A:2EC689:276D761:35A5C00:6B0042E0
html-safe-nonce97d818c78b6e3651bc83ef46ffad024cbb41d07bfce2e27bbef3cbcdf72e3bc7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjFBOjJFQzY4OToyNzZENzYxOjM1QTVDMDA6NkIwMDQyRTAiLCJ2aXNpdG9yX2lkIjoiNTk2NDkxODIwNjc0MDA1NDc1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac14dab6534abd314d85aebb9ca14b2197d2a7e77fed182e64f3e429799bebb16c
hovercard-subject-tagpull_request:1040562013
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/13557/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fcf0c7a394a0cb1cdbfd3376e53670fdbebbbce3a0536bf238d2dce39e6125cb/python/mypy/pull/13557
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fcf0c7a394a0cb1cdbfd3376e53670fdbebbbce3a0536bf238d2dce39e6125cb/python/mypy/pull/13557
og:image:altAllow a TypedDict to be decorated with @final. Like a regular class, mypy will emit an error if a final TypedDict is subclassed. Relates-to: #7981 Description Allow @final to be applied to a TypedD...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegodlygeek
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/13557#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13557
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13557
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/13557
Reloadhttps://github.com/python/mypy/pull/13557
Reloadhttps://github.com/python/mypy/pull/13557
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
godlygeek:final_typeddictshttps://github.com/godlygeek/mypy/tree/final_typeddicts
Conversationhttps://github.com/python/mypy/pull/13557
Commits2 (2)https://github.com/python/mypy/pull/13557/commits
Checkshttps://github.com/python/mypy/pull/13557/checks
Files changedhttps://github.com/python/mypy/pull/13557/files
Allow @final on TypedDicthttps://github.com/python/mypy/pull/13557#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
godlygeek:final_typeddictshttps://github.com/godlygeek/mypy/tree/final_typeddicts
https://github.com/godlygeek
godlygeekhttps://github.com/godlygeek
Aug 30, 2022https://github.com/python/mypy/pull/13557#issue-1355287128
#7981https://github.com/python/mypy/issues/7981
#7981https://github.com/python/mypy/issues/7981
#7981https://github.com/python/mypy/issues/7981
Please reload this pagehttps://github.com/python/mypy/pull/13557
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13557
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Aug 30, 2022 https://github.com/python/mypy/pull/13557#pullrequestreview-1090515081
View reviewed changes https://github.com/python/mypy/pull/13557/files
mypy/semanal.pyhttps://github.com/python/mypy/pull/13557/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
JelleZijlstrahttps://github.com/JelleZijlstra
Aug 30, 2022https://github.com/python/mypy/pull/13557#discussion_r958615754
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/13557
sobolevnhttps://github.com/sobolevn
Aug 30, 2022https://github.com/python/mypy/pull/13557#discussion_r958672177
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/13557
godlygeekhttps://github.com/godlygeek
Aug 30, 2022https://github.com/python/mypy/pull/13557#discussion_r958843454
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/13557
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Aug 30, 2022https://github.com/python/mypy/pull/13557#issuecomment-1231812334
Please reload this pagehttps://github.com/python/mypy/pull/13557
https://github.com/godlygeek
Allow @final on TypedDicthttps://github.com/python/mypy/pull/13557/commits/623a332de507ed7ff792f7f0121a6322e4fdc838
623a332https://github.com/python/mypy/pull/13557/commits/623a332de507ed7ff792f7f0121a6322e4fdc838
python#7981https://github.com/python/mypy/issues/7981
https://github.com/godlygeek
godlygeekhttps://github.com/godlygeek
force-pushedhttps://github.com/python/mypy/compare/3c0a1ed048a2c4788641db1752a44466135d771f..623a332de507ed7ff792f7f0121a6322e4fdc838
3c0a1edhttps://github.com/python/mypy/commit/3c0a1ed048a2c4788641db1752a44466135d771f
623a332https://github.com/python/mypy/commit/623a332de507ed7ff792f7f0121a6322e4fdc838
Compare https://github.com/python/mypy/compare/3c0a1ed048a2c4788641db1752a44466135d771f..623a332de507ed7ff792f7f0121a6322e4fdc838
August 30, 2022 19:07https://github.com/python/mypy/pull/13557#event-7290236230
https://github.com/godlygeek
godlygeekhttps://github.com/godlygeek
Aug 30, 2022https://github.com/python/mypy/pull/13557#issuecomment-1232058791
Please reload this pagehttps://github.com/python/mypy/pull/13557
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13557
https://github.com/godlygeek
godlygeekhttps://github.com/godlygeek
Aug 30, 2022https://github.com/python/mypy/pull/13557#issuecomment-1232101887
Please reload this pagehttps://github.com/python/mypy/pull/13557
judging by Exit status: -11https://github.com/python/mypy/runs/8099770249?check_suite_focus=true#step:8:353
Please reload this pagehttps://github.com/python/mypy/pull/13557
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Aug 31, 2022https://github.com/python/mypy/pull/13557#issuecomment-1233081493
Please reload this pagehttps://github.com/python/mypy/pull/13557
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Aug 31, 2022 https://github.com/python/mypy/pull/13557#ref-issue-1358021878
mypyc incremental failures on master #13572 https://github.com/python/mypy/issues/13572
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Sep 1, 2022 https://github.com/python/mypy/pull/13557#pullrequestreview-1093974436
View reviewed changes https://github.com/python/mypy/pull/13557/files/623a332de507ed7ff792f7f0121a6322e4fdc838
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/mypy/pull/13557#pullrequestreview-1093974436
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/13557
https://github.com/hauntsaninja
Merge branch 'master' into final_typeddictshttps://github.com/python/mypy/pull/13557/commits/88faf742bc679b342deb3a27f2ab1d63c81e982d
88faf74https://github.com/python/mypy/pull/13557/commits/88faf742bc679b342deb3a27f2ab1d63c81e982d
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 2, 2022https://github.com/python/mypy/pull/13557#issuecomment-1235977108
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/13557
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
4de0caahttps://github.com/python/mypy/commit/4de0caa3c2b30a18dcb9fc4d4f07ac65e6e201cd
Sep 8, 2022https://github.com/python/mypy/pull/13557#event-7343977914
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Oct 4, 2022 https://github.com/python/mypy/pull/13557#ref-issue-1395301189
"'field' in typed_dict_union" discrimination #13802 https://github.com/python/mypy/issues/13802
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Oct 19, 2022 https://github.com/python/mypy/pull/13557#ref-pullrequest-1401812276
'in' can narrow TypedDict unions #13838 https://github.com/python/mypy/pull/13838
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13557
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/mypy/pull/13557/files/3c0a1ed048a2c4788641db1752a44466135d771f
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/mypy/pull/13557/files/3c0a1ed048a2c4788641db1752a44466135d771f
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/13557/files/623a332de507ed7ff792f7f0121a6322e4fdc838
Please reload this pagehttps://github.com/python/mypy/pull/13557
Please reload this pagehttps://github.com/python/mypy/pull/13557
https://github.com/godlygeek
https://github.com/JelleZijlstra
https://github.com/sobolevn
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.