| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2a28f556-fbe5-3e13-1d77-556e4b3713bc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CCBA:34D604:1907CCE:21127EA:6B00291D |
| html-safe-nonce | 075ecbfe9f503f3f954d05e754c44056fa214a91705e4f2705932fa5403e576d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0JBOjM0RDYwNDoxOTA3Q0NFOjIxMTI3RUE6NkIwMDI5MUQiLCJ2aXNpdG9yX2lkIjoiODg5NTk4NTQzMzUwMzA4Mjc4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | aba4ee18604a0ccdc2715273d649c93adff302338ab7777bed39517b5010a3db |
| hovercard-subject-tag | pull_request:1037089663 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/13513/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/47f14ef8f9c0167512341c7c99cfd1a15b9ee0ba3a457dc7270bf4f56ebc4d32/python/mypy/pull/13513 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/47f14ef8f9c0167512341c7c99cfd1a15b9ee0ba3a457dc7270bf4f56ebc4d32/python/mypy/pull/13513 |
| og:image:alt | Fixes #5018
Fixes #5439
Fixes #10850
The implementation is simple but not the most beautiful one. I simply add a new slot to the Instance class that represents content of the module. This new attri... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/13513#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/13513 |
| Reload | https://github.com/python/mypy/pull/13513 |
| Reload | https://github.com/python/mypy/pull/13513 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:more-proto-impls-2 | https://github.com/ilevkivskyi/mypy/tree/more-proto-impls-2 |
| Conversation | https://github.com/python/mypy/pull/13513 |
| Commits12 (12) | https://github.com/python/mypy/pull/13513/commits |
| Checks | https://github.com/python/mypy/pull/13513/checks |
| Files changed | https://github.com/python/mypy/pull/13513/files |
| Allow using modules as subtypes of protocols | https://github.com/python/mypy/pull/13513#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:more-proto-impls-2 | https://github.com/ilevkivskyi/mypy/tree/more-proto-impls-2 |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 25, 2022 | https://github.com/python/mypy/pull/13513#issue-1351269421 |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| #5018 | https://github.com/python/mypy/issues/5018 |
| #5439 | https://github.com/python/mypy/issues/5439 |
| #10850 | https://github.com/python/mypy/issues/10850 |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| August 25, 2022 15:38 | https://github.com/python/mypy/pull/13513#commits-pushed-e82b6fd |
|
| https://github.com/ilevkivskyi |
| Allow modules as protocol implementations | https://github.com/python/mypy/pull/13513/commits/e82b6fdcb82e2b5936d8a22740829d2eed8aa035 |
| e82b6fd | https://github.com/python/mypy/pull/13513/commits/e82b6fdcb82e2b5936d8a22740829d2eed8aa035 |
|
| https://github.com/ilevkivskyi |
| Fix fine/incremental; better diagnostics | https://github.com/python/mypy/pull/13513/commits/978fa3264fb3f07557dad30f9dec275e413cc41e |
| 978fa32 | https://github.com/python/mypy/pull/13513/commits/978fa3264fb3f07557dad30f9dec275e413cc41e |
|
| https://github.com/ilevkivskyi |
| Merge remote-tracking branch 'upstream/master' into more-proto-impls-2 | https://github.com/python/mypy/pull/13513/commits/8373d241efef7538a29836e96a6698f19c89efae |
| 8373d24 | https://github.com/python/mypy/pull/13513/commits/8373d241efef7538a29836e96a6698f19c89efae |
|
| https://github.com/ilevkivskyi |
| Better module detection in messages | https://github.com/python/mypy/pull/13513/commits/3ce4a7370851681d98af6ceb9acb10ffc80073af |
| 3ce4a73 | https://github.com/python/mypy/pull/13513/commits/3ce4a7370851681d98af6ceb9acb10ffc80073af |
|
| https://github.com/ilevkivskyi |
| Fix self-check | https://github.com/python/mypy/pull/13513/commits/16fa7dc2e1662e88b45195b44128497ec6957877 |
| 16fa7dc | https://github.com/python/mypy/pull/13513/commits/16fa7dc2e1662e88b45195b44128497ec6957877 |
|
| https://github.com/ilevkivskyi |
| Show module names only for protocols | https://github.com/python/mypy/pull/13513/commits/2e7ac2ed12711208f295c0a71d96d06edd832905 |
| 2e7ac2e | https://github.com/python/mypy/pull/13513/commits/2e7ac2ed12711208f295c0a71d96d06edd832905 |
|
| https://github.com/ilevkivskyi |
| Also allow classes and type aliases | https://github.com/python/mypy/pull/13513/commits/c9251a82a3a34c570ce855ae7c2fd6f543680c7f |
| c9251a8 | https://github.com/python/mypy/pull/13513/commits/c9251a82a3a34c570ce855ae7c2fd6f543680c7f |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| JukkaL | https://github.com/JukkaL |
| hauntsaninja | https://github.com/hauntsaninja |
| August 25, 2022 18:08 | https://github.com/python/mypy/pull/13513#event-7261753311 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 25, 2022 | https://github.com/python/mypy/pull/13513#issuecomment-1227641031 |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| August 25, 2022 20:00 | https://github.com/python/mypy/pull/13513#commits-pushed-6ef1db2 |
|
| https://github.com/ilevkivskyi |
| Try fixing mypy_primer | https://github.com/python/mypy/pull/13513/commits/6ef1db2aa869f978828d3b10d31362728b4f8b6d |
| 6ef1db2 | https://github.com/python/mypy/pull/13513/commits/6ef1db2aa869f978828d3b10d31362728b4f8b6d |
|
| https://github.com/ilevkivskyi |
| Typo | https://github.com/python/mypy/pull/13513/commits/4b2566adad08a89c2a985a9f06124373350f88d0 |
| 4b2566a | https://github.com/python/mypy/pull/13513/commits/4b2566adad08a89c2a985a9f06124373350f88d0 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Aug 26, 2022
| https://github.com/python/mypy/pull/13513#pullrequestreview-1086682162 |
|
View reviewed changes
| https://github.com/python/mypy/pull/13513/files/4b2566adad08a89c2a985a9f06124373350f88d0 |
| test-data/unit/check-protocols.test | https://github.com/python/mypy/pull/13513/files/4b2566adad08a89c2a985a9f06124373350f88d0#diff-9197c899266eb7fc4382f2c2852c3f77ca6df8ec4bec97d985ab2f8c59aedaa2 |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Aug 26, 2022
| https://github.com/python/mypy/pull/13513#pullrequestreview-1086688672 |
|
View reviewed changes
| https://github.com/python/mypy/pull/13513/files/4b2566adad08a89c2a985a9f06124373350f88d0 |
| test-data/unit/check-protocols.test | https://github.com/python/mypy/pull/13513/files/4b2566adad08a89c2a985a9f06124373350f88d0#diff-9197c899266eb7fc4382f2c2852c3f77ca6df8ec4bec97d985ab2f8c59aedaa2 |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 26, 2022 | https://github.com/python/mypy/pull/13513#issuecomment-1228334303 |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| August 26, 2022 16:29 | https://github.com/python/mypy/pull/13513#commits-pushed-fb108be |
|
| https://github.com/ilevkivskyi |
| CR; also fix Final for instances | https://github.com/python/mypy/pull/13513/commits/fb108beadf8f49bca6b62f6b671913ad6b41c9dd |
| fb108be | https://github.com/python/mypy/pull/13513/commits/fb108beadf8f49bca6b62f6b671913ad6b41c9dd |
|
| https://github.com/ilevkivskyi |
| Merge remote-tracking branch 'upstream/master' into more-proto-impls-2 | https://github.com/python/mypy/pull/13513/commits/123a6807574eb190b6aa049d3d4dd27bb3134670 |
| 123a680 | https://github.com/python/mypy/pull/13513/commits/123a6807574eb190b6aa049d3d4dd27bb3134670 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 26, 2022 | https://github.com/python/mypy/pull/13513#issuecomment-1228645836 |
| @sobolevn | https://github.com/sobolevn |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| sobolevn | https://github.com/sobolevn |
| August 26, 2022 15:35 | https://github.com/python/mypy/pull/13513#event-7268606101 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Aug 26, 2022
| https://github.com/python/mypy/pull/13513#pullrequestreview-1087199422 |
|
View reviewed changes
| https://github.com/python/mypy/pull/13513/files/123a6807574eb190b6aa049d3d4dd27bb3134670 |
| sobolevn | https://github.com/sobolevn |
| https://github.com/python/mypy/pull/13513#pullrequestreview-1087199422 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
|
| https://github.com/ilevkivskyi |
| Merge remote-tracking branch 'upstream/master' into more-proto-impls-2 | https://github.com/python/mypy/pull/13513/commits/d11fae2aa3a26eefa96f682b9d5dc0b7cd7f2602 |
| d11fae2 | https://github.com/python/mypy/pull/13513/commits/d11fae2aa3a26eefa96f682b9d5dc0b7cd7f2602 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 27, 2022 | https://github.com/python/mypy/pull/13513#issuecomment-1229073916 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 3efbc5c | https://github.com/python/mypy/commit/3efbc5c5e910296a60ed5b9e0e7eb11dd912c3ed |
| Aug 27, 2022 | https://github.com/python/mypy/pull/13513#event-7272417494 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| August 27, 2022 18:47 | https://github.com/python/mypy/pull/13513#event-7272417548 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Aug 27, 2022 | https://github.com/python/mypy/pull/13513#issuecomment-1229252208 |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 27, 2022 | https://github.com/python/mypy/pull/13513#issuecomment-1229252488 |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Aug 27, 2022 | https://github.com/python/mypy/pull/13513#issuecomment-1229253172 |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 27, 2022 | https://github.com/python/mypy/pull/13513#issuecomment-1229253306 |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
| https://github.com/asottile |
| asottile | https://github.com/asottile |
|
Sep 29, 2022
| https://github.com/python/mypy/pull/13513#ref-issue-1391340396 |
|
modules as protocols doesn't type-check against the protocol
#13771
| https://github.com/python/mypy/issues/13771 |
| https://github.com/clokep |
| clokep | https://github.com/clokep |
|
Feb 13, 2023
| https://github.com/python/mypy/pull/13513#ref-pullrequest-1580036255 |
|
Use mypy 1.0
matrix-org/synapse#15052
| https://github.com/matrix-org/synapse/pull/15052 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513 |
|
| https://github.com/sobolevn |
|
sobolevn
| https://github.com/sobolevn |
|
| https://github.com/python/mypy/pull/13513/files/123a6807574eb190b6aa049d3d4dd27bb3134670 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
|
Final variable is mutable when using structural subtyping
| https://github.com/python/mypy/issues/10850 |
|
Member is not assignable error when accessing a module member
| https://github.com/python/mypy/issues/5439 |
|
Allow using modules as subtypes of protocols
| https://github.com/python/mypy/issues/5018 |
| Please reload this page | https://github.com/python/mypy/pull/13513 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/gvanrossum |
|
| https://github.com/sobolevn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |