René's URL Explorer Experiment


Title: Allow using modules as subtypes of protocols by ilevkivskyi · Pull Request #13513 · python/mypy · GitHub

Open Graph Title: Allow using modules as subtypes of protocols by ilevkivskyi · Pull Request #13513 · python/mypy

X Title: Allow using modules as subtypes of protocols by ilevkivskyi · Pull Request #13513 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #5018 Fixes #5439 Fixes #10850 The implementation is simple but not the most beautiful one. I simply add a new slot to the Instance class that represents content of the module. This new attri...

X Description: Fixes #5018 Fixes #5439 Fixes #10850 The implementation is simple but not the most beautiful one. I simply add a new slot to the Instance class that represents content of the module. This new attri...

Opengraph URL: https://github.com/python/mypy/pull/13513

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2a28f556-fbe5-3e13-1d77-556e4b3713bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCBA:34D604:1907CCE:21127EA:6B00291D
html-safe-nonce075ecbfe9f503f3f954d05e754c44056fa214a91705e4f2705932fa5403e576d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0JBOjM0RDYwNDoxOTA3Q0NFOjIxMTI3RUE6NkIwMDI5MUQiLCJ2aXNpdG9yX2lkIjoiODg5NTk4NTQzMzUwMzA4Mjc4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaba4ee18604a0ccdc2715273d649c93adff302338ab7777bed39517b5010a3db
hovercard-subject-tagpull_request:1037089663
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/13513/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/47f14ef8f9c0167512341c7c99cfd1a15b9ee0ba3a457dc7270bf4f56ebc4d32/python/mypy/pull/13513
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/47f14ef8f9c0167512341c7c99cfd1a15b9ee0ba3a457dc7270bf4f56ebc4d32/python/mypy/pull/13513
og:image:altFixes #5018 Fixes #5439 Fixes #10850 The implementation is simple but not the most beautiful one. I simply add a new slot to the Instance class that represents content of the module. This new attri...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/13513#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/13513
Reloadhttps://github.com/python/mypy/pull/13513
Reloadhttps://github.com/python/mypy/pull/13513
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:more-proto-impls-2https://github.com/ilevkivskyi/mypy/tree/more-proto-impls-2
Conversationhttps://github.com/python/mypy/pull/13513
Commits12 (12)https://github.com/python/mypy/pull/13513/commits
Checkshttps://github.com/python/mypy/pull/13513/checks
Files changedhttps://github.com/python/mypy/pull/13513/files
Allow using modules as subtypes of protocolshttps://github.com/python/mypy/pull/13513#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:more-proto-impls-2https://github.com/ilevkivskyi/mypy/tree/more-proto-impls-2
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 25, 2022https://github.com/python/mypy/pull/13513#issue-1351269421
Please reload this pagehttps://github.com/python/mypy/pull/13513
#5018https://github.com/python/mypy/issues/5018
#5439https://github.com/python/mypy/issues/5439
#10850https://github.com/python/mypy/issues/10850
Please reload this pagehttps://github.com/python/mypy/pull/13513
ilevkivskyihttps://github.com/ilevkivskyi
August 25, 2022 15:38https://github.com/python/mypy/pull/13513#commits-pushed-e82b6fd
https://github.com/ilevkivskyi
Allow modules as protocol implementationshttps://github.com/python/mypy/pull/13513/commits/e82b6fdcb82e2b5936d8a22740829d2eed8aa035
e82b6fdhttps://github.com/python/mypy/pull/13513/commits/e82b6fdcb82e2b5936d8a22740829d2eed8aa035
https://github.com/ilevkivskyi
Fix fine/incremental; better diagnosticshttps://github.com/python/mypy/pull/13513/commits/978fa3264fb3f07557dad30f9dec275e413cc41e
978fa32https://github.com/python/mypy/pull/13513/commits/978fa3264fb3f07557dad30f9dec275e413cc41e
https://github.com/ilevkivskyi
Merge remote-tracking branch 'upstream/master' into more-proto-impls-2https://github.com/python/mypy/pull/13513/commits/8373d241efef7538a29836e96a6698f19c89efae
8373d24https://github.com/python/mypy/pull/13513/commits/8373d241efef7538a29836e96a6698f19c89efae
https://github.com/ilevkivskyi
Better module detection in messageshttps://github.com/python/mypy/pull/13513/commits/3ce4a7370851681d98af6ceb9acb10ffc80073af
3ce4a73https://github.com/python/mypy/pull/13513/commits/3ce4a7370851681d98af6ceb9acb10ffc80073af
https://github.com/ilevkivskyi
Fix self-checkhttps://github.com/python/mypy/pull/13513/commits/16fa7dc2e1662e88b45195b44128497ec6957877
16fa7dchttps://github.com/python/mypy/pull/13513/commits/16fa7dc2e1662e88b45195b44128497ec6957877
https://github.com/ilevkivskyi
Show module names only for protocolshttps://github.com/python/mypy/pull/13513/commits/2e7ac2ed12711208f295c0a71d96d06edd832905
2e7ac2ehttps://github.com/python/mypy/pull/13513/commits/2e7ac2ed12711208f295c0a71d96d06edd832905
https://github.com/ilevkivskyi
Also allow classes and type aliaseshttps://github.com/python/mypy/pull/13513/commits/c9251a82a3a34c570ce855ae7c2fd6f543680c7f
c9251a8https://github.com/python/mypy/pull/13513/commits/c9251a82a3a34c570ce855ae7c2fd6f543680c7f
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
hauntsaninjahttps://github.com/hauntsaninja
August 25, 2022 18:08https://github.com/python/mypy/pull/13513#event-7261753311
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 25, 2022https://github.com/python/mypy/pull/13513#issuecomment-1227641031
Please reload this pagehttps://github.com/python/mypy/pull/13513
ilevkivskyihttps://github.com/ilevkivskyi
August 25, 2022 20:00https://github.com/python/mypy/pull/13513#commits-pushed-6ef1db2
https://github.com/ilevkivskyi
Try fixing mypy_primerhttps://github.com/python/mypy/pull/13513/commits/6ef1db2aa869f978828d3b10d31362728b4f8b6d
6ef1db2https://github.com/python/mypy/pull/13513/commits/6ef1db2aa869f978828d3b10d31362728b4f8b6d
https://github.com/ilevkivskyi
Typohttps://github.com/python/mypy/pull/13513/commits/4b2566adad08a89c2a985a9f06124373350f88d0
4b2566ahttps://github.com/python/mypy/pull/13513/commits/4b2566adad08a89c2a985a9f06124373350f88d0
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Aug 26, 2022 https://github.com/python/mypy/pull/13513#pullrequestreview-1086682162
View reviewed changes https://github.com/python/mypy/pull/13513/files/4b2566adad08a89c2a985a9f06124373350f88d0
test-data/unit/check-protocols.testhttps://github.com/python/mypy/pull/13513/files/4b2566adad08a89c2a985a9f06124373350f88d0#diff-9197c899266eb7fc4382f2c2852c3f77ca6df8ec4bec97d985ab2f8c59aedaa2
Please reload this pagehttps://github.com/python/mypy/pull/13513
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Aug 26, 2022 https://github.com/python/mypy/pull/13513#pullrequestreview-1086688672
View reviewed changes https://github.com/python/mypy/pull/13513/files/4b2566adad08a89c2a985a9f06124373350f88d0
test-data/unit/check-protocols.testhttps://github.com/python/mypy/pull/13513/files/4b2566adad08a89c2a985a9f06124373350f88d0#diff-9197c899266eb7fc4382f2c2852c3f77ca6df8ec4bec97d985ab2f8c59aedaa2
Please reload this pagehttps://github.com/python/mypy/pull/13513
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 26, 2022https://github.com/python/mypy/pull/13513#issuecomment-1228334303
Please reload this pagehttps://github.com/python/mypy/pull/13513
ilevkivskyihttps://github.com/ilevkivskyi
August 26, 2022 16:29https://github.com/python/mypy/pull/13513#commits-pushed-fb108be
https://github.com/ilevkivskyi
CR; also fix Final for instanceshttps://github.com/python/mypy/pull/13513/commits/fb108beadf8f49bca6b62f6b671913ad6b41c9dd
fb108behttps://github.com/python/mypy/pull/13513/commits/fb108beadf8f49bca6b62f6b671913ad6b41c9dd
https://github.com/ilevkivskyi
Merge remote-tracking branch 'upstream/master' into more-proto-impls-2https://github.com/python/mypy/pull/13513/commits/123a6807574eb190b6aa049d3d4dd27bb3134670
123a680https://github.com/python/mypy/pull/13513/commits/123a6807574eb190b6aa049d3d4dd27bb3134670
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 26, 2022https://github.com/python/mypy/pull/13513#issuecomment-1228645836
@sobolevnhttps://github.com/sobolevn
Please reload this pagehttps://github.com/python/mypy/pull/13513
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
sobolevnhttps://github.com/sobolevn
August 26, 2022 15:35https://github.com/python/mypy/pull/13513#event-7268606101
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Aug 26, 2022 https://github.com/python/mypy/pull/13513#pullrequestreview-1087199422
View reviewed changes https://github.com/python/mypy/pull/13513/files/123a6807574eb190b6aa049d3d4dd27bb3134670
sobolevnhttps://github.com/sobolevn
https://github.com/python/mypy/pull/13513#pullrequestreview-1087199422
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/13513
https://github.com/ilevkivskyi
Merge remote-tracking branch 'upstream/master' into more-proto-impls-2https://github.com/python/mypy/pull/13513/commits/d11fae2aa3a26eefa96f682b9d5dc0b7cd7f2602
d11fae2https://github.com/python/mypy/pull/13513/commits/d11fae2aa3a26eefa96f682b9d5dc0b7cd7f2602
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 27, 2022https://github.com/python/mypy/pull/13513#issuecomment-1229073916
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/13513
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
3efbc5chttps://github.com/python/mypy/commit/3efbc5c5e910296a60ed5b9e0e7eb11dd912c3ed
Aug 27, 2022https://github.com/python/mypy/pull/13513#event-7272417494
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
August 27, 2022 18:47https://github.com/python/mypy/pull/13513#event-7272417548
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Aug 27, 2022https://github.com/python/mypy/pull/13513#issuecomment-1229252208
Please reload this pagehttps://github.com/python/mypy/pull/13513
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 27, 2022https://github.com/python/mypy/pull/13513#issuecomment-1229252488
Please reload this pagehttps://github.com/python/mypy/pull/13513
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Aug 27, 2022https://github.com/python/mypy/pull/13513#issuecomment-1229253172
Please reload this pagehttps://github.com/python/mypy/pull/13513
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 27, 2022https://github.com/python/mypy/pull/13513#issuecomment-1229253306
Please reload this pagehttps://github.com/python/mypy/pull/13513
https://github.com/asottile
asottilehttps://github.com/asottile
Sep 29, 2022 https://github.com/python/mypy/pull/13513#ref-issue-1391340396
modules as protocols doesn't type-check against the protocol #13771 https://github.com/python/mypy/issues/13771
https://github.com/clokep
clokephttps://github.com/clokep
Feb 13, 2023 https://github.com/python/mypy/pull/13513#ref-pullrequest-1580036255
Use mypy 1.0 matrix-org/synapse#15052 https://github.com/matrix-org/synapse/pull/15052
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13513
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/mypy/pull/13513/files/123a6807574eb190b6aa049d3d4dd27bb3134670
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
Please reload this pagehttps://github.com/python/mypy/pull/13513
Final variable is mutable when using structural subtyping https://github.com/python/mypy/issues/10850
Member is not assignable error when accessing a module member https://github.com/python/mypy/issues/5439
Allow using modules as subtypes of protocols https://github.com/python/mypy/issues/5018
Please reload this pagehttps://github.com/python/mypy/pull/13513
https://github.com/ilevkivskyi
https://github.com/gvanrossum
https://github.com/sobolevn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.