René's URL Explorer Experiment


Title: Allow overriding attribute with a settable property by ilevkivskyi · Pull Request #13475 · python/mypy · GitHub

Open Graph Title: Allow overriding attribute with a settable property by ilevkivskyi · Pull Request #13475 · python/mypy

X Title: Allow overriding attribute with a settable property by ilevkivskyi · Pull Request #13475 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #4125 Previously the code compared the original signatures for properties. Now we compare just the return types, similar to how we do it in checkmember.py. Note that we still only allow invar...

X Description: Fixes #4125 Previously the code compared the original signatures for properties. Now we compare just the return types, similar to how we do it in checkmember.py. Note that we still only allow invar...

Opengraph URL: https://github.com/python/mypy/pull/13475

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0f1e869f-3ce9-ea43-3e77-c5f05244d3ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA380:23FDF9:203C051:2BECAC2:6B00237E
html-safe-nonce359cf65abe53d22ae243f647b3e06a9a8369a05da6e81b768e13c66c0d336370
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzgwOjIzRkRGOToyMDNDMDUxOjJCRUNBQzI6NkIwMDIzN0UiLCJ2aXNpdG9yX2lkIjoiMTExNTgwMTc2OTQ4NjY3MjYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4d199e24536007efb08fe4e19ed44b8ef1443dd5568e956620d1a592a9631633
hovercard-subject-tagpull_request:1032153333
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/13475/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b2fe54a48a3f08bb53ed4bb8fe0af3c9c603db0b0bab671c28ce8f7e5c593740/python/mypy/pull/13475
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b2fe54a48a3f08bb53ed4bb8fe0af3c9c603db0b0bab671c28ce8f7e5c593740/python/mypy/pull/13475
og:image:altFixes #4125 Previously the code compared the original signatures for properties. Now we compare just the return types, similar to how we do it in checkmember.py. Note that we still only allow invar...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/13475#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13475
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13475
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/13475
Reloadhttps://github.com/python/mypy/pull/13475
Reloadhttps://github.com/python/mypy/pull/13475
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-property-overridehttps://github.com/ilevkivskyi/mypy/tree/fix-property-override
Conversationhttps://github.com/python/mypy/pull/13475
Commits6 (6)https://github.com/python/mypy/pull/13475/commits
Checkshttps://github.com/python/mypy/pull/13475/checks
Files changedhttps://github.com/python/mypy/pull/13475/files
Allow overriding attribute with a settable propertyhttps://github.com/python/mypy/pull/13475#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-property-overridehttps://github.com/ilevkivskyi/mypy/tree/fix-property-override
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 21, 2022https://github.com/python/mypy/pull/13475#issue-1345627824
Please reload this pagehttps://github.com/python/mypy/pull/13475
#4125https://github.com/python/mypy/issues/4125
Please reload this pagehttps://github.com/python/mypy/pull/13475
ilevkivskyihttps://github.com/ilevkivskyi
August 22, 2022 00:14https://github.com/python/mypy/pull/13475#commits-pushed-4dad8e2
https://github.com/ilevkivskyi
Allow overriding attribute with a settable propertyhttps://github.com/python/mypy/pull/13475/commits/4dad8e2fb2370d2cb8f57d2c0d02343c06596012
4dad8e2https://github.com/python/mypy/pull/13475/commits/4dad8e2fb2370d2cb8f57d2c0d02343c06596012
https://github.com/ilevkivskyi
Fix existing testshttps://github.com/python/mypy/pull/13475/commits/ee8c2f4091d94b42eb2dd2f42d7f605880d42686
ee8c2f4https://github.com/python/mypy/pull/13475/commits/ee8c2f4091d94b42eb2dd2f42d7f605880d42686
https://github.com/ilevkivskyi
Use a more robust wayhttps://github.com/python/mypy/pull/13475/commits/97830e6380a5f150aa333f710efc64de73d65c0f
97830e6https://github.com/python/mypy/pull/13475/commits/97830e6380a5f150aa333f710efc64de73d65c0f
https://github.com/ilevkivskyi
Fix self-checkhttps://github.com/python/mypy/pull/13475/commits/1a08008953cd01b5774e7aa52b918c17c0cc1d3f
1a08008https://github.com/python/mypy/pull/13475/commits/1a08008953cd01b5774e7aa52b918c17c0cc1d3f
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
hauntsaninjahttps://github.com/hauntsaninja
jhancehttps://github.com/jhance
August 21, 2022 23:37https://github.com/python/mypy/pull/13475#event-7228345171
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13475
https://github.com/ilevkivskyi
Adjust new errorhttps://github.com/python/mypy/pull/13475/commits/eb4dc4630a88e6542a275e317fd4fa4c1c31964a
eb4dc46https://github.com/python/mypy/pull/13475/commits/eb4dc4630a88e6542a275e317fd4fa4c1c31964a
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 22, 2022https://github.com/python/mypy/pull/13475#issuecomment-1221674115
@OttoWinterhttps://github.com/OttoWinter
@balloobhttps://github.com/balloob
Please reload this pagehttps://github.com/python/mypy/pull/13475
https://github.com/ilevkivskyi
Update line number in a testhttps://github.com/python/mypy/pull/13475/commits/f29edcad50637d8ea834fc5554bc8bd8443e1bc2
f29edcahttps://github.com/python/mypy/pull/13475/commits/f29edcad50637d8ea834fc5554bc8bd8443e1bc2
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13475
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 22, 2022https://github.com/python/mypy/pull/13475#issuecomment-1221694478
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/13475
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Aug 22, 2022 https://github.com/python/mypy/pull/13475#pullrequestreview-1079784515
View reviewed changes https://github.com/python/mypy/pull/13475/files/f29edcad50637d8ea834fc5554bc8bd8443e1bc2
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/mypy/pull/13475#pullrequestreview-1079784515
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/13475
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Aug 22, 2022https://github.com/python/mypy/pull/13475#issuecomment-1221992581
Please reload this pagehttps://github.com/python/mypy/pull/13475
https://github.com/cdce8p
cdce8phttps://github.com/cdce8p
Aug 22, 2022 https://github.com/python/mypy/pull/13475#ref-pullrequest-1346300600
Improve esphome state property decorator typing home-assistant/core#77152 https://github.com/home-assistant/core/pull/77152
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 22, 2022https://github.com/python/mypy/pull/13475#issuecomment-1222302362
#3004https://github.com/python/mypy/issues/3004
Please reload this pagehttps://github.com/python/mypy/pull/13475
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
40dd719https://github.com/python/mypy/commit/40dd719a536589d375ce8ef6cf5f9c6588bbea29
Aug 22, 2022https://github.com/python/mypy/pull/13475#event-7232466187
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
August 22, 2022 12:40https://github.com/python/mypy/pull/13475#event-7232466649
https://github.com/anis-campos
anis-camposhttps://github.com/anis-campos
Aug 24, 2022 https://github.com/python/mypy/pull/13475#ref-issue-555237894
Crash when overriding field as property/method on frozen derived class #8334 https://github.com/python/mypy/issues/8334
https://github.com/Rocamonde
Rocamondehttps://github.com/Rocamonde
Sep 7, 2022 https://github.com/python/mypy/pull/13475#ref-issue-1364251127
Remove type ignore in replay_buffer_wrapper once new mypy version is released HumanCompatibleAI/imitation#552 https://github.com/HumanCompatibleAI/imitation/issues/552
https://github.com/daniel-montanari
daniel-montanarihttps://github.com/daniel-montanari
Sep 13, 2022 https://github.com/python/mypy/pull/13475#ref-pullrequest-1370790391
Mypy PyFixate/Fixate#154 https://github.com/PyFixate/Fixate/pull/154
https://github.com/Rocamonde
Rocamondehttps://github.com/Rocamonde
Oct 11, 2022https://github.com/python/mypy/pull/13475#issuecomment-1274698339
Please reload this pagehttps://github.com/python/mypy/pull/13475
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Oct 11, 2022https://github.com/python/mypy/pull/13475#issuecomment-1274714013
Please reload this pagehttps://github.com/python/mypy/pull/13475
40dd719https://github.com/python/mypy/commit/40dd719a536589d375ce8ef6cf5f9c6588bbea29
bf143d9https://github.com/python/mypy/commit/bf143d919cef0d04316338babe49f45fc76db8ae
https://user-images.githubusercontent.com/66076021/195108545-75b0f23f-3e13-42ae-8953-c367428de847.png
Please reload this pagehttps://github.com/python/mypy/pull/13475
https://github.com/tmke8
tmke8https://github.com/tmke8
Oct 28, 2022 https://github.com/python/mypy/pull/13475#ref-issue-1426392555
Failure when overriding an protocol attribute with a property in protocol subclass #13954 https://github.com/python/mypy/issues/13954
py3-pipenv/3000.0.0 package update wolfi-dev/os#21529 https://github.com/wolfi-dev/os/pull/21529
py3-pipenv/2024.0.0 package update wolfi-dev/os#21539 https://github.com/wolfi-dev/os/pull/21539
py3-pipenv/2024.0.1 package update wolfi-dev/os#21767 https://github.com/wolfi-dev/os/pull/21767
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 1, 2024 https://github.com/python/mypy/pull/13475#ref-pullrequest-2384365797
py3-setuptools/70.2.0 package update wolfi-dev/os#22941 https://github.com/wolfi-dev/os/pull/22941
py3-setuptools/74.1.0 package update wolfi-dev/os#27422 https://github.com/wolfi-dev/os/pull/27422
py3-setuptools/74.1.0 package update wolfi-dev/os#27423 https://github.com/wolfi-dev/os/pull/27423
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 23, 2024 https://github.com/python/mypy/pull/13475#ref-pullrequest-2541568276
py3-pipenv/2024.0.3 package update wolfi-dev/os#29158 https://github.com/wolfi-dev/os/pull/29158
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13475
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/13475/files/f29edcad50637d8ea834fc5554bc8bd8443e1bc2
https://github.com/jhance
jhance https://github.com/jhance
Please reload this pagehttps://github.com/python/mypy/pull/13475
Mypy disallows overriding an attribute with a property https://github.com/python/mypy/issues/4125
Please reload this pagehttps://github.com/python/mypy/pull/13475
https://github.com/ilevkivskyi
https://github.com/sobolevn
https://github.com/Rocamonde
https://github.com/AlexWaygood
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.