René's URL Explorer Experiment


Title: Add import Union to stub file (#12929) by SilvestrLanik · Pull Request #13428 · python/mypy · GitHub

Open Graph Title: Add import Union to stub file (#12929) by SilvestrLanik · Pull Request #13428 · python/mypy

X Title: Add import Union to stub file (#12929) by SilvestrLanik · Pull Request #13428 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #12929 Stubs generated from files with new format of Union typing will include importing Union from typing. Test Plan I've added 3 new tests while making sure they pass locally.

X Description: Fixes #12929 Stubs generated from files with new format of Union typing will include importing Union from typing. Test Plan I've added 3 new tests while making sure they pass locally.

Opengraph URL: https://github.com/python/mypy/pull/13428

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5ef4f517-dabe-a05a-30cf-d324b1352628
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3BA:38EF13:830F52:B46E03:6AEC3997
html-safe-nonce3b06bd7b58c10932364d5f370abd6706f47793e21f0f45987d9eba36bc72cf04
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0JBOjM4RUYxMzo4MzBGNTI6QjQ2RTAzOjZBRUMzOTk3IiwidmlzaXRvcl9pZCI6Ijg4NDIxOTY5NjgxODg2ODg3OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac052f3d78e7d6f8ca799ba0f44613c74b421a6e8653b9cce670cc4106fa3f99e3
hovercard-subject-tagpull_request:1026820044
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/13428/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f387b2be0c1d07ba7c29ccacab1cd1529fee04c14a59663fc9fe6a82f6f4ee1a/python/mypy/pull/13428
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f387b2be0c1d07ba7c29ccacab1cd1529fee04c14a59663fc9fe6a82f6f4ee1a/python/mypy/pull/13428
og:image:altFixes #12929 Stubs generated from files with new format of Union typing will include importing Union from typing. Test Plan I've added 3 new tests while making sure they pass locally.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSilvestrLanik
hostnamegithub.com
expected-hostnamegithub.com
None1dcf8db8e9101b96aecb2bc4e1fd095c110db63a7a140d8a7a9de997e07663e3
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec248a9ae2572141cd7b35bf30a770cdc842dbc35
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/13428#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13428
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13428
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/13428
Reloadhttps://github.com/python/mypy/pull/13428
Reloadhttps://github.com/python/mypy/pull/13428
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests522 (522)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/pulse
https://github.com/python/mypy
SilvestrLanikhttps://github.com/SilvestrLanik
python:masterhttps://github.com/python/mypy/tree/master
SilvestrLanik:Adding_union_importshttps://github.com/SilvestrLanik/mypy/tree/Adding_union_imports
Conversationhttps://github.com/python/mypy/pull/13428
Commits2 (2)https://github.com/python/mypy/pull/13428/commits
Checkshttps://github.com/python/mypy/pull/13428/checks
Files changedhttps://github.com/python/mypy/pull/13428/files
Add import Union to stub file (#12929)https://github.com/python/mypy/pull/13428#top
SilvestrLanikhttps://github.com/SilvestrLanik
python:masterhttps://github.com/python/mypy/tree/master
SilvestrLanik:Adding_union_importshttps://github.com/SilvestrLanik/mypy/tree/Adding_union_imports
https://github.com/SilvestrLanik
SilvestrLanikhttps://github.com/SilvestrLanik
Aug 15, 2022https://github.com/python/mypy/pull/13428#issue-1339424661
#12929https://github.com/python/mypy/issues/12929
Please reload this pagehttps://github.com/python/mypy/pull/13428
SilvestrLanikhttps://github.com/SilvestrLanik
August 16, 2022 22:06https://github.com/python/mypy/pull/13428#commits-pushed-b5181c4
https://github.com/SilvestrLanik
fix: add import Union to stub filehttps://github.com/python/mypy/pull/13428/commits/b5181c414e53ce5a4fce88558eaa23d1900cf9c8
b5181c4https://github.com/python/mypy/pull/13428/commits/b5181c414e53ce5a4fce88558eaa23d1900cf9c8
https://github.com/SilvestrLanik
test: fixing failing testhttps://github.com/python/mypy/pull/13428/commits/9e88224ce1ba2a15791632a1cb83c29a859b2c85
9e88224https://github.com/python/mypy/pull/13428/commits/9e88224ce1ba2a15791632a1cb83c29a859b2c85
https://github.com/SilvestrLanik
SilvestrLanikhttps://github.com/SilvestrLanik
force-pushedhttps://github.com/python/mypy/compare/88ac62e298991c6a363abe3f216843efbcadd171..9e88224ce1ba2a15791632a1cb83c29a859b2c85
88ac62ehttps://github.com/python/mypy/commit/88ac62e298991c6a363abe3f216843efbcadd171
9e88224https://github.com/python/mypy/commit/9e88224ce1ba2a15791632a1cb83c29a859b2c85
Compare https://github.com/python/mypy/compare/88ac62e298991c6a363abe3f216843efbcadd171..9e88224ce1ba2a15791632a1cb83c29a859b2c85
August 16, 2022 20:08https://github.com/python/mypy/pull/13428#event-7200249460
https://github.com/SilvestrLanik
SilvestrLanikhttps://github.com/SilvestrLanik
Aug 16, 2022https://github.com/python/mypy/pull/13428#issuecomment-1217110584
Please reload this pagehttps://github.com/python/mypy/pull/13428
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
topic-stubgen https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-stubgen
Aug 20, 2022https://github.com/python/mypy/pull/13428#event-7226360512
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Sep 11, 2022 https://github.com/python/mypy/pull/13428#pullrequestreview-1103363513
View reviewed changes https://github.com/python/mypy/pull/13428/files/9e88224ce1ba2a15791632a1cb83c29a859b2c85
test-data/unit/stubgen.testhttps://github.com/python/mypy/pull/13428/files/9e88224ce1ba2a15791632a1cb83c29a859b2c85#diff-660bace74255abc117df6428b5fd549fa2a481988030ea96eb96c8b8a96baf3f
sobolevnhttps://github.com/sobolevn
Sep 11, 2022https://github.com/python/mypy/pull/13428#discussion_r967898485
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/13428
hamdanalhttps://github.com/hamdanal
Feb 3, 2023 https://github.com/python/mypy/pull/13428#ref-commit-2b51a9b
https://github.com/hamdanal
[stubgen] Preserve PEP 604 Unions in generated pyi fileshttps://github.com/hamdanal/mypy/commit/2b51a9b41b902238cfe061cc91d03b23378011b6
2b51a9bhttps://github.com/hamdanal/mypy/commit/2b51a9b41b902238cfe061cc91d03b23378011b6
python#12929https://github.com/python/mypy/issues/12929
python#13428https://github.com/python/mypy/pull/13428
python#12920https://github.com/python/mypy/issues/12920
https://github.com/hamdanal
hamdanalhttps://github.com/hamdanal
Feb 3, 2023 https://github.com/python/mypy/pull/13428#ref-pullrequest-1570543977
[stubgen] Preserve PEP 604 Unions in generated pyi files #14601 https://github.com/python/mypy/pull/14601
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
#14601 https://github.com/python/mypy/pull/14601
Feb 7, 2023https://github.com/python/mypy/pull/13428#event-8454632852
hauntsaninjahttps://github.com/hauntsaninja
Feb 7, 2023 https://github.com/python/mypy/pull/13428#ref-commit-725214b
https://github.com/hamdanal
stubgen: preserve PEP 604 Unions in generated pyi files (https://github.com/python/mypy/commit/725214b6bb75e2dd4a01a21ed707c311d15d7bd3
#14601https://github.com/python/mypy/pull/14601
)https://github.com/python/mypy/commit/725214b6bb75e2dd4a01a21ed707c311d15d7bd3
725214bhttps://github.com/python/mypy/commit/725214b6bb75e2dd4a01a21ed707c311d15d7bd3
#12929https://github.com/python/mypy/issues/12929
#13428https://github.com/python/mypy/pull/13428
#12920https://github.com/python/mypy/issues/12920
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13428
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/mypy/pull/13428/files/9e88224ce1ba2a15791632a1cb83c29a859b2c85
Please reload this pagehttps://github.com/python/mypy/pull/13428
topic-stubgen https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-stubgen
stubgen: import Union if generated stub code includes https://github.com/python/mypy/issues/12929
Please reload this pagehttps://github.com/python/mypy/pull/13428
https://github.com/SilvestrLanik
https://github.com/sobolevn
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.