René's URL Explorer Experiment


Title: Cleaner usage of get_proper_type() by ilevkivskyi · Pull Request #13326 · python/mypy · GitHub

Open Graph Title: Cleaner usage of get_proper_type() by ilevkivskyi · Pull Request #13326 · python/mypy

X Title: Cleaner usage of get_proper_type() by ilevkivskyi · Pull Request #13326 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This is a follow up for #13297 I move around some calls to get_proper_type() to preserve original types as much as possible (plus few related required low-risk changes). This makes error messages m...

X Description: This is a follow up for #13297 I move around some calls to get_proper_type() to preserve original types as much as possible (plus few related required low-risk changes). This makes error messages m...

Opengraph URL: https://github.com/python/mypy/pull/13326

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f1ae3034-a5ca-1cdc-3db4-e5a3fbf35c30
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB3DE:2463C6:13C950:1AA6FD:6B001EE0
html-safe-noncea718d00e23752994c5bad2f25c6098da764a16617901192cce8df163692a861a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0RFOjI0NjNDNjoxM0M5NTA6MUFBNkZEOjZCMDAxRUUwIiwidmlzaXRvcl9pZCI6IjY5Nzk5MTU4NjAzNjIxNDE0MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac675f10efcc93dc3fbd60fe573060845854825d783877931532684f1509b042b5
hovercard-subject-tagpull_request:1017877016
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/13326/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7c62a1a2fd429f133ed7e74e681973ccdb81f43888ab9c5f02cc7445fc3261f9/python/mypy/pull/13326
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7c62a1a2fd429f133ed7e74e681973ccdb81f43888ab9c5f02cc7445fc3261f9/python/mypy/pull/13326
og:image:altThis is a follow up for #13297 I move around some calls to get_proper_type() to preserve original types as much as possible (plus few related required low-risk changes). This makes error messages m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/13326#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13326
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13326
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/13326
Reloadhttps://github.com/python/mypy/pull/13326
Reloadhttps://github.com/python/mypy/pull/13326
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:clean-get-proper-typehttps://github.com/ilevkivskyi/mypy/tree/clean-get-proper-type
Conversationhttps://github.com/python/mypy/pull/13326
Commits18 (18)https://github.com/python/mypy/pull/13326/commits
Checkshttps://github.com/python/mypy/pull/13326/checks
Files changedhttps://github.com/python/mypy/pull/13326/files
Cleaner usage of get_proper_type()https://github.com/python/mypy/pull/13326#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:clean-get-proper-typehttps://github.com/ilevkivskyi/mypy/tree/clean-get-proper-type
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 4, 2022https://github.com/python/mypy/pull/13326#issue-1329012383
#13297https://github.com/python/mypy/pull/13297
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/13326
ilevkivskyihttps://github.com/ilevkivskyi
August 3, 2022 22:03https://github.com/python/mypy/pull/13326#commits-pushed-51670ca
https://github.com/ilevkivskyi
Go through subtypes.pyhttps://github.com/python/mypy/pull/13326/commits/51670ca106af6539b66b1d5ff21c796e4f3de0b4
51670cahttps://github.com/python/mypy/pull/13326/commits/51670ca106af6539b66b1d5ff21c796e4f3de0b4
https://github.com/ilevkivskyi
Go through applytype.pyhttps://github.com/python/mypy/pull/13326/commits/20f0b8e44864c7b6cb8574c1f0f92e840d146d93
20f0b8ehttps://github.com/python/mypy/pull/13326/commits/20f0b8e44864c7b6cb8574c1f0f92e840d146d93
https://github.com/ilevkivskyi
Add couple testshttps://github.com/python/mypy/pull/13326/commits/5067998c349e54a03f3e56a87e13b28f91df492e
5067998https://github.com/python/mypy/pull/13326/commits/5067998c349e54a03f3e56a87e13b28f91df492e
https://github.com/ilevkivskyi
Some more cleanup; add testhttps://github.com/python/mypy/pull/13326/commits/c85098bce6ffff4026bbf51ab5c8faeba2baeb0e
c85098bhttps://github.com/python/mypy/pull/13326/commits/c85098bce6ffff4026bbf51ab5c8faeba2baeb0e
https://github.com/ilevkivskyi
Fix one testhttps://github.com/python/mypy/pull/13326/commits/20286fdc5bc3612bd67529f709b0a3aeffc841fe
20286fdhttps://github.com/python/mypy/pull/13326/commits/20286fdc5bc3612bd67529f709b0a3aeffc841fe
https://github.com/ilevkivskyi
Add a test case for joinhttps://github.com/python/mypy/pull/13326/commits/f0970b8aa46ea5c0403bbcdaaf9d6f45285187d8
f0970b8https://github.com/python/mypy/pull/13326/commits/f0970b8aa46ea5c0403bbcdaaf9d6f45285187d8
https://github.com/ilevkivskyi
Bake out one in constraints.py (just in case)https://github.com/python/mypy/pull/13326/commits/b5a8655a97f8f8e8cfe6c15ab3173166ba550e86
b5a8655https://github.com/python/mypy/pull/13326/commits/b5a8655a97f8f8e8cfe6c15ab3173166ba550e86
https://github.com/ilevkivskyi
Mark erasetype.py as also donehttps://github.com/python/mypy/pull/13326/commits/6c98581fb175e65e2cafae4fa93844020360b4ff
6c98581https://github.com/python/mypy/pull/13326/commits/6c98581fb175e65e2cafae4fa93844020360b4ff
https://github.com/ilevkivskyi
Go through meet.pyhttps://github.com/python/mypy/pull/13326/commits/8516bd560356cde5164347f4064416ad5baa60d0
8516bd5https://github.com/python/mypy/pull/13326/commits/8516bd560356cde5164347f4064416ad5baa60d0
https://github.com/ilevkivskyi
Mark solve.py as also donehttps://github.com/python/mypy/pull/13326/commits/5b0e1010e06fe20bdbf6ab6ca815e6989f408e88
5b0e101https://github.com/python/mypy/pull/13326/commits/5b0e1010e06fe20bdbf6ab6ca815e6989f408e88
https://github.com/ilevkivskyi
Mark argmap.py as also donehttps://github.com/python/mypy/pull/13326/commits/2d6dbee6ee52917f95ec513885eba9ac2c5fcd43
2d6dbeehttps://github.com/python/mypy/pull/13326/commits/2d6dbee6ee52917f95ec513885eba9ac2c5fcd43
https://github.com/ilevkivskyi
Mark expandtype.py as also donehttps://github.com/python/mypy/pull/13326/commits/42e1fc6420b8f5a169d62efeb65c99a6ec468273
42e1fc6https://github.com/python/mypy/pull/13326/commits/42e1fc6420b8f5a169d62efeb65c99a6ec468273
https://github.com/ilevkivskyi
Fix self-check; mark join.py as donehttps://github.com/python/mypy/pull/13326/commits/db14a35d7dd18e9d93954724e1b22ff11361412b
db14a35https://github.com/python/mypy/pull/13326/commits/db14a35d7dd18e9d93954724e1b22ff11361412b
https://github.com/ilevkivskyi
Update pluginhttps://github.com/python/mypy/pull/13326/commits/7ae87141b908f003fa49bc8c6e33455522792269
7ae8714https://github.com/python/mypy/pull/13326/commits/7ae87141b908f003fa49bc8c6e33455522792269
https://github.com/ilevkivskyi
Remove some unneeded callshttps://github.com/python/mypy/pull/13326/commits/a50e8e4590647c80cb409c59954de7b7c3769bf8
a50e8e4https://github.com/python/mypy/pull/13326/commits/a50e8e4590647c80cb409c59954de7b7c3769bf8
https://github.com/ilevkivskyi
Merge remote-tracking branch 'upstream/master' into clean-get-proper-…https://github.com/python/mypy/pull/13326/commits/021f18f6ae907c405481f71be290f1d4e40186a3
021f18fhttps://github.com/python/mypy/pull/13326/commits/021f18f6ae907c405481f71be290f1d4e40186a3
https://github.com/ilevkivskyi
Restore some weird special-casinghttps://github.com/python/mypy/pull/13326/commits/e056c81c9f8d605df059b59a3383512af8aae39e
e056c81https://github.com/python/mypy/pull/13326/commits/e056c81c9f8d605df059b59a3383512af8aae39e
https://github.com/ilevkivskyi
Some more fixeshttps://github.com/python/mypy/pull/13326/commits/841b72c284f59a528c333ec03121460c7649dd62
841b72chttps://github.com/python/mypy/pull/13326/commits/841b72c284f59a528c333ec03121460c7649dd62
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
hauntsaninjahttps://github.com/hauntsaninja
August 4, 2022 18:09https://github.com/python/mypy/pull/13326#event-7130425026
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 4, 2022https://github.com/python/mypy/pull/13326#issuecomment-1205607051
Please reload this pagehttps://github.com/python/mypy/pull/13326
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 4, 2022https://github.com/python/mypy/pull/13326#issuecomment-1205631817
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/13326
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 4, 2022https://github.com/python/mypy/pull/13326#issuecomment-1205671801
Please reload this pagehttps://github.com/python/mypy/pull/13326
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Aug 4, 2022 https://github.com/python/mypy/pull/13326#pullrequestreview-1062477880
View reviewed changes https://github.com/python/mypy/pull/13326/files/841b72c284f59a528c333ec03121460c7649dd62
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/mypy/pull/13326#pullrequestreview-1062477880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/13326
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
43476aahttps://github.com/python/mypy/commit/43476aabf73fbe885f1db49597735c797799fa67
Aug 4, 2022https://github.com/python/mypy/pull/13326#event-7131305720
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
August 4, 2022 20:40https://github.com/python/mypy/pull/13326#event-7131306078
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13326
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/13326/files/841b72c284f59a528c333ec03121460c7649dd62
Please reload this pagehttps://github.com/python/mypy/pull/13326
Please reload this pagehttps://github.com/python/mypy/pull/13326
https://github.com/ilevkivskyi
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.