| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f1ae3034-a5ca-1cdc-3db4-e5a3fbf35c30 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B3DE:2463C6:13C950:1AA6FD:6B001EE0 |
| html-safe-nonce | a718d00e23752994c5bad2f25c6098da764a16617901192cce8df163692a861a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0RFOjI0NjNDNjoxM0M5NTA6MUFBNkZEOjZCMDAxRUUwIiwidmlzaXRvcl9pZCI6IjY5Nzk5MTU4NjAzNjIxNDE0MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 675f10efcc93dc3fbd60fe573060845854825d783877931532684f1509b042b5 |
| hovercard-subject-tag | pull_request:1017877016 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/13326/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7c62a1a2fd429f133ed7e74e681973ccdb81f43888ab9c5f02cc7445fc3261f9/python/mypy/pull/13326 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7c62a1a2fd429f133ed7e74e681973ccdb81f43888ab9c5f02cc7445fc3261f9/python/mypy/pull/13326 |
| og:image:alt | This is a follow up for #13297
I move around some calls to get_proper_type() to preserve original types as much as possible (plus few related required low-risk changes). This makes error messages m... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/13326#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13326 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13326 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/13326 |
| Reload | https://github.com/python/mypy/pull/13326 |
| Reload | https://github.com/python/mypy/pull/13326 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:clean-get-proper-type | https://github.com/ilevkivskyi/mypy/tree/clean-get-proper-type |
| Conversation | https://github.com/python/mypy/pull/13326 |
| Commits18 (18) | https://github.com/python/mypy/pull/13326/commits |
| Checks | https://github.com/python/mypy/pull/13326/checks |
| Files changed | https://github.com/python/mypy/pull/13326/files |
| Cleaner usage of get_proper_type() | https://github.com/python/mypy/pull/13326#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:clean-get-proper-type | https://github.com/ilevkivskyi/mypy/tree/clean-get-proper-type |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 4, 2022 | https://github.com/python/mypy/pull/13326#issue-1329012383 |
| #13297 | https://github.com/python/mypy/pull/13297 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/13326 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| August 3, 2022 22:03 | https://github.com/python/mypy/pull/13326#commits-pushed-51670ca |
|
| https://github.com/ilevkivskyi |
| Go through subtypes.py | https://github.com/python/mypy/pull/13326/commits/51670ca106af6539b66b1d5ff21c796e4f3de0b4 |
| 51670ca | https://github.com/python/mypy/pull/13326/commits/51670ca106af6539b66b1d5ff21c796e4f3de0b4 |
|
| https://github.com/ilevkivskyi |
| Go through applytype.py | https://github.com/python/mypy/pull/13326/commits/20f0b8e44864c7b6cb8574c1f0f92e840d146d93 |
| 20f0b8e | https://github.com/python/mypy/pull/13326/commits/20f0b8e44864c7b6cb8574c1f0f92e840d146d93 |
|
| https://github.com/ilevkivskyi |
| Add couple tests | https://github.com/python/mypy/pull/13326/commits/5067998c349e54a03f3e56a87e13b28f91df492e |
| 5067998 | https://github.com/python/mypy/pull/13326/commits/5067998c349e54a03f3e56a87e13b28f91df492e |
|
| https://github.com/ilevkivskyi |
| Some more cleanup; add test | https://github.com/python/mypy/pull/13326/commits/c85098bce6ffff4026bbf51ab5c8faeba2baeb0e |
| c85098b | https://github.com/python/mypy/pull/13326/commits/c85098bce6ffff4026bbf51ab5c8faeba2baeb0e |
|
| https://github.com/ilevkivskyi |
| Fix one test | https://github.com/python/mypy/pull/13326/commits/20286fdc5bc3612bd67529f709b0a3aeffc841fe |
| 20286fd | https://github.com/python/mypy/pull/13326/commits/20286fdc5bc3612bd67529f709b0a3aeffc841fe |
|
| https://github.com/ilevkivskyi |
| Add a test case for join | https://github.com/python/mypy/pull/13326/commits/f0970b8aa46ea5c0403bbcdaaf9d6f45285187d8 |
| f0970b8 | https://github.com/python/mypy/pull/13326/commits/f0970b8aa46ea5c0403bbcdaaf9d6f45285187d8 |
|
| https://github.com/ilevkivskyi |
| Bake out one in constraints.py (just in case) | https://github.com/python/mypy/pull/13326/commits/b5a8655a97f8f8e8cfe6c15ab3173166ba550e86 |
| b5a8655 | https://github.com/python/mypy/pull/13326/commits/b5a8655a97f8f8e8cfe6c15ab3173166ba550e86 |
|
| https://github.com/ilevkivskyi |
| Mark erasetype.py as also done | https://github.com/python/mypy/pull/13326/commits/6c98581fb175e65e2cafae4fa93844020360b4ff |
| 6c98581 | https://github.com/python/mypy/pull/13326/commits/6c98581fb175e65e2cafae4fa93844020360b4ff |
|
| https://github.com/ilevkivskyi |
| Go through meet.py | https://github.com/python/mypy/pull/13326/commits/8516bd560356cde5164347f4064416ad5baa60d0 |
| 8516bd5 | https://github.com/python/mypy/pull/13326/commits/8516bd560356cde5164347f4064416ad5baa60d0 |
|
| https://github.com/ilevkivskyi |
| Mark solve.py as also done | https://github.com/python/mypy/pull/13326/commits/5b0e1010e06fe20bdbf6ab6ca815e6989f408e88 |
| 5b0e101 | https://github.com/python/mypy/pull/13326/commits/5b0e1010e06fe20bdbf6ab6ca815e6989f408e88 |
|
| https://github.com/ilevkivskyi |
| Mark argmap.py as also done | https://github.com/python/mypy/pull/13326/commits/2d6dbee6ee52917f95ec513885eba9ac2c5fcd43 |
| 2d6dbee | https://github.com/python/mypy/pull/13326/commits/2d6dbee6ee52917f95ec513885eba9ac2c5fcd43 |
|
| https://github.com/ilevkivskyi |
| Mark expandtype.py as also done | https://github.com/python/mypy/pull/13326/commits/42e1fc6420b8f5a169d62efeb65c99a6ec468273 |
| 42e1fc6 | https://github.com/python/mypy/pull/13326/commits/42e1fc6420b8f5a169d62efeb65c99a6ec468273 |
|
| https://github.com/ilevkivskyi |
| Fix self-check; mark join.py as done | https://github.com/python/mypy/pull/13326/commits/db14a35d7dd18e9d93954724e1b22ff11361412b |
| db14a35 | https://github.com/python/mypy/pull/13326/commits/db14a35d7dd18e9d93954724e1b22ff11361412b |
|
| https://github.com/ilevkivskyi |
| Update plugin | https://github.com/python/mypy/pull/13326/commits/7ae87141b908f003fa49bc8c6e33455522792269 |
| 7ae8714 | https://github.com/python/mypy/pull/13326/commits/7ae87141b908f003fa49bc8c6e33455522792269 |
|
| https://github.com/ilevkivskyi |
| Remove some unneeded calls | https://github.com/python/mypy/pull/13326/commits/a50e8e4590647c80cb409c59954de7b7c3769bf8 |
| a50e8e4 | https://github.com/python/mypy/pull/13326/commits/a50e8e4590647c80cb409c59954de7b7c3769bf8 |
|
| https://github.com/ilevkivskyi |
| Merge remote-tracking branch 'upstream/master' into clean-get-proper-… | https://github.com/python/mypy/pull/13326/commits/021f18f6ae907c405481f71be290f1d4e40186a3 |
| 021f18f | https://github.com/python/mypy/pull/13326/commits/021f18f6ae907c405481f71be290f1d4e40186a3 |
|
| https://github.com/ilevkivskyi |
| Restore some weird special-casing | https://github.com/python/mypy/pull/13326/commits/e056c81c9f8d605df059b59a3383512af8aae39e |
| e056c81 | https://github.com/python/mypy/pull/13326/commits/e056c81c9f8d605df059b59a3383512af8aae39e |
|
| https://github.com/ilevkivskyi |
| Some more fixes | https://github.com/python/mypy/pull/13326/commits/841b72c284f59a528c333ec03121460c7649dd62 |
| 841b72c | https://github.com/python/mypy/pull/13326/commits/841b72c284f59a528c333ec03121460c7649dd62 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| hauntsaninja | https://github.com/hauntsaninja |
| August 4, 2022 18:09 | https://github.com/python/mypy/pull/13326#event-7130425026 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 4, 2022 | https://github.com/python/mypy/pull/13326#issuecomment-1205607051 |
| Please reload this page | https://github.com/python/mypy/pull/13326 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 4, 2022 | https://github.com/python/mypy/pull/13326#issuecomment-1205631817 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/13326 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 4, 2022 | https://github.com/python/mypy/pull/13326#issuecomment-1205671801 |
| Please reload this page | https://github.com/python/mypy/pull/13326 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Aug 4, 2022
| https://github.com/python/mypy/pull/13326#pullrequestreview-1062477880 |
|
View reviewed changes
| https://github.com/python/mypy/pull/13326/files/841b72c284f59a528c333ec03121460c7649dd62 |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/mypy/pull/13326#pullrequestreview-1062477880 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/13326 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 43476aa | https://github.com/python/mypy/commit/43476aabf73fbe885f1db49597735c797799fa67 |
| Aug 4, 2022 | https://github.com/python/mypy/pull/13326#event-7131305720 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| August 4, 2022 20:40 | https://github.com/python/mypy/pull/13326#event-7131306078 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13326 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/13326/files/841b72c284f59a528c333ec03121460c7649dd62 |
| Please reload this page | https://github.com/python/mypy/pull/13326 |
| Please reload this page | https://github.com/python/mypy/pull/13326 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |