René's URL Explorer Experiment


Title: Merge subtype visitors by ilevkivskyi · Pull Request #13303 · python/mypy · GitHub

Open Graph Title: Merge subtype visitors by ilevkivskyi · Pull Request #13303 · python/mypy

X Title: Merge subtype visitors by ilevkivskyi · Pull Request #13303 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #3297 This removes a significant chunk of code duplication. This is not a pure refactor, there were some cases when one of the visitors (mostly non-proper one) was more correct and/or complet...

X Description: Fixes #3297 This removes a significant chunk of code duplication. This is not a pure refactor, there were some cases when one of the visitors (mostly non-proper one) was more correct and/or complet...

Opengraph URL: https://github.com/python/mypy/pull/13303

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e7106b7d-44b0-c1d3-9429-15fa0d8d4c48
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC9E:1C3DC0:390BE1:4CB936:6B00291C
html-safe-nonce0d84c30e4fe2642e2519729fd42ab1b1f20e888f9e0a4683dd1e1edace355d92
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzlFOjFDM0RDMDozOTBCRTE6NENCOTM2OjZCMDAyOTFDIiwidmlzaXRvcl9pZCI6IjE3OTI2MzM4MTE1NTM1OTAwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac38dcd2fdfa19fcd7a01fadcff025074f1967311f918b9f3c3609883342acb3bd
hovercard-subject-tagpull_request:1014360109
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/13303/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ca502fed440ae2b4da7392f4c9e9b81a5cf9cf152b8a977f84046359271456f2/python/mypy/pull/13303
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ca502fed440ae2b4da7392f4c9e9b81a5cf9cf152b8a977f84046359271456f2/python/mypy/pull/13303
og:image:altFixes #3297 This removes a significant chunk of code duplication. This is not a pure refactor, there were some cases when one of the visitors (mostly non-proper one) was more correct and/or complet...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/13303#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/13303
Reloadhttps://github.com/python/mypy/pull/13303
Reloadhttps://github.com/python/mypy/pull/13303
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:merge-subtype-visitorshttps://github.com/ilevkivskyi/mypy/tree/merge-subtype-visitors
Conversationhttps://github.com/python/mypy/pull/13303
Commits12 (12)https://github.com/python/mypy/pull/13303/commits
Checkshttps://github.com/python/mypy/pull/13303/checks
Files changedhttps://github.com/python/mypy/pull/13303/files
Merge subtype visitorshttps://github.com/python/mypy/pull/13303#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:merge-subtype-visitorshttps://github.com/ilevkivskyi/mypy/tree/merge-subtype-visitors
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 1, 2022https://github.com/python/mypy/pull/13303#issue-1324991714
#3297https://github.com/python/mypy/issues/3297
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/13303
ilevkivskyihttps://github.com/ilevkivskyi
August 1, 2022 18:10https://github.com/python/mypy/pull/13303#commits-pushed-38bfd99
https://github.com/ilevkivskyi
Merge subtype visitorshttps://github.com/python/mypy/pull/13303/commits/38bfd9964de8d417f724f29369f889ed01dcfbe3
38bfd99https://github.com/python/mypy/pull/13303/commits/38bfd9964de8d417f724f29369f889ed01dcfbe3
https://github.com/ilevkivskyi
Fix self-check and linthttps://github.com/python/mypy/pull/13303/commits/470dfe75b5058286f7bdc74a08bea7f466208a88
470dfe7https://github.com/python/mypy/pull/13303/commits/470dfe75b5058286f7bdc74a08bea7f466208a88
https://github.com/ilevkivskyi
Fix testshttps://github.com/python/mypy/pull/13303/commits/03ef94f2e689240fb9836dbaffbacc437b9b7f48
03ef94fhttps://github.com/python/mypy/pull/13303/commits/03ef94f2e689240fb9836dbaffbacc437b9b7f48
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 1, 2022https://github.com/python/mypy/pull/13303#issuecomment-1201834321
Please reload this pagehttps://github.com/python/mypy/pull/13303
https://github.com/ilevkivskyi
Try a more principled Type[...] logichttps://github.com/python/mypy/pull/13303/commits/f04b04c562364fce4174aa140ec14f83ba62744c
f04b04chttps://github.com/python/mypy/pull/13303/commits/f04b04c562364fce4174aa140ec14f83ba62744c
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303
https://github.com/ilevkivskyi
One more Type[...] related thinghttps://github.com/python/mypy/pull/13303/commits/e38702728b34868893a8a2957f326dea73997df2
e387027https://github.com/python/mypy/pull/13303/commits/e38702728b34868893a8a2957f326dea73997df2
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303
https://github.com/ilevkivskyi
Fix properness for protocolshttps://github.com/python/mypy/pull/13303/commits/0b4c820306596cfb7c4dc6c8326af0a66d1428ab
0b4c820https://github.com/python/mypy/pull/13303/commits/0b4c820306596cfb7c4dc6c8326af0a66d1428ab
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 2, 2022https://github.com/python/mypy/pull/13303#issuecomment-1203167505
@hauntsaninjahttps://github.com/hauntsaninja
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://github.com/python/mypy/pull/13303
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Aug 3, 2022https://github.com/python/mypy/pull/13303#issuecomment-1203407481
https://github.com/encode/starlette/blob/0b5b9c45ed281135f5d23d45041a12824d232260/starlette/config.py#L77https://github.com/encode/starlette/blob/0b5b9c45ed281135f5d23d45041a12824d232260/starlette/config.py#L77
Please reload this pagehttps://github.com/python/mypy/pull/13303
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Aug 3, 2022 https://github.com/python/mypy/pull/13303#pullrequestreview-1059623132
View reviewed changes https://github.com/python/mypy/pull/13303/files/0b4c820306596cfb7c4dc6c8326af0a66d1428ab
JelleZijlstrahttps://github.com/JelleZijlstra
https://github.com/python/mypy/pull/13303#pullrequestreview-1059623132
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/13303
ilevkivskyihttps://github.com/ilevkivskyi
August 3, 2022 11:51https://github.com/python/mypy/pull/13303#commits-pushed-1993339
https://github.com/ilevkivskyi
Prohibit calling is_subtype() with proper_subtype directlyhttps://github.com/python/mypy/pull/13303/commits/1993339501f36afdad56b4504bceb01afd514b58
1993339https://github.com/python/mypy/pull/13303/commits/1993339501f36afdad56b4504bceb01afd514b58
https://github.com/ilevkivskyi
Use a better split pointhttps://github.com/python/mypy/pull/13303/commits/19d81bfd272d69c22b9eba3f947434e50ce7169c
19d81bfhttps://github.com/python/mypy/pull/13303/commits/19d81bfd272d69c22b9eba3f947434e50ce7169c
https://github.com/ilevkivskyi
Mark a comment as TODOhttps://github.com/python/mypy/pull/13303/commits/4eb089f0cc36eed1a3941217803b90069dd5fe47
4eb089fhttps://github.com/python/mypy/pull/13303/commits/4eb089f0cc36eed1a3941217803b90069dd5fe47
https://github.com/ilevkivskyi
Merge remote-tracking branch 'upstream/master' into merge-subtype-vis…https://github.com/python/mypy/pull/13303/commits/cc15dc420bf1e0c693233d32ac056dd3058194c7
cc15dc4https://github.com/python/mypy/pull/13303/commits/cc15dc420bf1e0c693233d32ac056dd3058194c7
https://github.com/ilevkivskyi
Re-apply blackhttps://github.com/python/mypy/pull/13303/commits/a85194b494c9e3063207e22d33029beb81414587
a85194bhttps://github.com/python/mypy/pull/13303/commits/a85194b494c9e3063207e22d33029beb81414587
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 3, 2022https://github.com/python/mypy/pull/13303#issuecomment-1203852724
Please reload this pagehttps://github.com/python/mypy/pull/13303
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303
https://github.com/ilevkivskyi
Make it even harder to mess things uphttps://github.com/python/mypy/pull/13303/commits/2866f4263279bb9c639b07c519e0d4fc83560995
2866f42https://github.com/python/mypy/pull/13303/commits/2866f4263279bb9c639b07c519e0d4fc83560995
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 3, 2022https://github.com/python/mypy/pull/13303#issuecomment-1203924946
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/13303
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
d27bff6https://github.com/python/mypy/commit/d27bff62f71a8b914b1df239467148e81d2e88a2
Aug 3, 2022https://github.com/python/mypy/pull/13303#event-7118797915
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
August 3, 2022 13:46https://github.com/python/mypy/pull/13303#event-7118798379
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Aug 19, 2022https://github.com/python/mypy/pull/13303#issuecomment-1220342535
Please reload this pagehttps://github.com/python/mypy/pull/13303
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Aug 19, 2022 https://github.com/python/mypy/pull/13303#ref-issue-1336219147
Mypy 0.980 Release Planning #13385 https://github.com/python/mypy/issues/13385
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 20, 2022https://github.com/python/mypy/pull/13303#issuecomment-1221382063
#13461https://github.com/python/mypy/pull/13461
Please reload this pagehttps://github.com/python/mypy/pull/13303
REGR: 0.981 dict-item error for union of Iterable and Mapping #13750 https://github.com/python/mypy/issues/13750
ambiguity on using union of type[generic type] and callable in mypy==0.981 #13756 https://github.com/python/mypy/issues/13756
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Oct 3, 2022 https://github.com/python/mypy/pull/13303#ref-issue-1395400255
Hashable and None have overlapping type in mypy >= 0.981 #13805 https://github.com/python/mypy/issues/13805
JukkaLhttps://github.com/JukkaL
Dec 20, 2022 https://github.com/python/mypy/pull/13303#ref-commit-bdb32f7
https://github.com/JukkaL
Optimize type parameter checks in subtype checkinghttps://github.com/python/mypy/commit/bdb32f76df7ac34481bb315704c7b084e9c9f79c
bdb32f7https://github.com/python/mypy/commit/bdb32f76df7ac34481bb315704c7b084e9c9f79c
#13303https://github.com/python/mypy/pull/13303
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Dec 20, 2022 https://github.com/python/mypy/pull/13303#ref-pullrequest-1504591617
Optimize type parameter checks in subtype checking #14324 https://github.com/python/mypy/pull/14324
JukkaLhttps://github.com/JukkaL
Dec 20, 2022 https://github.com/python/mypy/pull/13303#ref-commit-ac480b9
https://github.com/JukkaL
Optimize subtype checking by avoiding a nested functionhttps://github.com/python/mypy/commit/ac480b9534d3c5728682f08b7a5e7551f3b44f90
ac480b9https://github.com/python/mypy/commit/ac480b9534d3c5728682f08b7a5e7551f3b44f90
#13303https://github.com/python/mypy/pull/13303
#14324https://github.com/python/mypy/pull/14324
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Dec 20, 2022 https://github.com/python/mypy/pull/13303#ref-pullrequest-1504605669
Optimize subtype checking by avoiding a nested function #14325 https://github.com/python/mypy/pull/14325
JukkaLhttps://github.com/JukkaL
Dec 20, 2022 https://github.com/python/mypy/pull/13303#ref-commit-d35e571
https://github.com/JukkaL
Optimize type parameter checks in subtype checking (https://github.com/python/mypy/commit/d35e571ef303ec63f4c8c3437669c858d85329eb
#14324https://github.com/python/mypy/pull/14324
)https://github.com/python/mypy/commit/d35e571ef303ec63f4c8c3437669c858d85329eb
d35e571https://github.com/python/mypy/commit/d35e571ef303ec63f4c8c3437669c858d85329eb
#13303https://github.com/python/mypy/pull/13303
JukkaLhttps://github.com/JukkaL
Dec 20, 2022 https://github.com/python/mypy/pull/13303#ref-commit-b5fc748
https://github.com/JukkaL
Optimize subtype checking by avoiding a nested function (https://github.com/python/mypy/commit/b5fc748a1ccb65a9d4dc0eef897c71ee8b15ddc9
#14325https://github.com/python/mypy/pull/14325
)https://github.com/python/mypy/commit/b5fc748a1ccb65a9d4dc0eef897c71ee8b15ddc9
b5fc748https://github.com/python/mypy/commit/b5fc748a1ccb65a9d4dc0eef897c71ee8b15ddc9
#13303https://github.com/python/mypy/pull/13303
#14324https://github.com/python/mypy/pull/14324
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 9, 2023 https://github.com/python/mypy/pull/13303#ref-pullrequest-1521972520
Fix incorrect join in the presence of Any fallback #14404 https://github.com/python/mypy/pull/14404
Negative type narrowing fails for protocols with overloaded methods #12228 https://github.com/python/mypy/issues/12228
Type is dropped from a Union when using TypedDicts with optional fields #11840 https://github.com/python/mypy/issues/11840
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/mypy/pull/13303/files/0b4c820306596cfb7c4dc6c8326af0a66d1428ab
Please reload this pagehttps://github.com/python/mypy/pull/13303
is_subtype vs is_proper_subtype https://github.com/python/mypy/issues/3297
Please reload this pagehttps://github.com/python/mypy/pull/13303
https://github.com/ilevkivskyi
https://github.com/JelleZijlstra
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.