| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e7106b7d-44b0-c1d3-9429-15fa0d8d4c48 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CC9E:1C3DC0:390BE1:4CB936:6B00291C |
| html-safe-nonce | 0d84c30e4fe2642e2519729fd42ab1b1f20e888f9e0a4683dd1e1edace355d92 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzlFOjFDM0RDMDozOTBCRTE6NENCOTM2OjZCMDAyOTFDIiwidmlzaXRvcl9pZCI6IjE3OTI2MzM4MTE1NTM1OTAwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 38dcd2fdfa19fcd7a01fadcff025074f1967311f918b9f3c3609883342acb3bd |
| hovercard-subject-tag | pull_request:1014360109 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/13303/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ca502fed440ae2b4da7392f4c9e9b81a5cf9cf152b8a977f84046359271456f2/python/mypy/pull/13303 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ca502fed440ae2b4da7392f4c9e9b81a5cf9cf152b8a977f84046359271456f2/python/mypy/pull/13303 |
| og:image:alt | Fixes #3297
This removes a significant chunk of code duplication. This is not a pure refactor, there were some cases when one of the visitors (mostly non-proper one) was more correct and/or complet... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/13303#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/13303 |
| Reload | https://github.com/python/mypy/pull/13303 |
| Reload | https://github.com/python/mypy/pull/13303 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:merge-subtype-visitors | https://github.com/ilevkivskyi/mypy/tree/merge-subtype-visitors |
| Conversation | https://github.com/python/mypy/pull/13303 |
| Commits12 (12) | https://github.com/python/mypy/pull/13303/commits |
| Checks | https://github.com/python/mypy/pull/13303/checks |
| Files changed | https://github.com/python/mypy/pull/13303/files |
| Merge subtype visitors | https://github.com/python/mypy/pull/13303#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:merge-subtype-visitors | https://github.com/ilevkivskyi/mypy/tree/merge-subtype-visitors |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 1, 2022 | https://github.com/python/mypy/pull/13303#issue-1324991714 |
| #3297 | https://github.com/python/mypy/issues/3297 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/13303 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| August 1, 2022 18:10 | https://github.com/python/mypy/pull/13303#commits-pushed-38bfd99 |
|
| https://github.com/ilevkivskyi |
| Merge subtype visitors | https://github.com/python/mypy/pull/13303/commits/38bfd9964de8d417f724f29369f889ed01dcfbe3 |
| 38bfd99 | https://github.com/python/mypy/pull/13303/commits/38bfd9964de8d417f724f29369f889ed01dcfbe3 |
|
| https://github.com/ilevkivskyi |
| Fix self-check and lint | https://github.com/python/mypy/pull/13303/commits/470dfe75b5058286f7bdc74a08bea7f466208a88 |
| 470dfe7 | https://github.com/python/mypy/pull/13303/commits/470dfe75b5058286f7bdc74a08bea7f466208a88 |
|
| https://github.com/ilevkivskyi |
| Fix tests | https://github.com/python/mypy/pull/13303/commits/03ef94f2e689240fb9836dbaffbacc437b9b7f48 |
| 03ef94f | https://github.com/python/mypy/pull/13303/commits/03ef94f2e689240fb9836dbaffbacc437b9b7f48 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 1, 2022 | https://github.com/python/mypy/pull/13303#issuecomment-1201834321 |
| Please reload this page | https://github.com/python/mypy/pull/13303 |
|
| https://github.com/ilevkivskyi |
| Try a more principled Type[...] logic | https://github.com/python/mypy/pull/13303/commits/f04b04c562364fce4174aa140ec14f83ba62744c |
| f04b04c | https://github.com/python/mypy/pull/13303/commits/f04b04c562364fce4174aa140ec14f83ba62744c |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303 |
|
| https://github.com/ilevkivskyi |
| One more Type[...] related thing | https://github.com/python/mypy/pull/13303/commits/e38702728b34868893a8a2957f326dea73997df2 |
| e387027 | https://github.com/python/mypy/pull/13303/commits/e38702728b34868893a8a2957f326dea73997df2 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303 |
|
| https://github.com/ilevkivskyi |
| Fix properness for protocols | https://github.com/python/mypy/pull/13303/commits/0b4c820306596cfb7c4dc6c8326af0a66d1428ab |
| 0b4c820 | https://github.com/python/mypy/pull/13303/commits/0b4c820306596cfb7c4dc6c8326af0a66d1428ab |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 2, 2022 | https://github.com/python/mypy/pull/13303#issuecomment-1203167505 |
| @hauntsaninja | https://github.com/hauntsaninja |
| @JelleZijlstra | https://github.com/JelleZijlstra |
| Please reload this page | https://github.com/python/mypy/pull/13303 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Aug 3, 2022 | https://github.com/python/mypy/pull/13303#issuecomment-1203407481 |
| https://github.com/encode/starlette/blob/0b5b9c45ed281135f5d23d45041a12824d232260/starlette/config.py#L77 | https://github.com/encode/starlette/blob/0b5b9c45ed281135f5d23d45041a12824d232260/starlette/config.py#L77 |
| Please reload this page | https://github.com/python/mypy/pull/13303 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Aug 3, 2022
| https://github.com/python/mypy/pull/13303#pullrequestreview-1059623132 |
|
View reviewed changes
| https://github.com/python/mypy/pull/13303/files/0b4c820306596cfb7c4dc6c8326af0a66d1428ab |
| JelleZijlstra | https://github.com/JelleZijlstra |
| https://github.com/python/mypy/pull/13303#pullrequestreview-1059623132 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/13303 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| August 3, 2022 11:51 | https://github.com/python/mypy/pull/13303#commits-pushed-1993339 |
|
| https://github.com/ilevkivskyi |
| Prohibit calling is_subtype() with proper_subtype directly | https://github.com/python/mypy/pull/13303/commits/1993339501f36afdad56b4504bceb01afd514b58 |
| 1993339 | https://github.com/python/mypy/pull/13303/commits/1993339501f36afdad56b4504bceb01afd514b58 |
|
| https://github.com/ilevkivskyi |
| Use a better split point | https://github.com/python/mypy/pull/13303/commits/19d81bfd272d69c22b9eba3f947434e50ce7169c |
| 19d81bf | https://github.com/python/mypy/pull/13303/commits/19d81bfd272d69c22b9eba3f947434e50ce7169c |
|
| https://github.com/ilevkivskyi |
| Mark a comment as TODO | https://github.com/python/mypy/pull/13303/commits/4eb089f0cc36eed1a3941217803b90069dd5fe47 |
| 4eb089f | https://github.com/python/mypy/pull/13303/commits/4eb089f0cc36eed1a3941217803b90069dd5fe47 |
|
| https://github.com/ilevkivskyi |
| Merge remote-tracking branch 'upstream/master' into merge-subtype-vis… | https://github.com/python/mypy/pull/13303/commits/cc15dc420bf1e0c693233d32ac056dd3058194c7 |
| cc15dc4 | https://github.com/python/mypy/pull/13303/commits/cc15dc420bf1e0c693233d32ac056dd3058194c7 |
|
| https://github.com/ilevkivskyi |
| Re-apply black | https://github.com/python/mypy/pull/13303/commits/a85194b494c9e3063207e22d33029beb81414587 |
| a85194b | https://github.com/python/mypy/pull/13303/commits/a85194b494c9e3063207e22d33029beb81414587 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 3, 2022 | https://github.com/python/mypy/pull/13303#issuecomment-1203852724 |
| Please reload this page | https://github.com/python/mypy/pull/13303 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303 |
|
| https://github.com/ilevkivskyi |
| Make it even harder to mess things up | https://github.com/python/mypy/pull/13303/commits/2866f4263279bb9c639b07c519e0d4fc83560995 |
| 2866f42 | https://github.com/python/mypy/pull/13303/commits/2866f4263279bb9c639b07c519e0d4fc83560995 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 3, 2022 | https://github.com/python/mypy/pull/13303#issuecomment-1203924946 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/13303 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| d27bff6 | https://github.com/python/mypy/commit/d27bff62f71a8b914b1df239467148e81d2e88a2 |
| Aug 3, 2022 | https://github.com/python/mypy/pull/13303#event-7118797915 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| August 3, 2022 13:46 | https://github.com/python/mypy/pull/13303#event-7118798379 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| Aug 19, 2022 | https://github.com/python/mypy/pull/13303#issuecomment-1220342535 |
| Please reload this page | https://github.com/python/mypy/pull/13303 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Aug 19, 2022
| https://github.com/python/mypy/pull/13303#ref-issue-1336219147 |
|
Mypy 0.980 Release Planning
#13385
| https://github.com/python/mypy/issues/13385 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 20, 2022 | https://github.com/python/mypy/pull/13303#issuecomment-1221382063 |
| #13461 | https://github.com/python/mypy/pull/13461 |
| Please reload this page | https://github.com/python/mypy/pull/13303 |
|
REGR: 0.981 dict-item error for union of Iterable and Mapping
#13750
| https://github.com/python/mypy/issues/13750 |
|
ambiguity on using union of type[generic type] and callable in mypy==0.981
#13756
| https://github.com/python/mypy/issues/13756 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Oct 3, 2022
| https://github.com/python/mypy/pull/13303#ref-issue-1395400255 |
|
Hashable and None have overlapping type in mypy >= 0.981
#13805
| https://github.com/python/mypy/issues/13805 |
| JukkaL | https://github.com/JukkaL |
|
Dec 20, 2022
| https://github.com/python/mypy/pull/13303#ref-commit-bdb32f7 |
|
| https://github.com/JukkaL |
| Optimize type parameter checks in subtype checking | https://github.com/python/mypy/commit/bdb32f76df7ac34481bb315704c7b084e9c9f79c |
| bdb32f7 | https://github.com/python/mypy/commit/bdb32f76df7ac34481bb315704c7b084e9c9f79c |
| #13303 | https://github.com/python/mypy/pull/13303 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Dec 20, 2022
| https://github.com/python/mypy/pull/13303#ref-pullrequest-1504591617 |
|
Optimize type parameter checks in subtype checking
#14324
| https://github.com/python/mypy/pull/14324 |
| JukkaL | https://github.com/JukkaL |
|
Dec 20, 2022
| https://github.com/python/mypy/pull/13303#ref-commit-ac480b9 |
|
| https://github.com/JukkaL |
| Optimize subtype checking by avoiding a nested function | https://github.com/python/mypy/commit/ac480b9534d3c5728682f08b7a5e7551f3b44f90 |
| ac480b9 | https://github.com/python/mypy/commit/ac480b9534d3c5728682f08b7a5e7551f3b44f90 |
| #13303 | https://github.com/python/mypy/pull/13303 |
| #14324 | https://github.com/python/mypy/pull/14324 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Dec 20, 2022
| https://github.com/python/mypy/pull/13303#ref-pullrequest-1504605669 |
|
Optimize subtype checking by avoiding a nested function
#14325
| https://github.com/python/mypy/pull/14325 |
| JukkaL | https://github.com/JukkaL |
|
Dec 20, 2022
| https://github.com/python/mypy/pull/13303#ref-commit-d35e571 |
|
| https://github.com/JukkaL |
| Optimize type parameter checks in subtype checking ( | https://github.com/python/mypy/commit/d35e571ef303ec63f4c8c3437669c858d85329eb |
| #14324 | https://github.com/python/mypy/pull/14324 |
| ) | https://github.com/python/mypy/commit/d35e571ef303ec63f4c8c3437669c858d85329eb |
| d35e571 | https://github.com/python/mypy/commit/d35e571ef303ec63f4c8c3437669c858d85329eb |
| #13303 | https://github.com/python/mypy/pull/13303 |
| JukkaL | https://github.com/JukkaL |
|
Dec 20, 2022
| https://github.com/python/mypy/pull/13303#ref-commit-b5fc748 |
|
| https://github.com/JukkaL |
| Optimize subtype checking by avoiding a nested function ( | https://github.com/python/mypy/commit/b5fc748a1ccb65a9d4dc0eef897c71ee8b15ddc9 |
| #14325 | https://github.com/python/mypy/pull/14325 |
| ) | https://github.com/python/mypy/commit/b5fc748a1ccb65a9d4dc0eef897c71ee8b15ddc9 |
| b5fc748 | https://github.com/python/mypy/commit/b5fc748a1ccb65a9d4dc0eef897c71ee8b15ddc9 |
| #13303 | https://github.com/python/mypy/pull/13303 |
| #14324 | https://github.com/python/mypy/pull/14324 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jan 9, 2023
| https://github.com/python/mypy/pull/13303#ref-pullrequest-1521972520 |
|
Fix incorrect join in the presence of Any fallback
#14404
| https://github.com/python/mypy/pull/14404 |
|
Negative type narrowing fails for protocols with overloaded methods
#12228
| https://github.com/python/mypy/issues/12228 |
|
Type is dropped from a Union when using TypedDicts with optional fields
#11840
| https://github.com/python/mypy/issues/11840 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F13303 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/mypy/pull/13303/files/0b4c820306596cfb7c4dc6c8326af0a66d1428ab |
| Please reload this page | https://github.com/python/mypy/pull/13303 |
|
is_subtype vs is_proper_subtype
| https://github.com/python/mypy/issues/3297 |
| Please reload this page | https://github.com/python/mypy/pull/13303 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |