René's URL Explorer Experiment


Title: Use class name as namespace for type variables by JukkaL · Pull Request #12590 · python/mypy · GitHub

Open Graph Title: Use class name as namespace for type variables by JukkaL · Pull Request #12590 · python/mypy

X Title: Use class name as namespace for type variables by JukkaL · Pull Request #12590 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This avoids confusion between type variables of two classes, which can happen at least in some edge cases. Type variables are only the same if both the numeric id and namespace match (plus meta lev...

X Description: This avoids confusion between type variables of two classes, which can happen at least in some edge cases. Type variables are only the same if both the numeric id and namespace match (plus meta lev...

Opengraph URL: https://github.com/python/mypy/pull/12590

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:47941d5c-2e0e-e7f3-80f0-2709dbebf1a1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C00:21E5F:96C30:CB51B:6B001BD7
html-safe-nonce1e3c118bb5719a1fb031cae5982271a31e08ffe97b229740c2cbd4c2d65697a8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzAwOjIxRTVGOjk2QzMwOkNCNTFCOjZCMDAxQkQ3IiwidmlzaXRvcl9pZCI6IjkxOTM0MjY5NDY4NDE2NDgwODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1093da104aff24691609e6a8892a567b7a873df38c6a68808159f7c12e925942
hovercard-subject-tagpull_request:910155910
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/12590/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5b0b15ec7ccaa198682bb2eddae76201baf0a35c9c048966b2fbdf1f7e19a548/python/mypy/pull/12590
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5b0b15ec7ccaa198682bb2eddae76201baf0a35c9c048966b2fbdf1f7e19a548/python/mypy/pull/12590
og:image:altThis avoids confusion between type variables of two classes, which can happen at least in some edge cases. Type variables are only the same if both the numeric id and namespace match (plus meta lev...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJukkaL
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/12590#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12590
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12590
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/12590
Reloadhttps://github.com/python/mypy/pull/12590
Reloadhttps://github.com/python/mypy/pull/12590
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
tvar-namespacinghttps://github.com/python/mypy/tree/tvar-namespacing
Conversationhttps://github.com/python/mypy/pull/12590
Commits8 (8)https://github.com/python/mypy/pull/12590/commits
Checkshttps://github.com/python/mypy/pull/12590/checks
Files changedhttps://github.com/python/mypy/pull/12590/files
Use class name as namespace for type variableshttps://github.com/python/mypy/pull/12590#top
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
tvar-namespacinghttps://github.com/python/mypy/tree/tvar-namespacing
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Apr 14, 2022https://github.com/python/mypy/pull/12590#issue-1204764911
#12588https://github.com/python/mypy/issues/12588
Please reload this pagehttps://github.com/python/mypy/pull/12590
JukkaLhttps://github.com/JukkaL
April 14, 2022 16:09https://github.com/python/mypy/pull/12590#commits-pushed-7eabfe2
https://github.com/JukkaL
Add namespacing to class type variables to avoid conflictshttps://github.com/python/mypy/pull/12590/commits/7eabfe24356d056657305bc81093312d9f7cc78c
7eabfe2https://github.com/python/mypy/pull/12590/commits/7eabfe24356d056657305bc81093312d9f7cc78c
https://github.com/JukkaL
Fix serializationhttps://github.com/python/mypy/pull/12590/commits/4990c9b972d254e4e05c35ab8a760955ce9664ed
4990c9bhttps://github.com/python/mypy/pull/12590/commits/4990c9b972d254e4e05c35ab8a760955ce9664ed
https://github.com/JukkaL
WIP testshttps://github.com/python/mypy/pull/12590/commits/0959c4af96ad47a41b41e9484781b6a78465039e
0959c4ahttps://github.com/python/mypy/pull/12590/commits/0959c4af96ad47a41b41e9484781b6a78465039e
https://github.com/JukkaL
Fix match statement issuehttps://github.com/python/mypy/pull/12590/commits/f111aad3d788c0126e54120571159a4d47befd1a
f111aadhttps://github.com/python/mypy/pull/12590/commits/f111aad3d788c0126e54120571159a4d47befd1a
https://github.com/JukkaL
Fix serializationhttps://github.com/python/mypy/pull/12590/commits/14a24c00298632063d8552e11f23b5da0d1bfebf
14a24c0https://github.com/python/mypy/pull/12590/commits/14a24c00298632063d8552e11f23b5da0d1bfebf
https://github.com/JukkaL
Clean up testshttps://github.com/python/mypy/pull/12590/commits/d3ae7b1679e913f9fc22e0d8a23cc93531170fbc
d3ae7b1https://github.com/python/mypy/pull/12590/commits/d3ae7b1679e913f9fc22e0d8a23cc93531170fbc
https://github.com/JukkaL
Update commenthttps://github.com/python/mypy/pull/12590/commits/b38953a23362cb74fb13ac2461e8b9304aa1bf3e
b38953ahttps://github.com/python/mypy/pull/12590/commits/b38953a23362cb74fb13ac2461e8b9304aa1bf3e
https://github.com/JukkaL
Add TODOhttps://github.com/python/mypy/pull/12590/commits/70b4ab2724aa0e1861f410fdfdda08cea7799275
70b4ab2https://github.com/python/mypy/pull/12590/commits/70b4ab2724aa0e1861f410fdfdda08cea7799275
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 14, 2022https://github.com/python/mypy/pull/12590#issuecomment-1099432221
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/12590
https://github.com/jhance
jhancehttps://github.com/jhance
Apr 15, 2022 https://github.com/python/mypy/pull/12590#pullrequestreview-943749329
View reviewed changes https://github.com/python/mypy/pull/12590/files/70b4ab2724aa0e1861f410fdfdda08cea7799275
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 15, 2022https://github.com/python/mypy/pull/12590#issuecomment-1100424486
Please reload this pagehttps://github.com/python/mypy/pull/12590
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 16, 2022https://github.com/python/mypy/pull/12590#issuecomment-1100501992
@A5rockshttps://github.com/A5rocks
#11657https://github.com/python/mypy/pull/11657
Please reload this pagehttps://github.com/python/mypy/pull/12590
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Apr 16, 2022 https://github.com/python/mypy/pull/12590#pullrequestreview-943833907
View reviewed changes https://github.com/python/mypy/pull/12590/files/70b4ab2724aa0e1861f410fdfdda08cea7799275
A5rockshttps://github.com/A5rocks
https://github.com/python/mypy/pull/12590#pullrequestreview-943833907
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/12590
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Apr 19, 2022https://github.com/python/mypy/pull/12590#issuecomment-1102497615
@A5rockshttps://github.com/A5rocks
Please reload this pagehttps://github.com/python/mypy/pull/12590
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
20b0b9bhttps://github.com/python/mypy/commit/20b0b9b460cd11a4755f70ae08823fa6a8f5fbd4
Apr 19, 2022https://github.com/python/mypy/pull/12590#event-6454241339
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
April 19, 2022 10:50https://github.com/python/mypy/pull/12590#event-6454241467
JukkaLhttps://github.com/JukkaL
Apr 19, 2022 https://github.com/python/mypy/pull/12590#ref-commit-d96330b
https://github.com/JukkaL
Use class name as namespace for type variables (https://github.com/python/mypy/commit/d96330b67a71c4d8031f08ab913fd3f7de0be222
#12590https://github.com/python/mypy/pull/12590
)https://github.com/python/mypy/commit/d96330b67a71c4d8031f08ab913fd3f7de0be222
d96330bhttps://github.com/python/mypy/commit/d96330b67a71c4d8031f08ab913fd3f7de0be222
#12588https://github.com/python/mypy/issues/12588
JukkaLhttps://github.com/JukkaL
Apr 19, 2022 https://github.com/python/mypy/pull/12590#ref-commit-3d5376f
https://github.com/JukkaL
Add overlapping type variables test casehttps://github.com/python/mypy/commit/3d5376f0297a9ecb22b9931b7f1bc0d3215231d7
3d5376fhttps://github.com/python/mypy/commit/3d5376f0297a9ecb22b9931b7f1bc0d3215231d7
@A5rockshttps://github.com/A5rocks
#11657https://github.com/python/mypy/pull/11657
#12590https://github.com/python/mypy/pull/12590
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Apr 19, 2022 https://github.com/python/mypy/pull/12590#ref-pullrequest-1208176739
Add overlapping type variables test case #12623 https://github.com/python/mypy/pull/12623
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 19, 2022 https://github.com/python/mypy/pull/12590#ref-issue-1206397297
add test case: regression w/ mypy mis-interpreting generator comprehension #12610 https://github.com/python/mypy/issues/12610
Ensure TypeVarIds are unique #11657 https://github.com/python/mypy/pull/11657
Release 0.950 planning #12579 https://github.com/python/mypy/issues/12579
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 19, 2022 https://github.com/python/mypy/pull/12590#ref-pullrequest-1208698340
Add test case for recently fixed enumerate regression #12627 https://github.com/python/mypy/pull/12627
hauntsaninjahttps://github.com/hauntsaninja
Apr 20, 2022 https://github.com/python/mypy/pull/12590#ref-commit-0bcca59
https://github.com/JukkaL
Add overlapping type variables test case (https://github.com/python/mypy/commit/0bcca591b49cbc9349d55ba4d38b85f9bc222566
#12623https://github.com/python/mypy/pull/12623
)https://github.com/python/mypy/commit/0bcca591b49cbc9349d55ba4d38b85f9bc222566
0bcca59https://github.com/python/mypy/commit/0bcca591b49cbc9349d55ba4d38b85f9bc222566
@A5rockshttps://github.com/A5rocks
#11657https://github.com/python/mypy/pull/11657
#12590https://github.com/python/mypy/pull/12590
https://github.com/cdce8p
cdce8phttps://github.com/cdce8p
Apr 20, 2022 https://github.com/python/mypy/pull/12590#ref-issue-1210268318
Regression with generic TypeVar inheritance #12633 https://github.com/python/mypy/issues/12633
cdce8phttps://github.com/cdce8p
Apr 21, 2022 https://github.com/python/mypy/pull/12590#ref-commit-775fa41
https://github.com/cdce8p
Revert "Use class name as namespace for type variables (https://github.com/cdce8p/mypy/commit/775fa41808381a1b777275c4fc1b8f06d52828f5
python#12590https://github.com/python/mypy/pull/12590
)"https://github.com/cdce8p/mypy/commit/775fa41808381a1b777275c4fc1b8f06d52828f5
775fa41https://github.com/cdce8p/mypy/commit/775fa41808381a1b777275c4fc1b8f06d52828f5
20b0b9bhttps://github.com/cdce8p/mypy/commit/20b0b9b460cd11a4755f70ae08823fa6a8f5fbd4
cdce8phttps://github.com/cdce8p
Apr 21, 2022 https://github.com/python/mypy/pull/12590#ref-commit-3547354
https://github.com/cdce8p
Revert "Use class name as namespace for type variables (https://github.com/cdce8p/mypy/commit/3547354b9b117f8e56e4e0fc554ef1e3c7304941
python#12590https://github.com/python/mypy/pull/12590
)"https://github.com/cdce8p/mypy/commit/3547354b9b117f8e56e4e0fc554ef1e3c7304941
3547354https://github.com/cdce8p/mypy/commit/3547354b9b117f8e56e4e0fc554ef1e3c7304941
20b0b9bhttps://github.com/cdce8p/mypy/commit/20b0b9b460cd11a4755f70ae08823fa6a8f5fbd4
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 21, 2022 https://github.com/python/mypy/pull/12590#ref-issue-1210737251
[Add test case] Bug in return type of deque.copy() in generic type #12641 https://github.com/python/mypy/issues/12641
Add regression test for recently fixed deque.copy() bug #12648 https://github.com/python/mypy/pull/12648
Generic classes with nested generic classes can't have different TypeVars #5551 https://github.com/python/mypy/issues/5551
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 21, 2022 https://github.com/python/mypy/pull/12590#ref-pullrequest-1211631370
Add test case for fixed bug regarding nested generic classes #12652 https://github.com/python/mypy/pull/12652
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 22, 2022 https://github.com/python/mypy/pull/12590#ref-commit-09dbdf6
https://github.com/AlexWaygood
Add test case for fixed bug regarding nested generic classes (https://github.com/python/mypy/commit/09dbdf6c1020aac533e0a7e71eeb97f1f1dd00f9
#12652https://github.com/python/mypy/pull/12652
)https://github.com/python/mypy/commit/09dbdf6c1020aac533e0a7e71eeb97f1f1dd00f9
09dbdf6https://github.com/python/mypy/commit/09dbdf6c1020aac533e0a7e71eeb97f1f1dd00f9
#5551https://github.com/python/mypy/issues/5551
#12590https://github.com/python/mypy/pull/12590
cdce8phttps://github.com/cdce8p
Apr 23, 2022 https://github.com/python/mypy/pull/12590#ref-commit-2c6e598
https://github.com/cdce8p
Revert "Use class name as namespace for type variables (https://github.com/cdce8p/mypy/commit/2c6e5988dc3b85ec2afa8a7bfb472f0527c9961f
python#12590https://github.com/python/mypy/pull/12590
)"https://github.com/cdce8p/mypy/commit/2c6e5988dc3b85ec2afa8a7bfb472f0527c9961f
2c6e598https://github.com/cdce8p/mypy/commit/2c6e5988dc3b85ec2afa8a7bfb472f0527c9961f
20b0b9bhttps://github.com/cdce8p/mypy/commit/20b0b9b460cd11a4755f70ae08823fa6a8f5fbd4
cdce8phttps://github.com/cdce8p
Apr 24, 2022 https://github.com/python/mypy/pull/12590#ref-commit-89abce5
https://github.com/cdce8p
Revert "Use class name as namespace for type variables (https://github.com/cdce8p/mypy/commit/89abce519bca24c5a79be3a69ff975e9a7b6f3a3
python#12590https://github.com/python/mypy/pull/12590
)"https://github.com/cdce8p/mypy/commit/89abce519bca24c5a79be3a69ff975e9a7b6f3a3
89abce5https://github.com/cdce8p/mypy/commit/89abce519bca24c5a79be3a69ff975e9a7b6f3a3
20b0b9bhttps://github.com/cdce8p/mypy/commit/20b0b9b460cd11a4755f70ae08823fa6a8f5fbd4
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Nov 12, 2022 https://github.com/python/mypy/pull/12590#ref-issue-1444322746
(regression) Interaction between __new__ and Generics #14061 https://github.com/python/mypy/issues/14061
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Jul 18, 2023 https://github.com/python/mypy/pull/12590#ref-issue-1803346574
Mypy errors out with attrs, generics and inheritance #15658 https://github.com/python/mypy/issues/15658
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Aug 13, 2023 https://github.com/python/mypy/pull/12590#ref-issue-975569057
Inconsistent errors adding to list of generic values #10999 https://github.com/python/mypy/issues/10999
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12590
https://github.com/jhance
jhance https://github.com/jhance
https://github.com/python/mypy/pull/12590/files/70b4ab2724aa0e1861f410fdfdda08cea7799275
https://github.com/A5rocks
A5rocks https://github.com/A5rocks
https://github.com/python/mypy/pull/12590/files/70b4ab2724aa0e1861f410fdfdda08cea7799275
Please reload this pagehttps://github.com/python/mypy/pull/12590
Invalid type inference for zip in a generic class https://github.com/python/mypy/issues/12588
Please reload this pagehttps://github.com/python/mypy/pull/12590
https://github.com/JukkaL
https://github.com/JelleZijlstra
https://github.com/hauntsaninja
https://github.com/jhance
https://github.com/A5rocks
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.