| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:06953f38-2419-2dae-cae2-3ada173dc9c5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB72:609A0:329444D:429539C:6B00292E |
| html-safe-nonce | ee4a7da0c40fad2b333a56de86a5b9e445e002d4e2b771294e5d9b12ed6fb1db |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjcyOjYwOUEwOjMyOTQ0NEQ6NDI5NTM5Qzo2QjAwMjkyRSIsInZpc2l0b3JfaWQiOiIyOTUyNDgyODExNjY5MzkxNjYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 92813b3ddbe652b7ee1cdd4ab6aea1edbfe1a0e10b339e6021b12b911e0dc18f |
| hovercard-subject-tag | pull_request:839487231 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/12118/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f2f2c5dbb9efa8b395dd5c3e2926b011fa29872e89944e04ee2216fa0da4bedb/python/mypy/pull/12118 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f2f2c5dbb9efa8b395dd5c3e2926b011fa29872e89944e04ee2216fa0da4bedb/python/mypy/pull/12118 |
| og:image:alt | Description
closes #8005
closes #8926
Based on the quick fix idea from this comment by @ilevkivskyi .
For the problem description see #8005. The underlying problem is arguably #2350, but that seems... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tmke8 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/12118#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12118 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12118 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/12118 |
| Reload | https://github.com/python/mypy/pull/12118 |
| Reload | https://github.com/python/mypy/pull/12118 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| tmke8:protocol-empty-methods2 | https://github.com/tmke8/mypy/tree/protocol-empty-methods2 |
| Conversation | https://github.com/python/mypy/pull/12118 |
| Commits11 (11) | https://github.com/python/mypy/pull/12118/commits |
| Checks | https://github.com/python/mypy/pull/12118/checks |
| Files changed | https://github.com/python/mypy/pull/12118/files |
| Treat methods with empty bodies in Protocols as abstract | https://github.com/python/mypy/pull/12118#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| tmke8:protocol-empty-methods2 | https://github.com/tmke8/mypy/tree/protocol-empty-methods2 |
|
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
| Feb 3, 2022 | https://github.com/python/mypy/pull/12118#issue-1123301586 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| #8005 | https://github.com/python/mypy/issues/8005 |
| #8926 | https://github.com/python/mypy/issues/8926 |
| from this comment | https://github.com/python/mypy/issues/8005#issuecomment-558341465 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| #8005 | https://github.com/python/mypy/issues/8005 |
| #2350 | https://github.com/python/mypy/issues/2350 |
| #8111 | https://github.com/python/mypy/pull/8111 |
| #8111 | https://github.com/python/mypy/pull/8111 |
| #8111 | https://github.com/python/mypy/pull/8111 |
| pointed out here | https://github.com/python/mypy/issues/2350#issuecomment-256701609 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/nickgaya |
| nickgaya | https://github.com/nickgaya |
| Feb 4, 2022 | https://github.com/python/mypy/pull/12118#issuecomment-1029612283 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| #8005 | https://github.com/python/mypy/issues/8005 |
| #8926 | https://github.com/python/mypy/issues/8926 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Feb 4, 2022
| https://github.com/python/mypy/pull/12118#pullrequestreview-872833563 |
|
View reviewed changes
| https://github.com/python/mypy/pull/12118/files |
| sobolevn | https://github.com/sobolevn |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/python/mypy/pull/12118#pullrequestreview-872833563 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/semanal.py | https://github.com/python/mypy/pull/12118/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Feb 4, 2022
| https://github.com/python/mypy/pull/12118#ref-pullrequest-1123987621 |
|
Sync mypy_primer_comment with typeshed
#12125
| https://github.com/python/mypy/pull/12125 |
| https://github.com/a-reich |
| a-reich | https://github.com/a-reich |
| Feb 4, 2022 | https://github.com/python/mypy/pull/12118#issuecomment-1030032733 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
| Feb 4, 2022 | https://github.com/python/mypy/pull/12118#issuecomment-1030126429 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| the PEP | https://www.python.org/dev/peps/pep-0544/ |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
| Feb 4, 2022 | https://github.com/python/mypy/pull/12118#issuecomment-1030136765 |
| #2350 | https://github.com/python/mypy/issues/2350 |
| #8111 | https://github.com/python/mypy/pull/8111 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
| force-pushed | https://github.com/python/mypy/compare/2f9d921fa3d756c268065f03b591272032637ded..e09397d0cec83bbd4ebd33512a0194b6e5ccc087 |
| 2f9d921 | https://github.com/python/mypy/commit/2f9d921fa3d756c268065f03b591272032637ded |
| e09397d | https://github.com/python/mypy/commit/e09397d0cec83bbd4ebd33512a0194b6e5ccc087 |
|
Compare
| https://github.com/python/mypy/compare/2f9d921fa3d756c268065f03b591272032637ded..e09397d0cec83bbd4ebd33512a0194b6e5ccc087 |
| February 10, 2022 13:58 | https://github.com/python/mypy/pull/12118#event-6042422810 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
| Feb 10, 2022 | https://github.com/python/mypy/pull/12118#issuecomment-1034956861 |
| #8926 | https://github.com/python/mypy/issues/8926 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12118 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
| force-pushed | https://github.com/python/mypy/compare/e09397d0cec83bbd4ebd33512a0194b6e5ccc087..74be938a047aff1e3072ecae331186ae6b3e3727 |
| e09397d | https://github.com/python/mypy/commit/e09397d0cec83bbd4ebd33512a0194b6e5ccc087 |
| 74be938 | https://github.com/python/mypy/commit/74be938a047aff1e3072ecae331186ae6b3e3727 |
|
Compare
| https://github.com/python/mypy/compare/e09397d0cec83bbd4ebd33512a0194b6e5ccc087..74be938a047aff1e3072ecae331186ae6b3e3727 |
| February 23, 2022 12:44 | https://github.com/python/mypy/pull/12118#event-6124725853 |
| https://github.com/ian-r-rose |
| ian-r-rose | https://github.com/ian-r-rose |
|
Apr 22, 2022
| https://github.com/python/mypy/pull/12118#ref-pullrequest-1126460865 |
|
Collection Protocol
dask/dask#8674
| https://github.com/dask/dask/pull/8674 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
| Jul 22, 2022 | https://github.com/python/mypy/pull/12118#issuecomment-1192410421 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Jul 23, 2022
| https://github.com/python/mypy/pull/12118#pullrequestreview-1048540872 |
|
View reviewed changes
| https://github.com/python/mypy/pull/12118/files |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/12118#pullrequestreview-1048540872 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
| Jul 24, 2022 | https://github.com/python/mypy/pull/12118#issuecomment-1193382611 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| tmke8 | https://github.com/tmke8 |
| July 29, 2022 13:56 | https://github.com/python/mypy/pull/12118#commits-pushed-af4e8fd |
|
| https://github.com/tmke8 |
| Treat methods with empty bodies in Protocols as abstract | https://github.com/python/mypy/pull/12118/commits/af4e8fd24d65c1cca82b4c647a4a367409ff6fe6 |
| af4e8fd | https://github.com/python/mypy/pull/12118/commits/af4e8fd24d65c1cca82b4c647a4a367409ff6fe6 |
| python#8005 | https://github.com/python/mypy/issues/8005 |
| python#8926 | https://github.com/python/mypy/issues/8926 |
|
| https://github.com/tmke8 |
| Address code review feedback | https://github.com/python/mypy/pull/12118/commits/aaaf4c45ed6c3750b0ef2bb5cf96c1319cf25af5 |
| aaaf4c4 | https://github.com/python/mypy/pull/12118/commits/aaaf4c45ed6c3750b0ef2bb5cf96c1319cf25af5 |
|
| https://github.com/tmke8 |
| Format with black | https://github.com/python/mypy/pull/12118/commits/614c9cc16bbf25c19d44ce1e58ba84a14c0b6cf2 |
| 614c9cc | https://github.com/python/mypy/pull/12118/commits/614c9cc16bbf25c19d44ce1e58ba84a14c0b6cf2 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
| force-pushed | https://github.com/python/mypy/compare/74be938a047aff1e3072ecae331186ae6b3e3727..614c9cc16bbf25c19d44ce1e58ba84a14c0b6cf2 |
| 74be938 | https://github.com/python/mypy/commit/74be938a047aff1e3072ecae331186ae6b3e3727 |
| 614c9cc | https://github.com/python/mypy/commit/614c9cc16bbf25c19d44ce1e58ba84a14c0b6cf2 |
|
Compare
| https://github.com/python/mypy/compare/74be938a047aff1e3072ecae331186ae6b3e3727..614c9cc16bbf25c19d44ce1e58ba84a14c0b6cf2 |
| July 29, 2022 11:57 | https://github.com/python/mypy/pull/12118#event-7088891001 |
| tmke8 | https://github.com/tmke8 |
| July 29, 2022 16:03 | https://github.com/python/mypy/pull/12118#commits-pushed-5714b56 |
|
| https://github.com/tmke8 |
| Don't special-case none-return | https://github.com/python/mypy/pull/12118/commits/5714b56cc2ef9a146632beb79c8e0d8561108ce3 |
| 5714b56 | https://github.com/python/mypy/pull/12118/commits/5714b56cc2ef9a146632beb79c8e0d8561108ce3 |
|
| https://github.com/tmke8 |
| Add a nice note to the error message | https://github.com/python/mypy/pull/12118/commits/8ad2ee16a0cce19ccef1bd0bc335be51f5e81307 |
| 8ad2ee1 | https://github.com/python/mypy/pull/12118/commits/8ad2ee16a0cce19ccef1bd0bc335be51f5e81307 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12118 |
| tmke8 | https://github.com/tmke8 |
| July 30, 2022 13:18 | https://github.com/python/mypy/pull/12118#commits-pushed-84a2f88 |
|
| https://github.com/tmke8 |
| Fix most errors | https://github.com/python/mypy/pull/12118/commits/84a2f88dd5c76d0de489b1a9866eff2d10860d16 |
| 84a2f88 | https://github.com/python/mypy/pull/12118/commits/84a2f88dd5c76d0de489b1a9866eff2d10860d16 |
|
| https://github.com/tmke8 |
| Prevent protocols from becoming abstract | https://github.com/python/mypy/pull/12118/commits/decee85074f191bd2153f129799e7f15ca5eebb2 |
| decee85 | https://github.com/python/mypy/pull/12118/commits/decee85074f191bd2153f129799e7f15ca5eebb2 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
| Jul 30, 2022 | https://github.com/python/mypy/pull/12118#issuecomment-1200164591 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/yelp/paasta | https://github.com/yelp/paasta |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12118 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 2, 2022
| https://github.com/python/mypy/pull/12118#pullrequestreview-1058520820 |
|
View reviewed changes
| https://github.com/python/mypy/pull/12118/files/decee85074f191bd2153f129799e7f15ca5eebb2 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/12118#pullrequestreview-1058520820 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/checker.py | https://github.com/python/mypy/pull/12118/files/decee85074f191bd2153f129799e7f15ca5eebb2#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/strconv.py | https://github.com/python/mypy/pull/12118/files/decee85074f191bd2153f129799e7f15ca5eebb2#diff-143edb163bb2e8e724b6e28f363b00e1f7e43e633199ca4376ff8c905c80fd2f |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/semanal.py | https://github.com/python/mypy/pull/12118/files/decee85074f191bd2153f129799e7f15ca5eebb2#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/checkexpr.py | https://github.com/python/mypy/pull/12118/files/decee85074f191bd2153f129799e7f15ca5eebb2#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/checkexpr.py | https://github.com/python/mypy/pull/12118/files/decee85074f191bd2153f129799e7f15ca5eebb2#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/messages.py | https://github.com/python/mypy/pull/12118/files/decee85074f191bd2153f129799e7f15ca5eebb2#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/checkexpr.py | https://github.com/python/mypy/pull/12118/files/decee85074f191bd2153f129799e7f15ca5eebb2#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/checkexpr.py | https://github.com/python/mypy/pull/12118/files/decee85074f191bd2153f129799e7f15ca5eebb2#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/nodes.py | https://github.com/python/mypy/pull/12118/files/decee85074f191bd2153f129799e7f15ca5eebb2#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/nodes.py | https://github.com/python/mypy/pull/12118/files/decee85074f191bd2153f129799e7f15ca5eebb2#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 2, 2022 | https://github.com/python/mypy/pull/12118#issuecomment-1202320117 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| tmke8 | https://github.com/tmke8 |
| August 2, 2022 14:43 | https://github.com/python/mypy/pull/12118#commits-pushed-2e99ddd |
|
| https://github.com/tmke8 |
| Address review feedback | https://github.com/python/mypy/pull/12118/commits/2e99ddd321adebcebf4081beec88e98b10c9c4c3 |
| 2e99ddd | https://github.com/python/mypy/pull/12118/commits/2e99ddd321adebcebf4081beec88e98b10c9c4c3 |
|
| https://github.com/tmke8 |
| Don't mark as implicitly abstract if it's already abstract | https://github.com/python/mypy/pull/12118/commits/b2f3fbd793ee411f6c750cd91b9a3cfe679c99ec |
| b2f3fbd | https://github.com/python/mypy/pull/12118/commits/b2f3fbd793ee411f6c750cd91b9a3cfe679c99ec |
|
| https://github.com/tmke8 |
| Fix context of new message | https://github.com/python/mypy/pull/12118/commits/b96e4ecd1efc0f707f6ff0f593912ba3adb14683 |
| b96e4ec | https://github.com/python/mypy/pull/12118/commits/b96e4ecd1efc0f707f6ff0f593912ba3adb14683 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
| Aug 2, 2022 | https://github.com/python/mypy/pull/12118#issuecomment-1202683714 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 2, 2022
| https://github.com/python/mypy/pull/12118#pullrequestreview-1059105628 |
|
View reviewed changes
| https://github.com/python/mypy/pull/12118/files/b96e4ecd1efc0f707f6ff0f593912ba3adb14683 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/12118#pullrequestreview-1059105628 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| mypy/messages.py | https://github.com/python/mypy/pull/12118/files/b96e4ecd1efc0f707f6ff0f593912ba3adb14683#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 2, 2022 | https://github.com/python/mypy/pull/12118#discussion_r935826771 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| tmke8 | https://github.com/tmke8 |
| Aug 2, 2022 | https://github.com/python/mypy/pull/12118#discussion_r935864644 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12118 |
|
| https://github.com/tmke8 |
| Tweak the note | https://github.com/python/mypy/pull/12118/commits/7dc8d868e90273e2310831bf7cfb5d55f8748b93 |
| 7dc8d86 | https://github.com/python/mypy/pull/12118/commits/7dc8d868e90273e2310831bf7cfb5d55f8748b93 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 2, 2022 | https://github.com/python/mypy/pull/12118#issuecomment-1203075538 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 1bb970a | https://github.com/python/mypy/commit/1bb970a874653964c7313521db4b7a6c69296232 |
| Aug 2, 2022 | https://github.com/python/mypy/pull/12118#event-7112411335 |
| https://github.com/cmeyer |
| cmeyer | https://github.com/cmeyer |
|
Sep 29, 2022
| https://github.com/python/mypy/pull/12118#ref-issue-1391153734 |
|
Incorrect "implicitly abstract" function when function returns None and implementation is 'pass'
#13770
| https://github.com/python/mypy/issues/13770 |
|
Remove NullLocker and satisfy mypy 0.990
python-poetry/poetry#7006
| https://github.com/python-poetry/poetry/issues/7006 |
|
Fix: Remove NullLocker
python-poetry/poetry#7025
| https://github.com/python-poetry/poetry/pull/7025 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
|
Jan 28, 2026
| https://github.com/python/mypy/pull/12118#ref-pullrequest-3851654813 |
|
[ty] Recognize functions with stub bodies in Protocol classes as implicitly abstract
astral-sh/ruff#22838
| https://github.com/astral-sh/ruff/pull/22838 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12118 |
|
| https://github.com/sobolevn |
|
sobolevn
| https://github.com/sobolevn |
|
| https://github.com/python/mypy/pull/12118/files/2f9d921fa3d756c268065f03b591272032637ded |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/12118/files/b96e4ecd1efc0f707f6ff0f593912ba3adb14683 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
|
Should concrete implementations be required to implement protocol?
| https://github.com/python/mypy/issues/8926 |
|
Extending a Protocol leads to unsafe behavior
| https://github.com/python/mypy/issues/8005 |
| Please reload this page | https://github.com/python/mypy/pull/12118 |
|
| https://github.com/tmke8 |
|
| https://github.com/nickgaya |
|
| https://github.com/a-reich |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/sobolevn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |