| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:68f9c781-69d6-d0ba-b8c6-158c6f5367e7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C380:157BA1:168EA7:1E9A46:6B001FCD |
| html-safe-nonce | fbcd1c783806a8f7f60575f58833a55fbecc5840688cc7062c84a105892a5972 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzgwOjE1N0JBMToxNjhFQTc6MUU5QTQ2OjZCMDAxRkNEIiwidmlzaXRvcl9pZCI6Ijg3MTE3MDE0MTM0Njc1MjkxNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 449e7f033e1c5ca887242da150cc9306e541dadf6fcffd10c6633fed7a78c62a |
| hovercard-subject-tag | pull_request:833786507 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/12086/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dd8bea4f636d214c1a4b09c1b013c085343d709562c9c3e4c7471e901d454044/python/mypy/pull/12086 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dd8bea4f636d214c1a4b09c1b013c085343d709562c9c3e4c7471e901d454044/python/mypy/pull/12086 |
| og:image:alt | Motivation
Detect unreachable except branches as proposed here #11514.
try:
error()
except Exception:
pass
except RuntimeError: # This is unreachable.
pass
These checks are already imp... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kreathon |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/12086#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12086 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12086 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/12086 |
| Reload | https://github.com/python/mypy/pull/12086 |
| Reload | https://github.com/python/mypy/pull/12086 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| kreathon | https://github.com/kreathon |
| python:master | https://github.com/python/mypy/tree/master |
| kreathon:unreachable-except-blocks-errors | https://github.com/kreathon/mypy/tree/unreachable-except-blocks-errors |
| Conversation | https://github.com/python/mypy/pull/12086 |
| Commits8 (8) | https://github.com/python/mypy/pull/12086/commits |
| Checks | https://github.com/python/mypy/pull/12086/checks |
| Files changed | https://github.com/python/mypy/pull/12086/files |
| Report unreachable except blocks | https://github.com/python/mypy/pull/12086#top |
| kreathon | https://github.com/kreathon |
| python:master | https://github.com/python/mypy/tree/master |
| kreathon:unreachable-except-blocks-errors | https://github.com/kreathon/mypy/tree/unreachable-except-blocks-errors |
|
| https://github.com/kreathon |
| kreathon | https://github.com/kreathon |
| Jan 27, 2022 | https://github.com/python/mypy/pull/12086#issue-1116627659 |
| #11514 | https://github.com/python/mypy/issues/11514 |
| microsoft/pyright#2761 | https://github.com/microsoft/pyright/issues/2761 |
| @sobolevn | https://github.com/sobolevn |
| #11514 | https://github.com/python/mypy/issues/11514 |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
|
| https://github.com/kreathon |
| Report unreachable except blocks | https://github.com/python/mypy/pull/12086/commits/18673874edb66340bb589ff5bf2f2e5065d94dd9 |
| 1867387 | https://github.com/python/mypy/pull/12086/commits/18673874edb66340bb589ff5bf2f2e5065d94dd9 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Jan 27, 2022
| https://github.com/python/mypy/pull/12086#pullrequestreview-865315040 |
|
View reviewed changes
| https://github.com/python/mypy/pull/12086/files/18673874edb66340bb589ff5bf2f2e5065d94dd9 |
| sobolevn | https://github.com/sobolevn |
| https://github.com/python/mypy/pull/12086#pullrequestreview-865315040 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| mypy/checker.py | https://github.com/python/mypy/pull/12086/files/18673874edb66340bb589ff5bf2f2e5065d94dd9#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| sobolevn | https://github.com/sobolevn |
| Jan 27, 2022 | https://github.com/python/mypy/pull/12086#discussion_r793917467 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| kreathon | https://github.com/kreathon |
| Jan 28, 2022 | https://github.com/python/mypy/pull/12086#discussion_r794681869 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| mypy/messages.py | https://github.com/python/mypy/pull/12086/files/18673874edb66340bb589ff5bf2f2e5065d94dd9#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0 |
| sobolevn | https://github.com/sobolevn |
| Jan 27, 2022 | https://github.com/python/mypy/pull/12086#discussion_r793918156 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/12086/files/18673874edb66340bb589ff5bf2f2e5065d94dd9#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| sobolevn | https://github.com/sobolevn |
| Jan 27, 2022 | https://github.com/python/mypy/pull/12086#discussion_r793919185 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| kreathon | https://github.com/kreathon |
| Jan 28, 2022 | https://github.com/python/mypy/pull/12086#discussion_r794669362 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| sobolevn | https://github.com/sobolevn |
| Jan 28, 2022 | https://github.com/python/mypy/pull/12086#discussion_r794681611 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/12086/files/18673874edb66340bb589ff5bf2f2e5065d94dd9#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| sobolevn | https://github.com/sobolevn |
| Jan 27, 2022 | https://github.com/python/mypy/pull/12086#discussion_r793919423 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/12086/files/18673874edb66340bb589ff5bf2f2e5065d94dd9#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| sobolevn | https://github.com/sobolevn |
| Jan 27, 2022 | https://github.com/python/mypy/pull/12086#discussion_r793920131 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| kreathon | https://github.com/kreathon |
| Jan 28, 2022 | https://github.com/python/mypy/pull/12086#discussion_r794683532 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/12086/files/18673874edb66340bb589ff5bf2f2e5065d94dd9#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| sobolevn | https://github.com/sobolevn |
| Jan 27, 2022 | https://github.com/python/mypy/pull/12086#discussion_r793920530 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| kreathon | https://github.com/kreathon |
| Jan 28, 2022 | https://github.com/python/mypy/pull/12086#discussion_r794685611 |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| sobolevn | https://github.com/sobolevn |
| Jan 28, 2022 | https://github.com/python/mypy/pull/12086#discussion_r794687060 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| kreathon | https://github.com/kreathon |
| January 28, 2022 16:40 | https://github.com/python/mypy/pull/12086#commits-pushed-14ee9a1 |
|
| https://github.com/kreathon |
| Move errors to message_registry | https://github.com/python/mypy/pull/12086/commits/14ee9a158f12e4cd3de55d23a02c1adeb0672dc2 |
| 14ee9a1 | https://github.com/python/mypy/pull/12086/commits/14ee9a158f12e4cd3de55d23a02c1adeb0672dc2 |
|
| https://github.com/kreathon |
| Split tests and make them more expressive | https://github.com/python/mypy/pull/12086/commits/374e680f2bbcaeb7838afb6cd58ca7983558c4f4 |
| 374e680 | https://github.com/python/mypy/pull/12086/commits/374e680f2bbcaeb7838afb6cd58ca7983558c4f4 |
|
| https://github.com/kreathon |
| Add safety check | https://github.com/python/mypy/pull/12086/commits/5b4d73ddfd6be314b61e7f677371bc424bce589c |
| 5b4d73d | https://github.com/python/mypy/pull/12086/commits/5b4d73ddfd6be314b61e7f677371bc424bce589c |
|
| https://github.com/kreathon |
| Add test for no errors without --warn-unreachable flag | https://github.com/python/mypy/pull/12086/commits/0576effcff4677d507c3f6e4ad700556d7042784 |
| 0576eff | https://github.com/python/mypy/pull/12086/commits/0576effcff4677d507c3f6e4ad700556d7042784 |
|
| https://github.com/kreathon |
| Add type to 'UNREACHABLE' (to satisfy mypyc) | https://github.com/python/mypy/pull/12086/commits/0c3d194dba40865d97c5ef0067f711eb3a412c9d |
| 0c3d194 | https://github.com/python/mypy/pull/12086/commits/0c3d194dba40865d97c5ef0067f711eb3a412c9d |
| https://github.com/kreathon |
| kreathon | https://github.com/kreathon |
| Jan 28, 2022 | https://github.com/python/mypy/pull/12086#issuecomment-1024497113 |
| @sobolevn | https://github.com/sobolevn |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Feb 2, 2022
| https://github.com/python/mypy/pull/12086#pullrequestreview-870263510 |
|
View reviewed changes
| https://github.com/python/mypy/pull/12086/files/0c3d194dba40865d97c5ef0067f711eb3a412c9d |
| mypy/checker.py | https://github.com/python/mypy/pull/12086/files/0c3d194dba40865d97c5ef0067f711eb3a412c9d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| sobolevn | https://github.com/sobolevn |
| Feb 2, 2022 | https://github.com/python/mypy/pull/12086#discussion_r797405060 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| kreathon | https://github.com/kreathon |
| Feb 3, 2022 | https://github.com/python/mypy/pull/12086#discussion_r798802956 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| kreathon | https://github.com/kreathon |
| Feb 17, 2022 | https://github.com/python/mypy/pull/12086#discussion_r809359495 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @sobolevn | https://github.com/sobolevn |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| https://github.com/kreathon |
| kreathon | https://github.com/kreathon |
| sobolevn | https://github.com/sobolevn |
| March 10, 2022 16:57 | https://github.com/python/mypy/pull/12086#event-6219325588 |
|
| https://github.com/kreathon |
| Merge branch 'master' into unreachable-except-blocks-errors | https://github.com/python/mypy/pull/12086/commits/143ae23160e39aa989b433bea363b355428bc122 |
| 143ae23 | https://github.com/python/mypy/pull/12086/commits/143ae23160e39aa989b433bea363b355428bc122 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12086 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| May 1, 2022 | https://github.com/python/mypy/pull/12086#issuecomment-1114228049 |
| #12631 | https://github.com/python/mypy/pull/12631 |
| #12699 | https://github.com/python/mypy/pull/12699 |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
|
| https://github.com/kreathon |
| Replace disable_errors call with new filter_errors call | https://github.com/python/mypy/pull/12086/commits/329bd3658f0fea6c65333af9fcce6e08bcdaa96b |
| 329bd36 | https://github.com/python/mypy/pull/12086/commits/329bd3658f0fea6c65333af9fcce6e08bcdaa96b |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| May 1, 2022 | https://github.com/python/mypy/pull/12086#issuecomment-1114270930 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
| https://github.com/kreathon |
| kreathon | https://github.com/kreathon |
| Dec 27, 2023 | https://github.com/python/mypy/pull/12086#event-11345472046 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F12086 |
|
| https://github.com/sobolevn |
|
sobolevn
| https://github.com/sobolevn |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
|
Detect unreachable except branches
| https://github.com/python/mypy/issues/11514 |
| Please reload this page | https://github.com/python/mypy/pull/12086 |
|
| https://github.com/kreathon |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/sobolevn |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |