| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1829e4ce-7074-adb5-a841-2c5c339cf35c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D350:2A0045:2EB05F5:3D9974C:6B0023DA |
| html-safe-nonce | 7bcacf180afe1e43636d87f13beadb87cbe0f7208518d6f259f073823b8636b4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzUwOjJBMDA0NToyRUIwNUY1OjNEOTk3NEM6NkIwMDIzREEiLCJ2aXNpdG9yX2lkIjoiODEyNzg4OTU5MjcwODc2ODczMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e982e029df860430a6e8eadd17aefea5db62d07e8c1d3d9e20ce90fdc90c04dd |
| hovercard-subject-tag | pull_request:775660744 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/11496/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ffba0bc08a0d709b35ccfa510b0fc42e38b3898651ca15edb1c633eb44104d6f/python/mypy/pull/11496 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ffba0bc08a0d709b35ccfa510b0fc42e38b3898651ca15edb1c633eb44104d6f/python/mypy/pull/11496 |
| og:image:alt | Closes #11463
Closes #11495
I still need to add a test case for 3.9, where there's no unsafe_hash arg, but __hash__ is still added somehow.
Right now I just want to see the CI results. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/11496#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/11496 |
| Reload | https://github.com/python/mypy/pull/11496 |
| Reload | https://github.com/python/mypy/pull/11496 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| sobolevn | https://github.com/sobolevn |
| python:master | https://github.com/python/mypy/tree/master |
| Conversation | https://github.com/python/mypy/pull/11496 |
| Commits10 (10) | https://github.com/python/mypy/pull/11496/commits |
| Checks | https://github.com/python/mypy/pull/11496/checks |
| Files changed | https://github.com/python/mypy/pull/11496/files |
| Adds __hash__ method to @dataclasses.dataclass, refs #11463 | https://github.com/python/mypy/pull/11496#top |
| sobolevn | https://github.com/sobolevn |
| python:master | https://github.com/python/mypy/tree/master |
|
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Nov 8, 2021 | https://github.com/python/mypy/pull/11496#issue-1047571919 |
| #11463 | https://github.com/python/mypy/issues/11463 |
| #11495 | https://github.com/python/mypy/issues/11495 |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Nov 12, 2021
| https://github.com/python/mypy/pull/11496#pullrequestreview-801654084 |
|
View reviewed changes
| https://github.com/python/mypy/pull/11496/files |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/11496#pullrequestreview-801654084 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| mypy/plugins/dataclasses.py | https://github.com/python/mypy/pull/11496/files#diff-1fdad80f805993800524fbb9b684cc3d09879f54a0e51c71f2a447c7d46c1eb4 |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| mypy/plugins/dataclasses.py | https://github.com/python/mypy/pull/11496/files#diff-1fdad80f805993800524fbb9b684cc3d09879f54a0e51c71f2a447c7d46c1eb4 |
| JukkaL | https://github.com/JukkaL |
| Nov 9, 2021 | https://github.com/python/mypy/pull/11496#discussion_r745894119 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| sobolevn | https://github.com/sobolevn |
| Nov 16, 2021 | https://github.com/python/mypy/pull/11496#discussion_r750047599 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| test-data/unit/check-dataclasses.test | https://github.com/python/mypy/pull/11496/files#diff-5379cab042a82b77ec5dffbbe846636f62f6c7482d537a998b285f7629ea1888 |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| mypy/plugins/dataclasses.py | https://github.com/python/mypy/pull/11496/files#diff-1fdad80f805993800524fbb9b684cc3d09879f54a0e51c71f2a447c7d46c1eb4 |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Dec 11, 2021
| https://github.com/python/mypy/pull/11496#ref-issue-1076901364 |
|
Release 0.930 planning
#11700
| https://github.com/python/mypy/issues/11700 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Dec 13, 2021 | https://github.com/python/mypy/pull/11496#issuecomment-992583419 |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Dec 14, 2021 | https://github.com/python/mypy/pull/11496#issuecomment-993524320 |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Feb 6, 2022
| https://github.com/python/mypy/pull/11496#ref-issue-1107998785 |
|
Release 0.940 planning
#12021
| https://github.com/python/mypy/issues/12021 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Feb 22, 2022 | https://github.com/python/mypy/pull/11496#issuecomment-1047862112 |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| sobolevn | https://github.com/sobolevn |
| February 22, 2022 19:48 | https://github.com/python/mypy/pull/11496#commits-pushed-0c915ca |
|
| https://github.com/sobolevn |
| Adds | https://github.com/python/mypy/pull/11496/commits/0c915cae82f790d1709ccf5bb05a969144a53a1a |
| __hash__ | https://github.com/python/mypy/pull/11496/commits/0c915cae82f790d1709ccf5bb05a969144a53a1a |
| method to | https://github.com/python/mypy/pull/11496/commits/0c915cae82f790d1709ccf5bb05a969144a53a1a |
| @dataclasses.dataclass | https://github.com/python/mypy/pull/11496/commits/0c915cae82f790d1709ccf5bb05a969144a53a1a |
| , refs | https://github.com/python/mypy/pull/11496/commits/0c915cae82f790d1709ccf5bb05a969144a53a1a |
| #11463 | https://github.com/python/mypy/issues/11463 |
| 0c915ca | https://github.com/python/mypy/pull/11496/commits/0c915cae82f790d1709ccf5bb05a969144a53a1a |
|
| https://github.com/sobolevn |
| Fixes version specific issues | https://github.com/python/mypy/pull/11496/commits/d355e6ab7fa2be562dd11a081e665c82481afe8b |
| d355e6a | https://github.com/python/mypy/pull/11496/commits/d355e6ab7fa2be562dd11a081e665c82481afe8b |
|
| https://github.com/sobolevn |
| Flake8 | https://github.com/python/mypy/pull/11496/commits/1eeb9b99577b7164f8f6017e2b725bc0b42640b1 |
| 1eeb9b9 | https://github.com/python/mypy/pull/11496/commits/1eeb9b99577b7164f8f6017e2b725bc0b42640b1 |
|
| https://github.com/sobolevn |
| Fixes CI | https://github.com/python/mypy/pull/11496/commits/89bee702c06435459ee515688c45edb58d8b020e |
| 89bee70 | https://github.com/python/mypy/pull/11496/commits/89bee702c06435459ee515688c45edb58d8b020e |
|
| https://github.com/sobolevn |
| Fixes CI | https://github.com/python/mypy/pull/11496/commits/48e9839c9eec2974df75d35cb4059566a41f3a6b |
| 48e9839 | https://github.com/python/mypy/pull/11496/commits/48e9839c9eec2974df75d35cb4059566a41f3a6b |
|
| https://github.com/sobolevn |
| Addresses review | https://github.com/python/mypy/pull/11496/commits/40081cbdea3b0013714ea7f9e683822f65a0fd1e |
| 40081cb | https://github.com/python/mypy/pull/11496/commits/40081cbdea3b0013714ea7f9e683822f65a0fd1e |
|
| https://github.com/sobolevn |
| Typo | https://github.com/python/mypy/pull/11496/commits/1961bac0590e3b7a0cf0e3e2ef6d08d9ba9d9931 |
| 1961bac | https://github.com/python/mypy/pull/11496/commits/1961bac0590e3b7a0cf0e3e2ef6d08d9ba9d9931 |
|
| https://github.com/sobolevn |
| Addresses review | https://github.com/python/mypy/pull/11496/commits/635c47f45302613fc66dd62d30ab6c3883f312fb |
| 635c47f | https://github.com/python/mypy/pull/11496/commits/635c47f45302613fc66dd62d30ab6c3883f312fb |
|
| https://github.com/sobolevn |
| Fix ci | https://github.com/python/mypy/pull/11496/commits/6415faa917fb12b2efc7e4532543cf20b5236383 |
| 6415faa | https://github.com/python/mypy/pull/11496/commits/6415faa917fb12b2efc7e4532543cf20b5236383 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Jul 19, 2022 | https://github.com/python/mypy/pull/11496#event-7019754068 |
|
| https://github.com/sobolevn |
| Merge branch 'master' into issue-11463 | https://github.com/python/mypy/pull/11496/commits/c7645b87f1ffee925fca1d29b2c84c8d63aabe83 |
| c7645b8 | https://github.com/python/mypy/pull/11496/commits/c7645b87f1ffee925fca1d29b2c84c8d63aabe83 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Jul 19, 2022 | https://github.com/python/mypy/pull/11496#issuecomment-1188929138 |
| @AlexWaygood | https://github.com/AlexWaygood |
| Adds __hash__ method to @dataclasses.dataclass, refs #11463 #11496 | https://github.com/python/mypy/pull/11496 |
| Disallow to use TypeGuard type outside of .ret_type, refs #11765 #11790 | https://github.com/python/mypy/pull/11790 |
| @classmethod and @staticmethod were not shown in error messages when cached #11793 | https://github.com/python/mypy/pull/11793 |
| Fixes how ** affects inference in {} expressions, refs #11691 #11693 | https://github.com/python/mypy/pull/11693 |
| Fix @dataclass(frozen=True) fail on name shadowing #12088 | https://github.com/python/mypy/pull/12088 |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Jul 19, 2022 | https://github.com/python/mypy/pull/11496#issuecomment-1188935255 |
| Do not count __slots__ as a protocol member #11885 | https://github.com/python/mypy/pull/11885 |
| Adds Literal type math #11992 | https://github.com/python/mypy/pull/11992 |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Jul 19, 2022 | https://github.com/python/mypy/pull/11496#event-7020019185 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Jul 19, 2022 | https://github.com/python/mypy/pull/11496#event-7020019476 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Jul 19, 2022 | https://github.com/python/mypy/pull/11496#event-7020155772 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Jul 19, 2022
| https://github.com/python/mypy/pull/11496#ref-pullrequest-1309430531 |
|
Adds __hash__ method to @dataclasses.dataclass
#13187
| https://github.com/python/mypy/pull/13187 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jul 19, 2022 | https://github.com/python/mypy/pull/11496#issuecomment-1188981290 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11496 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/11496/files/ce850447e546781723f8ae00c8e98762dee3e98f |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
|
@dataclass does not handle __hash__: None special case
| https://github.com/python/mypy/issues/11495 |
|
dataclass is not Hashable
| https://github.com/python/mypy/issues/11463 |
| Please reload this page | https://github.com/python/mypy/pull/11496 |
|
| https://github.com/sobolevn |
|
| https://github.com/JukkaL |
|
| https://github.com/AlexWaygood |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |