| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3d2e080a-a6be-a16c-a5c5-83f761a9ca98 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D012:1756E4:16F1E90:1E39B41:6B002251 |
| html-safe-nonce | 817126f7519b9ffe3e30a1d973390ac00601832b2644454d752d18f273d54207 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDEyOjE3NTZFNDoxNkYxRTkwOjFFMzlCNDE6NkIwMDIyNTEiLCJ2aXNpdG9yX2lkIjoiMjQ5OTU0MDgyNjI2MzEzNDgwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5c1b950c235d9eb4a3432c2592a706e54cfe622c36c43adda77ea3409da7fdb7 |
| hovercard-subject-tag | pull_request:774361944 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/11478/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d044fb844419fb90abb0b09bbf5501eba9b6255610e9f5ed3eb56576659b9758/python/mypy/pull/11478 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d044fb844419fb90abb0b09bbf5501eba9b6255610e9f5ed3eb56576659b9758/python/mypy/pull/11478 |
| og:image:alt | As always, changing is_subtype is quite hard. There are multiple corner cases.
I am not sure that this will work, but let's see what the CI will say.
Closes #11470
Closes #11469 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/11478#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11478 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11478 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/11478 |
| Reload | https://github.com/python/mypy/pull/11478 |
| Reload | https://github.com/python/mypy/pull/11478 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| sobolevn | https://github.com/sobolevn |
| python:master | https://github.com/python/mypy/tree/master |
| Conversation | https://github.com/python/mypy/pull/11478 |
| Commits9 (9) | https://github.com/python/mypy/pull/11478/commits |
| Checks | https://github.com/python/mypy/pull/11478/checks |
| Files changed | https://github.com/python/mypy/pull/11478/files |
| Enhance is_subtype for TypeType | https://github.com/python/mypy/pull/11478#top |
| sobolevn | https://github.com/sobolevn |
| python:master | https://github.com/python/mypy/tree/master |
|
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Nov 5, 2021 | https://github.com/python/mypy/pull/11478#issue-1045982106 |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
| #11470 | https://github.com/python/mypy/issues/11470 |
| #11469 | https://github.com/python/mypy/issues/11469 |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
|
| https://github.com/sobolevn |
| Enhance | https://github.com/python/mypy/pull/11478/commits/a59ee23f02af134dbc9627a94fb38d33d05adb2d |
| is_subtype | https://github.com/python/mypy/pull/11478/commits/a59ee23f02af134dbc9627a94fb38d33d05adb2d |
| for | https://github.com/python/mypy/pull/11478/commits/a59ee23f02af134dbc9627a94fb38d33d05adb2d |
| TypeType | https://github.com/python/mypy/pull/11478/commits/a59ee23f02af134dbc9627a94fb38d33d05adb2d |
| , refs | https://github.com/python/mypy/pull/11478/commits/a59ee23f02af134dbc9627a94fb38d33d05adb2d |
| #11470 | https://github.com/python/mypy/issues/11470 |
| a59ee23 | https://github.com/python/mypy/pull/11478/commits/a59ee23f02af134dbc9627a94fb38d33d05adb2d |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Nov 5, 2021
| https://github.com/python/mypy/pull/11478#pullrequestreview-799043796 |
|
View reviewed changes
| https://github.com/python/mypy/pull/11478/files/a59ee23f02af134dbc9627a94fb38d33d05adb2d |
| test-data/unit/check-generic-subtyping.test | https://github.com/python/mypy/pull/11478/files/a59ee23f02af134dbc9627a94fb38d33d05adb2d#diff-6a712ae6fdcaa321e5fce6f0867be4ec2db8ffa014dc1c4c50720521b2ae6d61 |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11478 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Nov 5, 2021 | https://github.com/python/mypy/pull/11478#issuecomment-962010777 |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
|
| https://github.com/sobolevn |
| Simplifies test case | https://github.com/python/mypy/pull/11478/commits/7a393005d5eebc0f79ece60ad372503a2dde27c8 |
| 7a39300 | https://github.com/python/mypy/pull/11478/commits/7a393005d5eebc0f79ece60ad372503a2dde27c8 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Nov 5, 2021 | https://github.com/python/mypy/pull/11478#issuecomment-962030916 |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
| sobolevn | https://github.com/sobolevn |
| November 5, 2021 19:19 | https://github.com/python/mypy/pull/11478#commits-pushed-b57562a |
|
| https://github.com/sobolevn |
| Fixes fixture | https://github.com/python/mypy/pull/11478/commits/b57562ac7a5c596df9380d2db2a0f2118d9986ab |
| b57562a | https://github.com/python/mypy/pull/11478/commits/b57562ac7a5c596df9380d2db2a0f2118d9986ab |
|
| https://github.com/sobolevn |
| oups | https://github.com/python/mypy/pull/11478/commits/102219f3d10d3e48b87871473437353c1ce9cc54 |
| 102219f | https://github.com/python/mypy/pull/11478/commits/102219f3d10d3e48b87871473437353c1ce9cc54 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11478 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11478 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11478 |
|
| https://github.com/sobolevn |
| Adds fallback: Instance to TypeType | https://github.com/python/mypy/pull/11478/commits/302b27c7acce3bdbac68bfb6d3a7140da4bbbefc |
| 302b27c | https://github.com/python/mypy/pull/11478/commits/302b27c7acce3bdbac68bfb6d3a7140da4bbbefc |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Nov 5, 2021 | https://github.com/python/mypy/pull/11478#issuecomment-962211185 |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11478 |
| sobolevn | https://github.com/sobolevn |
| November 6, 2021 09:58 | https://github.com/python/mypy/pull/11478#commits-pushed-7c04bba |
|
| https://github.com/sobolevn |
| Revert "Adds fallback: Instance to TypeType" | https://github.com/python/mypy/pull/11478/commits/7c04bba0203c54e44e5fd198f3c9abbfd43e3016 |
| 7c04bba | https://github.com/python/mypy/pull/11478/commits/7c04bba0203c54e44e5fd198f3c9abbfd43e3016 |
| 302b27c | https://github.com/python/mypy/commit/302b27c7acce3bdbac68bfb6d3a7140da4bbbefc |
|
| https://github.com/sobolevn |
| New attempt: now TypeType.fallback is a class var | https://github.com/python/mypy/pull/11478/commits/43c214529c12e8e594075e62250ee6dd53f91ac7 |
| 43c2145 | https://github.com/python/mypy/pull/11478/commits/43c214529c12e8e594075e62250ee6dd53f91ac7 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Nov 6, 2021 | https://github.com/python/mypy/pull/11478#issuecomment-962411459 |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Nov 6, 2021
| https://github.com/python/mypy/pull/11478#ref-issue-1045431051 |
|
type[object] is not considered Hashable, when it is. And inconsistent inference of types
#11469
| https://github.com/python/mypy/issues/11469 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11478 |
|
| https://github.com/sobolevn |
| Adds test cases from | https://github.com/python/mypy/pull/11478/commits/a931f17a6b5a0bfdf34e02a7c9485bcc611844d0 |
| #11469 | https://github.com/python/mypy/issues/11469 |
| a931f17 | https://github.com/python/mypy/pull/11478/commits/a931f17a6b5a0bfdf34e02a7c9485bcc611844d0 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11478 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Nov 6, 2021 | https://github.com/python/mypy/pull/11478#event-5577801772 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Nov 6, 2021 | https://github.com/python/mypy/pull/11478#event-5577801784 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11478 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Nov 6, 2021 | https://github.com/python/mypy/pull/11478#issuecomment-962420711 |
| @JelleZijlstra | https://github.com/JelleZijlstra |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Nov 12, 2021
| https://github.com/python/mypy/pull/11478#ref-pullrequest-1045446184 |
|
Make dict KeyType bound to Hashable
python/typeshed#6244
| https://github.com/python/typeshed/pull/6244 |
| https://github.com/pranavrajpal |
| pranavrajpal | https://github.com/pranavrajpal |
|
Nov 30, 2021
| https://github.com/python/mypy/pull/11478#pullrequestreview-818568459 |
|
View reviewed changes
| https://github.com/python/mypy/pull/11478/files/a931f17a6b5a0bfdf34e02a7c9485bcc611844d0 |
| mypy/types.py | https://github.com/python/mypy/pull/11478/files/a931f17a6b5a0bfdf34e02a7c9485bcc611844d0#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664 |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
|
| https://github.com/sobolevn |
|
| https://github.com/pranavrajpal |
| Update mypy/types.py | https://github.com/python/mypy/pull/11478/commits/d37a43f8a3ef6eebc972b576db3df16ece93e0fa |
| d37a43f | https://github.com/python/mypy/pull/11478/commits/d37a43f8a3ef6eebc972b576db3df16ece93e0fa |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 30, 2021 | https://github.com/python/mypy/pull/11478#issuecomment-982369440 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Dec 3, 2021
| https://github.com/python/mypy/pull/11478#pullrequestreview-822661925 |
|
View reviewed changes
| https://github.com/python/mypy/pull/11478/files/d37a43f8a3ef6eebc972b576db3df16ece93e0fa |
| mypy/checker.py | https://github.com/python/mypy/pull/11478/files/d37a43f8a3ef6eebc972b576db3df16ece93e0fa#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| JukkaL | https://github.com/JukkaL |
| Dec 3, 2021 | https://github.com/python/mypy/pull/11478#discussion_r761943806 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
| sobolevn | https://github.com/sobolevn |
| Dec 3, 2021 | https://github.com/python/mypy/pull/11478#discussion_r762003877 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
| https://github.com/A5rocks |
| A5rocks | https://github.com/A5rocks |
| Dec 30, 2022 | https://github.com/python/mypy/pull/11478#issuecomment-1368124662 |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
| https://github.com/A5rocks |
| A5rocks | https://github.com/A5rocks |
|
Jan 21, 2023
| https://github.com/python/mypy/pull/11478#ref-pullrequest-1551070354 |
|
stdlib: Add bound Hashable for keys of mappings
python/typeshed#9570
| https://github.com/python/typeshed/pull/9570 |
| https://github.com/Hnasar |
| Hnasar | https://github.com/Hnasar |
|
Feb 10, 2024
| https://github.com/python/mypy/pull/11478#ref-issue-2063042618 |
|
Unexpected behavior with type narrowing and Callable
#16738
| https://github.com/python/mypy/issues/16738 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11478 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/mypy/pull/11478/files/a59ee23f02af134dbc9627a94fb38d33d05adb2d |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/11478/files/d37a43f8a3ef6eebc972b576db3df16ece93e0fa |
|
| https://github.com/pranavrajpal |
|
pranavrajpal
| https://github.com/pranavrajpal |
|
| https://github.com/python/mypy/pull/11478/files/a931f17a6b5a0bfdf34e02a7c9485bcc611844d0 |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
|
type[Any] not considered Hashable
| https://github.com/python/mypy/issues/11470 |
|
type[object] is not considered Hashable, when it is. And inconsistent inference of types
| https://github.com/python/mypy/issues/11469 |
| Please reload this page | https://github.com/python/mypy/pull/11478 |
|
| https://github.com/sobolevn |
|
| https://github.com/A5rocks |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/JukkaL |
|
| https://github.com/pranavrajpal |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |