René's URL Explorer Experiment


Title: Checks module bodies to be reachable by sobolevn · Pull Request #11361 · python/mypy · GitHub

Open Graph Title: Checks module bodies to be reachable by sobolevn · Pull Request #11361 · python/mypy

X Title: Checks module bodies to be reachable by sobolevn · Pull Request #11361 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This is a very simple change, but now module bodies are also checked to be reachable. Let's see what effect it will have. Closes #11331

X Description: This is a very simple change, but now module bodies are also checked to be reachable. Let's see what effect it will have. Closes #11331

Opengraph URL: https://github.com/python/mypy/pull/11361

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fe1952e7-7552-85a1-3d6d-fa57564707d4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCEA:354B:642F0F:824ECE:6AFFC98B
html-safe-nonce6195aa543ad4a78257e2291603134290d594b344a13d1f864b376ebbf884eaf0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0VBOjM1NEI6NjQyRjBGOjgyNEVDRTo2QUZGQzk4QiIsInZpc2l0b3JfaWQiOiIxOTQ5ODA5NTc5NTg4MDQ1MTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace1ee36024247e4108391d39375b6e285623e9dd2059577f78b71cc5d9b17a44c
hovercard-subject-tagpull_request:761626642
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/11361/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/edf70f04f124652e6e162a7867b8cf898dc19919171a6e0d077461e108a0c5ca/python/mypy/pull/11361
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/edf70f04f124652e6e162a7867b8cf898dc19919171a6e0d077461e108a0c5ca/python/mypy/pull/11361
og:image:altThis is a very simple change, but now module bodies are also checked to be reachable. Let's see what effect it will have. Closes #11331
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None1e805b832df235bb21305db712c3b6432920019dfc12cb25b9cb8d3b0c9403cf
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8fa4a54e6871c7908eda1c246ad5972982c0b59d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/11361#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11361
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11361
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/11361
Reloadhttps://github.com/python/mypy/pull/11361
Reloadhttps://github.com/python/mypy/pull/11361
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
Conversationhttps://github.com/python/mypy/pull/11361
Commits6 (6)https://github.com/python/mypy/pull/11361/commits
Checkshttps://github.com/python/mypy/pull/11361/checks
Files changedhttps://github.com/python/mypy/pull/11361/files
Checks module bodies to be reachablehttps://github.com/python/mypy/pull/11361#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Oct 19, 2021https://github.com/python/mypy/pull/11361#issue-1030545381
Please reload this pagehttps://github.com/python/mypy/pull/11361
#11331https://github.com/python/mypy/issues/11331
Please reload this pagehttps://github.com/python/mypy/pull/11361
sobolevnhttps://github.com/sobolevn
October 19, 2021 20:00https://github.com/python/mypy/pull/11361#commits-pushed-8f8e9b6
https://github.com/sobolevn
Very naive attempt tohttps://github.com/python/mypy/pull/11361/commits/8f8e9b690e44771fa654a0ee123a6c4203c0de3c
fixhttps://github.com/python/mypy/pull/11361/commits/8f8e9b690e44771fa654a0ee123a6c4203c0de3c
#11331https://github.com/python/mypy/issues/11331
8f8e9b6https://github.com/python/mypy/pull/11361/commits/8f8e9b690e44771fa654a0ee123a6c4203c0de3c
https://github.com/sobolevn
Very naive attempt tohttps://github.com/python/mypy/pull/11361/commits/582e6f92ea6357d4dc9cc3cbbe85cf24a2c42726
fixhttps://github.com/python/mypy/pull/11361/commits/582e6f92ea6357d4dc9cc3cbbe85cf24a2c42726
#11331https://github.com/python/mypy/issues/11331
582e6f9https://github.com/python/mypy/pull/11361/commits/582e6f92ea6357d4dc9cc3cbbe85cf24a2c42726
https://github.com/sobolevn
Very naive attempt tohttps://github.com/python/mypy/pull/11361/commits/c165a583c5a316296f6d1b11d71308908d912a1c
fixhttps://github.com/python/mypy/pull/11361/commits/c165a583c5a316296f6d1b11d71308908d912a1c
#11331https://github.com/python/mypy/issues/11331
c165a58https://github.com/python/mypy/pull/11361/commits/c165a583c5a316296f6d1b11d71308908d912a1c
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Oct 19, 2021 https://github.com/python/mypy/pull/11361#pullrequestreview-783585755
View reviewed changes https://github.com/python/mypy/pull/11361/files/c165a583c5a316296f6d1b11d71308908d912a1c
mypy/checker.pyhttps://github.com/python/mypy/pull/11361/files/c165a583c5a316296f6d1b11d71308908d912a1c#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
sobolevnhttps://github.com/sobolevn
Oct 19, 2021https://github.com/python/mypy/pull/11361#discussion_r732095105
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11361
sobolevnhttps://github.com/sobolevn
October 19, 2021 20:47https://github.com/python/mypy/pull/11361#commits-pushed-8333ae6
https://github.com/sobolevn
Fixes existing testhttps://github.com/python/mypy/pull/11361/commits/8333ae657f4ab211c1a39adc94a96317e633a0c4
8333ae6https://github.com/python/mypy/pull/11361/commits/8333ae657f4ab211c1a39adc94a96317e633a0c4
https://github.com/sobolevn
Fixes existing testhttps://github.com/python/mypy/pull/11361/commits/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f
ba9c53ahttps://github.com/python/mypy/pull/11361/commits/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Oct 19, 2021https://github.com/python/mypy/pull/11361#event-5488049399
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Oct 19, 2021https://github.com/python/mypy/pull/11361#event-5488049533
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Oct 20, 2021https://github.com/python/mypy/pull/11361#event-5489941998
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Oct 22, 2021 https://github.com/python/mypy/pull/11361#pullrequestreview-786726274
View reviewed changes https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/11361#pullrequestreview-786726274
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11361
test-data/unit/check-unreachable-code.testhttps://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2
JukkaLhttps://github.com/JukkaL
Oct 22, 2021https://github.com/python/mypy/pull/11361#discussion_r734454154
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11361
hauntsaninjahttps://github.com/hauntsaninja
Oct 31, 2021https://github.com/python/mypy/pull/11361#discussion_r739875638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11361
mypy/checker.pyhttps://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/11361
https://github.com/sobolevn
Addresses reviewhttps://github.com/python/mypy/pull/11361/commits/2d51fb85261a23242f79e9ffaa4dc95cb7c0c5d0
2d51fb8https://github.com/python/mypy/pull/11361/commits/2d51fb85261a23242f79e9ffaa4dc95cb7c0c5d0
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Oct 22, 2021https://github.com/python/mypy/pull/11361#issuecomment-949740957
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/11361
https://github.com/harahu
harahuhttps://github.com/harahu
Oct 23, 2021 https://github.com/python/mypy/pull/11361#pullrequestreview-787411167
View reviewed changes https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f
test-data/unit/check-unreachable-code.testhttps://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2
harahuhttps://github.com/harahu
Oct 23, 2021https://github.com/python/mypy/pull/11361#discussion_r734996015
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11361
sobolevnhttps://github.com/sobolevn
Oct 31, 2021https://github.com/python/mypy/pull/11361#discussion_r739854163
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11361
harahuhttps://github.com/harahu
Nov 1, 2021https://github.com/python/mypy/pull/11361#discussion_r740004005
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11361
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Oct 31, 2021 https://github.com/python/mypy/pull/11361#pullrequestreview-793759240
View reviewed changes https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f
test-data/unit/check-unreachable-code.testhttps://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2
hauntsaninjahttps://github.com/hauntsaninja
Oct 31, 2021https://github.com/python/mypy/pull/11361#discussion_r739875638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11361
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Oct 31, 2021https://github.com/python/mypy/pull/11361#issuecomment-955795128
@hauntsaninjahttps://github.com/hauntsaninja
Please reload this pagehttps://github.com/python/mypy/pull/11361
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Oct 31, 2021 https://github.com/python/mypy/pull/11361#pullrequestreview-793762151
View reviewed changes https://github.com/python/mypy/pull/11361/files/2d51fb85261a23242f79e9ffaa4dc95cb7c0c5d0
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/mypy/pull/11361#pullrequestreview-793762151
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11361
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
e9c7e10https://github.com/python/mypy/commit/e9c7e1007b724becec9d6a3e5eacfdca69c0c9fc
Oct 31, 2021https://github.com/python/mypy/pull/11361#event-5545769409
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Nov 3, 2021 https://github.com/python/mypy/pull/11361#ref-issue-1042984496
warn-unreachable doesn't work on the top level #11438 https://github.com/python/mypy/issues/11438
tushar-deepsourcehttps://github.com/tushar-deepsource
Jan 20, 2022 https://github.com/python/mypy/pull/11361#ref-commit-35558cd
https://github.com/sobolevn
https://github.com/tushar-deepsource
Check module bodies to be reachable (https://github.com/DeepSourceCorp/mypy/commit/35558cd84e6c8b9a11dd2ccb80775117d6269a11
python#11361https://github.com/python/mypy/pull/11361
)https://github.com/DeepSourceCorp/mypy/commit/35558cd84e6c8b9a11dd2ccb80775117d6269a11
35558cdhttps://github.com/DeepSourceCorp/mypy/commit/35558cd84e6c8b9a11dd2ccb80775117d6269a11
python#11331https://github.com/python/mypy/issues/11331
https://github.com/KotlinIsland
KotlinIslandhttps://github.com/KotlinIsland
Mar 21, 2022 https://github.com/python/mypy/pull/11361#ref-issue-1175258806
(🐞) Inconsistent reachability depending if module level or not #12409 https://github.com/python/mypy/issues/12409
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Jun 9, 2023 https://github.com/python/mypy/pull/11361#ref-pullrequest-1745008191
Consistently avoid type-checking unreachable code #15386 https://github.com/python/mypy/pull/15386
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11361
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/11361/files/2d51fb85261a23242f79e9ffaa4dc95cb7c0c5d0
https://github.com/harahu
harahu https://github.com/harahu
https://github.com/python/mypy/pull/11361/files/2d51fb85261a23242f79e9ffaa4dc95cb7c0c5d0
Please reload this pagehttps://github.com/python/mypy/pull/11361
The [unreachable] check fails for module scope code and allows unreachable raising of Exceptions https://github.com/python/mypy/issues/11331
Please reload this pagehttps://github.com/python/mypy/pull/11361
https://github.com/sobolevn
https://github.com/JukkaL
https://github.com/harahu
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.