| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fe1952e7-7552-85a1-3d6d-fa57564707d4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CCEA:354B:642F0F:824ECE:6AFFC98B |
| html-safe-nonce | 6195aa543ad4a78257e2291603134290d594b344a13d1f864b376ebbf884eaf0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0VBOjM1NEI6NjQyRjBGOjgyNEVDRTo2QUZGQzk4QiIsInZpc2l0b3JfaWQiOiIxOTQ5ODA5NTc5NTg4MDQ1MTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e1ee36024247e4108391d39375b6e285623e9dd2059577f78b71cc5d9b17a44c |
| hovercard-subject-tag | pull_request:761626642 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/11361/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/edf70f04f124652e6e162a7867b8cf898dc19919171a6e0d077461e108a0c5ca/python/mypy/pull/11361 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/edf70f04f124652e6e162a7867b8cf898dc19919171a6e0d077461e108a0c5ca/python/mypy/pull/11361 |
| og:image:alt | This is a very simple change, but now module bodies are also checked to be reachable.
Let's see what effect it will have.
Closes #11331 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1e805b832df235bb21305db712c3b6432920019dfc12cb25b9cb8d3b0c9403cf |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8fa4a54e6871c7908eda1c246ad5972982c0b59d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/11361#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11361 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11361 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/11361 |
| Reload | https://github.com/python/mypy/pull/11361 |
| Reload | https://github.com/python/mypy/pull/11361 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| Conversation | https://github.com/python/mypy/pull/11361 |
| Commits6 (6) | https://github.com/python/mypy/pull/11361/commits |
| Checks | https://github.com/python/mypy/pull/11361/checks |
| Files changed | https://github.com/python/mypy/pull/11361/files |
| Checks module bodies to be reachable | https://github.com/python/mypy/pull/11361#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
|
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Oct 19, 2021 | https://github.com/python/mypy/pull/11361#issue-1030545381 |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| #11331 | https://github.com/python/mypy/issues/11331 |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| sobolevn | https://github.com/sobolevn |
| October 19, 2021 20:00 | https://github.com/python/mypy/pull/11361#commits-pushed-8f8e9b6 |
|
| https://github.com/sobolevn |
| Very naive attempt to | https://github.com/python/mypy/pull/11361/commits/8f8e9b690e44771fa654a0ee123a6c4203c0de3c |
| fix | https://github.com/python/mypy/pull/11361/commits/8f8e9b690e44771fa654a0ee123a6c4203c0de3c |
| #11331 | https://github.com/python/mypy/issues/11331 |
| 8f8e9b6 | https://github.com/python/mypy/pull/11361/commits/8f8e9b690e44771fa654a0ee123a6c4203c0de3c |
|
| https://github.com/sobolevn |
| Very naive attempt to | https://github.com/python/mypy/pull/11361/commits/582e6f92ea6357d4dc9cc3cbbe85cf24a2c42726 |
| fix | https://github.com/python/mypy/pull/11361/commits/582e6f92ea6357d4dc9cc3cbbe85cf24a2c42726 |
| #11331 | https://github.com/python/mypy/issues/11331 |
| 582e6f9 | https://github.com/python/mypy/pull/11361/commits/582e6f92ea6357d4dc9cc3cbbe85cf24a2c42726 |
|
| https://github.com/sobolevn |
| Very naive attempt to | https://github.com/python/mypy/pull/11361/commits/c165a583c5a316296f6d1b11d71308908d912a1c |
| fix | https://github.com/python/mypy/pull/11361/commits/c165a583c5a316296f6d1b11d71308908d912a1c |
| #11331 | https://github.com/python/mypy/issues/11331 |
| c165a58 | https://github.com/python/mypy/pull/11361/commits/c165a583c5a316296f6d1b11d71308908d912a1c |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Oct 19, 2021
| https://github.com/python/mypy/pull/11361#pullrequestreview-783585755 |
|
View reviewed changes
| https://github.com/python/mypy/pull/11361/files/c165a583c5a316296f6d1b11d71308908d912a1c |
| mypy/checker.py | https://github.com/python/mypy/pull/11361/files/c165a583c5a316296f6d1b11d71308908d912a1c#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| sobolevn | https://github.com/sobolevn |
| Oct 19, 2021 | https://github.com/python/mypy/pull/11361#discussion_r732095105 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| sobolevn | https://github.com/sobolevn |
| October 19, 2021 20:47 | https://github.com/python/mypy/pull/11361#commits-pushed-8333ae6 |
|
| https://github.com/sobolevn |
| Fixes existing test | https://github.com/python/mypy/pull/11361/commits/8333ae657f4ab211c1a39adc94a96317e633a0c4 |
| 8333ae6 | https://github.com/python/mypy/pull/11361/commits/8333ae657f4ab211c1a39adc94a96317e633a0c4 |
|
| https://github.com/sobolevn |
| Fixes existing test | https://github.com/python/mypy/pull/11361/commits/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f |
| ba9c53a | https://github.com/python/mypy/pull/11361/commits/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Oct 19, 2021 | https://github.com/python/mypy/pull/11361#event-5488049399 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Oct 19, 2021 | https://github.com/python/mypy/pull/11361#event-5488049533 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Oct 20, 2021 | https://github.com/python/mypy/pull/11361#event-5489941998 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Oct 22, 2021
| https://github.com/python/mypy/pull/11361#pullrequestreview-786726274 |
|
View reviewed changes
| https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/11361#pullrequestreview-786726274 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| JukkaL | https://github.com/JukkaL |
| Oct 22, 2021 | https://github.com/python/mypy/pull/11361#discussion_r734454154 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| hauntsaninja | https://github.com/hauntsaninja |
| Oct 31, 2021 | https://github.com/python/mypy/pull/11361#discussion_r739875638 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| mypy/checker.py | https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
|
| https://github.com/sobolevn |
| Addresses review | https://github.com/python/mypy/pull/11361/commits/2d51fb85261a23242f79e9ffaa4dc95cb7c0c5d0 |
| 2d51fb8 | https://github.com/python/mypy/pull/11361/commits/2d51fb85261a23242f79e9ffaa4dc95cb7c0c5d0 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Oct 22, 2021 | https://github.com/python/mypy/pull/11361#issuecomment-949740957 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| https://github.com/harahu |
| harahu | https://github.com/harahu |
|
Oct 23, 2021
| https://github.com/python/mypy/pull/11361#pullrequestreview-787411167 |
|
View reviewed changes
| https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| harahu | https://github.com/harahu |
| Oct 23, 2021 | https://github.com/python/mypy/pull/11361#discussion_r734996015 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| sobolevn | https://github.com/sobolevn |
| Oct 31, 2021 | https://github.com/python/mypy/pull/11361#discussion_r739854163 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| harahu | https://github.com/harahu |
| Nov 1, 2021 | https://github.com/python/mypy/pull/11361#discussion_r740004005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Oct 31, 2021
| https://github.com/python/mypy/pull/11361#pullrequestreview-793759240 |
|
View reviewed changes
| https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f |
| test-data/unit/check-unreachable-code.test | https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f#diff-cd456843a4ec53f88d553e542403cd68e536db6fd6462d14baaccac1518bffc2 |
| hauntsaninja | https://github.com/hauntsaninja |
| Oct 31, 2021 | https://github.com/python/mypy/pull/11361#discussion_r739875638 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Oct 31, 2021 | https://github.com/python/mypy/pull/11361#issuecomment-955795128 |
| @hauntsaninja | https://github.com/hauntsaninja |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Oct 31, 2021
| https://github.com/python/mypy/pull/11361#pullrequestreview-793762151 |
|
View reviewed changes
| https://github.com/python/mypy/pull/11361/files/2d51fb85261a23242f79e9ffaa4dc95cb7c0c5d0 |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/mypy/pull/11361#pullrequestreview-793762151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| e9c7e10 | https://github.com/python/mypy/commit/e9c7e1007b724becec9d6a3e5eacfdca69c0c9fc |
| Oct 31, 2021 | https://github.com/python/mypy/pull/11361#event-5545769409 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Nov 3, 2021
| https://github.com/python/mypy/pull/11361#ref-issue-1042984496 |
|
warn-unreachable doesn't work on the top level
#11438
| https://github.com/python/mypy/issues/11438 |
| tushar-deepsource | https://github.com/tushar-deepsource |
|
Jan 20, 2022
| https://github.com/python/mypy/pull/11361#ref-commit-35558cd |
|
| https://github.com/sobolevn |
|
| https://github.com/tushar-deepsource |
| Check module bodies to be reachable ( | https://github.com/DeepSourceCorp/mypy/commit/35558cd84e6c8b9a11dd2ccb80775117d6269a11 |
| python#11361 | https://github.com/python/mypy/pull/11361 |
| ) | https://github.com/DeepSourceCorp/mypy/commit/35558cd84e6c8b9a11dd2ccb80775117d6269a11 |
| 35558cd | https://github.com/DeepSourceCorp/mypy/commit/35558cd84e6c8b9a11dd2ccb80775117d6269a11 |
| python#11331 | https://github.com/python/mypy/issues/11331 |
| https://github.com/KotlinIsland |
| KotlinIsland | https://github.com/KotlinIsland |
|
Mar 21, 2022
| https://github.com/python/mypy/pull/11361#ref-issue-1175258806 |
|
(🐞) Inconsistent reachability depending if module level or not
#12409
| https://github.com/python/mypy/issues/12409 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
|
Jun 9, 2023
| https://github.com/python/mypy/pull/11361#ref-pullrequest-1745008191 |
|
Consistently avoid type-checking unreachable code
#15386
| https://github.com/python/mypy/pull/15386 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11361 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/11361/files/ba9c53a9ae89b1e1f29f7f48b1d3ae44629caa2f |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/11361/files/2d51fb85261a23242f79e9ffaa4dc95cb7c0c5d0 |
|
| https://github.com/harahu |
|
harahu
| https://github.com/harahu |
|
| https://github.com/python/mypy/pull/11361/files/2d51fb85261a23242f79e9ffaa4dc95cb7c0c5d0 |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
|
The [unreachable] check fails for module scope code and allows unreachable raising of Exceptions
| https://github.com/python/mypy/issues/11331 |
| Please reload this page | https://github.com/python/mypy/pull/11361 |
|
| https://github.com/sobolevn |
|
| https://github.com/JukkaL |
|
| https://github.com/harahu |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |