| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6cf8f8af-817d-6252-088e-da86845a4cc6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A058:145630:366BEE3:48817F3:6B004CF3 |
| html-safe-nonce | f3d9845c24296a141c27188a9ce2e88573e0689ec3be353c41b8681acdbcb5e5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDU4OjE0NTYzMDozNjZCRUUzOjQ4ODE3RjM6NkIwMDRDRjMiLCJ2aXNpdG9yX2lkIjoiNjkwNTM3MTk4Mjc3MTAxNDg5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9f27aa0f08835c48e2c549e4120a04e121c871752a0c0ffd5445b0e1842e5777 |
| hovercard-subject-tag | pull_request:756888703 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/11323/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c04a9cd4fbaf6800603ca9eaf73dbe39ad814852e48cd6539a7c9e0f250c89b4/python/mypy/pull/11323 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c04a9cd4fbaf6800603ca9eaf73dbe39ad814852e48cd6539a7c9e0f250c89b4/python/mypy/pull/11323 |
| og:image:alt | Prep for #9636
First test was failing because a was not a valid import (pkg.a was)
Second test was failing because foo.py resolved in two ways, both
as foo and foo.foo. Disambiguating the dir from... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nipunn1313 |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/11323#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11323 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11323 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/11323 |
| Reload | https://github.com/python/mypy/pull/11323 |
| Reload | https://github.com/python/mypy/pull/11323 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:master | https://github.com/python/mypy/tree/master |
| nipunn1313:cmdline | https://github.com/nipunn1313/mypy/tree/cmdline |
| Conversation | https://github.com/python/mypy/pull/11323 |
| Commits1 (1) | https://github.com/python/mypy/pull/11323/commits |
| Checks | https://github.com/python/mypy/pull/11323/checks |
| Files changed | https://github.com/python/mypy/pull/11323/files |
| Fix cmdline package tests for namespace packages | https://github.com/python/mypy/pull/11323#top |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:master | https://github.com/python/mypy/tree/master |
| nipunn1313:cmdline | https://github.com/nipunn1313/mypy/tree/cmdline |
|
| https://github.com/nipunn1313 |
| nipunn1313 | https://github.com/nipunn1313 |
| Oct 12, 2021 | https://github.com/python/mypy/pull/11323#issue-1024607691 |
| Please reload this page | https://github.com/python/mypy/pull/11323 |
| #9636 | https://github.com/python/mypy/pull/9636 |
| #9636 | https://github.com/python/mypy/pull/9636 |
| Please reload this page | https://github.com/python/mypy/pull/11323 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Oct 12, 2021
| https://github.com/python/mypy/pull/11323#pullrequestreview-777965508 |
|
View reviewed changes
| https://github.com/python/mypy/pull/11323/files |
|
| https://github.com/nipunn1313 |
| Fix cmdline package tests for namespace packages | https://github.com/python/mypy/pull/11323/commits/5a8270231bc5f015a893bcb7b7728352416f55c1 |
| 5a82702 | https://github.com/python/mypy/pull/11323/commits/5a8270231bc5f015a893bcb7b7728352416f55c1 |
| python#9636 | https://github.com/python/mypy/pull/9636 |
| https://github.com/nipunn1313 |
| nipunn1313 | https://github.com/nipunn1313 |
| Oct 13, 2021 | https://github.com/python/mypy/pull/11323#issuecomment-941836675 |
| #11324 | https://github.com/python/mypy/pull/11324 |
| Please reload this page | https://github.com/python/mypy/pull/11323 |
| https://github.com/nipunn1313 |
| nipunn1313 | https://github.com/nipunn1313 |
| force-pushed | https://github.com/python/mypy/compare/ca245598bb985b40a13bfea517451215b2194657..5a8270231bc5f015a893bcb7b7728352416f55c1 |
| ca24559 | https://github.com/python/mypy/commit/ca245598bb985b40a13bfea517451215b2194657 |
| 5a82702 | https://github.com/python/mypy/commit/5a8270231bc5f015a893bcb7b7728352416f55c1 |
|
Compare
| https://github.com/python/mypy/compare/ca245598bb985b40a13bfea517451215b2194657..5a8270231bc5f015a893bcb7b7728352416f55c1 |
| October 13, 2021 02:13 | https://github.com/python/mypy/pull/11323#event-5453927162 |
| https://github.com/nipunn1313 |
| nipunn1313 | https://github.com/nipunn1313 |
|
Oct 13, 2021
| https://github.com/python/mypy/pull/11323#ref-pullrequest-728879049 |
|
Make --namespace-packages the default
#9636
| https://github.com/python/mypy/pull/9636 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| 6f12251 | https://github.com/python/mypy/commit/6f122511b12269b84e1257c8d8d492609f1efe5a |
| Oct 13, 2021 | https://github.com/python/mypy/pull/11323#event-5454138979 |
| https://github.com/nipunn1313 |
| nipunn1313 | https://github.com/nipunn1313 |
| October 13, 2021 21:15 | https://github.com/python/mypy/pull/11323#event-5459901737 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11323 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/mypy/pull/11323/files/ca245598bb985b40a13bfea517451215b2194657 |
| Please reload this page | https://github.com/python/mypy/pull/11323 |
| Please reload this page | https://github.com/python/mypy/pull/11323 |
|
| https://github.com/nipunn1313 |
|
| https://github.com/JelleZijlstra |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |