| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:31b5b132-8f53-2454-9924-087ff17a8856 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8DC2:3F7C2E:27F49:38100:6B004FB7 |
| html-safe-nonce | 80a58a626a419ff99520dab38a0a8df1fe79dcb42f887219695208d718a69f9b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REMyOjNGN0MyRToyN0Y0OTozODEwMDo2QjAwNEZCNyIsInZpc2l0b3JfaWQiOiI3MjgyMzk5NTM2NDU3MjA3NzM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 48ede39d9741e45f404dc824c73d001192bfcb9d435abea439590bf884cdeddb |
| hovercard-subject-tag | pull_request:750265778 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/11273/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/cc765b448109ad21bf0dfe02034b2303590576014853f1f6d28287fede62e013/python/mypy/pull/11273 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cc765b448109ad21bf0dfe02034b2303590576014853f1f6d28287fede62e013/python/mypy/pull/11273 |
| og:image:alt | As always, fixing issues with type narrowing / inference is always very hard, because small changes can backfire.
But, this looks as a simple change. Let's see how tests will behave.
Closes #11272 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sobolevn |
| hostname | github.com |
| expected-hostname | github.com |
| None | f420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26e00df917aba0f128135dc073ea0c5e33a70d40 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/11273#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11273 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11273 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/11273 |
| Reload | https://github.com/python/mypy/pull/11273 |
| Reload | https://github.com/python/mypy/pull/11273 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| Conversation | https://github.com/python/mypy/pull/11273 |
| Commits3 (3) | https://github.com/python/mypy/pull/11273/commits |
| Checks | https://github.com/python/mypy/pull/11273/checks |
| Files changed | https://github.com/python/mypy/pull/11273/files |
| Fixes type narrowing for overlaping runtime types | https://github.com/python/mypy/pull/11273#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
|
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Oct 5, 2021 | https://github.com/python/mypy/pull/11273#issue-1016795556 |
| #11272 | https://github.com/python/mypy/issues/11272 |
| Please reload this page | https://github.com/python/mypy/pull/11273 |
| sobolevn | https://github.com/sobolevn |
| October 5, 2021 23:28 | https://github.com/python/mypy/pull/11273#commits-pushed-e127ada |
|
| https://github.com/sobolevn |
| Fixes type narrowing for overlaping runtime types, refs | https://github.com/python/mypy/pull/11273/commits/e127ada8c428d62d8d2a60fa85a6743351ab3b63 |
| #11272 | https://github.com/python/mypy/issues/11272 |
| e127ada | https://github.com/python/mypy/pull/11273/commits/e127ada8c428d62d8d2a60fa85a6743351ab3b63 |
|
| https://github.com/sobolevn |
| Fixes type narrowing for overlaping runtime types, refs | https://github.com/python/mypy/pull/11273/commits/0ee45823f88b82fbb4e13d3c8ed8e40c58096167 |
| #11272 | https://github.com/python/mypy/issues/11272 |
| 0ee4582 | https://github.com/python/mypy/pull/11273/commits/0ee45823f88b82fbb4e13d3c8ed8e40c58096167 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11273 |
|
| https://github.com/sobolevn |
| Typo fixed | https://github.com/python/mypy/pull/11273/commits/f99462af00b0b6c177a47c01156d1cad381dc291 |
| f99462a | https://github.com/python/mypy/pull/11273/commits/f99462af00b0b6c177a47c01156d1cad381dc291 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
| Oct 5, 2021 | https://github.com/python/mypy/pull/11273#issuecomment-934835609 |
| Please reload this page | https://github.com/python/mypy/pull/11273 |
| Please reload this page | https://github.com/python/mypy/pull/11273 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Oct 5, 2021 | https://github.com/python/mypy/pull/11273#issuecomment-934838074 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/11273 |
|
Adds assert_never helper
pydantic/pydantic#3294
| https://github.com/pydantic/pydantic/pull/3294 |
|
Annotates indexers/utils.py functions that don't return anything with None
pandas-dev/pandas#43893
| https://github.com/pandas-dev/pandas/pull/43893 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Oct 10, 2021
| https://github.com/python/mypy/pull/11273#pullrequestreview-775641883 |
|
View reviewed changes
| https://github.com/python/mypy/pull/11273/files/f99462af00b0b6c177a47c01156d1cad381dc291 |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/mypy/pull/11273#pullrequestreview-775641883 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/11273 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| f4a21a4 | https://github.com/python/mypy/commit/f4a21a4010405a3e98d0345de6c8f7ca955ce892 |
| Oct 31, 2021 | https://github.com/python/mypy/pull/11273#event-5545708080 |
| https://github.com/freundTech |
| freundTech | https://github.com/freundTech |
|
Dec 14, 2021
| https://github.com/python/mypy/pull/11273#ref-pullrequest-826742589 |
|
Support for python 3.10 match statement
#10191
| https://github.com/python/mypy/pull/10191 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jan 6, 2022
| https://github.com/python/mypy/pull/11273#ref-issue-1094706801 |
|
INTERNAL ERROR RuntimeError in visit_erased_type with mypy 0.930
#11913
| https://github.com/python/mypy/issues/11913 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Jan 6, 2022
| https://github.com/python/mypy/pull/11273#ref-pullrequest-1095444180 |
|
Fix crash on ErasedType and covers_at_runtime
#11924
| https://github.com/python/mypy/pull/11924 |
| JukkaL | https://github.com/JukkaL |
|
Jan 7, 2022
| https://github.com/python/mypy/pull/11273#ref-commit-a0f27b1 |
|
| https://github.com/sobolevn |
|
| https://github.com/hauntsaninja |
| Fix crash on | https://github.com/python/mypy/commit/a0f27b1d1f21bc6c7502374c3a1e2b642758a4bb |
| ErasedType | https://github.com/python/mypy/commit/a0f27b1d1f21bc6c7502374c3a1e2b642758a4bb |
| and | https://github.com/python/mypy/commit/a0f27b1d1f21bc6c7502374c3a1e2b642758a4bb |
| covers_at_runtime | https://github.com/python/mypy/commit/a0f27b1d1f21bc6c7502374c3a1e2b642758a4bb |
| ( | https://github.com/python/mypy/commit/a0f27b1d1f21bc6c7502374c3a1e2b642758a4bb |
| #11924 | https://github.com/python/mypy/pull/11924 |
| ) | https://github.com/python/mypy/commit/a0f27b1d1f21bc6c7502374c3a1e2b642758a4bb |
| a0f27b1 | https://github.com/python/mypy/commit/a0f27b1d1f21bc6c7502374c3a1e2b642758a4bb |
| #11913 | https://github.com/python/mypy/issues/11913 |
| #11273 | https://github.com/python/mypy/pull/11273 |
| JukkaL | https://github.com/JukkaL |
|
Jan 7, 2022
| https://github.com/python/mypy/pull/11273#ref-commit-5b3280e |
|
| https://github.com/sobolevn |
|
| https://github.com/hauntsaninja |
|
| https://github.com/JukkaL |
| Fix crash on | https://github.com/python/mypy/commit/5b3280e667aea60c4a22b3e1df4fad6c5df421bd |
| ErasedType | https://github.com/python/mypy/commit/5b3280e667aea60c4a22b3e1df4fad6c5df421bd |
| and | https://github.com/python/mypy/commit/5b3280e667aea60c4a22b3e1df4fad6c5df421bd |
| covers_at_runtime | https://github.com/python/mypy/commit/5b3280e667aea60c4a22b3e1df4fad6c5df421bd |
| ( | https://github.com/python/mypy/commit/5b3280e667aea60c4a22b3e1df4fad6c5df421bd |
| #11924 | https://github.com/python/mypy/pull/11924 |
| ) | https://github.com/python/mypy/commit/5b3280e667aea60c4a22b3e1df4fad6c5df421bd |
| 5b3280e | https://github.com/python/mypy/commit/5b3280e667aea60c4a22b3e1df4fad6c5df421bd |
| #11913 | https://github.com/python/mypy/issues/11913 |
| #11273 | https://github.com/python/mypy/pull/11273 |
| tushar-deepsource | https://github.com/tushar-deepsource |
|
Jan 20, 2022
| https://github.com/python/mypy/pull/11273#ref-commit-d8e7cd5 |
|
| https://github.com/sobolevn |
|
| https://github.com/tushar-deepsource |
| Fixes type narrowing for overlaping runtime types ( | https://github.com/DeepSourceCorp/mypy/commit/d8e7cd56b9b0e3cbcfdefdd5aa9621020119f1ed |
| python#11273 | https://github.com/python/mypy/pull/11273 |
| ) | https://github.com/DeepSourceCorp/mypy/commit/d8e7cd56b9b0e3cbcfdefdd5aa9621020119f1ed |
| d8e7cd5 | https://github.com/DeepSourceCorp/mypy/commit/d8e7cd56b9b0e3cbcfdefdd5aa9621020119f1ed |
| python#11272 | https://github.com/python/mypy/issues/11272 |
| tushar-deepsource | https://github.com/tushar-deepsource |
|
Jan 20, 2022
| https://github.com/python/mypy/pull/11273#ref-commit-4d972cf |
|
| https://github.com/sobolevn |
|
| https://github.com/hauntsaninja |
|
| https://github.com/tushar-deepsource |
| Fix crash on | https://github.com/DeepSourceCorp/mypy/commit/4d972cf5bf33118f11f977b39de81e5d13909fe0 |
| ErasedType | https://github.com/DeepSourceCorp/mypy/commit/4d972cf5bf33118f11f977b39de81e5d13909fe0 |
| and | https://github.com/DeepSourceCorp/mypy/commit/4d972cf5bf33118f11f977b39de81e5d13909fe0 |
| covers_at_runtime | https://github.com/DeepSourceCorp/mypy/commit/4d972cf5bf33118f11f977b39de81e5d13909fe0 |
| ( | https://github.com/DeepSourceCorp/mypy/commit/4d972cf5bf33118f11f977b39de81e5d13909fe0 |
| python#11924 | https://github.com/python/mypy/pull/11924 |
| ) | https://github.com/DeepSourceCorp/mypy/commit/4d972cf5bf33118f11f977b39de81e5d13909fe0 |
| 4d972cf | https://github.com/DeepSourceCorp/mypy/commit/4d972cf5bf33118f11f977b39de81e5d13909fe0 |
| python#11913 | https://github.com/python/mypy/issues/11913 |
| python#11273 | https://github.com/python/mypy/pull/11273 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Aug 12, 2023
| https://github.com/python/mypy/pull/11273#ref-issue-823891459 |
|
Narrowing depends on the order of isinstance checks when using a genric type
#10178
| https://github.com/python/mypy/issues/10178 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11273 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/11273/files/f99462af00b0b6c177a47c01156d1cad381dc291 |
| Please reload this page | https://github.com/python/mypy/pull/11273 |
|
Type narrowing of a union type works incorrectly in presence of a list
| https://github.com/python/mypy/issues/11272 |
| Please reload this page | https://github.com/python/mypy/pull/11273 |
|
| https://github.com/sobolevn |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |