René's URL Explorer Experiment


Title: Fix type guard crashes by hauntsaninja · Pull Request #11061 · python/mypy · GitHub

Open Graph Title: Fix type guard crashes by hauntsaninja · Pull Request #11061 · python/mypy

X Title: Fix type guard crashes by hauntsaninja · Pull Request #11061 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #11007, fixes #10899, fixes #10647 Since the initial implementation of TypeGuard, there have been several fixes quickly applied to make mypy not crash on various TypeGuard things. This includ...

X Description: Fixes #11007, fixes #10899, fixes #10647 Since the initial implementation of TypeGuard, there have been several fixes quickly applied to make mypy not crash on various TypeGuard things. This includ...

Opengraph URL: https://github.com/python/mypy/pull/11061

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:869161e3-c21d-32ab-d357-34ae42fbf83f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDEC:2FD3CB:B1E800:EE7B9F:6B004D34
html-safe-nonce7c995f37b2d2891df6e7a210a07414913e74325c0d28ce5d3dce858764f8102a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREVDOjJGRDNDQjpCMUU4MDA6RUU3QjlGOjZCMDA0RDM0IiwidmlzaXRvcl9pZCI6IjQ1MTA2OTEzNTg5MDU3NDg3ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac458730acb7b9b2e341e5e451769bf9b7f7a6f083ef6fd631c141b9c0cc611842
hovercard-subject-tagpull_request:727547118
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/11061/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d3b5a445faf8437ee0ea0d14e92ad48cd448ba466a925fcc39cbeae8d521ed53/python/mypy/pull/11061
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d3b5a445faf8437ee0ea0d14e92ad48cd448ba466a925fcc39cbeae8d521ed53/python/mypy/pull/11061
og:image:altFixes #11007, fixes #10899, fixes #10647 Since the initial implementation of TypeGuard, there have been several fixes quickly applied to make mypy not crash on various TypeGuard things. This includ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/11061#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11061
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11061
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/11061
Reloadhttps://github.com/python/mypy/pull/11061
Reloadhttps://github.com/python/mypy/pull/11061
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:typeg3https://github.com/hauntsaninja/mypy/tree/typeg3
Conversationhttps://github.com/python/mypy/pull/11061
Commits9 (9)https://github.com/python/mypy/pull/11061/commits
Checkshttps://github.com/python/mypy/pull/11061/checks
Files changedhttps://github.com/python/mypy/pull/11061/files
Fix type guard crasheshttps://github.com/python/mypy/pull/11061#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:typeg3https://github.com/hauntsaninja/mypy/tree/typeg3
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Sep 6, 2021https://github.com/python/mypy/pull/11061#issue-988692382
Please reload this pagehttps://github.com/python/mypy/pull/11061
#11007https://github.com/python/mypy/issues/11007
#10899https://github.com/python/mypy/issues/10899
#10647https://github.com/python/mypy/issues/10647
#10496https://github.com/python/mypy/pull/10496
#10683https://github.com/python/mypy/pull/10683
#11015https://github.com/python/mypy/pull/11015
#10496https://github.com/python/mypy/pull/10496
#10899https://github.com/python/mypy/issues/10899
#10683https://github.com/python/mypy/pull/10683
#11015https://github.com/python/mypy/pull/11015
Please reload this pagehttps://github.com/python/mypy/pull/11061
September 5, 2021 19:16https://github.com/python/mypy/pull/11061#commits-pushed-e1bd6cf
make typeguard an improper typehttps://github.com/python/mypy/pull/11061/commits/e1bd6cf3c06f5d96cd42fc86ed740586e278018d
e1bd6cfhttps://github.com/python/mypy/pull/11061/commits/e1bd6cf3c06f5d96cd42fc86ed740586e278018d
remove some more special casinghttps://github.com/python/mypy/pull/11061/commits/ac8c2a3212175678eea1b1797e284a8ebe5d25ad
ac8c2a3https://github.com/python/mypy/pull/11061/commits/ac8c2a3212175678eea1b1797e284a8ebe5d25ad
mark as xfailhttps://github.com/python/mypy/pull/11061/commits/436e9ad5aabe68d68e341d38a87e2bbc6b716252
436e9adhttps://github.com/python/mypy/pull/11061/commits/436e9ad5aabe68d68e341d38a87e2bbc6b716252
add back commenthttps://github.com/python/mypy/pull/11061/commits/2494cd41813d09b8f3f8316e85d234a9e12a6e14
2494cd4https://github.com/python/mypy/pull/11061/commits/2494cd41813d09b8f3f8316e85d234a9e12a6e14
linthttps://github.com/python/mypy/pull/11061/commits/884307c14de941db42851572361b65cea90ae2bf
884307chttps://github.com/python/mypy/pull/11061/commits/884307c14de941db42851572361b65cea90ae2bf
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11061
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11061
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11061
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 7, 2021 https://github.com/python/mypy/pull/11061#pullrequestreview-747806128
View reviewed changes https://github.com/python/mypy/pull/11061/files/884307c14de941db42851572361b65cea90ae2bf
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/11061#pullrequestreview-747806128
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11061
mypy/fixup.pyhttps://github.com/python/mypy/pull/11061/files/884307c14de941db42851572361b65cea90ae2bf#diff-68ad7e14d14c5c769296b859d2ab8a5a38fde4e2a9ad628de1000666c5d9ed1d
ilevkivskyihttps://github.com/ilevkivskyi
Sep 7, 2021https://github.com/python/mypy/pull/11061#discussion_r703382342
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11061
mypy/meet.pyhttps://github.com/python/mypy/pull/11061/files/884307c14de941db42851572361b65cea90ae2bf#diff-cdffaffb73fce8b49d0e95f9edde45fcd45462465182c182a41e022d897da965
Please reload this pagehttps://github.com/python/mypy/pull/11061
mypy/server/astdiff.pyhttps://github.com/python/mypy/pull/11061/files/884307c14de941db42851572361b65cea90ae2bf#diff-97d13a4232abb42832982ed6badc8f6fd50ef8761a3ee4f271e6ddc1c9b143fc
ilevkivskyihttps://github.com/ilevkivskyi
Sep 7, 2021https://github.com/python/mypy/pull/11061#discussion_r703387821
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11061
mypy/subtypes.pyhttps://github.com/python/mypy/pull/11061/files/884307c14de941db42851572361b65cea90ae2bf#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
ilevkivskyihttps://github.com/ilevkivskyi
Sep 7, 2021https://github.com/python/mypy/pull/11061#discussion_r703390221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/11061
hauntsaninjahttps://github.com/hauntsaninja
Sep 14, 2021https://github.com/python/mypy/pull/11061#discussion_r707897885
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
mypy/mypy/typeanal.pyhttps://github.com/python/mypy/blob/e1bd6cf3c06f5d96cd42fc86ed740586e278018d/mypy/typeanal.py#L356
e1bd6cfhttps://github.com/python/mypy/commit/e1bd6cf3c06f5d96cd42fc86ed740586e278018d
mypy/mypy/checker.pyhttps://github.com/python/mypy/blob/9c9c3580fa80a7c4145b2951bd91c31dfa6bc7e6/mypy/checker.py#L4268
9c9c358https://github.com/python/mypy/commit/9c9c3580fa80a7c4145b2951bd91c31dfa6bc7e6
Please reload this pagehttps://github.com/python/mypy/pull/11061
https://github.com/hauntsaninja
Merge branch 'master' into typeg3https://github.com/python/mypy/pull/11061/commits/9c9c3580fa80a7c4145b2951bd91c31dfa6bc7e6
9c9c358https://github.com/python/mypy/pull/11061/commits/9c9c3580fa80a7c4145b2951bd91c31dfa6bc7e6
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11061
.https://github.com/python/mypy/pull/11061/commits/75808e0ab2ee18827d4035b2d92dd9258ea3f533
75808e0https://github.com/python/mypy/pull/11061/commits/75808e0ab2ee18827d4035b2d92dd9258ea3f533
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11061
.https://github.com/python/mypy/pull/11061/commits/74f04f4c00574f93b73e4cfd78679f2fa8648373
74f04f4https://github.com/python/mypy/pull/11061/commits/74f04f4c00574f93b73e4cfd78679f2fa8648373
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11061
.https://github.com/python/mypy/pull/11061/commits/6d4af01cc443affc2671461be8b0a1a8b8f704f0
6d4af01https://github.com/python/mypy/pull/11061/commits/6d4af01cc443affc2671461be8b0a1a8b8f704f0
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 14, 2021https://github.com/python/mypy/pull/11061#issuecomment-918828620
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/11061
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
05f3857https://github.com/python/mypy/commit/05f38571f1b7af46dbadaeba0f74626d3a9e07c9
Sep 14, 2021https://github.com/python/mypy/pull/11061#event-5297389503
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
September 14, 2021 06:42https://github.com/python/mypy/pull/11061#event-5297389792
https://github.com/wbolster
wbolsterhttps://github.com/wbolster
Nov 1, 2021 https://github.com/python/mypy/pull/11061#ref-issue-1041383081
TypeGuard functions not properly recognizing generic types #11428 https://github.com/python/mypy/issues/11428
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F11061
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/11061/files/884307c14de941db42851572361b65cea90ae2bf
Please reload this pagehttps://github.com/python/mypy/pull/11061
Internal error checking xarray with --check-untyped-defs https://github.com/python/mypy/issues/11007
type guarded value is same type as typing.TypeGuard[T]? https://github.com/python/mypy/issues/10899
TypeGuard should not appear here https://github.com/python/mypy/issues/10647
Please reload this pagehttps://github.com/python/mypy/pull/11061
https://github.com/hauntsaninja
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.