| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2d2a2bfa-8dad-ca21-e4be-712c87057fca |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC56:1A7566:1CC7C0:26D47B:6B002158 |
| html-safe-nonce | 5e73a4860cc4bf541b62a13aafd9a048138198332299b2de53b4611d7e8e0119 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzU2OjFBNzU2NjoxQ0M3QzA6MjZENDdCOjZCMDAyMTU4IiwidmlzaXRvcl9pZCI6IjUxMTA1MDg5MjA3NTM4ODk2MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d13b8a4a433211fffb47d29f92570a6ed07fbaf4cfafc0ae10f848b0163c7f01 |
| hovercard-subject-tag | pull_request:674706786 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/10685/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d81dfaa0ad558217b5b3a4dda88e7f51df70a24cef2e4977b72229f476f8f715/python/mypy/pull/10685 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d81dfaa0ad558217b5b3a4dda88e7f51df70a24cef2e4977b72229f476f8f715/python/mypy/pull/10685 |
| og:image:alt | Description
As title. Related to Guido’s coding style suggestion in #1184
Test Plan
Existing tests with # flags: --allow-redefinition should pass. No new test cases were added |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | atakiar |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/10685#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10685 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10685 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/10685 |
| Reload | https://github.com/python/mypy/pull/10685 |
| Reload | https://github.com/python/mypy/pull/10685 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:master | https://github.com/python/mypy/tree/master |
| atakiar:renmaing-use-contextmanagers | https://github.com/atakiar/mypy/tree/renmaing-use-contextmanagers |
| Conversation | https://github.com/python/mypy/pull/10685 |
| Commits4 (4) | https://github.com/python/mypy/pull/10685/commits |
| Checks | https://github.com/python/mypy/pull/10685/checks |
| Files changed | https://github.com/python/mypy/pull/10685/files |
| refactor: add contextmanager to VariableRenameVisitor | https://github.com/python/mypy/pull/10685#top |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:master | https://github.com/python/mypy/tree/master |
| atakiar:renmaing-use-contextmanagers | https://github.com/atakiar/mypy/tree/renmaing-use-contextmanagers |
|
| https://github.com/atakiar |
| atakiar | https://github.com/atakiar |
| Jun 21, 2021 | https://github.com/python/mypy/pull/10685#issue-926396463 |
| #1184 | https://github.com/python/mypy/issues/1184 |
| Please reload this page | https://github.com/python/mypy/pull/10685 |
|
| https://github.com/atakiar |
| refactor: add contextmanager to VariableRenameVisitor | https://github.com/python/mypy/pull/10685/commits/6b6e0be4f91b294a511ec6a3860ec7faf54c1ea7 |
| 6b6e0be | https://github.com/python/mypy/pull/10685/commits/6b6e0be4f91b294a511ec6a3860ec7faf54c1ea7 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Jun 21, 2021
| https://github.com/python/mypy/pull/10685#pullrequestreview-688651887 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10685/files/6b6e0be4f91b294a511ec6a3860ec7faf54c1ea7 |
| mypy/renaming.py | https://github.com/python/mypy/pull/10685/files/6b6e0be4f91b294a511ec6a3860ec7faf54c1ea7#diff-a0cbd708db24512f4d3975740ac9fa9de8c4366395980a4216d0001c6945a0f2 |
| Please reload this page | https://github.com/python/mypy/pull/10685 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Jun 21, 2021
| https://github.com/python/mypy/pull/10685#pullrequestreview-688652488 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10685/files/6b6e0be4f91b294a511ec6a3860ec7faf54c1ea7 |
| mypy/renaming.py | https://github.com/python/mypy/pull/10685/files/6b6e0be4f91b294a511ec6a3860ec7faf54c1ea7#diff-a0cbd708db24512f4d3975740ac9fa9de8c4366395980a4216d0001c6945a0f2 |
| Please reload this page | https://github.com/python/mypy/pull/10685 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Jun 21, 2021
| https://github.com/python/mypy/pull/10685#ref-pullrequest-907798794 |
|
Convert MessageBuilder.disable_errors to a context manager
#10569
| https://github.com/python/mypy/pull/10569 |
| atakiar | https://github.com/atakiar |
| June 21, 2021 13:02 | https://github.com/python/mypy/pull/10685#commits-pushed-b456948 |
|
| https://github.com/atakiar |
| chore: combine context expressions to save indent | https://github.com/python/mypy/pull/10685/commits/b45694833f46a5e89c74e5f0706916399160d209 |
| b456948 | https://github.com/python/mypy/pull/10685/commits/b45694833f46a5e89c74e5f0706916399160d209 |
|
| https://github.com/atakiar |
| chore: add try-finally to enter_block | https://github.com/python/mypy/pull/10685/commits/da842b12e24f6d78b4f6a2525656813b31c587d5 |
| da842b1 | https://github.com/python/mypy/pull/10685/commits/da842b12e24f6d78b4f6a2525656813b31c587d5 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Jun 21, 2021
| https://github.com/python/mypy/pull/10685#pullrequestreview-688685238 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10685/files/da842b12e24f6d78b4f6a2525656813b31c587d5 |
| mypy/renaming.py | https://github.com/python/mypy/pull/10685/files/da842b12e24f6d78b4f6a2525656813b31c587d5#diff-a0cbd708db24512f4d3975740ac9fa9de8c4366395980a4216d0001c6945a0f2 |
| Please reload this page | https://github.com/python/mypy/pull/10685 |
|
| https://github.com/atakiar |
| chore: add try-finally to all contextmanagers | https://github.com/python/mypy/pull/10685/commits/c1aefa7b468c73f8569a275fe4df76ac65c84566 |
| c1aefa7 | https://github.com/python/mypy/pull/10685/commits/c1aefa7b468c73f8569a275fe4df76ac65c84566 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Jun 21, 2021
| https://github.com/python/mypy/pull/10685#pullrequestreview-688691100 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10685/files/c1aefa7b468c73f8569a275fe4df76ac65c84566 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| 08e6ba8 | https://github.com/python/mypy/commit/08e6ba888ea8deb81a6ccea0a04ff7a2b3149d56 |
| Jun 21, 2021 | https://github.com/python/mypy/pull/10685#event-4918456303 |
| https://github.com/atakiar |
| atakiar | https://github.com/atakiar |
| June 21, 2021 19:00 | https://github.com/python/mypy/pull/10685#event-4918602137 |
| https://github.com/97littleleaf11 |
| 97littleleaf11 | https://github.com/97littleleaf11 |
|
Sep 3, 2021
| https://github.com/python/mypy/pull/10685#ref-pullrequest-987890981 |
|
Refactor: use context manager for Scope
#11053
| https://github.com/python/mypy/pull/11053 |
| JukkaL | https://github.com/JukkaL |
|
Sep 6, 2021
| https://github.com/python/mypy/pull/10685#ref-commit-725a24a |
|
| https://github.com/97littleleaf11 |
| Use context manager for Scope ( | https://github.com/python/mypy/commit/725a24a82fdf79521db5d0c43549e8731f793c55 |
| #11053 | https://github.com/python/mypy/pull/11053 |
| ) | https://github.com/python/mypy/commit/725a24a82fdf79521db5d0c43549e8731f793c55 |
| 725a24a | https://github.com/python/mypy/commit/725a24a82fdf79521db5d0c43549e8731f793c55 |
| #1184 | https://github.com/python/mypy/issues/1184 |
| #10569 | https://github.com/python/mypy/pull/10569 |
| #10685 | https://github.com/python/mypy/pull/10685 |
| freundTech | https://github.com/freundTech |
|
Sep 27, 2021
| https://github.com/python/mypy/pull/10685#ref-commit-a5eb480 |
|
| https://github.com/freundTech |
| Fixed more failing tests after merge (Caused by | https://github.com/freundTech/mypy/commit/a5eb48085722a282a8e22eda279202c546783c3d |
| python#10685 | https://github.com/python/mypy/pull/10685 |
| ) | https://github.com/freundTech/mypy/commit/a5eb48085722a282a8e22eda279202c546783c3d |
| a5eb480 | https://github.com/freundTech/mypy/commit/a5eb48085722a282a8e22eda279202c546783c3d |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10685 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/mypy/pull/10685/files/c1aefa7b468c73f8569a275fe4df76ac65c84566 |
| Please reload this page | https://github.com/python/mypy/pull/10685 |
| Please reload this page | https://github.com/python/mypy/pull/10685 |
|
| https://github.com/atakiar |
|
| https://github.com/JelleZijlstra |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |