René's URL Explorer Experiment


Title: Fix typeguards crash when assigning guarded value in if statement by A5rocks · Pull Request #10671 · python/mypy · GitHub

Open Graph Title: Fix typeguards crash when assigning guarded value in if statement by A5rocks · Pull Request #10671 · python/mypy

X Title: Fix typeguards crash when assigning guarded value in if statement by A5rocks · Pull Request #10671 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Description Fixes #10665 This PR implements joining type guard types (which can happen when leaving an if statement). (it continues along the lines of #10496) Test Plan Added the crash case the tes...

X Description: Description Fixes #10665 This PR implements joining type guard types (which can happen when leaving an if statement). (it continues along the lines of #10496) Test Plan Added the crash case the tes...

Opengraph URL: https://github.com/python/mypy/pull/10671

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3dc0d40d-ca3c-3a6f-f35e-7a0ed5b98a33
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1C6:59CDA:37B98B1:49C4875:6B004CD9
html-safe-nonce0272b023a0312769196b30339cb7089e654e4ec3e9bdf7c5cbb947810abdcc11
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUM2OjU5Q0RBOjM3Qjk4QjE6NDlDNDg3NTo2QjAwNENEOSIsInZpc2l0b3JfaWQiOiI2NzA4NjQ0NTA2MTc2MDgxMTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac53ce90caa5bc133ec5ee0406b3c6e804b0945fe7d8b4d62915f267aa3fc8d223
hovercard-subject-tagpull_request:673816410
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/10671/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d097ef0a29e4d2d8d66abe692f909eb27826d15e2bc50f1282e32f5833fc3a45/python/mypy/pull/10671
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d097ef0a29e4d2d8d66abe692f909eb27826d15e2bc50f1282e32f5833fc3a45/python/mypy/pull/10671
og:image:altDescription Fixes #10665 This PR implements joining type guard types (which can happen when leaving an if statement). (it continues along the lines of #10496) Test Plan Added the crash case the tes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameA5rocks
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/10671#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10671
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10671
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/10671
Reloadhttps://github.com/python/mypy/pull/10671
Reloadhttps://github.com/python/mypy/pull/10671
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
A5rockshttps://github.com/A5rocks
python:masterhttps://github.com/python/mypy/tree/master
A5rocks:fix-typeguards-crashhttps://github.com/A5rocks/mypy/tree/fix-typeguards-crash
Conversationhttps://github.com/python/mypy/pull/10671
Commits3 (3)https://github.com/python/mypy/pull/10671/commits
Checkshttps://github.com/python/mypy/pull/10671/checks
Files changedhttps://github.com/python/mypy/pull/10671/files
Fix typeguards crash when assigning guarded value in if statementhttps://github.com/python/mypy/pull/10671#top
A5rockshttps://github.com/A5rocks
python:masterhttps://github.com/python/mypy/tree/master
A5rocks:fix-typeguards-crashhttps://github.com/A5rocks/mypy/tree/fix-typeguards-crash
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Jun 19, 2021https://github.com/python/mypy/pull/10671#issue-925309272
Please reload this pagehttps://github.com/python/mypy/pull/10671
#10665https://github.com/python/mypy/issues/10665
#10496https://github.com/python/mypy/pull/10496
Please reload this pagehttps://github.com/python/mypy/pull/10671
A5rockshttps://github.com/A5rocks
June 19, 2021 12:11https://github.com/python/mypy/pull/10671#commits-pushed-3f068f5
https://github.com/A5rocks
Do not annotate variables as type guardshttps://github.com/python/mypy/pull/10671/commits/3f068f5246b9cc5ef6d9f78a5875a8fc939d5809
3f068f5https://github.com/python/mypy/pull/10671/commits/3f068f5246b9cc5ef6d9f78a5875a8fc939d5809
https://github.com/A5rocks
Remove unneeded importhttps://github.com/python/mypy/pull/10671/commits/707cfdf7b1c953f12e373c4c751f1cbc61eb849a
707cfdfhttps://github.com/python/mypy/pull/10671/commits/707cfdf7b1c953f12e373c4c751f1cbc61eb849a
https://github.com/A5rocks
Tests failed, trying a different approachhttps://github.com/python/mypy/pull/10671/commits/12dbc2aa3540252fb8b4fdcc187db818b89b58c7
12dbc2ahttps://github.com/python/mypy/pull/10671/commits/12dbc2aa3540252fb8b4fdcc187db818b89b58c7
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Jun 19, 2021 https://github.com/python/mypy/pull/10671#pullrequestreview-687794432
View reviewed changes https://github.com/python/mypy/pull/10671/files/12dbc2aa3540252fb8b4fdcc187db818b89b58c7
mypy/join.pyhttps://github.com/python/mypy/pull/10671/files/12dbc2aa3540252fb8b4fdcc187db818b89b58c7#diff-dc731faa017a06257ba26e3eacaf17e68a6078aeaf9755d1c06d917fe13ce457
JelleZijlstrahttps://github.com/JelleZijlstra
Jun 19, 2021https://github.com/python/mypy/pull/10671#discussion_r654746546
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10671
A5rockshttps://github.com/A5rocks
Jun 19, 2021https://github.com/python/mypy/pull/10671#discussion_r654746773
Please reload this pagehttps://github.com/python/mypy/pull/10671
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
3f068f5https://github.com/python/mypy/commit/3f068f5246b9cc5ef6d9f78a5875a8fc939d5809
Please reload this pagehttps://github.com/python/mypy/pull/10671
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Jun 19, 2021https://github.com/python/mypy/pull/10671#issuecomment-864447717
mypy/mypy/checkexpr.pyhttps://github.com/python/mypy/blob/790ab35ca936d04c484d427704d5acb17904012b/mypy/checkexpr.py#L4178-L4181
790ab35https://github.com/python/mypy/commit/790ab35ca936d04c484d427704d5acb17904012b
initial approachhttps://github.com/python/mypy/pull/10671/commits/3f068f5246b9cc5ef6d9f78a5875a8fc939d5809
Please reload this pagehttps://github.com/python/mypy/pull/10671
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Jun 21, 2021https://github.com/python/mypy/pull/10671#issuecomment-865033422
Please reload this pagehttps://github.com/python/mypy/pull/10671
JukkaLhttps://github.com/JukkaL
Jun 21, 2021 https://github.com/python/mypy/pull/10671#ref-commit-db02ec6
https://github.com/JukkaL
Fix crash with assignment to variable guarded with TypeGuardhttps://github.com/python/mypy/commit/db02ec6573abd5790e1fef6ecc081b125d10cb14
db02ec6https://github.com/python/mypy/commit/db02ec6573abd5790e1fef6ecc081b125d10cb14
#10671https://github.com/python/mypy/pull/10671
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Jun 21, 2021 https://github.com/python/mypy/pull/10671#ref-pullrequest-926272474
Fix crash with assignment to variable guarded with TypeGuard #10683 https://github.com/python/mypy/pull/10683
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Jun 21, 2021https://github.com/python/mypy/pull/10671#issuecomment-865144648
#10683https://github.com/python/mypy/pull/10683
Please reload this pagehttps://github.com/python/mypy/pull/10671
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
#10683 https://github.com/python/mypy/pull/10683
Jun 21, 2021https://github.com/python/mypy/pull/10671#event-4918295577
JukkaLhttps://github.com/JukkaL
Jun 21, 2021 https://github.com/python/mypy/pull/10671#ref-commit-749dbf0
https://github.com/JukkaL
Fix crash with assignment to variable guarded with TypeGuard (https://github.com/python/mypy/commit/749dbf092220d992fda5f879210c907e99927a03
#10683https://github.com/python/mypy/pull/10683
)https://github.com/python/mypy/commit/749dbf092220d992fda5f879210c907e99927a03
749dbf0https://github.com/python/mypy/commit/749dbf092220d992fda5f879210c907e99927a03
#10671https://github.com/python/mypy/pull/10671
JukkaLhttps://github.com/JukkaL
Jun 22, 2021 https://github.com/python/mypy/pull/10671#ref-commit-9637f99
https://github.com/JukkaL
Fix crash with assignment to variable guarded with TypeGuard (https://github.com/python/mypy/commit/9637f992fbd9f0d8e5ae4a0fed91c6aa3fdb10f2
#10683https://github.com/python/mypy/pull/10683
)https://github.com/python/mypy/commit/9637f992fbd9f0d8e5ae4a0fed91c6aa3fdb10f2
9637f99https://github.com/python/mypy/commit/9637f992fbd9f0d8e5ae4a0fed91c6aa3fdb10f2
#10671https://github.com/python/mypy/pull/10671
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Aug 1, 2021 https://github.com/python/mypy/pull/10671#ref-issue-957353054
type guarded value is same type as typing.TypeGuard[T]? #10899 https://github.com/python/mypy/issues/10899
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10671
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/mypy/pull/10671/files/12dbc2aa3540252fb8b4fdcc187db818b89b58c7
Please reload this pagehttps://github.com/python/mypy/pull/10671
Crash on assigning to guarded variable in failed TypeGuard branch https://github.com/python/mypy/issues/10665
Please reload this pagehttps://github.com/python/mypy/pull/10671
https://github.com/A5rocks
https://github.com/JukkaL
https://github.com/JelleZijlstra
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.