| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:02f6576b-1bbc-8651-11f5-186102250257 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CC18:1833B7:12690F1:1898847:6AFFCEA9 |
| html-safe-nonce | a1654f4a23c7be4db8ad8d2fb9ac995927b0613ca9638b2200efd29e7f03c589 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzE4OjE4MzNCNzoxMjY5MEYxOjE4OTg4NDc6NkFGRkNFQTkiLCJ2aXNpdG9yX2lkIjoiMjQyMjY3NjA0MjgzNDQ5NzE5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 16a5f8e6db3b2f0214c76e997d535f479b545f782dcf22c9c81cf26504175601 |
| hovercard-subject-tag | pull_request:659187870 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/10572/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/969d7e4ffeb833067b94d839cfd85cb55932f874690a9ba20c7f56484a01ae84/python/mypy/pull/10572 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/969d7e4ffeb833067b94d839cfd85cb55932f874690a9ba20c7f56484a01ae84/python/mypy/pull/10572 |
| og:image:alt | Description
Closes #3379. See PR #3410 for some context
Currently if a method is incompatible with a base class, mypy just states the name of the base class but doesn't actually give more detai... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | atakiar |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/10572#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10572 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10572 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/10572 |
| Reload | https://github.com/python/mypy/pull/10572 |
| Reload | https://github.com/python/mypy/pull/10572 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| msullivan | https://github.com/msullivan |
| python:master | https://github.com/python/mypy/tree/master |
| atakiar:better-incompatible-messages | https://github.com/atakiar/mypy/tree/better-incompatible-messages |
| Conversation | https://github.com/python/mypy/pull/10572 |
| Commits18 (18) | https://github.com/python/mypy/pull/10572/commits |
| Checks | https://github.com/python/mypy/pull/10572/checks |
| Files changed | https://github.com/python/mypy/pull/10572/files |
| feat: better message if method incompatible with base class | https://github.com/python/mypy/pull/10572#top |
| msullivan | https://github.com/msullivan |
| python:master | https://github.com/python/mypy/tree/master |
| atakiar:better-incompatible-messages | https://github.com/atakiar/mypy/tree/better-incompatible-messages |
|
| https://github.com/atakiar |
| atakiar | https://github.com/atakiar |
| Jun 1, 2021 | https://github.com/python/mypy/pull/10572#issue-908506089 |
| #3379 | https://github.com/python/mypy/issues/3379 |
| #3410 | https://github.com/python/mypy/pull/3410 |
| Please reload this page | https://github.com/python/mypy/pull/10572 |
| atakiar | https://github.com/atakiar |
| May 31, 2021 17:51 | https://github.com/python/mypy/pull/10572#commits-pushed-73971a4 |
|
| https://github.com/atakiar |
| feat: allow duplicate messages | https://github.com/python/mypy/pull/10572/commits/73971a49ce95803a57ea4113e796cd76be5269ad |
| 73971a4 | https://github.com/python/mypy/pull/10572/commits/73971a49ce95803a57ea4113e796cd76be5269ad |
|
| https://github.com/atakiar |
| chore: move pretty_overload's arbitrary offset calculation to call sites | https://github.com/python/mypy/pull/10572/commits/6bea6a4db21058dba9c077d4885f9abebe159411 |
| 6bea6a4 | https://github.com/python/mypy/pull/10572/commits/6bea6a4db21058dba9c077d4885f9abebe159411 |
|
| https://github.com/atakiar |
| feat: add allow duplicate messages support to MessageBuilder | https://github.com/python/mypy/pull/10572/commits/91e7c91dcbaa6390fa5f0ebd3510cc32ee65c8a2 |
| 91e7c91 | https://github.com/python/mypy/pull/10572/commits/91e7c91dcbaa6390fa5f0ebd3510cc32ee65c8a2 |
|
| https://github.com/atakiar |
| feat: add pretty_class_or_static_decorator | https://github.com/python/mypy/pull/10572/commits/cb5bd3e46af07203579f5e556c6c61b16a1f41a5 |
| cb5bd3e | https://github.com/python/mypy/pull/10572/commits/cb5bd3e46af07203579f5e556c6c61b16a1f41a5 |
|
| https://github.com/atakiar |
| feat: update pretty_overload's parameters | https://github.com/python/mypy/pull/10572/commits/32b0bb7941c0ea5f32fc495f6344a12f7496217f |
| 32b0bb7 | https://github.com/python/mypy/pull/10572/commits/32b0bb7941c0ea5f32fc495f6344a12f7496217f |
|
| https://github.com/atakiar |
| feat: display better incompatible messages | https://github.com/python/mypy/pull/10572/commits/5d940748f16801369115fabd7cb8480f2892f44a |
| 5d94074 | https://github.com/python/mypy/pull/10572/commits/5d940748f16801369115fabd7cb8480f2892f44a |
|
| https://github.com/atakiar |
| fix: pretty_callable's handling of TypeGuards | https://github.com/python/mypy/pull/10572/commits/4d108e2159d07938d8c129f178da663e0249429a |
| 4d108e2 | https://github.com/python/mypy/pull/10572/commits/4d108e2159d07938d8c129f178da663e0249429a |
|
| https://github.com/atakiar |
| chore: update tests | https://github.com/python/mypy/pull/10572/commits/4bf8cc312cf5935b552648726131109cf668581c |
| 4bf8cc3 | https://github.com/python/mypy/pull/10572/commits/4bf8cc312cf5935b552648726131109cf668581c |
|
| https://github.com/atakiar |
| Merge branch 'master' into better-incompatible-messages | https://github.com/python/mypy/pull/10572/commits/4670d2e48f6d9544333a302a60fbd98aad925b02 |
| 4670d2e | https://github.com/python/mypy/pull/10572/commits/4670d2e48f6d9544333a302a60fbd98aad925b02 |
|
| https://github.com/atakiar |
| Merge branch 'master' into better-incompatible-messages | https://github.com/python/mypy/pull/10572/commits/f01efecd112f86374b7ca42309469adb232ba33f |
| f01efec | https://github.com/python/mypy/pull/10572/commits/f01efecd112f86374b7ca42309469adb232ba33f |
|
| https://github.com/atakiar |
| Merge branch 'master' into better-incompatible-messages | https://github.com/python/mypy/pull/10572/commits/10ea6adf889530313c2ae5ccfaf9be336005c5a0 |
| 10ea6ad | https://github.com/python/mypy/pull/10572/commits/10ea6adf889530313c2ae5ccfaf9be336005c5a0 |
| https://github.com/atakiar |
| atakiar | https://github.com/atakiar |
| Jun 1, 2021 | https://github.com/python/mypy/pull/10572#issuecomment-852337324 |
| mypy/mypy/messages.py | https://github.com/python/mypy/blob/10ea6adf889530313c2ae5ccfaf9be336005c5a0/mypy/messages.py#L1932-L1949 |
| 10ea6ad | https://github.com/python/mypy/commit/10ea6adf889530313c2ae5ccfaf9be336005c5a0 |
| Please reload this page | https://github.com/python/mypy/pull/10572 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10572 |
| atakiar | https://github.com/atakiar |
| June 9, 2021 14:26 | https://github.com/python/mypy/pull/10572#commits-pushed-98138bd |
|
| https://github.com/atakiar |
| Merge branch 'master' into better-incompatible-messages | https://github.com/python/mypy/pull/10572/commits/98138bd8a3afd574a40c6a89d38cd62337dea0dd |
| 98138bd | https://github.com/python/mypy/pull/10572/commits/98138bd8a3afd574a40c6a89d38cd62337dea0dd |
|
| https://github.com/atakiar |
| Merge branch 'master' into better-incompatible-messages | https://github.com/python/mypy/pull/10572/commits/d3c0b3178c2bbc5112aee8ca621c67159199cbb8 |
| d3c0b31 | https://github.com/python/mypy/pull/10572/commits/d3c0b3178c2bbc5112aee8ca621c67159199cbb8 |
|
| https://github.com/atakiar |
| fix: missing positional argument in call to ErrorInfo | https://github.com/python/mypy/pull/10572/commits/1736224e5f275a38ac3a3d4a1fdb99e154725352 |
| 1736224 | https://github.com/python/mypy/pull/10572/commits/1736224e5f275a38ac3a3d4a1fdb99e154725352 |
| https://github.com/atakiar |
| atakiar | https://github.com/atakiar |
|
Jun 12, 2021
| https://github.com/python/mypy/pull/10572#ref-pullrequest-919363665 |
|
feat: improve diff formatting
hauntsaninja/mypy_primer#12
| https://github.com/hauntsaninja/mypy_primer/pull/12 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10572 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| Jun 13, 2021 | https://github.com/python/mypy/pull/10572#issuecomment-860288825 |
| @atakiar | https://github.com/atakiar |
| Please reload this page | https://github.com/python/mypy/pull/10572 |
| atakiar | https://github.com/atakiar |
| June 14, 2021 12:08 | https://github.com/python/mypy/pull/10572#commits-pushed-4a1d52f |
|
| https://github.com/atakiar |
| Merge branch 'master' into better-incompatible-messages | https://github.com/python/mypy/pull/10572/commits/4a1d52fed18a2a49b28bac9f1e09388291127c42 |
| 4a1d52f | https://github.com/python/mypy/pull/10572/commits/4a1d52fed18a2a49b28bac9f1e09388291127c42 |
|
| https://github.com/atakiar |
| Merge branch 'master' into better-incompatible-messages | https://github.com/python/mypy/pull/10572/commits/2b76a3b1d32ee066749f1890517be33731bd97bf |
| 2b76a3b | https://github.com/python/mypy/pull/10572/commits/2b76a3b1d32ee066749f1890517be33731bd97bf |
| https://github.com/atakiar |
| atakiar | https://github.com/atakiar |
| Jun 17, 2021 | https://github.com/python/mypy/pull/10572#issuecomment-863620729 |
| @msullivan | https://github.com/msullivan |
| Please reload this page | https://github.com/python/mypy/pull/10572 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10572 |
| https://github.com/atakiar |
| atakiar | https://github.com/atakiar |
| Jun 18, 2021 | https://github.com/python/mypy/pull/10572#issuecomment-863701001 |
| @msullivan | https://github.com/msullivan |
| #10579 | https://github.com/python/mypy/pull/10579 |
| Please reload this page | https://github.com/python/mypy/pull/10572 |
|
| https://github.com/atakiar |
| Merge branch 'master' into better-incompatible-messages | https://github.com/python/mypy/pull/10572/commits/ca728b325f9e0d6317d34714d2e99d13e4dc1542 |
| ca728b3 | https://github.com/python/mypy/pull/10572/commits/ca728b325f9e0d6317d34714d2e99d13e4dc1542 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10572 |
|
| https://github.com/atakiar |
| Merge branch 'master' into better-incompatible-messages | https://github.com/python/mypy/pull/10572/commits/e14994877107a4e4fbf0485620ce9bd5f28f6e33 |
| e149948 | https://github.com/python/mypy/pull/10572/commits/e14994877107a4e4fbf0485620ce9bd5f28f6e33 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jul 4, 2021 | https://github.com/python/mypy/pull/10572#issuecomment-873520233 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/10572 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Jul 10, 2021
| https://github.com/python/mypy/pull/10572#pullrequestreview-703524613 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10572/files/e14994877107a4e4fbf0485620ce9bd5f28f6e33 |
| msullivan | https://github.com/msullivan |
| https://github.com/python/mypy/pull/10572#pullrequestreview-703524613 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10572 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
| 612d59a | https://github.com/python/mypy/commit/612d59a3c2dadda2cff391637b66a0393b479095 |
| Jul 10, 2021 | https://github.com/python/mypy/pull/10572#event-5003530153 |
| https://github.com/atakiar |
| atakiar | https://github.com/atakiar |
| July 29, 2021 00:20 | https://github.com/python/mypy/pull/10572#event-5083078998 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10572 |
|
| https://github.com/msullivan |
|
msullivan
| https://github.com/msullivan |
|
| https://github.com/python/mypy/pull/10572/files/e14994877107a4e4fbf0485620ce9bd5f28f6e33 |
| Please reload this page | https://github.com/python/mypy/pull/10572 |
|
Better message if method incompatible with base class
| https://github.com/python/mypy/issues/3379 |
| Please reload this page | https://github.com/python/mypy/pull/10572 |
|
| https://github.com/atakiar |
|
| https://github.com/msullivan |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |