| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c5e8f0ad-72f6-0ac9-f857-18350758b703 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8156:B5253:14902BC:1B1B090:6B001733 |
| html-safe-nonce | feeef45b3204935915ceddf39d0ea93bfa80c1ee0782ade7cf8ea33abc02e369 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTU2OkI1MjUzOjE0OTAyQkM6MUIxQjA5MDo2QjAwMTczMyIsInZpc2l0b3JfaWQiOiI1MTQ0ODQyODE2MzAzNjY2OTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d2bb4a137f54ef4916f5d72a4f440bcb4ad6dc0dc197f3885829b6a3babed41d |
| hovercard-subject-tag | pull_request:658580223 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/10567/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b40f56e9ba2eaffc612bcec6bc71cc6f659b93dff6ad85bd4b0c842383928c1f/python/mypy/pull/10567 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b40f56e9ba2eaffc612bcec6bc71cc6f659b93dff6ad85bd4b0c842383928c1f/python/mypy/pull/10567 |
| og:image:alt | Context managers used in tests should do their cleanups in finally so that tests don't bleed into each other and cause unrelated tests to fail (and send us down a wild goose chase)
Add __traceb... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ikonst |
| hostname | github.com |
| expected-hostname | github.com |
| None | a2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 70121d4e855ee0bb7b75cf15d061d91f8863c0f8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/10567#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10567 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10567 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/10567 |
| Reload | https://github.com/python/mypy/pull/10567 |
| Reload | https://github.com/python/mypy/pull/10567 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| ikonst:pytest-quality-of-life | https://github.com/ikonst/mypy/tree/pytest-quality-of-life |
| Conversation | https://github.com/python/mypy/pull/10567 |
| Commits3 (3) | https://github.com/python/mypy/pull/10567/commits |
| Checks | https://github.com/python/mypy/pull/10567/checks |
| Files changed | https://github.com/python/mypy/pull/10567/files |
| Improve pytest quality of life | https://github.com/python/mypy/pull/10567#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| ikonst:pytest-quality-of-life | https://github.com/ikonst/mypy/tree/pytest-quality-of-life |
|
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| Jun 1, 2021 | https://github.com/python/mypy/pull/10567#issue-907791443 |
| Please reload this page | https://github.com/python/mypy/pull/10567 |
| https://docs.pytest.org/en/6.2.x/example/simple.html#writing-well-integrated-assertion-helpers | https://docs.pytest.org/en/6.2.x/example/simple.html#writing-well-integrated-assertion-helpers |
| Please reload this page | https://github.com/python/mypy/pull/10567 |
|
| https://github.com/ikonst |
| Improve pytest quality of life | https://github.com/python/mypy/pull/10567/commits/c36dd346c432ec54f444cda6564dc78a4b05397a |
| c36dd34 | https://github.com/python/mypy/pull/10567/commits/c36dd346c432ec54f444cda6564dc78a4b05397a |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
|
Jun 1, 2021
| https://github.com/python/mypy/pull/10567#pullrequestreview-672590660 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a |
| mypy/state.py | https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a#diff-ed0810dae3bbc958cec507d91bb8f5a10288126c3cd29a6833bfbcb26b30900e |
| ikonst | https://github.com/ikonst |
| Jun 1, 2021 | https://github.com/python/mypy/pull/10567#discussion_r642727706 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10567 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
|
Jun 1, 2021
| https://github.com/python/mypy/pull/10567#pullrequestreview-672590769 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a |
| mypy/test/helpers.py | https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a#diff-960782756750eeb77bd6dba85ac60db67cbd65b44262d0060e5fa2ea757cd6b4 |
| ikonst | https://github.com/ikonst |
| Jun 1, 2021 | https://github.com/python/mypy/pull/10567#discussion_r642727810 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://docs.pytest.org/en/6.2.x/example/simple.html#writing-well-integrated-assertion-helpers | https://docs.pytest.org/en/6.2.x/example/simple.html#writing-well-integrated-assertion-helpers |
| Please reload this page | https://github.com/python/mypy/pull/10567 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
|
Jun 1, 2021
| https://github.com/python/mypy/pull/10567#pullrequestreview-672591129 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a |
| mypy/test/helpers.py | https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a#diff-960782756750eeb77bd6dba85ac60db67cbd65b44262d0060e5fa2ea757cd6b4 |
| ikonst | https://github.com/ikonst |
| Jun 1, 2021 | https://github.com/python/mypy/pull/10567#discussion_r642728087 |
| Please reload this page | https://github.com/python/mypy/pull/10567 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #4369 | https://github.com/python/mypy/pull/4369 |
| Please reload this page | https://github.com/python/mypy/pull/10567 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Jun 1, 2021
| https://github.com/python/mypy/pull/10567#pullrequestreview-672591524 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jun 1, 2021
| https://github.com/python/mypy/pull/10567#pullrequestreview-672608159 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a |
| mypy/test/testtypes.py | https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a#diff-7b0a8fc4d41aa3ceec983af052a5e15380d407ac85a01671b776a4348635f0e5 |
| hauntsaninja | https://github.com/hauntsaninja |
| Jun 1, 2021 | https://github.com/python/mypy/pull/10567#discussion_r642742572 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10567 |
| ikonst | https://github.com/ikonst |
| Jun 1, 2021 | https://github.com/python/mypy/pull/10567#discussion_r642747063 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10567 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jun 1, 2021
| https://github.com/python/mypy/pull/10567#pullrequestreview-672608254 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/mypy/pull/10567#pullrequestreview-672608254 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10567 |
| ikonst | https://github.com/ikonst |
| May 31, 2021 22:46 | https://github.com/python/mypy/pull/10567#commits-pushed-f45604b |
|
| https://github.com/ikonst |
| clean up after sloppy regex | https://github.com/python/mypy/pull/10567/commits/f45604b67042bead90b7bc233a391b6a5b111319 |
| f45604b | https://github.com/python/mypy/pull/10567/commits/f45604b67042bead90b7bc233a391b6a5b111319 |
|
| https://github.com/ikonst |
| lint | https://github.com/python/mypy/pull/10567/commits/a950524bd1d82bc0df1a9dad57179d47c9379238 |
| a950524 | https://github.com/python/mypy/pull/10567/commits/a950524bd1d82bc0df1a9dad57179d47c9379238 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| 98ac487 | https://github.com/python/mypy/commit/98ac4874f84dc83e0b9845ef10b73c1799111a7a |
| Jun 1, 2021 | https://github.com/python/mypy/pull/10567#event-4823042459 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| June 1, 2021 12:31 | https://github.com/python/mypy/pull/10567#event-4825085293 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10567 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/mypy/pull/10567/files/c36dd346c432ec54f444cda6564dc78a4b05397a |
| Please reload this page | https://github.com/python/mypy/pull/10567 |
| Please reload this page | https://github.com/python/mypy/pull/10567 |
|
| https://github.com/ikonst |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |