René's URL Explorer Experiment


Title: Fail when conditioning on implicit bool by ikonst · Pull Request #10557 · python/mypy · GitHub

Open Graph Title: Fail when conditioning on implicit bool by ikonst · Pull Request #10557 · python/mypy

X Title: Fail when conditioning on implicit bool by ikonst · Pull Request #10557 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Description Fails conditionals where the expression's type does not implement __bool__ nor __len__ since such expressions would always evaluate as truthy and likely an error (e.g. the common pi...

X Description: Description Fails conditionals where the expression's type does not implement __bool__ nor __len__ since such expressions would always evaluate as truthy and likely an error (e.g. the commo...

Opengraph URL: https://github.com/python/mypy/pull/10557

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4032d400-dcfe-efc6-d34b-02b0a7d44907
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D08:1A3D7F:3050F7D:3FDD294:6B0025EE
html-safe-noncee9b6b83dec31223627cf297bf4fd23cd063962f9d7443d9611c6c85dba050d65
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDA4OjFBM0Q3RjozMDUwRjdEOjNGREQyOTQ6NkIwMDI1RUUiLCJ2aXNpdG9yX2lkIjoiMTY5OTc4NTg0NTIyNzEzNjQ5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac914ac208f39b191ba942fde470d9b91df841d4e1732fb75202bf4ab78ad343e3
hovercard-subject-tagpull_request:657610534
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/10557/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4e4d1359f43ce2b58febbabd81d478fe09ae77925702187616a0e7bf7cad1e85/python/mypy/pull/10557
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4e4d1359f43ce2b58febbabd81d478fe09ae77925702187616a0e7bf7cad1e85/python/mypy/pull/10557
og:image:altDescription Fails conditionals where the expression's type does not implement __bool__ nor __len__ since such expressions would always evaluate as truthy and likely an error (e.g. the common pi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameikonst
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/10557#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10557
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10557
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/10557
Reloadhttps://github.com/python/mypy/pull/10557
Reloadhttps://github.com/python/mypy/pull/10557
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ikonsthttps://github.com/ikonst
python:masterhttps://github.com/python/mypy/tree/master
ikonst:implicit_boolhttps://github.com/ikonst/mypy/tree/implicit_bool
Conversationhttps://github.com/python/mypy/pull/10557
Commits2 (2)https://github.com/python/mypy/pull/10557/commits
Checkshttps://github.com/python/mypy/pull/10557/checks
Files changedhttps://github.com/python/mypy/pull/10557/files
Fail when conditioning on implicit boolhttps://github.com/python/mypy/pull/10557#top
ikonsthttps://github.com/ikonst
python:masterhttps://github.com/python/mypy/tree/master
ikonst:implicit_boolhttps://github.com/ikonst/mypy/tree/implicit_bool
https://github.com/ikonst
ikonsthttps://github.com/ikonst
May 30, 2021https://github.com/python/mypy/pull/10557#issue-906649890
@pkchhttps://github.com/pkch
#3195 (comment)https://github.com/python/mypy/issues/3195#issuecomment-295341122
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/ikonst
Fail when conditioning on implicit boolhttps://github.com/python/mypy/pull/10557/commits/e96ce45d5727eed08820a637f293ce0f646bba62
e96ce45https://github.com/python/mypy/pull/10557/commits/e96ce45d5727eed08820a637f293ce0f646bba62
https://github.com/ikonst
ikonsthttps://github.com/ikonst
force-pushedhttps://github.com/python/mypy/compare/2e1cbdd5c75a7379d819030197e9f7d77598becd..e96ce45d5727eed08820a637f293ce0f646bba62
2e1cbddhttps://github.com/python/mypy/commit/2e1cbdd5c75a7379d819030197e9f7d77598becd
e96ce45https://github.com/python/mypy/commit/e96ce45d5727eed08820a637f293ce0f646bba62
Compare https://github.com/python/mypy/compare/2e1cbdd5c75a7379d819030197e9f7d77598becd..e96ce45d5727eed08820a637f293ce0f646bba62
May 30, 2021 06:31https://github.com/python/mypy/pull/10557#event-4816771192
https://github.com/ikonst
ikonsthttps://github.com/ikonst
May 30, 2021 https://github.com/python/mypy/pull/10557#pullrequestreview-671796032
View reviewed changes https://github.com/python/mypy/pull/10557/files/e96ce45d5727eed08820a637f293ce0f646bba62
docs/source/error_code_list.rsthttps://github.com/python/mypy/pull/10557/files/e96ce45d5727eed08820a637f293ce0f646bba62#diff-34a79b7072942d3b7fbd7dd461c278f0de2ed0bcf03f7177cb5e52c2a7fc3a9d
ikonsthttps://github.com/ikonst
May 30, 2021https://github.com/python/mypy/pull/10557#discussion_r642027948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10557
hauntsaninjahttps://github.com/hauntsaninja
May 30, 2021https://github.com/python/mypy/pull/10557#discussion_r642034208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10557
ikonsthttps://github.com/ikonst
May 30, 2021https://github.com/python/mypy/pull/10557#discussion_r642110419
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/ikonst
ikonsthttps://github.com/ikonst
May 30, 2021 https://github.com/python/mypy/pull/10557#pullrequestreview-671796152
View reviewed changes https://github.com/python/mypy/pull/10557/files/e96ce45d5727eed08820a637f293ce0f646bba62
mypy/test/helpers.pyhttps://github.com/python/mypy/pull/10557/files/e96ce45d5727eed08820a637f293ce0f646bba62#diff-960782756750eeb77bd6dba85ac60db67cbd65b44262d0060e5fa2ea757cd6b4
ikonsthttps://github.com/ikonst
May 30, 2021https://github.com/python/mypy/pull/10557#discussion_r642028170
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/ikonst
add missing type annotationhttps://github.com/python/mypy/pull/10557/commits/2280b7e238fe31900dec23dbd7e619cc6eb22f46
2280b7ehttps://github.com/python/mypy/pull/10557/commits/2280b7e238fe31900dec23dbd7e619cc6eb22f46
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 30, 2021 https://github.com/python/mypy/pull/10557#pullrequestreview-671800106
View reviewed changes https://github.com/python/mypy/pull/10557/files/2280b7e238fe31900dec23dbd7e619cc6eb22f46
hauntsaninjahttps://github.com/hauntsaninja
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/python/mypy/pull/10557#pullrequestreview-671800106
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#8646https://github.com/python/mypy/issues/8646
#9297https://github.com/python/mypy/pull/9297
Please reload this pagehttps://github.com/python/mypy/pull/10557
docs/source/error_code_list.rsthttps://github.com/python/mypy/pull/10557/files/e96ce45d5727eed08820a637f293ce0f646bba62#diff-34a79b7072942d3b7fbd7dd461c278f0de2ed0bcf03f7177cb5e52c2a7fc3a9d
hauntsaninjahttps://github.com/hauntsaninja
May 30, 2021https://github.com/python/mypy/pull/10557#discussion_r642034208
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10557
mypy/message_registry.pyhttps://github.com/python/mypy/pull/10557/files/2280b7e238fe31900dec23dbd7e619cc6eb22f46#diff-22d8715978487b1dabbb697a6544012387b26d95dfd35463f5bc554fa6780ca6
hauntsaninjahttps://github.com/hauntsaninja
May 30, 2021https://github.com/python/mypy/pull/10557#discussion_r642035077
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/ikonst
ikonsthttps://github.com/ikonst
May 30, 2021https://github.com/python/mypy/pull/10557#issuecomment-851035174
Please reload this pagehttps://github.com/python/mypy/pull/10557
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/ikonst
ikonsthttps://github.com/ikonst
May 31, 2021https://github.com/python/mypy/pull/10557#issuecomment-851475501
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/jbcpollak
jbcpollakhttps://github.com/jbcpollak
Jun 2, 2021 https://github.com/python/mypy/pull/10557#ref-issue-909849276
Selector __init__ is incorrectly typed splintered-reality/py_trees#337 https://github.com/splintered-reality/py_trees/issues/337
https://github.com/Akuli
Akulihttps://github.com/Akuli
Jun 6, 2021https://github.com/python/mypy/pull/10557#issuecomment-855435480
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Jun 7, 2021https://github.com/python/mypy/pull/10557#issuecomment-855549293
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/Akuli
Akulihttps://github.com/Akuli
Jun 7, 2021https://github.com/python/mypy/pull/10557#issuecomment-855746504
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Sep 3, 2021https://github.com/python/mypy/pull/10557#issuecomment-912583881
#10666https://github.com/python/mypy/pull/10666
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/ikonst
ikonsthttps://github.com/ikonst
Sep 3, 2021https://github.com/python/mypy/pull/10557#event-5253871166
https://github.com/ikonst
ikonsthttps://github.com/ikonst
September 3, 2021 14:31https://github.com/python/mypy/pull/10557#event-5253871443
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Feb 10, 2022 https://github.com/python/mypy/pull/10557#ref-issue-1129254615
(🎁) final class without a __bool__ or __len__ method can never test false #12158 https://github.com/python/mypy/issues/12158
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10557
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/10557/files/2280b7e238fe31900dec23dbd7e619cc6eb22f46
Please reload this pagehttps://github.com/python/mypy/pull/10557
Please reload this pagehttps://github.com/python/mypy/pull/10557
https://github.com/ikonst
https://github.com/Akuli
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.