| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4032d400-dcfe-efc6-d34b-02b0a7d44907 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8D08:1A3D7F:3050F7D:3FDD294:6B0025EE |
| html-safe-nonce | e9b6b83dec31223627cf297bf4fd23cd063962f9d7443d9611c6c85dba050d65 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDA4OjFBM0Q3RjozMDUwRjdEOjNGREQyOTQ6NkIwMDI1RUUiLCJ2aXNpdG9yX2lkIjoiMTY5OTc4NTg0NTIyNzEzNjQ5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 914ac208f39b191ba942fde470d9b91df841d4e1732fb75202bf4ab78ad343e3 |
| hovercard-subject-tag | pull_request:657610534 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/10557/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4e4d1359f43ce2b58febbabd81d478fe09ae77925702187616a0e7bf7cad1e85/python/mypy/pull/10557 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4e4d1359f43ce2b58febbabd81d478fe09ae77925702187616a0e7bf7cad1e85/python/mypy/pull/10557 |
| og:image:alt | Description
Fails conditionals where the expression's type does not implement __bool__ nor __len__ since such expressions would always evaluate as truthy and likely an error (e.g. the common pi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ikonst |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/10557#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10557 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10557 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/10557 |
| Reload | https://github.com/python/mypy/pull/10557 |
| Reload | https://github.com/python/mypy/pull/10557 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ikonst | https://github.com/ikonst |
| python:master | https://github.com/python/mypy/tree/master |
| ikonst:implicit_bool | https://github.com/ikonst/mypy/tree/implicit_bool |
| Conversation | https://github.com/python/mypy/pull/10557 |
| Commits2 (2) | https://github.com/python/mypy/pull/10557/commits |
| Checks | https://github.com/python/mypy/pull/10557/checks |
| Files changed | https://github.com/python/mypy/pull/10557/files |
| Fail when conditioning on implicit bool | https://github.com/python/mypy/pull/10557#top |
| ikonst | https://github.com/ikonst |
| python:master | https://github.com/python/mypy/tree/master |
| ikonst:implicit_bool | https://github.com/ikonst/mypy/tree/implicit_bool |
|
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| May 30, 2021 | https://github.com/python/mypy/pull/10557#issue-906649890 |
| @pkch | https://github.com/pkch |
| #3195 (comment) | https://github.com/python/mypy/issues/3195#issuecomment-295341122 |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
|
| https://github.com/ikonst |
| Fail when conditioning on implicit bool | https://github.com/python/mypy/pull/10557/commits/e96ce45d5727eed08820a637f293ce0f646bba62 |
| e96ce45 | https://github.com/python/mypy/pull/10557/commits/e96ce45d5727eed08820a637f293ce0f646bba62 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| force-pushed | https://github.com/python/mypy/compare/2e1cbdd5c75a7379d819030197e9f7d77598becd..e96ce45d5727eed08820a637f293ce0f646bba62 |
| 2e1cbdd | https://github.com/python/mypy/commit/2e1cbdd5c75a7379d819030197e9f7d77598becd |
| e96ce45 | https://github.com/python/mypy/commit/e96ce45d5727eed08820a637f293ce0f646bba62 |
|
Compare
| https://github.com/python/mypy/compare/2e1cbdd5c75a7379d819030197e9f7d77598becd..e96ce45d5727eed08820a637f293ce0f646bba62 |
| May 30, 2021 06:31 | https://github.com/python/mypy/pull/10557#event-4816771192 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
|
May 30, 2021
| https://github.com/python/mypy/pull/10557#pullrequestreview-671796032 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10557/files/e96ce45d5727eed08820a637f293ce0f646bba62 |
| docs/source/error_code_list.rst | https://github.com/python/mypy/pull/10557/files/e96ce45d5727eed08820a637f293ce0f646bba62#diff-34a79b7072942d3b7fbd7dd461c278f0de2ed0bcf03f7177cb5e52c2a7fc3a9d |
| ikonst | https://github.com/ikonst |
| May 30, 2021 | https://github.com/python/mypy/pull/10557#discussion_r642027948 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| hauntsaninja | https://github.com/hauntsaninja |
| May 30, 2021 | https://github.com/python/mypy/pull/10557#discussion_r642034208 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| ikonst | https://github.com/ikonst |
| May 30, 2021 | https://github.com/python/mypy/pull/10557#discussion_r642110419 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
|
May 30, 2021
| https://github.com/python/mypy/pull/10557#pullrequestreview-671796152 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10557/files/e96ce45d5727eed08820a637f293ce0f646bba62 |
| mypy/test/helpers.py | https://github.com/python/mypy/pull/10557/files/e96ce45d5727eed08820a637f293ce0f646bba62#diff-960782756750eeb77bd6dba85ac60db67cbd65b44262d0060e5fa2ea757cd6b4 |
| ikonst | https://github.com/ikonst |
| May 30, 2021 | https://github.com/python/mypy/pull/10557#discussion_r642028170 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
|
| https://github.com/ikonst |
| add missing type annotation | https://github.com/python/mypy/pull/10557/commits/2280b7e238fe31900dec23dbd7e619cc6eb22f46 |
| 2280b7e | https://github.com/python/mypy/pull/10557/commits/2280b7e238fe31900dec23dbd7e619cc6eb22f46 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
May 30, 2021
| https://github.com/python/mypy/pull/10557#pullrequestreview-671800106 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10557/files/2280b7e238fe31900dec23dbd7e619cc6eb22f46 |
| hauntsaninja | https://github.com/hauntsaninja |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| https://github.com/python/mypy/pull/10557#pullrequestreview-671800106 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #8646 | https://github.com/python/mypy/issues/8646 |
| #9297 | https://github.com/python/mypy/pull/9297 |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| docs/source/error_code_list.rst | https://github.com/python/mypy/pull/10557/files/e96ce45d5727eed08820a637f293ce0f646bba62#diff-34a79b7072942d3b7fbd7dd461c278f0de2ed0bcf03f7177cb5e52c2a7fc3a9d |
| hauntsaninja | https://github.com/hauntsaninja |
| May 30, 2021 | https://github.com/python/mypy/pull/10557#discussion_r642034208 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| mypy/message_registry.py | https://github.com/python/mypy/pull/10557/files/2280b7e238fe31900dec23dbd7e619cc6eb22f46#diff-22d8715978487b1dabbb697a6544012387b26d95dfd35463f5bc554fa6780ca6 |
| hauntsaninja | https://github.com/hauntsaninja |
| May 30, 2021 | https://github.com/python/mypy/pull/10557#discussion_r642035077 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| May 30, 2021 | https://github.com/python/mypy/pull/10557#issuecomment-851035174 |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| May 31, 2021 | https://github.com/python/mypy/pull/10557#issuecomment-851475501 |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| https://github.com/jbcpollak |
| jbcpollak | https://github.com/jbcpollak |
|
Jun 2, 2021
| https://github.com/python/mypy/pull/10557#ref-issue-909849276 |
|
Selector __init__ is incorrectly typed
splintered-reality/py_trees#337
| https://github.com/splintered-reality/py_trees/issues/337 |
| https://github.com/Akuli |
| Akuli | https://github.com/Akuli |
| Jun 6, 2021 | https://github.com/python/mypy/pull/10557#issuecomment-855435480 |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| Jun 7, 2021 | https://github.com/python/mypy/pull/10557#issuecomment-855549293 |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| https://github.com/Akuli |
| Akuli | https://github.com/Akuli |
| Jun 7, 2021 | https://github.com/python/mypy/pull/10557#issuecomment-855746504 |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| Sep 3, 2021 | https://github.com/python/mypy/pull/10557#issuecomment-912583881 |
| #10666 | https://github.com/python/mypy/pull/10666 |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| Sep 3, 2021 | https://github.com/python/mypy/pull/10557#event-5253871166 |
| https://github.com/ikonst |
| ikonst | https://github.com/ikonst |
| September 3, 2021 14:31 | https://github.com/python/mypy/pull/10557#event-5253871443 |
| https://github.com/sobolevn |
| sobolevn | https://github.com/sobolevn |
|
Feb 10, 2022
| https://github.com/python/mypy/pull/10557#ref-issue-1129254615 |
|
(🎁) final class without a __bool__ or __len__ method can never test false
#12158
| https://github.com/python/mypy/issues/12158 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10557 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/10557/files/2280b7e238fe31900dec23dbd7e619cc6eb22f46 |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
| Please reload this page | https://github.com/python/mypy/pull/10557 |
|
| https://github.com/ikonst |
|
| https://github.com/Akuli |
|
| https://github.com/hauntsaninja |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |