René's URL Explorer Experiment


Title: Use context managers for disable_errors() by dixith · Pull Request #10251 · python/mypy · GitHub

Open Graph Title: Use context managers for disable_errors() by dixith · Pull Request #10251 · python/mypy

X Title: Use context managers for disable_errors() by dixith · Pull Request #10251 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Description This PR fixes one of the issue reported in #1184 Test Plan Since this change is coding style change, new cases are not added.

X Description: Description This PR fixes one of the issue reported in #1184 Test Plan Since this change is coding style change, new cases are not added.

Opengraph URL: https://github.com/python/mypy/pull/10251

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9645efe5-effe-1c89-ac52-346ad8afa1ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8322:1D7BA0:2E653:3F9B0:6B001A0F
html-safe-nonceafa587762aefbb1e8e02ee62a0b4b77b5521c26c328f96bec9f2c628e142b515
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzIyOjFEN0JBMDoyRTY1MzozRjlCMDo2QjAwMUEwRiIsInZpc2l0b3JfaWQiOiI2Mjg0NDA3ODg3NDQ3OTg4NzUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac35a0846f6b05bf30e92b9a71e302ba6e76b6910a64fcac241bc3e4712a910b03
hovercard-subject-tagpull_request:602076733
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/10251/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d04c37e9bfdfa4a4f2b71ca5727d035891cc7ccb0999361f455e950105946c23/python/mypy/pull/10251
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d04c37e9bfdfa4a4f2b71ca5727d035891cc7ccb0999361f455e950105946c23/python/mypy/pull/10251
og:image:altDescription This PR fixes one of the issue reported in #1184 Test Plan Since this change is coding style change, new cases are not added.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedixith
hostnamegithub.com
expected-hostnamegithub.com
Nonea2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release70121d4e855ee0bb7b75cf15d061d91f8863c0f8
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/10251#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10251
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10251
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/10251
Reloadhttps://github.com/python/mypy/pull/10251
Reloadhttps://github.com/python/mypy/pull/10251
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
dixithhttps://github.com/dixith
python:masterhttps://github.com/python/mypy/tree/master
dixith:masterhttps://github.com/dixith/mypy/tree/master
Conversationhttps://github.com/python/mypy/pull/10251
Commits8 (8)https://github.com/python/mypy/pull/10251/commits
Checkshttps://github.com/python/mypy/pull/10251/checks
Files changedhttps://github.com/python/mypy/pull/10251/files
Use context managers for disable_errors()https://github.com/python/mypy/pull/10251#top
dixithhttps://github.com/dixith
python:masterhttps://github.com/python/mypy/tree/master
dixith:masterhttps://github.com/dixith/mypy/tree/master
https://github.com/dixith
dixithhttps://github.com/dixith
Mar 27, 2021https://github.com/python/mypy/pull/10251#issue-842518739
Please reload this pagehttps://github.com/python/mypy/pull/10251
#1184https://github.com/python/mypy/issues/1184
Please reload this pagehttps://github.com/python/mypy/pull/10251
https://github.com/dixith
Use context managers for disable_errors()https://github.com/python/mypy/pull/10251/commits/57f83ea29a52a2fcf4e754dd561790240e4bd7ab
57f83eahttps://github.com/python/mypy/pull/10251/commits/57f83ea29a52a2fcf4e754dd561790240e4bd7ab
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Mar 27, 2021 https://github.com/python/mypy/pull/10251#pullrequestreview-622656526
View reviewed changes https://github.com/python/mypy/pull/10251/files/57f83ea29a52a2fcf4e754dd561790240e4bd7ab
JelleZijlstrahttps://github.com/JelleZijlstra
https://github.com/python/mypy/pull/10251#pullrequestreview-622656526
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10251
mypy/messages.pyhttps://github.com/python/mypy/pull/10251/files/57f83ea29a52a2fcf4e754dd561790240e4bd7ab#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0
JelleZijlstrahttps://github.com/JelleZijlstra
Mar 27, 2021https://github.com/python/mypy/pull/10251#discussion_r602729436
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10251
dixithhttps://github.com/dixith
Mar 27, 2021https://github.com/python/mypy/pull/10251#discussion_r602730518
Please reload this pagehttps://github.com/python/mypy/pull/10251
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://github.com/python/mypy/pull/10251
JelleZijlstrahttps://github.com/JelleZijlstra
Mar 27, 2021https://github.com/python/mypy/pull/10251#discussion_r602730650
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10251
dixithhttps://github.com/dixith
Mar 27, 2021https://github.com/python/mypy/pull/10251#discussion_r602731766
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10251
dixithhttps://github.com/dixith
Mar 27, 2021https://github.com/python/mypy/pull/10251#discussion_r602737409
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@JelleZijlstrahttps://github.com/JelleZijlstra
mypy/mypy/checkexpr.pyhttps://github.com/python/mypy/blob/8860575a2134d87d890119015a9ead172f7fdfb1/mypy/checkexpr.py#L2811
8860575https://github.com/python/mypy/commit/8860575a2134d87d890119015a9ead172f7fdfb1
Please reload this pagehttps://github.com/python/mypy/pull/10251
JelleZijlstrahttps://github.com/JelleZijlstra
Mar 27, 2021https://github.com/python/mypy/pull/10251#discussion_r602776847
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10251
mypy/messages.pyhttps://github.com/python/mypy/pull/10251/files/57f83ea29a52a2fcf4e754dd561790240e4bd7ab#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0
JelleZijlstrahttps://github.com/JelleZijlstra
Mar 27, 2021https://github.com/python/mypy/pull/10251#discussion_r602729448
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10251
dixithhttps://github.com/dixith
Mar 27, 2021https://github.com/python/mypy/pull/10251#discussion_r602729973
Please reload this pagehttps://github.com/python/mypy/pull/10251
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/10251
dixithhttps://github.com/dixith
March 27, 2021 20:35https://github.com/python/mypy/pull/10251#commits-pushed-52db50a
https://github.com/dixith
Remove unused function enable_errors()https://github.com/python/mypy/pull/10251/commits/52db50ae9d4163233f72cdaee9709d9316241772
52db50ahttps://github.com/python/mypy/pull/10251/commits/52db50ae9d4163233f72cdaee9709d9316241772
https://github.com/dixith
Change to make sure cleanup always happens by using try-finallyhttps://github.com/python/mypy/pull/10251/commits/8860575a2134d87d890119015a9ead172f7fdfb1
8860575https://github.com/python/mypy/pull/10251/commits/8860575a2134d87d890119015a9ead172f7fdfb1
https://github.com/dixith
dixithhttps://github.com/dixith
Mar 27, 2021https://github.com/python/mypy/pull/10251#issuecomment-808766636
Please reload this pagehttps://github.com/python/mypy/pull/10251
Please reload this pagehttps://github.com/python/mypy/pull/10251
dixithhttps://github.com/dixith
March 28, 2021 00:27https://github.com/python/mypy/pull/10251#commits-pushed-c62147d
https://github.com/dixith
Removed redundant try-finallyhttps://github.com/python/mypy/pull/10251/commits/c62147d9924569265c7068a197c67d277f190345
c62147dhttps://github.com/python/mypy/pull/10251/commits/c62147d9924569265c7068a197c67d277f190345
https://github.com/dixith
Removed extra white spacehttps://github.com/python/mypy/pull/10251/commits/db293552dd4f68e8c0898a75eca4caf6e75ee6a7
db29355https://github.com/python/mypy/pull/10251/commits/db293552dd4f68e8c0898a75eca4caf6e75ee6a7
https://github.com/dixith
dixithhttps://github.com/dixith
Apr 2, 2021https://github.com/python/mypy/pull/10251#issuecomment-812694421
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://github.com/python/mypy/pull/10251
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 2, 2021https://github.com/python/mypy/pull/10251#issuecomment-812695543
Please reload this pagehttps://github.com/python/mypy/pull/10251
https://github.com/dixith
dixithhttps://github.com/dixith
force-pushedhttps://github.com/python/mypy/compare/58c4ded34ed2ce9fdee7bb25ca94c78d794858ad..c7a2b5c582f136f04e3988b107e1ec132220929e
58c4dedhttps://github.com/python/mypy/commit/58c4ded34ed2ce9fdee7bb25ca94c78d794858ad
c7a2b5chttps://github.com/python/mypy/commit/c7a2b5c582f136f04e3988b107e1ec132220929e
Compare https://github.com/python/mypy/compare/58c4ded34ed2ce9fdee7bb25ca94c78d794858ad..c7a2b5c582f136f04e3988b107e1ec132220929e
April 3, 2021 07:13https://github.com/python/mypy/pull/10251#event-4547850352
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 3, 2021https://github.com/python/mypy/pull/10251#issuecomment-812826263
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/10251
https://github.com/dixith
dixithhttps://github.com/dixith
force-pushedhttps://github.com/python/mypy/compare/587937c63bf46147116e3e843f4f8b04ae675c7b..717e7ff119c1d3b50a9951db5f109cacef0ca292
587937chttps://github.com/python/mypy/commit/587937c63bf46147116e3e843f4f8b04ae675c7b
717e7ffhttps://github.com/python/mypy/commit/717e7ff119c1d3b50a9951db5f109cacef0ca292
Compare https://github.com/python/mypy/compare/587937c63bf46147116e3e843f4f8b04ae675c7b..717e7ff119c1d3b50a9951db5f109cacef0ca292
April 3, 2021 08:04https://github.com/python/mypy/pull/10251#event-4547885105
https://github.com/dixith
Remove context manager from analyze_cond_branch callhttps://github.com/python/mypy/pull/10251/commits/a83a5701cf0f0b40ea6d3fad4520459f9057172e
a83a570https://github.com/python/mypy/pull/10251/commits/a83a5701cf0f0b40ea6d3fad4520459f9057172e
https://github.com/dixith
dixithhttps://github.com/dixith
force-pushedhttps://github.com/python/mypy/compare/717e7ff119c1d3b50a9951db5f109cacef0ca292..a83a5701cf0f0b40ea6d3fad4520459f9057172e
717e7ffhttps://github.com/python/mypy/commit/717e7ff119c1d3b50a9951db5f109cacef0ca292
a83a570https://github.com/python/mypy/commit/a83a5701cf0f0b40ea6d3fad4520459f9057172e
Compare https://github.com/python/mypy/compare/717e7ff119c1d3b50a9951db5f109cacef0ca292..a83a5701cf0f0b40ea6d3fad4520459f9057172e
April 3, 2021 08:30https://github.com/python/mypy/pull/10251#event-4547904016
https://github.com/dixith
merge with mypyhttps://github.com/python/mypy/pull/10251/commits/2cc1af94cb71f52f9b2e80190b6f0092f66509a8
2cc1af9https://github.com/python/mypy/pull/10251/commits/2cc1af94cb71f52f9b2e80190b6f0092f66509a8
https://github.com/dixith
dixithhttps://github.com/dixith
April 4, 2021 11:17https://github.com/python/mypy/pull/10251#event-4548999593
https://github.com/dixith
Merge branch 'python:master' into masterhttps://github.com/python/mypy/pull/10251/commits/6b4f95864ee9b317a17a2f38893d5109b8b82279
6b4f958https://github.com/python/mypy/pull/10251/commits/6b4f95864ee9b317a17a2f38893d5109b8b82279
https://github.com/atakiar
atakiarhttps://github.com/atakiar
Jun 21, 2021 https://github.com/python/mypy/pull/10251#ref-pullrequest-907798794
Convert MessageBuilder.disable_errors to a context manager #10569 https://github.com/python/mypy/pull/10569
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Jun 21, 2021https://github.com/python/mypy/pull/10251#issuecomment-865184066
#10569https://github.com/python/mypy/pull/10569
Please reload this pagehttps://github.com/python/mypy/pull/10251
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Jun 21, 2021https://github.com/python/mypy/pull/10251#event-4917982828
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10251
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/mypy/pull/10251/files/8860575a2134d87d890119015a9ead172f7fdfb1
Please reload this pagehttps://github.com/python/mypy/pull/10251
Please reload this pagehttps://github.com/python/mypy/pull/10251
https://github.com/dixith
https://github.com/JelleZijlstra
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.