| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9645efe5-effe-1c89-ac52-346ad8afa1ab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8322:1D7BA0:2E653:3F9B0:6B001A0F |
| html-safe-nonce | afa587762aefbb1e8e02ee62a0b4b77b5521c26c328f96bec9f2c628e142b515 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzIyOjFEN0JBMDoyRTY1MzozRjlCMDo2QjAwMUEwRiIsInZpc2l0b3JfaWQiOiI2Mjg0NDA3ODg3NDQ3OTg4NzUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 35a0846f6b05bf30e92b9a71e302ba6e76b6910a64fcac241bc3e4712a910b03 |
| hovercard-subject-tag | pull_request:602076733 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/10251/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d04c37e9bfdfa4a4f2b71ca5727d035891cc7ccb0999361f455e950105946c23/python/mypy/pull/10251 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d04c37e9bfdfa4a4f2b71ca5727d035891cc7ccb0999361f455e950105946c23/python/mypy/pull/10251 |
| og:image:alt | Description
This PR fixes one of the issue reported in #1184
Test Plan
Since this change is coding style change, new cases are not added. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dixith |
| hostname | github.com |
| expected-hostname | github.com |
| None | a2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 70121d4e855ee0bb7b75cf15d061d91f8863c0f8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/10251#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10251 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10251 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/10251 |
| Reload | https://github.com/python/mypy/pull/10251 |
| Reload | https://github.com/python/mypy/pull/10251 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| dixith | https://github.com/dixith |
| python:master | https://github.com/python/mypy/tree/master |
| dixith:master | https://github.com/dixith/mypy/tree/master |
| Conversation | https://github.com/python/mypy/pull/10251 |
| Commits8 (8) | https://github.com/python/mypy/pull/10251/commits |
| Checks | https://github.com/python/mypy/pull/10251/checks |
| Files changed | https://github.com/python/mypy/pull/10251/files |
| Use context managers for disable_errors() | https://github.com/python/mypy/pull/10251#top |
| dixith | https://github.com/dixith |
| python:master | https://github.com/python/mypy/tree/master |
| dixith:master | https://github.com/dixith/mypy/tree/master |
|
| https://github.com/dixith |
| dixith | https://github.com/dixith |
| Mar 27, 2021 | https://github.com/python/mypy/pull/10251#issue-842518739 |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| #1184 | https://github.com/python/mypy/issues/1184 |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
|
| https://github.com/dixith |
| Use context managers for disable_errors() | https://github.com/python/mypy/pull/10251/commits/57f83ea29a52a2fcf4e754dd561790240e4bd7ab |
| 57f83ea | https://github.com/python/mypy/pull/10251/commits/57f83ea29a52a2fcf4e754dd561790240e4bd7ab |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Mar 27, 2021
| https://github.com/python/mypy/pull/10251#pullrequestreview-622656526 |
|
View reviewed changes
| https://github.com/python/mypy/pull/10251/files/57f83ea29a52a2fcf4e754dd561790240e4bd7ab |
| JelleZijlstra | https://github.com/JelleZijlstra |
| https://github.com/python/mypy/pull/10251#pullrequestreview-622656526 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| mypy/messages.py | https://github.com/python/mypy/pull/10251/files/57f83ea29a52a2fcf4e754dd561790240e4bd7ab#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0 |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Mar 27, 2021 | https://github.com/python/mypy/pull/10251#discussion_r602729436 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| dixith | https://github.com/dixith |
| Mar 27, 2021 | https://github.com/python/mypy/pull/10251#discussion_r602730518 |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @JelleZijlstra | https://github.com/JelleZijlstra |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Mar 27, 2021 | https://github.com/python/mypy/pull/10251#discussion_r602730650 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| dixith | https://github.com/dixith |
| Mar 27, 2021 | https://github.com/python/mypy/pull/10251#discussion_r602731766 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| dixith | https://github.com/dixith |
| Mar 27, 2021 | https://github.com/python/mypy/pull/10251#discussion_r602737409 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @JelleZijlstra | https://github.com/JelleZijlstra |
| mypy/mypy/checkexpr.py | https://github.com/python/mypy/blob/8860575a2134d87d890119015a9ead172f7fdfb1/mypy/checkexpr.py#L2811 |
| 8860575 | https://github.com/python/mypy/commit/8860575a2134d87d890119015a9ead172f7fdfb1 |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Mar 27, 2021 | https://github.com/python/mypy/pull/10251#discussion_r602776847 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| mypy/messages.py | https://github.com/python/mypy/pull/10251/files/57f83ea29a52a2fcf4e754dd561790240e4bd7ab#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0 |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Mar 27, 2021 | https://github.com/python/mypy/pull/10251#discussion_r602729448 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| dixith | https://github.com/dixith |
| Mar 27, 2021 | https://github.com/python/mypy/pull/10251#discussion_r602729973 |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| dixith | https://github.com/dixith |
| March 27, 2021 20:35 | https://github.com/python/mypy/pull/10251#commits-pushed-52db50a |
|
| https://github.com/dixith |
| Remove unused function enable_errors() | https://github.com/python/mypy/pull/10251/commits/52db50ae9d4163233f72cdaee9709d9316241772 |
| 52db50a | https://github.com/python/mypy/pull/10251/commits/52db50ae9d4163233f72cdaee9709d9316241772 |
|
| https://github.com/dixith |
| Change to make sure cleanup always happens by using try-finally | https://github.com/python/mypy/pull/10251/commits/8860575a2134d87d890119015a9ead172f7fdfb1 |
| 8860575 | https://github.com/python/mypy/pull/10251/commits/8860575a2134d87d890119015a9ead172f7fdfb1 |
| https://github.com/dixith |
| dixith | https://github.com/dixith |
| Mar 27, 2021 | https://github.com/python/mypy/pull/10251#issuecomment-808766636 |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| dixith | https://github.com/dixith |
| March 28, 2021 00:27 | https://github.com/python/mypy/pull/10251#commits-pushed-c62147d |
|
| https://github.com/dixith |
| Removed redundant try-finally | https://github.com/python/mypy/pull/10251/commits/c62147d9924569265c7068a197c67d277f190345 |
| c62147d | https://github.com/python/mypy/pull/10251/commits/c62147d9924569265c7068a197c67d277f190345 |
|
| https://github.com/dixith |
| Removed extra white space | https://github.com/python/mypy/pull/10251/commits/db293552dd4f68e8c0898a75eca4caf6e75ee6a7 |
| db29355 | https://github.com/python/mypy/pull/10251/commits/db293552dd4f68e8c0898a75eca4caf6e75ee6a7 |
| https://github.com/dixith |
| dixith | https://github.com/dixith |
| Apr 2, 2021 | https://github.com/python/mypy/pull/10251#issuecomment-812694421 |
| @JelleZijlstra | https://github.com/JelleZijlstra |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Apr 2, 2021 | https://github.com/python/mypy/pull/10251#issuecomment-812695543 |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| https://github.com/dixith |
| dixith | https://github.com/dixith |
| force-pushed | https://github.com/python/mypy/compare/58c4ded34ed2ce9fdee7bb25ca94c78d794858ad..c7a2b5c582f136f04e3988b107e1ec132220929e |
| 58c4ded | https://github.com/python/mypy/commit/58c4ded34ed2ce9fdee7bb25ca94c78d794858ad |
| c7a2b5c | https://github.com/python/mypy/commit/c7a2b5c582f136f04e3988b107e1ec132220929e |
|
Compare
| https://github.com/python/mypy/compare/58c4ded34ed2ce9fdee7bb25ca94c78d794858ad..c7a2b5c582f136f04e3988b107e1ec132220929e |
| April 3, 2021 07:13 | https://github.com/python/mypy/pull/10251#event-4547850352 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Apr 3, 2021 | https://github.com/python/mypy/pull/10251#issuecomment-812826263 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| https://github.com/dixith |
| dixith | https://github.com/dixith |
| force-pushed | https://github.com/python/mypy/compare/587937c63bf46147116e3e843f4f8b04ae675c7b..717e7ff119c1d3b50a9951db5f109cacef0ca292 |
| 587937c | https://github.com/python/mypy/commit/587937c63bf46147116e3e843f4f8b04ae675c7b |
| 717e7ff | https://github.com/python/mypy/commit/717e7ff119c1d3b50a9951db5f109cacef0ca292 |
|
Compare
| https://github.com/python/mypy/compare/587937c63bf46147116e3e843f4f8b04ae675c7b..717e7ff119c1d3b50a9951db5f109cacef0ca292 |
| April 3, 2021 08:04 | https://github.com/python/mypy/pull/10251#event-4547885105 |
|
| https://github.com/dixith |
| Remove context manager from analyze_cond_branch call | https://github.com/python/mypy/pull/10251/commits/a83a5701cf0f0b40ea6d3fad4520459f9057172e |
| a83a570 | https://github.com/python/mypy/pull/10251/commits/a83a5701cf0f0b40ea6d3fad4520459f9057172e |
| https://github.com/dixith |
| dixith | https://github.com/dixith |
| force-pushed | https://github.com/python/mypy/compare/717e7ff119c1d3b50a9951db5f109cacef0ca292..a83a5701cf0f0b40ea6d3fad4520459f9057172e |
| 717e7ff | https://github.com/python/mypy/commit/717e7ff119c1d3b50a9951db5f109cacef0ca292 |
| a83a570 | https://github.com/python/mypy/commit/a83a5701cf0f0b40ea6d3fad4520459f9057172e |
|
Compare
| https://github.com/python/mypy/compare/717e7ff119c1d3b50a9951db5f109cacef0ca292..a83a5701cf0f0b40ea6d3fad4520459f9057172e |
| April 3, 2021 08:30 | https://github.com/python/mypy/pull/10251#event-4547904016 |
|
| https://github.com/dixith |
| merge with mypy | https://github.com/python/mypy/pull/10251/commits/2cc1af94cb71f52f9b2e80190b6f0092f66509a8 |
| 2cc1af9 | https://github.com/python/mypy/pull/10251/commits/2cc1af94cb71f52f9b2e80190b6f0092f66509a8 |
| https://github.com/dixith |
| dixith | https://github.com/dixith |
| April 4, 2021 11:17 | https://github.com/python/mypy/pull/10251#event-4548999593 |
|
| https://github.com/dixith |
| Merge branch 'python:master' into master | https://github.com/python/mypy/pull/10251/commits/6b4f95864ee9b317a17a2f38893d5109b8b82279 |
| 6b4f958 | https://github.com/python/mypy/pull/10251/commits/6b4f95864ee9b317a17a2f38893d5109b8b82279 |
| https://github.com/atakiar |
| atakiar | https://github.com/atakiar |
|
Jun 21, 2021
| https://github.com/python/mypy/pull/10251#ref-pullrequest-907798794 |
|
Convert MessageBuilder.disable_errors to a context manager
#10569
| https://github.com/python/mypy/pull/10569 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Jun 21, 2021 | https://github.com/python/mypy/pull/10251#issuecomment-865184066 |
| #10569 | https://github.com/python/mypy/pull/10569 |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Jun 21, 2021 | https://github.com/python/mypy/pull/10251#event-4917982828 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F10251 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/mypy/pull/10251/files/8860575a2134d87d890119015a9ead172f7fdfb1 |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
| Please reload this page | https://github.com/python/mypy/pull/10251 |
|
| https://github.com/dixith |
|
| https://github.com/JelleZijlstra |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |